From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24E38C3ABCB for ; Tue, 13 May 2025 00:27:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E5AF6B008A; Mon, 12 May 2025 20:27:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81D456B008C; Mon, 12 May 2025 20:27:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66DB66B0092; Mon, 12 May 2025 20:27:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 428096B008A for ; Mon, 12 May 2025 20:27:27 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 32BDE120D0F for ; Tue, 13 May 2025 00:27:28 +0000 (UTC) X-FDA: 83435995776.06.47AEEB7 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf11.hostedemail.com (Postfix) with ESMTP id BF8B040003 for ; Tue, 13 May 2025 00:27:26 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="TFUI/QYe"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747096046; a=rsa-sha256; cv=none; b=QS7guPDdevlGwnTKS8Efhf24FD6BpCbbcc9VmdIBfyE+yolpkr9hUSaLCAKLodBoAjYgVU k/HaxgLhKbmrGFq27shk8lLcBGdP7bSaesFmU7rlgK4poSeOVTdKJha1xH+SijUefQ8oQo LSWzjyusD0lzbVuemQl4cSh7+WkbHFY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="TFUI/QYe"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747096046; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T+6bO3/lWsMVwstA2ZXcDTRLDr7pcOacSB1Oj4mFPvo=; b=LVjfjqCYO0cd+M8F2BvmEmwdZEgWCL7hejUml65bd2ydacyfv/Kz75uGzPk5FVQka1dFvF XKyjmMskux/yvTdI0iH2E13B4kLq5jGp/gyMuvd1Grf9xRIWQHPzUGqKq24hjv3jbHaLKE +WqUVMFR5J6gouaazQ+UBRhkirjgWT0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id E6E57A4CB07; Tue, 13 May 2025 00:27:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5EA7EC4CEEE; Tue, 13 May 2025 00:27:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747096045; bh=M92/gov+YRjIS6VM2BRObVBgAlR9lw1xuX3y69/FgHQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TFUI/QYeXvnLV1j1ziIYgAjnNmTfT37e+HvuxaYLy3iKGlkp70GFZglavMkpdwr7N ofWw+Sze4MkTYLXAzI+i955ustgk2/vvqCE7OIlrcP7rfJu790BgE/YgrlFjpExHG4 vhEkXlWt0Fr4rx09/Segf6ZE2FdQE+/6rBsDKwRyNWjcCt+j7XAQXMDiQmzbK0Pf+q CtHHoSNXqE77P+jTRI3/BMzxYJkHjow7HAsyXjnH0jWVMwZTzTvg/GSl3Cu73Ej5O0 gX7kSvQwG5aLugFO7NTc/o4631ilxefS9Y/qJKqBzURm9DQmF5XInOzraGRB4HeCfA ux1tAg94iO1rQ== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Brendan Higgins , David Gow , damon@lists.linux.dev, kernel-team@meta.com, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 4/6] mm/damon/tests/core-kunit: add a test for damos_set_filters_default_reject() Date: Mon, 12 May 2025 17:27:13 -0700 Message-Id: <20250513002715.40126-5-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250513002715.40126-1-sj@kernel.org> References: <20250513002715.40126-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: BF8B040003 X-Rspam-User: X-Stat-Signature: wi3mypcqb5ek6tkmgcm6easymusz9kon X-HE-Tag: 1747096046-372658 X-HE-Meta: U2FsdGVkX1+HAYYlHS5aLyDg2fvRe2DaEZlvaUZJgRClQTwcCxJ+Cc75CHiscDoHviVdcMQ9Uy/OW4xh6J4eehskYDXFFwNxg+EhSWXGPJdvLerBc3uxsvwrRcsA2uodFK8jYLo/WhtRHAlzQSbd4yNpS31kHsnhR42zxZQKNJWJIpvMod6gCcYh/BxUpfyyz0OT2XaupPs5kyn6vD0wOSzrmmQISKPNCds/Viz0lQ8YVNa2Dhrd/oszy7dISVfxXPVMHQ/CSIQHVoTE6WOwzmX3deCY/Id6M0tGRsEif7z2dNO9JwI9ckv5s5Rxsa+KvkolpPPllRTZyOKvrt2Rw7/fs54/VMsQyegSVg5N5if1ksW4ImH4gDI3jHFfl/oQGgVNQcRv1eE0s1nE8N1r2PuV2lV+tYanyNAiXbq7ZXswmV333KGg125Wcqo8ZyJ3Rkw0rLjzv+pMVxERrWEeaOZaar35HjaMI2gbEj/ZWg56z3mp9Ft2sFXdGM7cL9CIvTtpUrEJRp7l/O/2qXZDJXk5MQDOpTCZV9zd2XNzHjRAsNg2lSlcQbfWN/cv/R72KURxX3ij/CkMSWKJEUVdHxCmLdEemOZopyoaFJmIgRD+cs4NECvcZjX9+BuJ5EzityWKfYQDRrw8JLPoqaNz1AXSKzUSqt6eEcr9fIGcbMmryRHAfBC/Av8U4vQz13EeyVTsEAmkhuEVsZemNXO2QPLJ5sey3D5xOFo/lWn0NF/ECUm527bMk3y62ZxnFmfekTy7LiX2NcFRsGCt/bvztzmoY02ZM9W6iOft9u4JC8NaYnlKyl3ACrVug9dOh1TXGR+BjytKrfOdMBbdErLrHVsW+aQgaDnWWEQSLpALHY5WOR5AiY34LYH5RgBNP/jauNOG4Yzot9ZSnB3yndbya1ajL0mFvqVaHeRI1RZKuPn4EBnV4OoHjztslYuRlvIsDqhDYnX0fXShHtR0TXc HqC8MMTP mOWLP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: DAMOS filters' default reject behavior is not very simple. Actually there was a mistake[1] during the development. Add a kunit test for validating the behavior. [1] https://lore.kernel.org/20250227002913.19359-1-sj@kernel.org Signed-off-by: SeongJae Park --- mm/damon/tests/core-kunit.h | 70 +++++++++++++++++++++++++++++++++++++ 1 file changed, 70 insertions(+) diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h index be0fea9ee5fc..298c67557fae 100644 --- a/mm/damon/tests/core-kunit.h +++ b/mm/damon/tests/core-kunit.h @@ -510,6 +510,75 @@ static void damon_test_feed_loop_next_input(struct kunit *test) damon_feed_loop_next_input(last_input, 2000)); } +static void damon_test_set_filters_default_reject(struct kunit *test) +{ + struct damos scheme; + struct damos_filter *target_filter, *anon_filter; + + INIT_LIST_HEAD(&scheme.filters); + INIT_LIST_HEAD(&scheme.ops_filters); + + damos_set_filters_default_reject(&scheme); + /* + * No filter is installed. Allow by default on both core and ops layer + * filtering stages, since there are no filters at all. + */ + KUNIT_EXPECT_EQ(test, scheme.core_filters_default_reject, false); + KUNIT_EXPECT_EQ(test, scheme.ops_filters_default_reject, false); + + target_filter = damos_new_filter(DAMOS_FILTER_TYPE_TARGET, true, true); + damos_add_filter(&scheme, target_filter); + damos_set_filters_default_reject(&scheme); + /* + * A core-handled allow-filter is installed. + * Rejct by default on core layer filtering stage due to the last + * core-layer-filter's behavior. + * Allow by default on ops layer filtering stage due to the absence of + * ops layer filters. + */ + KUNIT_EXPECT_EQ(test, scheme.core_filters_default_reject, true); + KUNIT_EXPECT_EQ(test, scheme.ops_filters_default_reject, false); + + target_filter->allow = false; + damos_set_filters_default_reject(&scheme); + /* + * A core-handled reject-filter is installed. + * Allow by default on core layer filtering stage due to the last + * core-layer-filter's behavior. + * Allow by default on ops layer filtering stage due to the absence of + * ops layer filters. + */ + KUNIT_EXPECT_EQ(test, scheme.core_filters_default_reject, false); + KUNIT_EXPECT_EQ(test, scheme.ops_filters_default_reject, false); + + anon_filter = damos_new_filter(DAMOS_FILTER_TYPE_ANON, true, true); + damos_add_filter(&scheme, anon_filter); + + damos_set_filters_default_reject(&scheme); + /* + * A core-handled reject-filter and ops-handled allow-filter are installed. + * Allow by default on core layer filtering stage due to the existence + * of the ops-handled filter. + * Reject by default on ops layer filtering stage due to the last + * ops-layer-filter's behavior. + */ + KUNIT_EXPECT_EQ(test, scheme.core_filters_default_reject, false); + KUNIT_EXPECT_EQ(test, scheme.ops_filters_default_reject, true); + + target_filter->allow = true; + damos_set_filters_default_reject(&scheme); + /* + * A core-handled allow-filter and ops-handled allow-filter are + * installed. + * Allow by default on core layer filtering stage due to the existence + * of the ops-handled filter. + * Reject by default on ops layer filtering stage due to the last + * ops-layer-filter's behavior. + */ + KUNIT_EXPECT_EQ(test, scheme.core_filters_default_reject, false); + KUNIT_EXPECT_EQ(test, scheme.ops_filters_default_reject, true); +} + static struct kunit_case damon_test_cases[] = { KUNIT_CASE(damon_test_target), KUNIT_CASE(damon_test_regions), @@ -527,6 +596,7 @@ static struct kunit_case damon_test_cases[] = { KUNIT_CASE(damos_test_new_filter), KUNIT_CASE(damos_test_filter_out), KUNIT_CASE(damon_test_feed_loop_next_input), + KUNIT_CASE(damon_test_set_filters_default_reject), {}, }; -- 2.39.5