From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCC27C3ABC3 for ; Tue, 13 May 2025 02:00:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A7236B000A; Mon, 12 May 2025 22:00:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 656236B0083; Mon, 12 May 2025 22:00:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51D136B0085; Mon, 12 May 2025 22:00:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 338AB6B000A for ; Mon, 12 May 2025 22:00:15 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A320EC10D8 for ; Tue, 13 May 2025 02:00:16 +0000 (UTC) X-FDA: 83436229632.18.87A32BB Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf02.hostedemail.com (Postfix) with ESMTP id E474880009 for ; Tue, 13 May 2025 02:00:13 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf02.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf02.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747101614; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KGDm9OT70//uin6yRuVUZPOQgbkui8XSkxwMFSrkz2A=; b=7hvhofO9dXLNiHG9FWVKSsadrrzhXl6iSGs7w9o71/dSBTMfeJ445dX5AKFLP4rja8Cgo5 7rWPk0Wto4+ElvmbUBaof6GihmhPYRslPKvrJboiGxzchWrD1b4V7PkRxdOlP/ElDT25VC nuQMj21TjeEQLNqcMq10H8ERd7BH1BQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747101614; a=rsa-sha256; cv=none; b=Oin3u2B6GzpsypHzIpi3o12NI6pl442mgH8fp5D5Vbzd3HSaoy3AHTlXCxI1ZgH68J3VKD 9VIvHEwMy55HNjrx/L4nkNG9zuq5/m0qMj0No0+Q/zeNgjpItLt0zpW/XF74uJLh008A7K HnYYMzTnbqnU5gQyJyFyI6kfdJTBwRA= X-AuditID: a67dfc5b-669ff7000002311f-02-6822a7accd37 Date: Tue, 13 May 2025 11:00:07 +0900 From: Byungchul Park To: Mina Almasry Cc: Pavel Begunkov , willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, edumazet@google.com, pabeni@redhat.com, vishal.moola@gmail.com Subject: Re: [RFC 01/19] netmem: rename struct net_iov to struct netmem_desc Message-ID: <20250513020007.GB577@system.software.com> References: <20250509115126.63190-1-byungchul@sk.com> <20250509115126.63190-2-byungchul@sk.com> <20250512132939.GF45370@system.software.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrPIsWRmVeSWpSXmKPExsXC9ZZnoe6a5UoZBlc3y1nMWb+GzWL1jwqL 5Q92sFrMWbWN0eLLz9vsFosXfmO2mHO+hcXi6bFH7Bb3lz1jsdjTvp3ZorflN7NF044VTBYX tvWxWlzeNYfN4t6a/6wWxxaIWXw7/YbRYv2+G6wWv3/MYXMQ9tiy8iaTx85Zd9k9Fmwq9di8 Qsuj68YlZo9NqzrZPDZ9msTucefaHjaPEzN+s3js3PGZyePj01ssHu/3XWXz+LxJLoA3issm JTUnsyy1SN8ugSujZ/cFtoLVAhV/flc3MC7i6WLk5JAQMJG4N6uHEcbe+PY5E4jNIqAq8XT7 CWYQm01AXeLGjZ9gtoiApsSSfRNZuxi5OJgFzjJLfP10jhUkISzgI3Hh5X12EJtXwExiy7lZ jCBFQgJdTBKfdx1nhkgISpyc+YQFxGYGmvpn3iWgOAeQLS2x/B8HRFheonnrbLByToFAieWL GsDmiwooSxzYdpwJZKaEwCl2iZk3n7FDXC0pcXDFDZYJjIKzkKyYhWTFLIQVs5CsWMDIsopR KDOvLDcxM8dEL6MyL7NCLzk/dxMjMJqX1f6J3sH46ULwIUYBDkYlHt4TLxUzhFgTy4orcw8x SnAwK4nwNm4HCvGmJFZWpRblxxeV5qQWH2KU5mBREuc1+laeIiSQnliSmp2aWpBaBJNl4uCU amCUm+bHtl6vXiaVg8F24uubk0sSdb57R7zSDbk3MV0mcFM2y6HnHrtk8zcYScxKvj2x5lxU 07UloTciVhwOrvvG2Dgxb2U0mwuXsNOftAttF9S7wwT5ZjskisvKCRydxbJzY5zMikS9Oxvn sZ38IbNsTsMNX1F3Lrm385sbE27fu/TwwJ0oXk0lluKMREMt5qLiRADQefqS4gIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGIsWRmVeSWpSXmKPExsXC5WfdrLtmuVKGwdPrfBZz1q9hs1j9o8Ji +YMdrBZzVm1jtPjy8za7xeKF35gt5pxvYbF4euwRu8X9Zc9YLPa0b2e26G35zWzRtGMFk8Xh uSdZLS5s62O1uLxrDpvFvTX/WS2OLRCz+Hb6DaPF+n03WC1+/5jD5iDisWXlTSaPnbPusnss 2FTqsXmFlkfXjUvMHptWdbJ5bPo0id3jzrU9bB4nZvxm8di54zOTx8ent1g83u+7yuax+MUH Jo/Pm+QC+KK4bFJSczLLUov07RK4Mnp2X2ArWC1Q8ed3dQPjIp4uRk4OCQETiY1vnzOB2CwC qhJPt59gBrHZBNQlbtz4CWaLCGhKLNk3kbWLkYuDWeAss8TXT+dYQRLCAj4SF17eZwexeQXM JLacm8UIUiQk0MUk8XnXcWaIhKDEyZlPWEBsZqCpf+ZdAopzANnSEsv/cUCE5SWat84GK+cU CJRYvqgBbL6ogLLEgW3HmSYw8s1CMmkWkkmzECbNQjJpASPLKkaRzLyy3MTMHFO94uyMyrzM Cr3k/NxNjMDYXFb7Z+IOxi+X3Q8xCnAwKvHwnnipmCHEmlhWXJl7iFGCg1lJhLdxO1CINyWx siq1KD++qDQntfgQozQHi5I4r1d4aoKQQHpiSWp2ampBahFMlomDU6qB8XQF3zUL98knDu9b MmnnjQd2HGn9eaJvD3lL5LNWGdy6dTdgd4SA0WMmmy/1f5k/nG+bN4dh5dRfr4V3/r3uxj/5 z+X/69f0xjFPCYrRkD0VpK0558iigJCMlYfvZXRH6lzOv3YnXZ3PtVn6nG3YJlWZXZWp0RP2 tP8J77Wyz4s56SCXU/ygVYmlOCPRUIu5qDgRAClqDYrJAgAA X-CFilter-Loop: Reflected X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E474880009 X-Stat-Signature: cwqn999fs4x6br5j8r3g7h6m35534836 X-Rspam-User: X-HE-Tag: 1747101613-393173 X-HE-Meta: U2FsdGVkX1/Lk7KaW/imcYLn7W/A0AmD6qGR6D7NUhdR+VAbq7iKSbL5l74qjjZTpTPSgl8Xfqx3iTiFC+U2/3dzDZ10mEfALZuyxjHTLDfQY5YT2FlKZb8/zv65LwDzdqMrOjNRoH4e8jPpEDURUIIa40DUYsQDzpuLRZcBs/5KJPrCpzmykQmT9N93nsM3UvTlcjML99JtWej7aYp+ugAcY6itL2Ol6ubiri+hxFIXevbFEzKeAjcROnSLsl3AwWt3lJ/TPCA+AUgQNStPW6PamwdlX2SxIaMd0pEkr9QHKT0Hmw0bmW8G8sx4+GX513qNbfQVyp9lJ6Xbar6q10tCHnKT71QUywAsJ1JR0fgA0IWkSWwuYV2cpfbasViqdByjCHlG6C97r9XEJbBXGyzeT2o3hRKiFTG4gJdO2ItZaZ870T1NvtATwuXb4qg5hmGnV+5eouGcwiYy+nas6R5j7P89sVRakBXuS++3xqD8wTdLwhm+mSpnX6PaO1wk3xOUXn2Zy4Ryg6WKiywIj3WbBbbMbQhinPBsJU9gcOJtQ0c5xdk/vAgiZCI67RYnIRUV1GUp2G9WoA3ayOBva4AYe3pzMMcy9Nzaxl+HI8h8EOdVCZg5HbEJ5Z73smBd/0UR6rM1O9TyYw0cXNuPdRyLw+HDwKU9D987s3OIusgoVf1fXjNQUhgrjemae75Ta29dP0PrpXjA2m3Yjct7COk2zhgoTzEVszSnzuPK/x6amxU+IReaTWwmo9YDV0L22fYmapoSFCbARdE+FBqrMoBuP13kPcq/223RPiYrmlQwx+Ke7x4l8IgSasRLGPUl5bPT2rPnw6sFR04wRz4SVtEDlfiT5Fj7wip0Dfxx+oJXz+Z07NbU4Kl8DPlmWP6gJEKi8IYPu7Mnc/OQDf6qk9PAxdkYSqZecujI0DI6hMMYO6x+05xQlgN8nGWmYvgJF63ezBljdLFfqEIdE8x DTe5fWi7 jfUxYtbuLB3iMJAWc6iTuZ7wGAdKXz9t41C3HLdJLufnfRAd2qxKSQyiyxvCr8kk8G+tg+vPZjOEJHf3udVxIeISMVwGg2S74XrK1D1hvp1FDGsKaJB7/WIzJnucjyTDZSBI91QwGjOB57DxOo/DXDVB/mw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 12, 2025 at 12:14:13PM -0700, Mina Almasry wrote: > On Mon, May 12, 2025 at 6:29 AM Byungchul Park wrote: > > > > On Mon, May 12, 2025 at 02:11:13PM +0100, Pavel Begunkov wrote: > > > On 5/9/25 12:51, Byungchul Park wrote: > > > > To simplify struct page, the page pool members of struct page should be > > > > moved to other, allowing these members to be removed from struct page. > > > > > > > > Reuse struct net_iov for also system memory, that already mirrored the > > > > page pool members. > > > > > > > > Signed-off-by: Byungchul Park > > > > --- > > > > include/linux/skbuff.h | 4 +-- > > > > include/net/netmem.h | 20 ++++++------ > > > > include/net/page_pool/memory_provider.h | 6 ++-- > > > > io_uring/zcrx.c | 42 ++++++++++++------------- > > > > > > You're unnecessarily complicating it for yourself. It'll certainly > > > conflict with changes in the io_uring tree, and hence it can't > > > be taken normally through the net tree. > > > > > > Why are you renaming it in the first place? If there are good > > > > It's because the struct should be used for not only io vetor things but > > also system memory. Current network code uses struct page as system > > memory descriptor but struct page fields for page pool will be gone. > > > > So I had to reuse struct net_iov and I thought renaming it made more > > sense. It'd be welcome if you have better idea. > > > > As I said in another thread, struct page should not embed struct I don't understand here. Can you explain more? Do you mean do not use place holder? > net_iov as-is. struct net_iov already has fields that are unrelated to > page (like net_iov_owner) and more will be added in the future. > > I think what Matthew seems to agree with AFAIU in the other thread is > creating a new struct, struct netmem_desc, and having struct net_iov > embed netmem_desc. This would look better. I will try. Byungchul > -- > Thanks, > Mina