From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57258C3ABC3 for ; Tue, 13 May 2025 13:59:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2CDA86B00CD; Tue, 13 May 2025 09:59:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 27D9A6B00CF; Tue, 13 May 2025 09:59:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CFCC6B00CE; Tue, 13 May 2025 09:59:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E136E6B00BC for ; Tue, 13 May 2025 09:59:38 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A70E780CE2 for ; Tue, 13 May 2025 13:59:40 +0000 (UTC) X-FDA: 83438042520.26.028EBC2 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by imf22.hostedemail.com (Postfix) with ESMTP id C8D2AC0005 for ; Tue, 13 May 2025 13:59:38 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DUaXPuoF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747144778; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SxHPphgXbWdm5nbT9IaJtyapq7Mq0HF46NjBnfggMmc=; b=gfsW+gE26oRdB5TJtyA3JUQlWjX3Zfb3pVHprHTPhgom4zsTFktPSpfAjut2xIps06hdwc SsDer8zCRnGOZxANLMxSOg+j9H2K2C+AHzTlAX8FrWeTCon5JSBFRYjYfuc4zrOS3A70rK 48CtPwl9Iq3sncslVCGvO0EPr9i2rSg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747144778; a=rsa-sha256; cv=none; b=py2yhNvwM7WzMAamo78NPR8wjouR0CKZMOt7kfbBtKcyXs+mdRdIAHCecyrKWXKNfeIp2f 59lYHWZGYtmEyA8KXskdytKsh6wq5u+xjH7JALQQ6GA2MlxHqWtdDbMQ1X+6ajH7PV3aSR sjmtUPhJwjKSyd5gNI0NADwlaPG8eHs= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DUaXPuoF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-7082ce1e47cso54154797b3.2 for ; Tue, 13 May 2025 06:59:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747144778; x=1747749578; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SxHPphgXbWdm5nbT9IaJtyapq7Mq0HF46NjBnfggMmc=; b=DUaXPuoFmYnKP31zZM5nfgWboMz2fTI6okXwYTmDEjRlhvWEztK9a5lqkk6g8J5Szi TcMv2AKJr6O/UqX1iVDb9t7Go+JZQHmzwwxWoy9TMrh/zCQCIsT5rRfw4ec9RU2clzPm twAVYmRV92PBNV+uwSx06Pd1mDy4ldYzMOzRqCK92KlyHAuL2sjvQa/Z5lytdWvr7MjO kkI9ZNV3l5oW6PRUB2jA1XeOahQc2bDH/0d4eqAimEzA4gEg9qCN6Fb9irIVB38ep0a0 dhODt6qZT4yIgnUqi6CnBjZUOsfRGlQGRyfurqbGsWuuBrGw+vEJBBwhLVOQLJqsYE+s KkBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747144778; x=1747749578; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SxHPphgXbWdm5nbT9IaJtyapq7Mq0HF46NjBnfggMmc=; b=t7IaNr0pAijn6FObIFAfuMFc2bjTasdHR80Zim7X9zqY01IUEVBrs6hFYH9KsVlfEg Ea3E8KZQr732iisFNSnzfNuRsPPOvswWNn7hai5hkg4RjBrVZG5/xpAeV80QMFpT+OdZ Dr3P13s6V2Yl0lhBhvmhAHPQ0aALYY5+v6uF4FP7zdiU7E1+c/OWD9jwF4wnWQcZHvNU uyfug+9/ghvv4UkAxxESkktqDinCqImZDr1M/mlmxtyimBt6xYdvLWUB7Mc9PmdUoLRN 5LWG8IZXpAdUcOe3s6KxbDgr32dSVRJ6CMo/C1+9EkzINsF6fnCQIlDAq2bSyO+VHjjN EIBg== X-Forwarded-Encrypted: i=1; AJvYcCU7e1AnuIJkYllrmgXWFVjZ8OiqbOXKRS5kyfCUZ1BDuJOnN6GQGSgB4VqvCRsvwNWMaCzeKUIluA==@kvack.org X-Gm-Message-State: AOJu0Yz9JY5+CyOFUm7U3SRWfHEhcTVfKZFr6xw3PzrvoEBcviN2xN6x /JUkb2hCj0MjxJiIzdLysldS7kaGmAzdt70sy/mBs365zUN3wHjG X-Gm-Gg: ASbGnctHArTblocLPq+FlEKv9Vxl/wb7g/z80FNq97GlpOiQUSvhuS84Fk/6/knw6aD gYmLhFKMgtVBHTIfOucAZMLI3bdNy7IbasMGWz+nOZfpuXhJoqe0sJSKC3UaLhaXnxC059p26nl eAw5EviGHw+AYK0Z7RwsGEyGSTPIwTMyljH7lBiR7TXeaYceO3AaQkednOL1watBjVai7GB+VXR VO8Eih42X4XZHUxOO4geXWmePweaRLsLgI6EbhTR4XS3G2tisTLwBe2lDqdW12R6K5+RrIap8VD IYOHOjuYsXRbjd/giso7DwXNQCbRBZbH2LvcCAGNHyOX27LvLY8= X-Google-Smtp-Source: AGHT+IHHNeRb5OLaGj6qAjtuql5TdNI/3gNeh0Ot5Zvdx+MoysAHOVc6WPZPIR8ztl4F1Alzh3G7ZA== X-Received: by 2002:a05:690c:4d08:b0:702:52fb:4629 with SMTP id 00721157ae682-70a3fb123ccmr221926307b3.23.1747144777713; Tue, 13 May 2025 06:59:37 -0700 (PDT) Received: from localhost ([2a03:2880:25ff:71::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-70a3d9eccd9sm24474957b3.97.2025.05.13.06.59.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 May 2025 06:59:37 -0700 (PDT) From: Joshua Hahn To: "Huang, Ying" Cc: Andrew Morton , gourry@gourry.net, honggyu.kim@sk.com, yunjeong.mun@sk.com, gregkh@linuxfoundation.org, rafael@kernel.org, lenb@kernel.org, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, dave.jiang@intel.com, horen.chuang@linux.dev, hannes@cmpxchg.org, osalvador@suse.de, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com Subject: Re: [PATCH v8] mm/mempolicy: Weighted Interleave Auto-tuning Date: Tue, 13 May 2025 06:59:33 -0700 Message-ID: <20250513135935.2914896-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <87tt5puw21.fsf@DESKTOP-5N7EMDA> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: 4ouzx7xzcwyuxybwh49a4qfhninr1ant X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C8D2AC0005 X-HE-Tag: 1747144778-740672 X-HE-Meta: U2FsdGVkX18OXIrYVBmrWkA/gz3S1aYmw6gI53nZO/l1gRaEJgNJtvc7NSAtvcCThhDK3NmbcHkUwWVu1bXFMFV80Hl2uJ3yPY7kElUSyQjUfjc47xwg2hctziPvDuZb6DpYPV/wvonr391XwZcqS4FMfiy/UA2pDFuIjwpKZFgHn+DIZSvKmdRDBDMo2ZpZ76q2kSZPoOyeBYLsCME78S2PToqn6IdkoUpOYw163K+YlOdf4ZAXt+88Lc7XUDt9d9rY9LGPExfChidYFFD5O0EKMkR92maRAM81Gv33paxWlEgft3MV32FKFMKEMiEDRsV37/VvXB5+3u4L1WGfsctaISfWImj3WC7fY2k1rX0LHpA81HY5oRCsbkFrkfd/iiUpekcpgdVBcHHwwTDk1sQfG4Jb5kZDFJ1g7bd+bkREZCF7gaqA42xFrftTiJhG3bduSxnsEM30HmQcyFhDC0HPOc+oot40C8j8jtbFj2juS7MfioOUbw06EPcTGPd+3ybRjl3iaNqAiLBiAxjJM+0y9TsOwx5ljXYctWg48voQVl4KU4Q52/4WA+m80UMPWxfpnr359fXy9XAQy1Ou1TYyHqHf+DGbd68B6EulUQWR1wNtS5jUwDsgvJgcBi1Jh2/i+GmYyY1JT5rgNPrUYHYd1NLpSmlpvjtQa6KXyT5UzDo1A1KSRkPDonKhkcMPBepvW2Nk03acQBL1iTcbWoYIlamzeWHGeNIFhqfZopr/kC657HrHdzM/ALTAcVLolutjwPXDEJucQdc2BRqv+jFnFrbrTS7KRxWkgMZxeNNxjOYGTlP0hQX45kdpKvrq2ltyoDArP92tG4xGPd2+nTi05qgfmOafqj694lj8/wV/fX4Gv7/vs+I7zppRAMqOiEEC4wP5mWGOrRpmcgK0KJsAB+4XwjzA22y1tTncvbD+eYcFfRTXTQEJNEnQ0u/DzRXIq/J8mEqeXBrwImo VHbNEY7j KUZoJnvcqhGSeiP4oWmxms8W2yoRPepMQmQHohl+mbbc7KlYVXOEj68mRJPgWUjIKnI1y6m5p/Bkhm/H/M7GSH9tk0tKB4F5W/PesBqZCwgZ2VueQKeUWPykSJTn/Gng/kb/7yJDNdvC/sP0/LY95WxYhbyF4xXnP5azGGIuHY2kcXoQNAPz+/IE7yTm+/G6+hUilehiYwR5gK3Vf09J/VU0rVAeqwcWK+2/50RLyQQj/miB1LEsXQiI5GU8hJBRNtmFw60nQTmL4IfBw7tTVgl4dBh9tCvyfsvdKY7bfecxSh+lq96KS8L3uI6PVw8HY4DcX16pxDQxROtrjvEc7hyHfMQBoY81TWPYGy8lk+MHO92+sNB7xP67BH6Eb727X+ls0tsr0/BIgj32EaOy7z3drxrXBrWDMvG95T0wjb1uygj2yzs84CzOwLRz0G/gLV9SaXm+s7Znqaj0mW/SlZ99bK4d6yQiJ0PjpQqYWbc3OMmM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 13 May 2025 09:41:10 +0800 "Huang, Ying" wrote: > Joshua Hahn writes: > > > On Mon, 12 May 2025 09:35:16 +0800 "Huang, Ying" wrote: > > > >> Hi, Joshua, > >> > >> Joshua Hahn writes: > >> > >> [snip] > >> > >> > @@ -3707,8 +3720,12 @@ static void wi_state_free(void) > >> > kfree(&wi_group->wi_kobj); > >> > } > >> > > >> > +static struct kobj_attribute wi_auto_attr = > >> > + __ATTR(auto, 0664, weighted_interleave_auto_show, > >> > + weighted_interleave_auto_store); > >> > + > >> > static void wi_cleanup(void) { > >> > - sysfs_remove_file(&wi_group->wi_kobj, &wi_group->auto_kobj_attr.attr); > >> > + sysfs_remove_file(&wi_group->wi_kobj, &wi_auto_attr.attr); > >> > >> If we use wi_auto_attr directly here, we can remove auto_kobj_attr field > >> from struct sysfs_wi_group? > > > > Hi Ying, thank you for this comment. I should have caught it as well. > > Removing the last users / setters doesn't seem complicated. > > > > Andrew, I'm very sorry -- do you think you can fold this fixlet in as well? > > This is a minor change that removes the only users of this variable. > > > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > > index d5ae36d2eda8..8581cc861945 100644 > > --- a/mm/mempolicy.c > > +++ b/mm/mempolicy.c > > @@ -3543,7 +3543,6 @@ struct iw_node_attr { > > struct sysfs_wi_group { > > struct kobject wi_kobj; > > struct mutex kobj_lock; > > - struct kobj_attribute auto_kobj_attr; > > struct iw_node_attr *nattrs[]; > > }; > > > > @@ -3833,7 +3832,6 @@ static int __init add_weighted_interleave_group(struct kobject *mempolicy_kobj) > > err = sysfs_create_file(&wi_group->wi_kobj, &wi_auto_attr.attr); > > if (err) > > goto err_put_kobj; > > - wi_group->auto_kobj_attr = wi_auto_attr > > > > for_each_online_node(nid) { > > if (!node_state(nid, N_MEMORY)) > > > > Thank you both, I hope you have a great day! > > Thanks! LGTM, please feel free to add my > > Reviewed-by: Huang Ying Thank you Ying, really appreciate all of your feedback throughout this series. I hope you have a great day! Joshua > > --- > Best Regards, > Huang, Ying