From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D392C3ABD8 for ; Fri, 16 May 2025 04:56:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96BC96B00AB; Fri, 16 May 2025 00:56:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91B106B00AC; Fri, 16 May 2025 00:56:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80AA56B00AD; Fri, 16 May 2025 00:56:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 647D76B00AB for ; Fri, 16 May 2025 00:56:02 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D20091A1248 for ; Fri, 16 May 2025 04:56:02 +0000 (UTC) X-FDA: 83447558964.11.6570462 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf13.hostedemail.com (Postfix) with ESMTP id 1845C2000C for ; Fri, 16 May 2025 04:56:00 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=lst.de; spf=pass (imf13.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747371361; a=rsa-sha256; cv=none; b=J2DfoAX55JXFHxFz/qaVo5j9zinH3WoeL9S45tuLwJMsp/ZDvVxIIWNWTGN7Fxbs5R23+/ vehdxNYKINcO9bsn6heOlALWO2H+3sA8qbl2hFWZN+O4XjiBCheD3mg7kYHcRCBNlSf3XK psVedfSXBt3SBO8cGikL+J+Onz9n6Sg= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=lst.de; spf=pass (imf13.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747371361; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IzjWBZzYT+ODKDmi07UxcoBaOhFJJCcv3fiX8H9m2HM=; b=rt78npdhilxS4AV+xH1dTPGXzfY08ytGpP7NPptxAWB7IY6DPl99xhgAxTom4B8V43J5aH 9V4xShD0OAGtv8QtqMW2WOXoVQUfniMxLd+3C4/3Z1btw97du0+sZMhQwKBYzlvA3EXurk aUGlXABiyKF2HGFDZao0sR83zNkGHOQ= Received: by verein.lst.de (Postfix, from userid 2407) id 6BA3F68AA6; Fri, 16 May 2025 06:55:55 +0200 (CEST) Date: Fri, 16 May 2025 06:55:54 +0200 From: Christoph Hellwig To: Ryusuke Konishi Cc: Christoph Hellwig , Andrew Morton , Hugh Dickins , Johannes Weiner , Yosry Ahmed , Nhat Pham , Matthew Wilcox , Chengming Zhou , Baolin Wang , linux-nilfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 6/7] nilfs2: remove wbc->for_reclaim handling Message-ID: <20250516045554.GA13127@lst.de> References: <20250508054938.15894-1-hch@lst.de> <20250508054938.15894-7-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1845C2000C X-Rspam-User: X-Stat-Signature: aohtzxa7khdq4ae41dtwdczfjdbs7wtg X-HE-Tag: 1747371360-540758 X-HE-Meta: U2FsdGVkX1/B1vu/FuOp4lWkgn/2xsnnVDfnFfAptqnVSdyaR1/lbvfMG7FDz3pTnSqqnhiomBjpNhtdWAJ3O8UiYeUwXyI0MpT8ZcRCxPIm4pKDW4hVKoLuHeN7K2lJzUNPl5jpKgH2I45COCVJ8IrL3IBo3m9Ia9alQ8iFuzGFJHkhw0OBy72SkZcUs53sTBWphCpI95zq1UZfIhCWsUqUTECYW1VtjxoGXGN0tUTDc4bHffXgRGEkQi2uj8uM9N3Y7SpCnlhYamaYuknBPC++0qwSwirfGA6DmZT+q9aNrn2KBdo9cjoTvJI7kp/qTTEFMz5Ll3Dq1ZpqcaXh9NU2AebWnCGvW5GjJ4bflnTzQ+cG+rFtLq2CHHKu4/k/UdKLdqdaRdfAyHSPNpjh33GX6UA0tcIjQhoT141qpt2iOWDJXLscmNHy2LzIjNhZAkXK04t2sQ7cvnsYLSdPhwdTDs3a6Ec4phKaUDzFlQNuMZSPI/kMBypMrQyTbQu/Un1tSuuLoYvqzV21Z4HZLcwj3YdVWTveurmJ9JRqZWNLE6x0OdJByo9MbUcfXbCDpinsnLtbW400tC+o5mWyKazTXBW+hUhJW+sPaiuhomOaw3YsC4NcOPSlGnwsBFMY0UjyhDGFO26i5jG6jZfU72y0wVBtrGAisOtBLPDk0DHIhluBEEcSPA473K0BPaJU+ph6nxRexQSHjMbw/hSWIzgmfllFJRUkcAMEmtfh5JnmI25CfqkBZDB1ZANNb3rfSQNCEK9IfkzaotyL74z0oSKf2+cyTXeoYj3kezSRunnZ2UxdZ7Ona1k8cSC6Y4koAhFPqtkgfDlAn43KxA9aqiSa/UQQgfCWv1rkAnefKGGXSHYoq+GZzN+j6Dcq4LYOt6HyoJb5LkjbmJXISVOvegaBaJHBOJ/F X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 09, 2025 at 01:16:36AM +0900, Ryusuke Konishi wrote: > > Since commit 013a07052a1a ("nilfs2: convert metadata aops from writepage > > to writepages"), nilfs_mdt_write_folio can't be called from reclaim > > context any more. Remove the code keyed of the wbc->for_rename flag, > > which is now only set for writing out swap or shmem pages inside the > > swap code, but never passed to file systems. > > > > Signed-off-by: Christoph Hellwig > > Yes, the parts removed in this patch look like dead code now. > > So far, no issues have been detected with the previous conversion, but > even if it turns out that something has changed in that conversion and > needs to be fixed, I have no objection to this cleanup. Feel free to > add: Can you queue this up in the nilfs2 tree as it's independent of the previous patches in the series, and the last one can't go in until all dependencies have been merged anyway?