Re: [PATCH 6/7] nilfs2: remove wbc->for_reclaim handling

Ryusuke Konishi
2025-05-16T06:09:20Z

On Fri, May 16, 2025 at 1:55 PM Christoph Hellwig wrote:
>
> On Fri, May 09, 2025 at 01:16:36AM +0900, Ryusuke Konishi wrote:
> > > Since commit 013a07052a1a ("nilfs2: convert metadata aops from writepage
> > > to writepages"), nilfs_mdt_write_folio can't be called from reclaim
> > > context any more. Remove the code keyed of the wbc->for_rename flag,
> > > which is now only set for writing out swap or shmem pages inside the
> > > swap code, but never passed to file systems.
> > >
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> >
> > Yes, the parts removed in this patch look like dead code now.
> >
> > So far, no issues have been detected with the previous conversion, but
> > even if it turns out that something has changed in that conversion and
> > needs to be fixed, I have no objection to this cleanup. Feel free to
> > add:
>
> Can you queue this up in the nilfs2 tree as it's independent of the
> previous patches in the series, and the last one can't go in until
> all dependencies have been merged anyway?

All right, I'll handle this patch so it can go into the next merge
window separately (though it will go through the -mm tree anyway).

Regards,
Ryusuke Konishi