From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70CFCC3ABC9 for ; Fri, 16 May 2025 13:09:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 408856B0166; Fri, 16 May 2025 09:09:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38F2E6B0168; Fri, 16 May 2025 09:09:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BA5C6B0169; Fri, 16 May 2025 09:09:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EE2356B0166 for ; Fri, 16 May 2025 09:09:53 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2FECD591A2 for ; Fri, 16 May 2025 13:09:55 +0000 (UTC) X-FDA: 83448803550.02.67DCFFD Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf17.hostedemail.com (Postfix) with ESMTP id 1327B4001A for ; Fri, 16 May 2025 13:09:52 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=ObqLZ6+h; spf=pass (imf17.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.177 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747400993; a=rsa-sha256; cv=none; b=6/OjpbBJqOvFQ73iIgV75GDOB0GFN4ioE8vKPwDA3/gEz79No2oqF0V4hnChsKe6luFKTW 73v1kTS05RnPU1pnYYNhcRkLD3KQaD5/GYWT3T6EUHFSkI0GIvENxZ5dxRqru6awuHuuGP Uw0eM4faR6lm17v3fR5DyyhbHePXggU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=ObqLZ6+h; spf=pass (imf17.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.177 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747400993; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WBkLgz+xs0k99ZNtnJXNN8FdEZvlmytfCxgniwbp1fs=; b=IX7Oc2AIKRQKwQaJgYk4f2g7QXLV+UpahTIWxAKUcasX83uR3OKElS7FlUKcg7g7KK6ptv i8eqdkqQS1fDSAMD5251a3imTpCgg24BnLLHcN3j/qk6BPeA6W9vBzzrQr021thak9JPcu gYWpOiqSvLLhPrL05dN6wIRHlea15AQ= Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-4775ccf3e56so37417781cf.0 for ; Fri, 16 May 2025 06:09:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1747400992; x=1748005792; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WBkLgz+xs0k99ZNtnJXNN8FdEZvlmytfCxgniwbp1fs=; b=ObqLZ6+hSogiaonh08s97OohsnbqZjrKArV7Smou1IHxsyg9dXQGUKxFeH/aY0KPyi HunYbUqwek+vdYwaYk6dvDqVUGiDl3db5sIh0AS9mee1moHWUBFKlY8FXF5PWkO0y2Sn LLciNjkq3u8s2A4JEMIQWHye8prVDbHpDw4Wy4BtzbfcsFXQnL82ht5CvcUSUTBudjJ/ OT7SoK6Zbhkt6/tDsq5Y57UgS+GBce0U/pjYQeJVVuWtFgtsS2Xgiuk8s0TtJpqZP6kF K0dI0IF1nmnau51oHQ0vo8jqE6tXAvIGSsMy12Do1RO4YjoSRKZDTTpu1905i4a3qXcP BmLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747400992; x=1748005792; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WBkLgz+xs0k99ZNtnJXNN8FdEZvlmytfCxgniwbp1fs=; b=rpA6QWz1Jpu95WNkRVqSdmFH4aeoAAXmnSQhet3ex6RYZhcRuf4/ARGVNF3v0XHZmD AummEhkyz5O3RieGG1vJecCTtNP28rhVHizHQaTHHi4dx5tzWw/WWzJpEhFONKaGzIgD CvuZ69FBiXHz+bBJCcpSZ0lH7JKlobTSTU/1aNLM/KaI1NFjIsT2tPFiNd37dO4yP1r6 LanbR/dobYTYRNIoHL8+4DV4GwJBDcj/PkJ3RIxry8sH/EOQA7auyWNsC69OxfADYFB8 gFAN4EN0UVpdeuTyplVuKXZV9KY7K6+jvs1xGyvlw0aav5QXb5bQvr5Xjxw8A0MFr/IG +VmA== X-Forwarded-Encrypted: i=1; AJvYcCX4K4BYyCPTzpMwb+9eRm4LpVnQGFeMFWlGMOExMvRdshbWnT1aOmmi8732ZKqgGjE5a4O2per+JQ==@kvack.org X-Gm-Message-State: AOJu0Yyl4VZqiymMXioBNWoLKlNpxJG39ryXCQu2S/+38VlMvEoRphVc HjW1PupRAQkgOd/RKL06gayTYxHAYMbvH2xUbaLD0bFSmxvN3mBc7XbbUhre5kHLGAk= X-Gm-Gg: ASbGncs8XhH+PbmRWSkV6d8g8Z8U4L6QfGf8OnQS/8jJrOIp/GeLbaDXzkmioRho+EB rgOPh1cIESfJPJVzzGoBm89R+r2HR+rorCHTOZ66/8oOMaNKAq9TxaJ7ObQoTwOK+9deT9p3/zm /iBYjvFZKe2qFjvHd7ZTQpLEVfnSJoW6t2IXfyjw2IPzGxvtKA0vxff4v6c/uuMBozTrC2J8pJe KWjQ8uO6wz6tuob+mexmE2tluonzXYT3pEMbnbqoenIwvcMImiPyFElwiJUWk8hyr86J6XqXHQv txdprUiCcxLC9OUWd6mSjRaiIZNlnsW6AZnkNtHlAuwsTGBM8+s/UhANAzt5OZ75+iOQPmbDbCt ZpgGZAZTGMB2VGRGiQBn/GL6/4Gk= X-Google-Smtp-Source: AGHT+IHPCApkxTW848mw2pAvy0O37cjq5r1nPCJEjsfJzIZSF+v0PF+8hsJhAhsmje7cLGzcj8IimA== X-Received: by 2002:a05:6214:2428:b0:6e2:4da9:4e2d with SMTP id 6a1803df08f44-6f8b124984bmr51931186d6.9.1747400991725; Fri, 16 May 2025 06:09:51 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-167-56-70.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.167.56.70]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6f8b097a59fsm11761186d6.102.2025.05.16.06.09.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 May 2025 06:09:50 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1uFuow-00000002fSS-05ik; Fri, 16 May 2025 10:09:50 -0300 Date: Fri, 16 May 2025 10:09:50 -0300 From: Jason Gunthorpe To: Sean Christopherson Cc: Rick P Edgecombe , Vishal Annapurve , "palmer@dabbelt.com" , "kvm@vger.kernel.org" , "catalin.marinas@arm.com" , Jun Miao , "nsaenz@amazon.es" , "pdurrant@amazon.co.uk" , "vbabka@suse.cz" , "peterx@redhat.com" , "x86@kernel.org" , "tabba@google.com" , "keirf@google.com" , "quic_svaddagi@quicinc.com" , "amoorthy@google.com" , "pvorel@suse.cz" , "quic_eberman@quicinc.com" , "mail@maciej.szmigiero.name" , "vkuznets@redhat.com" , "anthony.yznaga@oracle.com" , Wei W Wang , "jack@suse.cz" , Maciej Wieczor-Retman , Yan Y Zhao , Dave Hansen , "ajones@ventanamicro.com" , "paul.walmsley@sifive.com" , "quic_mnalajal@quicinc.com" , "aik@amd.com" , "usama.arif@bytedance.com" , "willy@infradead.org" , "rppt@kernel.org" , "bfoster@redhat.com" , "quic_cvanscha@quicinc.com" , Fan Du , "fvdl@google.com" , "linux-kernel@vger.kernel.org" , "thomas.lendacky@amd.com" , "mic@digikod.net" , "oliver.upton@linux.dev" , "akpm@linux-foundation.org" , "steven.price@arm.com" , "muchun.song@linux.dev" , "binbin.wu@linux.intel.com" , Zhiquan1 Li , "rientjes@google.com" , "mpe@ellerman.id.au" , Erdem Aktas , "david@redhat.com" , "hughd@google.com" , Haibo1 Xu , "jhubbard@nvidia.com" , "anup@brainfault.org" , "maz@kernel.org" , Isaku Yamahata , "jthoughton@google.com" , "steven.sistare@oracle.com" , "jarkko@kernel.org" , "quic_pheragu@quicinc.com" , Kirill Shutemov , "chenhuacai@kernel.org" , Kai Huang , "shuah@kernel.org" , "dwmw@amazon.co.uk" , "pankaj.gupta@amd.com" , Chao Peng , "nikunj@amd.com" , Alexander Graf , "viro@zeniv.linux.org.uk" , "pbonzini@redhat.com" , "yuzenghui@huawei.com" , "jroedel@suse.de" , "suzuki.poulose@arm.com" , "jgowans@amazon.com" , Yilun Xu , "liam.merwick@oracle.com" , "michael.roth@amd.com" , "quic_tsoni@quicinc.com" , "richard.weiyang@gmail.com" , Ira Weiny , "aou@eecs.berkeley.edu" , Xiaoyao Li , "qperret@google.com" , "kent.overstreet@linux.dev" , "dmatlack@google.com" , "james.morse@arm.com" , "brauner@kernel.org" , "roypat@amazon.co.uk" , "ackerleytng@google.com" , "linux-fsdevel@vger.kernel.org" , "pgonda@google.com" , "quic_pderrin@quicinc.com" , "linux-mm@kvack.org" , "will@kernel.org" , "hch@infradead.org" Subject: Re: [RFC PATCH v2 00/51] 1G page support for guest_memfd Message-ID: <20250516130950.GA530183@ziepe.ca> References: <24e8ae7483d0fada8d5042f9cd5598573ca8f1c5.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1327B4001A X-Stat-Signature: nxtnjewhemnmwnbda6pnajipkryftjrt X-HE-Tag: 1747400992-481217 X-HE-Meta: U2FsdGVkX1+oK1fXmtsi8ILcPGPE9s65ByCd13DmRjifnHxSTPiKQYD4dGu6hXVGwVIGOD/JffXLDTG+71PolsEm6MT+DRk+r5ei4ThMSqTGA6wFrfGG2nS210d3ONm1ggvP2j1pSUY5qDQgOCoa3edWBietFgp9yR4RY+0HyjU9MUcUqb6/bwj1aXjyW4de9hfLbYRusTQuO8FjvSiQ/bJBpKNfOd6KBiG1qYLT9nHeIXVCRXyj8w3wDjxvJWbkHe60HtDsXaeJONJ10bPIGiMl5FUTUT+C9vpvzeyKBwGyBjkwIJ0umLk0tT8+mv+K1cC4eUeMREEebIhTwsxUv/l/FbQ+1DmqPG2tQBmfCDT0cbibIrUIgWJ7Nxkb9+zbN3ZlC7xd3My96ooyiVRZ1myJRdDsRQDHTwp+SvSKpwmyOjXqIdUEUoVMczMckA1DIqjv8QoNaM+i6pvdVVqLgNgcA8Gn9XY2fnqP7ggwMiD7QZcxPUetDQJExBmMgds2tRLaSA6qJzVG++LECOfOEFv2F49kwo2wUCF6ANrzDhUQPY9sb5VGKdWWYoswCtJzP/hX6U/wD/GNjmYGkhNsWAx8LEmehVjFptgeTzSVzvuQA2NTLNaaqXj/YBp0cC8QLm6kqihzV57DkWappq7y6JZz0qaUs5Ea+2dHUeYfWc4J3wAY0nIabr+dLFL8/cxjAWTB6blCct1/Dhb91s/aGo6QqOzziTa4ts3LiVY6+3zH+8FHKhjdHD73cs8gE7+cBprnXaqML42cZFbovIrvSqw0GPGkRF8KAuLgsCqWShfG9m42fHfG4023etJn24fO+Cjjp5X+LdWZKE+LFk0maUdvrI69rpDSqLtyshcYLvlnU2oKZteIB8l213+eXQ7oPvQGoXqI7Mpf0MSLXqdP89uwt0C8XkG2WL1i9dEO2lRaLG9LMqjpjI/2yF+oxY6Kt6UES5qhl+SvBsbsgl3 Go5kNC1Z e6KtkAs77Eu3/Zn1LmkvE7S85CRf2FZDqmhyFltu4sStpMawtowMW+uUHVByzHnOGmd5MmRdIZElAdCcrnV7DPxTSAd4R2z5XP8036hyJVW3AqHDb8RJcDF0/xWUfPEx+hmUr107DEhjqy1Sjhapi+RobHRIvwCV+tHLJgXzqeVvVxD6F+DWg1RN9P+QwU845swVWBn+FcacKtnfLd8FI9mtz0oszfc/+YCnN4FdPWyBj07Ja4jKUVyIV6+G5HqM/NX0nlaXWRSECjIXjaokbfAd0v87hJyrviYrKluPkHlBafuLni6xNlk//oBoBrVskTPHUW9MAxQToXH1/rgmTxdE+VPJICuKRIoV7knEHd+i48lWniwbf09yUuzDZx4yNOfbkjSl9gHiAfAbslTCorg9o1gDBBs09HvKTXwaC/blmLlWEyvePn8QbcLyIMRQg55nwYkhfXFNh/5j43vmV4mnBE3VKsmOwZcfQd2KUlBYO5Qo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 15, 2025 at 05:57:57PM -0700, Sean Christopherson wrote: > You're conflating two different things. guest_memfd allocating and managing > 1GiB physical pages, and KVM mapping memory into the guest at 1GiB/2MiB > granularity. Allocating memory in 1GiB chunks is useful even if KVM can only > map memory into the guest using 4KiB pages. Even if KVM is limited to 4K the IOMMU might not be - alot of these workloads have a heavy IO component and we need the iommu to perform well too. Frankly, I don't think there should be objection to making memory more contiguous. There is alot of data that this always brings wins somewhere for someone. > The longer term goal of guest_memfd is to make it suitable for backing all VMs, > hence Vishal's "Non-CoCo VMs" comment. Yes, some of this is useful for TDX, but > we (and others) want to use guest_memfd for far more than just CoCo VMs. And > for non-CoCo VMs, 1GiB hugepages are mandatory for various workloads. Yes, even from an iommu perspective with 2D translation we need to have the 1G pages from the S2 resident in the IOTLB or performance falls off a cliff. Jason