From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34539C2D0CD for ; Mon, 19 May 2025 06:26:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 548F06B0082; Mon, 19 May 2025 02:26:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 51EA56B0083; Mon, 19 May 2025 02:26:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C2DE6B0085; Mon, 19 May 2025 02:26:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 133056B0082 for ; Mon, 19 May 2025 02:26:17 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 87DE81213CC for ; Mon, 19 May 2025 06:26:19 +0000 (UTC) X-FDA: 83458672878.17.8323AEE Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by imf09.hostedemail.com (Postfix) with ESMTP id 9AA3214000B for ; Mon, 19 May 2025 06:26:17 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Jsoshtc4; spf=pass (imf09.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747635977; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NWxiWWoevLtui+2Q816C18FoVZShKeU4+z72oyVMeAE=; b=UnHv57tvkcJ8CLOQUdzUtjoJlqggwT7Rcmqr89885gmdrm9s68/HhmBaagqUtfZNTlWjua fZ3an/zY1rxkQgeOiZVlG06i9QV33mYgBAc3oPQ/0Ou+DmweFZxduMYBZav3RO8R8fTk6T CZ3aeFVXUuTr/rHfrzdetpdBB+wwUEM= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Jsoshtc4; spf=pass (imf09.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747635977; a=rsa-sha256; cv=none; b=PtcS92dxRfKCXbcUaVMFBow6mej488HQYKd3A78Jw0yT2mf6GxQNRDWKwQA061Xw66aXDW NoxeBhJkuhaUT6rwyntFdPE12g+b1dj0clxLOGlcSTFvUAjUGnWIYIRNqHR2hy7eByr6dq u1ZzZiE7gwZ9X4Ydr0NOmVAaIz/VMS0= Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-7370a2d1981so3168435b3a.2 for ; Sun, 18 May 2025 23:26:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747635976; x=1748240776; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NWxiWWoevLtui+2Q816C18FoVZShKeU4+z72oyVMeAE=; b=Jsoshtc4pw6CdCocCQ99ZFoUHBngI+xGaHsKDcXoHECCgTjYSk+6SPZVrgYObQ8JC2 SyJ+TjhpkgaP26iZXMzYDHva18WqKaqqA6kqVGZb8fyb/O4y2pfGy6kUFZVYp2FsqJ12 aBAUOVwxutVuXpvH8VDhiIxK1OBq2aVjSSscy5VPaCXMbtWFnFk9wn3SGzA8JXOkYOgq tzXLwdrPmGrqTsQoRBSz6iercl8qaSwWYes0pnjy144lbG8ociBhDK/v6XN7kcuQdnRM +pTvYyAjwCZGFIjXqQpHTc22xS5z2KvfRwgGAZDEFG53eJGZWgdGSf9xUOGBtzTRyoum irDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747635976; x=1748240776; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NWxiWWoevLtui+2Q816C18FoVZShKeU4+z72oyVMeAE=; b=kmq9k+v6dwX5ohtilZ/aERoxqcST3Yw+SVp2Izhqwz80kbPnPUFWe+ymkL5YudQ8cC W3Na3knlJQ2aYkiE7dJYMZNMy5I+mWMtPoGk4KBd6nEiO2ZLgsJNYhkigKW9jyBB1sLe /z0ZQFroTCPV3du1CKcNJXjUPECZQjGyUVFOJ8BvMoeOOlqxK+P3huu2GpfkvAjJzaaC ly+oWvQv7DqC2LBKWlaa+hQMHiHSSemo7ptXKNohPns2H16MaHyi+iphMQUOKx7NWKgP sAWpo/MV5kwV/fO9B/kbUiJFlfe1Xlqgfe384m/IrFEXYBb/+5JWQY6+GQFtsjoytbDZ h0Pw== X-Forwarded-Encrypted: i=1; AJvYcCUZx/230aTap6zucsE35JXdninbdIbYOjrqk9MFN+8hTABusAL0mlPpmRvZdCK7tgEUz3CKIR6D/Q==@kvack.org X-Gm-Message-State: AOJu0YxTfcKZxCjS9e1u7Qe/HgGYuuTxdstVHKRMrCMdaZ/GWgEwt0Li TF/H8XV4kVnjlzs2+dO+Onze5CGuKIS2iuG5EqxwaWUhbBuamxUgpKWm X-Gm-Gg: ASbGncszFN+7qM1VaAE9DO7LNo6TMbp/ICivo4kXgQedtyxjoMoVQ1Dbj1P21DkqewE 7cacZwOv+dYw1qHPS4FUkscmWf3nwdjYLrIRzj2IvGhiVBOH27sTTXWSppAd30tljj6rVabswDY gZkLDArqTkuiPSQjBUhosCfd5VrudX1i4Nqt6nln7REmnDdVxEmITMSs43sDNIf9IXnM9pNg7ze KyPJ+4wa8BanG30u9UtF1B8X6SoFGTkYsPbKFLZ/BLuvnwIl2cCiu3wmi0j1z8g5YRIX8YPZSHy 9PDUP/hF91QlE3uwwcPx1qBOjKZRKR5VBgfSyBPt6O3UZqbjQUu4isIuIydPkg55SLcjxg== X-Google-Smtp-Source: AGHT+IGmkOUH6qpMHvgR5iUTW6clZrFuf6mfg/hIbJxOzrjlpLKw3fd9givoUpchP3/XsUsjRRQWjQ== X-Received: by 2002:a05:6a21:9208:b0:1f5:839e:ece8 with SMTP id adf61e73a8af0-2170cafa2demr17995676637.2.1747635976266; Sun, 18 May 2025 23:26:16 -0700 (PDT) Received: from Barrys-MBP.hub ([118.92.138.162]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-742a98a2550sm5460847b3a.167.2025.05.18.23.26.09 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 18 May 2025 23:26:15 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: ryncsn@gmail.com Cc: akpm@linux-foundation.org, baohua@kernel.org, baolin.wang@linux.alibaba.com, bhe@redhat.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, hughd@google.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nphamcs@gmail.com, ryan.roberts@arm.com, shikemeng@huaweicloud.com, tim.c.chen@linux.intel.com, willy@infradead.org, ying.huang@linux.alibaba.com, yosryahmed@google.com Subject: Re: [PATCH 06/28] mm, swap: rearrange swap cluster definition and helpers Date: Mon, 19 May 2025 18:26:05 +1200 Message-Id: <20250519062605.2357-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: <20250514201729.48420-7-ryncsn@gmail.com> References: <20250514201729.48420-7-ryncsn@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 9AA3214000B X-Rspamd-Server: rspam09 X-Stat-Signature: 4pbmu3ap1c9yjifmoj8m86cu7ab6oine X-HE-Tag: 1747635977-541669 X-HE-Meta: U2FsdGVkX1/w1dJmj3JivHAJRWkkg7aHLIXS0uQ32q1hsjYPGHCnNleWTmb9ZE6Z8bFt0/pGR5uOq2KxQfG48ocuImqoCioy+pKGNnzvMvEQCU5b0a/cr65gL21a/N19yrezctZo+CDJZT3TF02NCCYoBU/OHw9//RxyaGnSkBSgKo95mopj+KQRr/kJW4PZz0Gbd72XZPZ0eJU6rsDA+LIth96rdL4nxYQH15GWTs5QRho2xUHy7e8vPbHqlyvFMk3W58009L/ojv21O1gtkIiLIU/BRrN0shNQ8DcRpcfRaxoMtaW2oU/xkX3ypRVCs8ARUZTFd0GxAQClVj/mBZdp7ovmlAs/qWn3V/OiKjF56yV3TaunnjOSw/9CmJdgT7ddVW3GcY48TJDFVk4bmKkQRtPZXqoN2HzORABrTRyW0EMxBADMZsnLJTpzYR1+zQx4JlPoSpCx971WkS+w4VKuF4IPNdo5y4MJS4w/+grmF3BXIoUGD/+0I51Xb7nOZ9hE71vEcT895w4x1msSALx8LeteHGWyYE/twmX8OyNtiTxzpsbgmK4a6NjcVbIGaYSwFFQ0Vs7Z1JnAxE2MxdQO+kVaibvMKtBSdOInOUwxT3WSrlHM2fCFK7zEFVg3o1DmgXYta9BFqwQpj879czuh5ezL5qp5wdQF4bQU8DfKcBIkxpC9ZSizRGmp0++JCqPk09GYrfG7JaDGn0vRnoMZjz7X57o6eHr2WdXwrZhFcSx4jTnj5LBJ/9cklNDz0XiIbInV/A8QHq7buZKuOFHATc8Tg74nguosemcYpve3J/cTndT+Mxq9lRwyO/1kn21L7UVMo6paTMuff0EJU6xNK2Z81VMgXfNsYxF1aEAjwLfs1Tz6EwQIWJ+PB3LY9GgqguOcfuVFPHF9u07/Rsn5GeAxe1RTDcQ/sYsNFKylkbbEB2hBZm6ad+1ZE1wmjKrIi0sYuZdgaY+326W UgaO0Skc YkTnPIJdZbl42O0xIYPPbFEr/jD/kIBaWf4dDegs8HHCkCb9fsL9E3tQ5rylUZ9Ucx43JzUn0xjL9hxtDQ2w4lpdnHLbFCpWBH3dMzToYp9tcrD2oWkcyFaLiVWi0Mo8W2EF/0c91dX6zrNFjXOHTKIQiB/X8Dq/yoTpuaJNK8FsJO7S5aa8rNlzOU0HDF7zzCoZIAdyjktClnjZgXYchAfns3RYGMpY36nHrOSg/OTA0uAkpNpoHD6nyB5wgA2PvwZYJEJjdne9vB38faXIzwrlPnFUO75d6tbEjrKdrNrZt1cPmlnf0R3lhTRI8NsI9vfNZ2GeEPVLMWsmXHXKtoLLmuzGZhRQw2aE4n7+vWnQsO6ZoN60mokWhuQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > From: Kairui Song > @@ -889,10 +849,8 @@ static unsigned long cluster_alloc_swap_entry(struct swap_info_struct *si, int o > /* Serialize HDD SWAP allocation for each device. */ > spin_lock(&si->global_cluster_lock); > offset = si->global_cluster->next[order]; > - if (offset == SWAP_ENTRY_INVALID) > - goto new_cluster; We are implicitly dropping this. Does it mean the current code is wrong? Do we need some clarification about this? > > - ci = lock_cluster(si, offset); > + ci = swap_lock_cluster(si, offset); > /* Cluster could have been used by another order */ > if (cluster_is_usable(ci, order)) { > if (cluster_is_empty(ci)) Thanks Barry