From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 987B4C54E71 for ; Wed, 21 May 2025 17:18:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C35A6B008C; Wed, 21 May 2025 13:18:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 974646B0093; Wed, 21 May 2025 13:18:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B11C6B0095; Wed, 21 May 2025 13:18:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6D8376B008C for ; Wed, 21 May 2025 13:18:15 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 11092BE48F for ; Wed, 21 May 2025 17:18:15 +0000 (UTC) X-FDA: 83467573350.25.ED2E8DA Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf06.hostedemail.com (Postfix) with ESMTP id 4F951180007 for ; Wed, 21 May 2025 17:18:13 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UffSjrmF; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747847893; a=rsa-sha256; cv=none; b=WqNjdb87z477QkkUzHtmbbruX7jF6bKllTYSq+vAJtDclIPSGUkSu/6hZUIueRl/MT+4uf cK3YaXdXMu1EhAFqddfmFkG+g68Hp0fKeoo2jXOWgkiLyRulOtGoAWG3cMTakGHaKoGI+q UgP2NonEXMMHp5TVw+Xmq2RWqArtIHo= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UffSjrmF; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747847893; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sf4t1o1PQ1Ru0LEZ5wJLgwA4Q6PNhqZW6CjHg1Rx9S4=; b=y+NFbHQr7nlubFdQdy4rL/QgTqwjnAFiOEYAtzRjOaf+dHHvDcUW4rwlWMM7ufcm5krLod GZTUlN3P6xdNQynsrWtJ670Y+72Q716guAsEn/nksacW2mwiWxL3qADWZbbhJAotvfVFh0 SxFuowp1E9XfqnJ0UCU/4FIMuVATBYQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 8E95B629FB; Wed, 21 May 2025 17:18:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 175FFC4CEE4; Wed, 21 May 2025 17:18:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747847892; bh=14JYG8vIqT62fjB/bSsVNtFZxojGaAGPVSvNx2IgS+0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UffSjrmFJqDcpb/gBmEqemkvG/b4uaR1tXmf2pOBSntNmZxwiUo0thojN0n54lppg fMjMqKvlK8Kmd4630V4lZcD8dPdH0DPzIfjjOUuoc91p9gaZt6q6YWhdHMsand5vQn BWSREDj+JgfRoIEtaMVftA9hdrdsECrgbemFC+of2jzH4AzAtcBGZ/2KlKHLgYM2hS TlfbCht+JIQv/acYI3T6ID/sAXb5MZqJ7HAlMQWbwGbWBZX3+u4BC0zMvW+tRT3Lwp rK7YEk5mntoYsSsFBMCqBAcCFz9aSBXuyytcv0VQQpZ7mHB0Qd330+WX7VPMOK0ZnA UfiK8X0ssx/Mg== From: SeongJae Park To: Enze Li Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org Subject: Re: [PATCH] mm/damon: make region calculations more precise Date: Wed, 21 May 2025 10:18:09 -0700 Message-Id: <20250521171809.45618-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250521070747.1458270-1-lienze@kylinos.cn> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: yoycrsfnz1f6sghz47ew5ip56ujsgso7 X-Rspam-User: X-Rspamd-Queue-Id: 4F951180007 X-Rspamd-Server: rspam06 X-HE-Tag: 1747847893-662755 X-HE-Meta: U2FsdGVkX19eTIJJVV5yETRpM3w0EiyY9Av5TZMkBdoULI1c3UV1hv6vlAdyu6U0ZnxTHEPBWY6P3xLJ48mU5jKNjbrjL6NW1u5CPX1OHAtsmTCTh3pJ5szd4EODtnKdskqkN2L4cjT3d+OIE25KLrmFzto1vKXctaPK9r/tVIm6ftbwQ3oB0dg3y0pB2iumSyDeoOnqvjraatfuCwjPExTIA/tOiKxwIMrBWASvp6W1lU0byNHQUHKJy1Jh6ljwePAZ88F+z+1AusJUaUEl/bgB9SZbQJh5R4iRSvIaEYyul3atBblpYMRFS3KrlG5l8w+86aez6lABPw3h5kGQPnr2uau9A4gLNfq5uAdGLQSFCcOi2N8+rX61cT4U6D0NiGoRpf+Y+RC6gZA/kusCJ15dG4BJkcdfFLUpqODiFREmyVwruV3LNUrv+EuCXxtpyYykxWoEm3kkTe2Emxx+Ki/KO5WqMsrKw0j6Tjx0iL/LOwFx0mBU99SuVaWqvj/5HOAX4idy2SE6EkAxjbIT79u4drR28kxDF3nK7FFqwW19qsyAguUGT880dMQAicV/XSrDXQC0dPPwpDubFP5OkeJsKAQlTJo980zxa0QG/IXWPsYGaxyvw/eyHETeQ3Z6mwbqN7pWSJbLapz5c95xfAuJsYWzBuitUPzk+t6qCuxNtu1ZYJFT8kzz52T9C8bdQERrP1x80p1iYRhrqTKujGAL0YeCd5SVhSFZr/vXifiM9zZx5gFYFTjsQ6pxM6bNVMo0IJwqDPjKSPur2q6h3EPvnilX7pbPE0EGK7+CpaFjSJHLKQggHgWrKdsTJ32/QYMivcH9x8exxMXzVHvVhQUC7SfOo0/taW9oqdn9mvURl3ttzeDk2BSuDttX5R1r+FIjOFmDlH5E1COUYN5WOAhN7zEdoHqyt/bU19U0YuKGa6yHMHh8/ciGpcnErf2HSpQtUAzaRvca9d7jd24 VaTTSURY DntMWFYheXiOvk8DL9NJ8HeceAolY4HnCxTKN8wvPgv+x8Crz4IQMeRtKCtlpfIjL/HbKB6RnXxjkCRSR5HY48I2naRCbKqUlACHqp3sgyRGqkeA7tRSVJoZpRikhgP7kBpSYHpk3zn3tkjqUKXE4XfNN4sfbznsJsgfQlPbzK0asoz8Yi1zAJsbd4YwMCQsq0ienbDHs8P52Xug= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Enze, On Wed, 21 May 2025 15:07:47 +0800 Enze Li wrote: > The damon_sz_region() function misses counting one element when > calculating region size, which leads to inaccurate results. This patch > corrects the size calculation by properly accounting for all elements. Thank you for this patch, but I don't think the current calculation is wrong. Please refer to the below comment. > > Signed-off-by: Enze Li > --- > include/linux/damon.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/damon.h b/include/linux/damon.h > index 47e36e6ea203..70473863f7fe 100644 > --- a/include/linux/damon.h > +++ b/include/linux/damon.h > @@ -808,7 +808,7 @@ static inline struct damon_region *damon_first_region(struct damon_target *t) > > static inline unsigned long damon_sz_region(struct damon_region *r) > { > - return r->ar.end - r->ar.start; > + return r->ar.end - r->ar.start + 1; > } 'ar' here is 'struct damon_addr_range' which is for a half-open range. Refer to the comment on 'struct damon_addr_range' definition on include/linux/damon.h for detail. So I don't think the current calculation is wrong. If you think this function also deserves a short comment for clarifying this, your patch for that wil be welcomed :) Please let me know if I'm missing something. Thanks, SJ [...]