From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50218C54F30 for ; Sat, 24 May 2025 16:29:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 617306B0082; Sat, 24 May 2025 12:29:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EF0B6B0083; Sat, 24 May 2025 12:29:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52C426B0085; Sat, 24 May 2025 12:29:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 33F396B0082 for ; Sat, 24 May 2025 12:29:17 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4962612087D for ; Sat, 24 May 2025 16:29:16 +0000 (UTC) X-FDA: 83478336312.06.45137B4 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf14.hostedemail.com (Postfix) with ESMTP id A50DE100007 for ; Sat, 24 May 2025 16:29:14 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MnXrbfAT; spf=pass (imf14.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748104154; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kB9NdUweKJWhJphW7/uA2B+pzUupdBepMuht6ibuEhg=; b=xnCHiEl209F8gSJ7LQ7NUUAfxPwcFuT+N8EbmqOjIa4YMUAGL84rD14Q2LDf6xaiC2tpVP rOXCfRfh4OyYH8fmgr6MGSEy4zpaohOx/CSwEcEVStuFNlqyJCAfAJSfPz6mvv9cts986e Pm4IL4IMUa9UCB0csuuJ3fiz9quSsjE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MnXrbfAT; spf=pass (imf14.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748104154; a=rsa-sha256; cv=none; b=wLpy4Ore38yQ22/4KMy7LAsp93pZFp/dcK1vxCUy0AjLgoBxzKyOLI1h/wNlHSQ9By9f+U yT6hk4xKYsHCJGKZ9IS8gLjelDHHPh9l4Pe15G87kjFYRCwjsxZhALejRWa8Hqra29in/7 fsbY8JhILp2+/edqmzl7W1qQnzz7xZ8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D3FFAA4AA42; Sat, 24 May 2025 16:29:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53D4DC4CEE4; Sat, 24 May 2025 16:29:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748104153; bh=RuxtQQu2rqdKNDy/24jUv4A1KuBO696D+ML/w/cSZ90=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MnXrbfATJLjU7Xp8OT9TWZQJ/yYvrm0lPaSVBDFBAH5nsPytoy1vb+u/6t8zUZy4e BClLHsHDahJgkER2tlwpC4AnfB9UkWjEuDiEiQdMQ69lk5HdJsQYjZ9H1W1yLtwqZC oCyX1L76vLUwtcCNAdSl5cbGxdl8DsfF3BdB6rsDw3njPbWwGB0mmvjku/rNAwBkOM IenCeu2z1k99KCM20M+f3S5s86f1BvVhJz2O5EsjR8Ps69ZV6FI01MaOdL2LUN+7IZ 9Dv+ncyW0ZeLITg0HtuOHTXSiFscDD6BS4J/MhvyhHkSaa3ovzC1vGPdWWDQiXZvdV glvlgBetzXEow== From: SeongJae Park To: Enze Li Cc: SeongJae Park , akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, enze.li@gmx.com Subject: Re: [PATCH] mm/damon: rename primitives to operations Date: Sat, 24 May 2025 09:29:10 -0700 Message-Id: <20250524162910.67889-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250524125536.13267-1-lienze@kylinos.cn> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: A50DE100007 X-Stat-Signature: eo86rwmggmbjo98gkrku56m1d5dtkd94 X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1748104154-969221 X-HE-Meta: U2FsdGVkX1/wMnW2c3fUThd4YscFddwmAsHrj3kkxrtPaW5qkcOG3aU+CQuchrTih6LjcVB7WBJ5Tr7OTyZ73qGc8NNKAxpq6GtlBvCJZl/KQxdfoLXbabZS+qWqiuV4lkDczuU9DyZndzsuT31fe9PAmDPJ7E8Fl6hKW3PFtFVg9+a8dEdOpVLugULBf1F1/1wUcx2xQmiee2cJcwtFAtiXtXGSQuWoNsU1AWyMIFw5i6zi98K6Q8AseuMw164jb0phjZUkU9UqnRCCrF3QdxSHPQ0YbSs3xatKsRRorWAmGSvXdMu+CcgdRjRWxen/GnS/YGp0yTb1mZpTx+dlk7rJDe5Yq7rGX/QIkXEw9/rX5ImtX77Sp3Q9cWQczTiJdE7YPSOokuVI/Le3QUNrRc+M0VaDBTRbhUdODpD+i7YcEA1biFaGJqOaYcFhtvwmMYovBKjXxAs5GnkhAwZ3TbHFl0GokOfBTLvQKq9aRGA966xnjzokSjwA/0d5daWsZArB2HAw1V/F25AWYtOX+KbGgvLz48Y3tDl7nnQfhz4Ayw5FT6JlNuFVVIBRU3lii6GK8txzPfhf+iO56SOT/wEwGk53g48oHdJKpnVpcRiuYYum/tOF0HjZXgAccZzho7c6V9bSUTiaaQEl5ugqedLD+wXKhf5rab6aSdwjxDjXtmkNa8iG8mTH1QYIjak6VuNH3WRJ2D/4OSCG/7ZM4v/cilCgsx/AIt0Li1chZX2vF/1Om7F5lvrg3J3YfhjhjHMmtfPoupycYEBFCubWXdDHXGPq9PdpovS5QNrIggnyvBKwRgDnna7Ru0TdNV7amaSANgvkhDoYrFOfnS34/uyNcDIbHqvSO5V13mm7W2rOYMeIasF339R9BP2Ih9AyJXrc7hF16nkGDbvN5H2vDNtQFpBfrCpEFwjvIQlU2awazbd134OAXcdsbDs1f2p6yZILebupLImY4B3+Z4+ 8Jx78ToO pqFa1EntEMGZnTvGNHgyT3BslfIgCuC+e3PSE5FMGcaVghtrgWoXLJd22y/zHEhD5jF8c9TRBvPD0eZbr56bhWxXTtNeshEo3pcA1+2n9QY6Nb5HU2oE4xkkUJi/4Fh1/bfiq0O2co+gmNTHur0E0jlpqRKV3sTEAxW3CM3L+sJB49ExlCx952J4kjekVcOqkCAQ9uNG53PkQW1Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Enze, On Sat, 24 May 2025 20:55:36 +0800 Enze Li wrote: > The word 'primitive' is not explicit and has been deprecated in DAMON's > context since commit f7d911c39cbb ("mm/damon: rename damon_primitives to > damon_operations"). To make the code easier to be understand, this > commit renames remaining 'primitives' to 'operations' in header comments > of DAMON source files. Thank you for this patch! The description makes sense to me. The title makes me bit confused, though. By reading it, I was assuming this patch is changing some code. But this is changing only comments. Could you please make the title more clearly specify that? E.g., "fix outdated comments for monitoring primitives"? > > Fixes: f7d911c39cbb ("mm/damon: rename damon_primitives to damon_operations") > Signed-off-by: Enze Li > --- > mm/damon/modules-common.c | 2 +- > mm/damon/modules-common.h | 2 +- > mm/damon/ops-common.c | 2 +- > mm/damon/ops-common.h | 2 +- > mm/damon/paddr.c | 2 +- > mm/damon/sysfs-common.c | 2 +- > mm/damon/sysfs-common.h | 2 +- > mm/damon/vaddr.c | 2 +- > 8 files changed, 8 insertions(+), 8 deletions(-) But, the term (primitives) on the comments of the files means the DAMON monitoring primitives (old name of DAMON operations) only in {p,v}addr.c files. On the comment of other files, the term means code for basic and common uses. Using 'Operations' term on the files look ok to me. But in the case, the commit message may better to slightly be updated to clarify this. Just keeping those files to use 'Primitives' term, or using a more neutral term, say, Code (e.g., Common Code for DAMON Modules) could also be options, in my opinion. I have no strong preference among these three options. Please pick what you prefer. Could you please revise as abovely suggested and resend? Thanks, SJ [...]