[PATCH] mm/damon: rename primitives to operations

[PATCH] mm/damon: rename primitives to operations

[Enze Li]

The word 'primitive' is not explicit and has been deprecated in DAMON's
context since commit f7d911c39cbb ("mm/damon: rename damon_primitives to
damon_operations").  To make the code easier to be understand, this
commit renames remaining 'primitives' to 'operations' in header comments
of DAMON source files.

Fixes: f7d911c39cbb ("mm/damon: rename damon_primitives to damon_operations")
Signed-off-by: Enze Li <lienze@kylinos.cn>
---
 mm/damon/modules-common.c | 2 +-
 mm/damon/modules-common.h | 2 +-
 mm/damon/ops-common.c     | 2 +-
 mm/damon/ops-common.h     | 2 +-
 mm/damon/paddr.c          | 2 +-
 mm/damon/sysfs-common.c   | 2 +-
 mm/damon/sysfs-common.h   | 2 +-
 mm/damon/vaddr.c          | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/mm/damon/modules-common.c b/mm/damon/modules-common.c
index 7cf96574cde7..61b38322a3aa 100644
--- a/mm/damon/modules-common.c
+++ b/mm/damon/modules-common.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Common Primitives for DAMON Modules
+ * Common Operations for DAMON Modules
  *
  * Author: SeongJae Park <sj@kernel.org>
  */
diff --git a/mm/damon/modules-common.h b/mm/damon/modules-common.h
index f49cdb417005..f1ffcc80a7bd 100644
--- a/mm/damon/modules-common.h
+++ b/mm/damon/modules-common.h
@@ -1,6 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0 */
 /*
- * Common Primitives for DAMON Modules
+ * Common Operations for DAMON Modules
  *
  * Author: SeongJae Park <sj@kernel.org>
  */
diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c
index 0db1fc70c84d..1da3932b6775 100644
--- a/mm/damon/ops-common.c
+++ b/mm/damon/ops-common.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Common Primitives for Data Access Monitoring
+ * Common Operations for Data Access Monitoring
  *
  * Author: SeongJae Park <sj@kernel.org>
  */
diff --git a/mm/damon/ops-common.h b/mm/damon/ops-common.h
index 18d837d11bce..1820945679b1 100644
--- a/mm/damon/ops-common.h
+++ b/mm/damon/ops-common.h
@@ -1,6 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0 */
 /*
- * Common Primitives for Data Access Monitoring
+ * Common Operations for Data Access Monitoring
  *
  * Author: SeongJae Park <sj@kernel.org>
  */
diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c
index 1b70d3f36046..a299fdda26e4 100644
--- a/mm/damon/paddr.c
+++ b/mm/damon/paddr.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * DAMON Primitives for The Physical Address Space
+ * DAMON Operations for The Physical Address Space
  *
  * Author: SeongJae Park <sj@kernel.org>
  */
diff --git a/mm/damon/sysfs-common.c b/mm/damon/sysfs-common.c
index 70edf45c2174..107c4c20231d 100644
--- a/mm/damon/sysfs-common.c
+++ b/mm/damon/sysfs-common.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Common Primitives for DAMON Sysfs Interface
+ * Common Operations for DAMON Sysfs Interface
  *
  * Author: SeongJae Park <sj@kernel.org>
  */
diff --git a/mm/damon/sysfs-common.h b/mm/damon/sysfs-common.h
index 70d84bdc9f5f..d1c1b2e857f0 100644
--- a/mm/damon/sysfs-common.h
+++ b/mm/damon/sysfs-common.h
@@ -1,6 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0 */
 /*
- * Common Primitives for DAMON Sysfs Interface
+ * Common Operations for DAMON Sysfs Interface
  *
  * Author: SeongJae Park <sj@kernel.org>
  */
diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c
index e6d99106a7f9..d034e7b5ddb8 100644
--- a/mm/damon/vaddr.c
+++ b/mm/damon/vaddr.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * DAMON Primitives for Virtual Address Spaces
+ * DAMON Operations for Virtual Address Spaces
  *
  * Author: SeongJae Park <sj@kernel.org>
  */
-- 
2.49.0

Re: [PATCH] mm/damon: rename primitives to operations

[SeongJae Park]

Hi Enze,

On Sat, 24 May 2025 20:55:36 +0800 Enze Li <lienze@kylinos.cn> wrote:

> The word 'primitive' is not explicit and has been deprecated in DAMON's
> context since commit f7d911c39cbb ("mm/damon: rename damon_primitives to
> damon_operations").  To make the code easier to be understand, this
> commit renames remaining 'primitives' to 'operations' in header comments
> of DAMON source files.

Thank you for this patch!  The description makes sense to me.

The title makes me bit confused, though.  By reading it, I was assuming this
patch is changing some code.  But this is changing only comments.  Could you
please make the title more clearly specify that?  E.g., "fix outdated comments
for monitoring primitives"?

> 
> Fixes: f7d911c39cbb ("mm/damon: rename damon_primitives to damon_operations")
> Signed-off-by: Enze Li <lienze@kylinos.cn>
> ---
>  mm/damon/modules-common.c | 2 +-
>  mm/damon/modules-common.h | 2 +-
>  mm/damon/ops-common.c     | 2 +-
>  mm/damon/ops-common.h     | 2 +-
>  mm/damon/paddr.c          | 2 +-
>  mm/damon/sysfs-common.c   | 2 +-
>  mm/damon/sysfs-common.h   | 2 +-
>  mm/damon/vaddr.c          | 2 +-
>  8 files changed, 8 insertions(+), 8 deletions(-)

But, the term (primitives) on the comments of the files means the DAMON
monitoring primitives (old name of DAMON operations) only in {p,v}addr.c files.
On the comment of other files, the term means code for basic and common uses.

Using 'Operations' term on the files look ok to me.  But in the case, the
commit message may better to slightly be updated to clarify this.

Just keeping those files to use 'Primitives' term, or using a more neutral
term, say, Code (e.g., Common Code for DAMON Modules) could also be options, in
my opinion.

I have no strong preference among these three options.  Please pick what you
prefer.

Could you please revise as abovely suggested and resend?


Thanks,
SJ

[...]

[PATCH v2] mm/damon: fix outdated comments for monitoring primitives

[Enze Li]

The word 'primitive' is not explicit.  To make the code easier to be
understood, this commit renames 'primitives' to 'code' in header
comments of some source files.

Signed-off-by: Enze Li <lienze@kylinos.cn>
---
Changes in v2:
- Fixed commit message maintainer feedback.
- Use a more neutral term instead of 'primitive'.
---
 mm/damon/modules-common.c | 2 +-
 mm/damon/modules-common.h | 2 +-
 mm/damon/ops-common.c     | 2 +-
 mm/damon/ops-common.h     | 2 +-
 mm/damon/paddr.c          | 2 +-
 mm/damon/sysfs-common.c   | 2 +-
 mm/damon/sysfs-common.h   | 2 +-
 mm/damon/vaddr.c          | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/mm/damon/modules-common.c b/mm/damon/modules-common.c
index 7cf96574cde7..86d58f8c4f63 100644
--- a/mm/damon/modules-common.c
+++ b/mm/damon/modules-common.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Common Primitives for DAMON Modules
+ * Common Code for DAMON Modules
  *
  * Author: SeongJae Park <sj@kernel.org>
  */
diff --git a/mm/damon/modules-common.h b/mm/damon/modules-common.h
index f49cdb417005..f103ad556368 100644
--- a/mm/damon/modules-common.h
+++ b/mm/damon/modules-common.h
@@ -1,6 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0 */
 /*
- * Common Primitives for DAMON Modules
+ * Common Code for DAMON Modules
  *
  * Author: SeongJae Park <sj@kernel.org>
  */
diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c
index 0db1fc70c84d..b43620fee6bb 100644
--- a/mm/damon/ops-common.c
+++ b/mm/damon/ops-common.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Common Primitives for Data Access Monitoring
+ * Common Code for Data Access Monitoring
  *
  * Author: SeongJae Park <sj@kernel.org>
  */
diff --git a/mm/damon/ops-common.h b/mm/damon/ops-common.h
index 18d837d11bce..cc9f5da9c012 100644
--- a/mm/damon/ops-common.h
+++ b/mm/damon/ops-common.h
@@ -1,6 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0 */
 /*
- * Common Primitives for Data Access Monitoring
+ * Common Code for Data Access Monitoring
  *
  * Author: SeongJae Park <sj@kernel.org>
  */
diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c
index 1b70d3f36046..c9c338170603 100644
--- a/mm/damon/paddr.c
+++ b/mm/damon/paddr.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * DAMON Primitives for The Physical Address Space
+ * DAMON Code for The Physical Address Space
  *
  * Author: SeongJae Park <sj@kernel.org>
  */
diff --git a/mm/damon/sysfs-common.c b/mm/damon/sysfs-common.c
index 70edf45c2174..ffaf285e241a 100644
--- a/mm/damon/sysfs-common.c
+++ b/mm/damon/sysfs-common.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Common Primitives for DAMON Sysfs Interface
+ * Common Code for DAMON Sysfs Interface
  *
  * Author: SeongJae Park <sj@kernel.org>
  */
diff --git a/mm/damon/sysfs-common.h b/mm/damon/sysfs-common.h
index 70d84bdc9f5f..2099adee11d0 100644
--- a/mm/damon/sysfs-common.h
+++ b/mm/damon/sysfs-common.h
@@ -1,6 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0 */
 /*
- * Common Primitives for DAMON Sysfs Interface
+ * Common Code for DAMON Sysfs Interface
  *
  * Author: SeongJae Park <sj@kernel.org>
  */
diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c
index e6d99106a7f9..46554e49a478 100644
--- a/mm/damon/vaddr.c
+++ b/mm/damon/vaddr.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * DAMON Primitives for Virtual Address Spaces
+ * DAMON Code for Virtual Address Spaces
  *
  * Author: SeongJae Park <sj@kernel.org>
  */

base-commit: 0ff41df1cb268fc69e703a08a57ee14ae967d0ca
-- 
2.43.0

Re: [PATCH] mm/damon: rename primitives to operations

[Enze Li]

Hi SeongJae,

On Sat, May 24 2025 at 09:29:10 AM -0700, SeongJae Park wrote:

> Hi Enze,
>
> On Sat, 24 May 2025 20:55:36 +0800 Enze Li <lienze@kylinos.cn> wrote:
>
>> The word 'primitive' is not explicit and has been deprecated in DAMON's
>> context since commit f7d911c39cbb ("mm/damon: rename damon_primitives to
>> damon_operations").  To make the code easier to be understand, this
>> commit renames remaining 'primitives' to 'operations' in header comments
>> of DAMON source files.
>
> Thank you for this patch!  The description makes sense to me.
>
> The title makes me bit confused, though.  By reading it, I was assuming this
> patch is changing some code.  But this is changing only comments.  Could you
> please make the title more clearly specify that?  E.g., "fix outdated comments
> for monitoring primitives"?
>
>> 
>> Fixes: f7d911c39cbb ("mm/damon: rename damon_primitives to damon_operations")
>> Signed-off-by: Enze Li <lienze@kylinos.cn>
>> ---
>>  mm/damon/modules-common.c | 2 +-
>>  mm/damon/modules-common.h | 2 +-
>>  mm/damon/ops-common.c     | 2 +-
>>  mm/damon/ops-common.h     | 2 +-
>>  mm/damon/paddr.c          | 2 +-
>>  mm/damon/sysfs-common.c   | 2 +-
>>  mm/damon/sysfs-common.h   | 2 +-
>>  mm/damon/vaddr.c          | 2 +-
>>  8 files changed, 8 insertions(+), 8 deletions(-)
>
> But, the term (primitives) on the comments of the files means the DAMON
> monitoring primitives (old name of DAMON operations) only in {p,v}addr.c files.
> On the comment of other files, the term means code for basic and common uses.
>
> Using 'Operations' term on the files look ok to me.  But in the case, the
> commit message may better to slightly be updated to clarify this.
>
> Just keeping those files to use 'Primitives' term, or using a more neutral
> term, say, Code (e.g., Common Code for DAMON Modules) could also be options, in
> my opinion.
>
> I have no strong preference among these three options.  Please pick what you
> prefer.

Thanks for your suggestion.  It seems to me that using 'Code' term is a
reasonable choice.

>
> Could you please revise as abovely suggested and resend?

I've sent a v2 to the current thread, many thanks for your review and
suggestions!  Please let me know if further adjustments are needed.

BR,
Enze

>
>
> Thanks,
> SJ
>
> [...]

Re: [PATCH] mm/damon: rename primitives to operations

[David Hildenbrand]

On 24.05.25 18:29, SeongJae Park wrote:
> Hi Enze,
> 
> On Sat, 24 May 2025 20:55:36 +0800 Enze Li <lienze@kylinos.cn> wrote:
> 
>> The word 'primitive' is not explicit and has been deprecated in DAMON's
>> context since commit f7d911c39cbb ("mm/damon: rename damon_primitives to
>> damon_operations").  To make the code easier to be understand, this
>> commit renames remaining 'primitives' to 'operations' in header comments
>> of DAMON source files.
> 
> Thank you for this patch!  The description makes sense to me.
> 
> The title makes me bit confused, though.  By reading it, I was assuming this
> patch is changing some code.  But this is changing only comments.  Could you
> please make the title more clearly specify that?  E.g., "fix outdated comments
> for monitoring primitives"?

Heh, but wouldn't we be calling this things "primitives" in the current 
context?

"don't refer to common code as 'primitives'"

-- 
Cheers,

David / dhildenb

Re: [PATCH] mm/damon: rename primitives to operations

[SeongJae Park]

Hi David,

On Mon, 26 May 2025 11:31:45 +0200 David Hildenbrand <david@redhat.com> wrote:

> On 24.05.25 18:29, SeongJae Park wrote:
> > Hi Enze,
> > 
> > On Sat, 24 May 2025 20:55:36 +0800 Enze Li <lienze@kylinos.cn> wrote:
> > 
> >> The word 'primitive' is not explicit and has been deprecated in DAMON's
> >> context since commit f7d911c39cbb ("mm/damon: rename damon_primitives to
> >> damon_operations").  To make the code easier to be understand, this
> >> commit renames remaining 'primitives' to 'operations' in header comments
> >> of DAMON source files.
> > 
> > Thank you for this patch!  The description makes sense to me.
> > 
> > The title makes me bit confused, though.  By reading it, I was assuming this
> > patch is changing some code.  But this is changing only comments.  Could you
> > please make the title more clearly specify that?  E.g., "fix outdated comments
> > for monitoring primitives"?
> 
> Heh, but wouldn't we be calling this things "primitives" in the current 
> context?

Thanks for giving us this good point.  I was reading this as "fix outdated
comments for monitoring primitives (, which is a deprecated term)".  And I
agree this is not very clear.

> 
> "don't refer to common code as 'primitives'"

Nice suggestion.  But, this wouldn't explain the changes to {p,v}addr.c files,
since those are not for common code.

Maybe "mm/damon: s/primitives/code/ on comments" could also be a simple and not
that bad title?


Thanks,
SJ

> 
> -- 
> Cheers,
> 
> David / dhildenb

Re: [PATCH] mm/damon: rename primitives to operations

[SeongJae Park]

On Mon, 26 May 2025 14:25:40 +0800 Enze Li <lienze@kylinos.cn> wrote:

> Hi SeongJae,
> 
> On Sat, May 24 2025 at 09:29:10 AM -0700, SeongJae Park wrote:
[...]
> >
> > Could you please revise as abovely suggested and resend?
> 
> I've sent a v2 to the current thread,

I think it is more common to send new versions of a patch as a new thread,
rather than as a reply to an old version.  Please do so from next time, for a
consistency.

> many thanks for your review and
> suggestions!  Please let me know if further adjustments are needed.

David gave us good point[1] to think about the title.  I don't think that's a
strict blocker, but also no reason to rush on this.  So let's take a bit more
time for the discussion, unless this is urgent for you.

[1] https://lore.kernel.org/dc5391f3-6e0a-4e6a-b319-0c602af29202@redhat.com


Thanks,
SJ

[...]

Re: [PATCH v2] mm/damon: fix outdated comments for monitoring primitives

[SeongJae Park]

On Mon, 26 May 2025 14:09:01 +0800 Enze Li <lienze@kylinos.cn> wrote:

> The word 'primitive' is not explicit.  To make the code easier to be
> understood, this commit renames 'primitives' to 'code' in header
> comments of some source files.
> 
> Signed-off-by: Enze Li <lienze@kylinos.cn>

So we have an ongoing discussion for the title[1].  Other than that, all looks
good to me and I believe the discussion will not change this patch
significantly.  So, giving my Reviewed-by first.

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

[...]

Re: [PATCH] mm/damon: rename primitives to operations

[SeongJae Park]

On Mon, 26 May 2025 10:55:24 -0700 SeongJae Park <sj@kernel.org> wrote:

[...]
> Maybe "mm/damon: s/primitives/code/ on comments" could also be a simple and not
> that bad title?

I understand we found no real concern on this. :)  Thanks to all discussion
participants and their patience.  Of course, just add more comments if you just
forgot posting it and I'm rushing.

Enze, could you please post v3 with the updated title?


Thanks,
SJ

[...]

Re: [PATCH] mm/damon: rename primitives to operations

[Enze Li]

On Mon, May 26 2025 at 11:09:21 AM -0700, SeongJae Park wrote:

> On Mon, 26 May 2025 14:25:40 +0800 Enze Li <lienze@kylinos.cn> wrote:
>
>> Hi SeongJae,
>> 
>> On Sat, May 24 2025 at 09:29:10 AM -0700, SeongJae Park wrote:
> [...]
>> >
>> > Could you please revise as abovely suggested and resend?
>> 
>> I've sent a v2 to the current thread,
>
> I think it is more common to send new versions of a patch as a new thread,
> rather than as a reply to an old version.  Please do so from next time, for a
> consistency.

Noted -- I'll keep that in mind.

BR,
Enze

[...]

Re: [PATCH] mm/damon: rename primitives to operations

[Enze Li]

Hi SeongJae,

On Thu, May 29 2025 at 10:26:47 AM -0700, SeongJae Park wrote:

> On Mon, 26 May 2025 10:55:24 -0700 SeongJae Park <sj@kernel.org> wrote:
>
> [...]
>> Maybe "mm/damon: s/primitives/code/ on comments" could also be a simple and not
>> that bad title?
>
> I understand we found no real concern on this. :)  Thanks to all discussion
> participants and their patience.  Of course, just add more comments if you just
> forgot posting it and I'm rushing.
>
> Enze, could you please post v3 with the updated title?

I've sent the v3 here [1].  Thank you for reviewing, and my appreciation
to David as well.

[1] https://lore.kernel.org/all/20250530053115.153238-1-lienze@kylinos.cn/

BR,
Enze

[...]