From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28692C5AD49 for ; Mon, 26 May 2025 15:49:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC4F96B0085; Mon, 26 May 2025 11:49:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9C846B0088; Mon, 26 May 2025 11:49:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A64E96B0089; Mon, 26 May 2025 11:49:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8B9476B0085 for ; Mon, 26 May 2025 11:49:48 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id ED56A5B991 for ; Mon, 26 May 2025 15:49:47 +0000 (UTC) X-FDA: 83485494414.04.DD2444E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id EFA1A4000E for ; Mon, 26 May 2025 15:49:45 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KTTTUmCU; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748274586; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=71sBxG+HNn06KJZZiyUhTeRS7hpVP19g02Rul7ZiNbM=; b=7+HR5TkofwFbZtOAxRN918K28N+Kz3JnvFRhO97TC8SXBablrmlL7q4jRFJ+G4ReKMlZ3X xzpBrHPFcIffluqpLp1aAbaalQw4U3RAf65yWq6g8Qz6LBKZG1B3ThqQwrKA0Zj6BnsWgF Af+PnVDo+Livf/Xdv2whZ2YSrBD4eb8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KTTTUmCU; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748274586; a=rsa-sha256; cv=none; b=ovYZ+WKhXntoM+050qqpbRpe5vSDIAuLNzVSkL4oh/PDmqStg5W7EUjqqZ4yhi0UYZganY MjaYtg/BpTaSWBhq7sRZYO/9CFPwQ+zDS4q4DEahkaWh0L4UHHu+0L0KYBlt6nXl3Yeif2 mv5zjZd725vSw8FaiqhtOQuZOQDlDPs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748274585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=71sBxG+HNn06KJZZiyUhTeRS7hpVP19g02Rul7ZiNbM=; b=KTTTUmCUSyiPYkXaVyzXO3mGYxmaH5c0Ah6nayUNc0XTJcvu6PKj7NAqv3WZnyF+h3Yfve 66pb9TaTjNhxVAOT41jEpTREDS5LdcfvEJJRJGJjXsYaJeFQg1X8A09Latwj5hrEXs2Lls whVXCn0oInVCOIFtb4heHYUM/EKLZWc= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-156-YiTpz-tYOrCvnBpakVAylA-1; Mon, 26 May 2025 11:49:41 -0400 X-MC-Unique: YiTpz-tYOrCvnBpakVAylA-1 X-Mimecast-MFC-AGG-ID: YiTpz-tYOrCvnBpakVAylA_1748274579 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5130B19560B5; Mon, 26 May 2025 15:49:38 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.44.32.4]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 0FE69195608D; Mon, 26 May 2025 15:49:32 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 26 May 2025 17:48:57 +0200 (CEST) Date: Mon, 26 May 2025 17:48:51 +0200 From: Oleg Nesterov To: Pu Lehui Cc: David Hildenbrand , lorenzo.stoakes@oracle.com, mhiramat@kernel.org, peterz@infradead.org, Liam.Howlett@oracle.com, akpm@linux-foundation.org, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pulehui@huawei.com Subject: Re: [RFC PATCH] mm/mmap: Fix uprobe anon page be overwritten when expanding vma during mremap Message-ID: <20250526154850.GA4156@redhat.com> References: <20250521092503.3116340-1-pulehui@huaweicloud.com> <62b5ccf5-f1cd-43c2-b0bc-f542f40c5bdf@redhat.com> <13c5fe73-9e11-4465-b401-fc96a22dc5d1@redhat.com> <4cbc1e43-ea46-44de-9e2b-1c62dcd2b6d5@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4cbc1e43-ea46-44de-9e2b-1c62dcd2b6d5@huaweicloud.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: EFA1A4000E X-Stat-Signature: z1efgaihfw8qfghbtbdn4nqixjreeisy X-Rspam-User: X-HE-Tag: 1748274585-577901 X-HE-Meta: U2FsdGVkX1/yRowLTRTokyeZhP8wyGo4CZatXxONVlpoaU5wcsyI/BM/GJppW9kCwwa1Jd0PqLUTCY1SypjwYkTXGiskIzEKvRNRgdxdYos/5QQJLAN51ibwf5ntMhY4Q6qpgGOXqFMGRxutE38cV7zMRrXhIzEZRv9qpM5GWIQAFwboG6MqoGc8i7Q+bKuhcgQ96OkBl4XuY93fsJqyZnLxwPIVZue5/iv+jkY15/FEQ5TlBtNjl/rXJhjazeDIrvrKvbLY5uW7fOsqgWBvkUDfwwdSPoLGsEn3vQCVW9I+hMF0m1FXDPwe02iNSKh08tbLE1+vBcZIk5qtvBbz7IwSX2jfmUdhXXNlEH4FlJFWPCDucJ2zV3mDIOamN18ZSYAI0gsZLDJkO8z8Q/9OriYCGaQavZQtMlkIwLS7iQjAgBuxH92pDJLF6QMYXBquK2xWf0dUeF5sl5DT2BEyMiOlSd3Wvb/206IWczFTe4aUo+IrOa3o3D1XBAm32clf+LgV+uk1S9c4BTTW1H4OrVkdbuq2BtLZMsLXw4aB8I7jRBpQ0n22+WxcKt9nse8bShfPGoNFN6nyuEsZRNJe2t1TGfYVGoC6QpsXPLnw5zf5TVtwWXvBTZZUVghuaw7toUIgzEb25+pik21pkjSccyuLutsnDWTNoQKtFexcRmIU9uLzJZ1CRQ1V0/RGteMHMy7eWM6z9R/XGJ62RLDfQtpEzuWO9sM5kUL8RhkmQh5yDboOnstAVu/behiAt3WguLMT1WWuqfi7nY2feTNYtw0JG4BMaHbwHs7Hh4irMS+FwffDkXGaCxBKZTK9sdxI+1JTqtHGbF03nDLjvgmdu0Hz13rHiJgHeSQQF3GLMeKXquaaP2+kypkJFLMkiu9YTO5U3tU3QwQoNNF0Kt6BcoKNnHcobdrlo4Qsvq76C6mpnHm6UVtEZiv2ebFgW6rSIO8Kw7aj0MXJ5X7Bjt9 +vQcQir4 Y2xYIm13GCKBjxalr3GOzx5IxqqZekz9MKEFxqWUvZT3UnDbckemQwD4zb6jb7tHO68E7BGVRv5i8g7ZUoC95VWf7AYfYZbdUGXba2tBWgQm2lxsxlFuKYOQwoZ6YlhatKUrhWlxqU5kb4CNnDcjRKU66MGmYzAZ88WP3Juu7SyxxYVvTTrjp8C1Y67j28eSBF3UAHVUii2fLhjXXcQIu1mlUJ0/cWy+QWAH8TrVOCpJ9ftj9uyRw3W3YQx0M6mW8ztH0DN1LQGktZ60PQHQRGEyKJ+m9NXn1rG1Vl6g5rHTyKl8dlisL8BZkPD6S8joDgIDY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Lehui, As I said, I don't understand mm/, so can't comment, but... On 05/26, Pu Lehui wrote: > > To make things simpler, perhaps we could try post-processing, that is: > > diff --git a/mm/mremap.c b/mm/mremap.c > index 83e359754961..46a757fd26dc 100644 > --- a/mm/mremap.c > +++ b/mm/mremap.c > @@ -240,6 +240,11 @@ static int move_ptes(struct pagetable_move_control > *pmc, > if (pte_none(ptep_get(old_pte))) > continue; > > + /* skip move pte when expanded range has uprobe */ > + if (unlikely(pte_present(*new_pte) && > + vma_has_uprobes(pmc->new, new_addr, new_addr + > PAGE_SIZE))) > + continue; > + I was thinking about WARN_ON(!pte_none(*new_pte)) at the start of the main loop. Obviously not to fix the problem, but rather to make it more explicit. This matches the similar xxx_none() checks in the move_pgt_entry() paths, say, move_normal_pmd(). Oleg.