From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FE4BC54FB3 for ; Mon, 26 May 2025 16:30:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 908316B007B; Mon, 26 May 2025 12:30:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B9836B0083; Mon, 26 May 2025 12:30:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CF166B0085; Mon, 26 May 2025 12:30:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 62B836B007B for ; Mon, 26 May 2025 12:30:38 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 118E31A006F for ; Mon, 26 May 2025 16:30:38 +0000 (UTC) X-FDA: 83485597356.03.757CA17 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 290F21C000D for ; Mon, 26 May 2025 16:30:36 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=acSozPIK; spf=pass (imf20.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748277036; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NBvrMK19KSp/CiSx2kvd5/A5fAYRmLTfpOnBN4783vc=; b=yDrU572yD0CkfqVEmbhTyGQRvwO5CX7EfyIuRdq1lDn98+JNu4CLeqLwPSxzsAMwozOCl4 yTtLrmRgWCBZjOaEoPYE7x3z2QCZ1LxguddmwGHZafyW9240bS4nW07BSX9Mfnn6lvE/TW IEkWl5l/OYDgJn/KfCY46rcvT+iv7uo= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=acSozPIK; spf=pass (imf20.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748277036; a=rsa-sha256; cv=none; b=1KFVRzPdpQBKSt0MLdIsO4dGicvuP+GjLxrX64Cx1vpyKsWk+MoavDH00H0DeSFHWkhocp bNeiAkhYXKVo3eTpNk/hThvIhQ9nis+L8h4Fqz4IQVzZ9hd05e5ybVYITeNfGrcthIVvPz 9vLxZKyn7DCeDlSJQkTOKDzmvR/6JyY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748277035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NBvrMK19KSp/CiSx2kvd5/A5fAYRmLTfpOnBN4783vc=; b=acSozPIKjQwx+o4c0pEJu4pziqhYHMuZKC7zSc7NCk3zncwq92bH2AbZYo4UyQd1rd+GUt g/p2ZY2DKfnPdIdmA4KWfrg1qzg40YXzi3kFWtHCHRjSYC76SZQc2wpfuNsmJ3y+4VTp91 zeu+yPMd8Fyk7hUxXqMVBgk5ncOJ3o8= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-388-nUvMjtZ7PB6awxYb-O0jmQ-1; Mon, 26 May 2025 12:30:31 -0400 X-MC-Unique: nUvMjtZ7PB6awxYb-O0jmQ-1 X-Mimecast-MFC-AGG-ID: nUvMjtZ7PB6awxYb-O0jmQ_1748277029 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EE5C51800570; Mon, 26 May 2025 16:30:28 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.44.32.4]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 41B4B19560A3; Mon, 26 May 2025 16:30:22 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 26 May 2025 18:29:48 +0200 (CEST) Date: Mon, 26 May 2025 18:29:41 +0200 From: Oleg Nesterov To: David Hildenbrand Cc: Pu Lehui , Lorenzo Stoakes , mhiramat@kernel.org, peterz@infradead.org, akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pulehui@huawei.com, Andrii Nakryiko , Jiri Olsa Subject: Re: [RFC PATCH] mm/mmap: Fix uprobe anon page be overwritten when expanding vma during mremap Message-ID: <20250526162940.GB4156@redhat.com> References: <20250521092503.3116340-1-pulehui@huaweicloud.com> <20250524164516.GA11642@redhat.com> <20250525095926.GA5391@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Stat-Signature: w8aax9h8i3zkk5zfj1dscgxahgfc1h64 X-Rspamd-Queue-Id: 290F21C000D X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1748277035-600834 X-HE-Meta: U2FsdGVkX18SynIiQ0S7fxcCeEtF3gLkUrGifoHvgmLoh+A3q24CgK4Fz7ktkKEICfVTdjaYUmZYqqMGPSVq5o1eLhduix9KevQ8p7+vaSkBY7DG1mrMyU17KwJJqtZ83KIfds2e3WkBURIhZibOgP/dnwk7Exg0s310Oy+mByYFh67GdizeE7CdXNY7ipYQVl+6Sww0HPAsVPtehzOiCwE52uuGEbW0Y54d547k86zSecAOJCxm4UP0TZMGcBqeXDtcgs0ftKNC9WaQEwtklxxx1FgXpTgXhugn6kXI58LdRqzjk1uOFM56/UKU9GKOD+rb7GXTH33ode/T0pTWLshv0bXPSXaJt/jUaQidw8zYVcV91LBOwCRYpnE77/D4UUeem1xlu5fzdv3wLHxIL+Th23ILIaTsvmEMChb6lFMh9UySJ/qt9lwyaqlE6AtJPbtR6bWjaZfnI/dfuaRHNUk0G8Dg4psVwF+HULkptd0JCnpl7CIbvg6Lj8ZW2ZJPrjh0GFExn5tVL2TZ2h1/68OV2c5v7AfmuocC5/CrCf50NnYfU3YVyl93zabpq64zVK6wYaN1fJwd76DWmT3mlC5rnDN6FDQM1dENz1GQq/nZ0X8Nmks9XeqGbpjHZBQz+45PTDnvM5/SinwlnoPkcmcz0japlGup7RsnmBtxLDIHm+e9/qRdzI/yVzLzBAv0P86QKwdI1IOi49/f8QMnXgcr9sXDkDfxiXZpGATwzz5v8Aw90+tWPCIn/7qeKZY3gfTsrmvzQiQIWB2yYVxFUAterapFHM39ixBYyCfnog/huj4EbYKV1sgpf4J3Zx5S3hxWPwED92MbnNGASX44XO05wzM4HOuE/cdD7sK7BhsFed2zZQjeU2g733pqAl1BOHporH8G0nJJrR+K6ItwB0loO6VnSoYTFRv+1BmlXDCZBFMksfcPfAuB78VBqdVpvqqcezccZvuwouyyVsw Wa5Qurfp 2Ao0SXSbFPbOnOKVexX0KnujLdD8fa0JHaAlpHEYB5jous1WupV2QdiB1IhGXF5RfmlZfrtHPv3vAKtSvTMA8Y16EfC1aDItd48OtMeUObFhqkQ6ubrSHWPz4FonO+tXqGX/HF2qIFzmET0qeEAEKBtQ3+RSMbrwPNpzNMaU7q6PcK0Wsz7VNy8BBHOooXpG39DObZex/6iPe+Y3sd8obCJJo3CxhTmsQuiPqKP22JeNJU7VJn54Fe7HNPHG007hU/rlx3dNrSv1peKpnvMhW9cFS0Wfuf0E7iKmbiAz9B3QNmNAy+5JrgQtfXu9dAVTctVf7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05/25, David Hildenbrand wrote: > > On 25.05.25 11:59, Oleg Nesterov wrote: > > > >OK. But do you see any reason why uprobe_mmap() should be ever called during > >mremap() ? > > Only when growing a VMA: we might now cover a part with a uprobe, which we > have take care of. Ah, indeed, thank you... But. What if mremap() expands and moves a VMA? it seems to me that in this case uprobe_mmap() won't be called? I'll try to make the test-case to check... Oleg.