From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92997C54FB3 for ; Mon, 26 May 2025 17:55:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A39C6B007B; Mon, 26 May 2025 13:55:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 254A76B0083; Mon, 26 May 2025 13:55:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16A486B0085; Mon, 26 May 2025 13:55:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F10FB6B007B for ; Mon, 26 May 2025 13:55:29 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 95C205CA95 for ; Mon, 26 May 2025 17:55:29 +0000 (UTC) X-FDA: 83485811178.21.385DE9B Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf08.hostedemail.com (Postfix) with ESMTP id E5483160004 for ; Mon, 26 May 2025 17:55:27 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=h9C5jJUR; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748282128; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rbEyV9hLf0panBLlpCDCnrH6PTnHSN7waDq9FOCb4qU=; b=NaSNAwnq0IUQMUbvQqPcSUpkQf/8+8FgPhEYfVBrcbo2Air7Y7XNz13H7E2VgbVfoPDIfa B0nEUA8N7puLLE/NcSVjDVP0D+j1IN1omAKTIfOfn00nFc42z5DjPCdbVod/cYrLKpNV5/ rax9ThwR5ZcInNDkuT5oI3ugzDl9GP0= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=h9C5jJUR; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748282128; a=rsa-sha256; cv=none; b=dSywenLlSxMLb7HJgeNuglUmyd8YzEiKmNAxO70Uv1lAdtBm6vM+rnh3vgMi9XlH2YD/ky SHtzieJc5NQMfuUhwPc+qCcQAioQAQm8792PQdE3pxmXpLuey/4tq4eUNnu97GtgwX+Q98 DrSKdMPj4CMR5CX+CFPVU1IOwYi2seE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 30D02A40A96; Mon, 26 May 2025 17:55:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60E25C4CEE7; Mon, 26 May 2025 17:55:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748282126; bh=2wt63rinmphgpNqJNqbGfrk3Gql5+JvD9dkXi/gRCTE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h9C5jJURpjf0oUMTyoXViwU1bnWKbU7Xyt+73axuv6OYVdL/cTsY9VPhU4y6UdbzJ GoAKieOH2EaLwFtJnAxSv1BkPx1tAMHyk63nbWXBt/uNmgGuS2nOHglXhEPrtpyP4H CDzwwXqkzw5IXWCQ8pUkIOO1MAGsfU7cPe1ViLhLT1t77Hq9zYQK4zJLBwMtOFuQCp 6v4j/bIPYLGF7MWb9cg9K01xHuWhn40hzI+Zq8iY1NfPs8lIwgV3EcVmYdjUrE4Q0Z XNtpKAa9kpCLLykFUxSRrZLEl/4lX287Brv675uS1ioqsUeo3AXAiWTtK4QQE4L82o 8j423CQbFaznA== From: SeongJae Park To: David Hildenbrand Cc: SeongJae Park , Enze Li , akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, enze.li@gmx.com Subject: Re: [PATCH] mm/damon: rename primitives to operations Date: Mon, 26 May 2025 10:55:24 -0700 Message-Id: <20250526175524.2651-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E5483160004 X-Stat-Signature: poaopufg7iy1da1pon6r5a7g7iigaswf X-Rspam-User: X-HE-Tag: 1748282127-603492 X-HE-Meta: U2FsdGVkX1+yCeQ4tQmL7DQBnIzQEnecCaGn1wWlyG72yKN4DwObvDq3PdWELQ1CJ/UmoQj1cmbzsMWYb+jNhowakyH2lkH2elZeO3w6yLO8xUykBhWcQzSvedPVrivLyamxb6qMprvk55S/sfGykeYxdTzcx3WRbbgH4/2QVXestOP9s9yI0RWGOAMisWgotDKQw3WLqldiUnGYRVm5OiZkJViSkyWyN5V+o4mHhss/5jWDs/HONreZNkNQyOtjo7GkGwWqKl/T9QtJ9oerE8DkUfLUaUMMtC9OI1VqyKx/BcFsQFifSFQsfQs41hn8dnMUTgYLef/tHoWQzs/v5iSFzG2rKnR7399ZS7Uj9uUETQ0vkuLZL+qPW5BeOapECXoqnWl57WQUBbmzpJKpQhZzbZjOphbvQuJ64F+NWGJAHltTnXJ+oifMYCmR/1HauJOni9t2B5qrp3hiineAgN2TeoA7C3Riyy7HK7xjXX4UkmtaFP+w26jfK9v1fh/Z5lTTbc/NKjWJuVICADakDWHZ5Wij3JeqYFRI2b3HJHRbcdhocZFyIFtU69WxlJHWJJds9++ncKWJmPxx/tmnKH6iF+ACPwbOBEgeI1P9lL29QrEyWWKXRi6sa0Raz8859EpclAAacesvxVi7AUmn72K/c9mNzk7vgkBKfZhTPohDlNDjMW0KW8r/oMIeI+eFgwD3DHMJfEGAhSeeDGyemfNxCV+Sgmw9v+4XRf8EEQ3+wq4VUQL1+nZ0SBlcvPTLlFgHkkK3aqEuxLPN7EaW2yXGvMPJjyKnG2zHyOoQYUx2VxvYishfb8o1q7R12bAOQC4wIS+owTUpfSslqM1e5Rz5F4C52nG15UjUlHbYUr9j3a3DiKGNKMXKCtqGxloga4E42ba+zh6Qi20SDRAsOJhxTLMv3Lsi/FMEIp6bn0Jekhn0J4YWMzh+P+Cqwaia5xR/cEvGY1l+vVcBkIL 16Nj7Pbe eqEGfqyIMTZ2V2Z78BXjCJw90E6RQjxL36ik57sQNipKFr/Ld/nZYkbkxXba8mUtALJxbq7zY1TMkzIfTbdNPN5Z70SvFk3x+IHeO7CZ8Z4XsSWVXCkU4WPWWWLVg0DIdM5pn2uCAajTfUfq4Fs2kkMtLen0TybYdcbPB8exoIxloK8s6i/IwNp+j62I3fYiCZZGu4RDxAU74xHElKbSOWjtdU8+4L9BHj1aloAPV79Rwhw0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi David, On Mon, 26 May 2025 11:31:45 +0200 David Hildenbrand wrote: > On 24.05.25 18:29, SeongJae Park wrote: > > Hi Enze, > > > > On Sat, 24 May 2025 20:55:36 +0800 Enze Li wrote: > > > >> The word 'primitive' is not explicit and has been deprecated in DAMON's > >> context since commit f7d911c39cbb ("mm/damon: rename damon_primitives to > >> damon_operations"). To make the code easier to be understand, this > >> commit renames remaining 'primitives' to 'operations' in header comments > >> of DAMON source files. > > > > Thank you for this patch! The description makes sense to me. > > > > The title makes me bit confused, though. By reading it, I was assuming this > > patch is changing some code. But this is changing only comments. Could you > > please make the title more clearly specify that? E.g., "fix outdated comments > > for monitoring primitives"? > > Heh, but wouldn't we be calling this things "primitives" in the current > context? Thanks for giving us this good point. I was reading this as "fix outdated comments for monitoring primitives (, which is a deprecated term)". And I agree this is not very clear. > > "don't refer to common code as 'primitives'" Nice suggestion. But, this wouldn't explain the changes to {p,v}addr.c files, since those are not for common code. Maybe "mm/damon: s/primitives/code/ on comments" could also be a simple and not that bad title? Thanks, SJ > > -- > Cheers, > > David / dhildenb