From: SeongJae Park <sj@kernel.org>
To: Enze Li <lienze@kylinos.cn>
Cc: SeongJae Park <sj@kernel.org>,
akpm@linux-foundation.org, damon@lists.linux.dev,
enze.li@gmx.com, linux-mm@kvack.org
Subject: Re: [PATCH v2] mm/damon: fix outdated comments for monitoring primitives
Date: Mon, 26 May 2025 11:12:31 -0700 [thread overview]
Message-ID: <20250526181231.3021-1-sj@kernel.org> (raw)
In-Reply-To: <20250526060901.78226-1-lienze@kylinos.cn>
On Mon, 26 May 2025 14:09:01 +0800 Enze Li <lienze@kylinos.cn> wrote:
> The word 'primitive' is not explicit. To make the code easier to be
> understood, this commit renames 'primitives' to 'code' in header
> comments of some source files.
>
> Signed-off-by: Enze Li <lienze@kylinos.cn>
So we have an ongoing discussion for the title[1]. Other than that, all looks
good to me and I believe the discussion will not change this patch
significantly. So, giving my Reviewed-by first.
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
[...]
prev parent reply other threads:[~2025-05-26 18:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-24 12:55 [PATCH] mm/damon: rename primitives to operations Enze Li
2025-05-24 16:29 ` SeongJae Park
2025-05-26 6:25 ` Enze Li
2025-05-26 18:09 ` SeongJae Park
2025-05-30 1:57 ` Enze Li
2025-05-26 9:31 ` David Hildenbrand
2025-05-26 17:55 ` SeongJae Park
2025-05-29 17:26 ` SeongJae Park
2025-05-30 5:47 ` Enze Li
2025-05-26 6:09 ` [PATCH v2] mm/damon: fix outdated comments for monitoring primitives Enze Li
2025-05-26 18:12 ` SeongJae Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250526181231.3021-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=enze.li@gmx.com \
--cc=lienze@kylinos.cn \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).