From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3139AC54ED1 for ; Tue, 27 May 2025 15:31:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C48D26B0096; Tue, 27 May 2025 11:31:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C205F6B009D; Tue, 27 May 2025 11:31:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5FAE6B00B8; Tue, 27 May 2025 11:31:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 98D8F6B0096 for ; Tue, 27 May 2025 11:31:04 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4FC575DF20 for ; Tue, 27 May 2025 15:31:04 +0000 (UTC) X-FDA: 83489076048.29.2CB5A8B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 4A90FC0003 for ; Tue, 27 May 2025 15:31:02 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cPWnp4re; spf=pass (imf28.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748359862; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k3Iaq3MntvjDln6IzJbTGvcMOmcLmVF70dqmVM6voj4=; b=H5BxMwtXOGFfIiLm/Fxcaw0DbkmIbP3h1/daqTCQ9D0VNWZ093Ibpdzi77R6NfTBJG1Kzq BQNA4+vDEatRqKMsLCiG3O9iW5Goeq0XJuQYfmGdBfNBnwpOHHZT4dZLTcjBOR2dxaBuVc s6ZMTnHamrP7X/GPlZTPsna1d0CZLjk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cPWnp4re; spf=pass (imf28.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748359862; a=rsa-sha256; cv=none; b=pFdSMtdk4ctyxvVFeb38QNOWHmCyBBEjE9Ts2Y1iVPvyIOZP5GI3jHnmeXmreUtkwCwdPE BPbFFyL8ammHhsMmjM6Fu3MjZanOqe4WjOUpt9PJee7CmOgU4ggGgayL5FuAW96tIZ2UWv TTcKJAAsstWj7OSiXPqEdgcYrE2k3RU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748359861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k3Iaq3MntvjDln6IzJbTGvcMOmcLmVF70dqmVM6voj4=; b=cPWnp4re9Wd28CIKcoBlAJ4qP7fnhWFJo+kxuqPhz+mta/HHYV1Bm4344qO1mH5LI1aSMe fHJZizK2kJxYbDT3wvPpCtD6tKgz++eC9QU8tfzbDeEmhCVZbFmFqN3t60EDUnsKomMYgi XwKsO2AAQAVupYuRe3CPjd1+UtsuerI= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-327-UvECuc6FMziKTV6uLV0KJg-1; Tue, 27 May 2025 11:30:57 -0400 X-MC-Unique: UvECuc6FMziKTV6uLV0KJg-1 X-Mimecast-MFC-AGG-ID: UvECuc6FMziKTV6uLV0KJg_1748359855 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 03A201945109; Tue, 27 May 2025 15:30:55 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.44.32.4]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 25C7519560A3; Tue, 27 May 2025 15:30:49 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 27 May 2025 17:30:14 +0200 (CEST) Date: Tue, 27 May 2025 17:30:08 +0200 From: Oleg Nesterov To: Pu Lehui Cc: mhiramat@kernel.org, peterz@infradead.org, akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pulehui@huawei.com Subject: Re: [RFC PATCH v2 1/2] mm/mremap: Fix uprobe anon page be overwritten when expanding vma during mremap Message-ID: <20250527153007.GD8333@redhat.com> References: <20250527132351.2050820-1-pulehui@huaweicloud.com> <20250527132351.2050820-2-pulehui@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250527132351.2050820-2-pulehui@huaweicloud.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 4A90FC0003 X-Stat-Signature: i187fcdq8tz78ee3rpafj8dind7eozrm X-Rspam-User: X-HE-Tag: 1748359862-430203 X-HE-Meta: U2FsdGVkX1+TyNkJuj9NmayCAor+rTrgtWYExObeTo4ZAWlFTOKHZvKQM+EdkV0tTLsfkWf7MQRx4EstfVbPvUnJNAbzDcxuN7s+mP3O+Zw7N3GqrAVfT6WJY+P/YOENRdakMUDAtJZzcGLKudkmNfVKXazC4E2ctuEzBLCcrmM7w9Qbb7MLBKINd3WvygDzvgkoV4qW4xXeqj+8kg+ZLZZbJ+EkxDURfCKh0EgM4kclMHd03lNK8BE+xOUmt1H0xIZSkm7ZydweXbvCfX5cT8AnYXTTInprzd3rqa0uoF80a1oRz9PrX618UJvsWB2Z0j2yzYc0Zxk3th7F218aB6JU18qOrWTYMIW+hPZ2lANSE5xGV2uqG53dHB19cXwPNXDB0k8O5FGxTMG8+qJcKjirRr4x8rn6FcfFUGTRREQNN2gz76JtboxDEgTEYHQP0wt7onqoz3w+r51SB+wQIk3k2/xgbi2bNwSZl1Y7ZGDnNkmzAo/1W0iWFZMrPuA2fWad2MmxdpB4mf5AQnkImrPWG7rX70Ge+PwXq8ftSfQOHu6HqIAZWxwMwrJsHG3bx6ARimB/ghIAQp6XY8KLkEt02L7iM/QfLvhIFO5oZzQb7Q4+5QGbl48exK4vNSDuBDO7ZlCXaSeaW1WypRl0BbN7UY9sFOCsQdkpxAQwLbt+RzMMOzc0HzHiltEPiW3fJW8Bk1GA8jtHtyaVBRXGt/HrHZKQ2ildsScJsIPf9JU1wz0kotmp5QTKNQF/7ZdTaG7LRTmS0sKbnwBA5lTv1McP6K1Om0MSQicrm+BFH4N2nUSRUr9fBWBs3HooKOZ/STxayXizycubFcf+3NGdAZB5c+bG4WH1fzY6L7domcIBwQD+W6LTG6Rl4o/tnbZD9G/polyszNLWHygZbJhHzypgsKJ/7Yf3F1P19bb0ZyWSXt10X0nvCLX5BzDDoiNd2mvyiF3wBWvT9OZCipr y/rtTNmd q0VdOsnXeVH9Ao/1ZDHfymArbqSbfAByysvrEBCMuVN3WqDGaKDmnw2irPoXQQho1zVbAYmYea9i8hQiUBSE+KVGLUXwJOkDVgno4RxQEoEq1+zPK9nqazCGdsUCf6GXgaLHtIeAkxUGD9FRs7dtrXflFGjyPKq7P9rI9Qkj41BskTPQKRqwDIlyXPVsWVQgxMn2uDQ5zORu8MiUCokDaUfYRa70eEuPaKHmbqwEjYF3pTBXupSwLMs0qBCuxzp9vLt7bQk4IyuCReDYERD8FoNe/R7A6KjFTPOrA9ywQThE3o3/k/MUOwfZyhh7aLAiMv3dV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Not that this is really important, but the test-case looks broken, On 05/27, Pu Lehui wrote: > > #define _GNU_SOURCE > #include > #include > #include > #include > #include > > int main(int argc, char *argv[]) > { > int fd = open(FNAME, O_RDWR|O_CREAT, 0600); FNAME is not defined > struct perf_event_attr attr = { > .type = 9, Cough ;) Yes I too used perf_event_attr.type == 9 when I wrote another test-case. Because I am lazy and this is what I see in /sys/bus/event_source/devices/uprobe/type on my machine. But me should not assume that perf_pmu_register(&perf_uprobe) -> idr_alloc() will return 9. > write(fd, "x", 1); looks unnecessary. Oleg.