From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D38CC54F30 for ; Tue, 27 May 2025 18:03:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD4BE6B00A9; Tue, 27 May 2025 14:03:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A5E1A6B00AA; Tue, 27 May 2025 14:03:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94C2D6B00AB; Tue, 27 May 2025 14:03:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 70D716B00A9 for ; Tue, 27 May 2025 14:03:23 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1FCEC12132C for ; Tue, 27 May 2025 18:03:23 +0000 (UTC) X-FDA: 83489459886.05.CEB0A74 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) by imf20.hostedemail.com (Postfix) with ESMTP id 29B9B1C000A for ; Tue, 27 May 2025 18:03:20 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1q3CmCKL; spf=pass (imf20.hostedemail.com: domain of 3Z_41aAUKCIQ1ijjiowwotm.kwutqv25-uus3iks.wzo@flex--tabba.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3Z_41aAUKCIQ1ijjiowwotm.kwutqv25-uus3iks.wzo@flex--tabba.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748369001; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YUv/6AxiCYz3znG3EpZR9aFsyQsCRwX0eENShgHFqLA=; b=DeOhXOKDEZBGBChMXOrIKjcmboEhItlScpnoPByre5hECwo4lg258o24UYws57veDQU1Sw iX3HEDv+ALe4CvsuIu/hRBuev7wL4l7CBw9KNuxSWj1+rPH16Qf+5mXg/hA6A8Ulmsjdm8 /pJ4hKtZrX0tkjjiTeOM9Vy0Zofl5gs= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1q3CmCKL; spf=pass (imf20.hostedemail.com: domain of 3Z_41aAUKCIQ1ijjiowwotm.kwutqv25-uus3iks.wzo@flex--tabba.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3Z_41aAUKCIQ1ijjiowwotm.kwutqv25-uus3iks.wzo@flex--tabba.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748369001; a=rsa-sha256; cv=none; b=BnHdAnwd0g0SgqE1Dq8OUpRebvB3z90agZblP6DnYHrvnZLEE7IStn59a+cJOvMp4oZSn/ rqJ5KiTP7oBhiGzQmfq8SIblaFgoBQK4/Sf7mwVdskMkgy1et/yl+yTlPor6gcP+QP7mxz ZFLJ5JcZA3S2mJ857RDtN0zT3VbdAcA= Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-43cf44b66f7so22020475e9.1 for ; Tue, 27 May 2025 11:03:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1748369000; x=1748973800; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=YUv/6AxiCYz3znG3EpZR9aFsyQsCRwX0eENShgHFqLA=; b=1q3CmCKLJExAVB5NtjdAZDz/yRW8Zti1JJGIleC7pOKLK36gZuy4n0B2591+3Bkwbw Z7nds+0Toz56BBtcuJT6vgcr+uHHdMFsLJw9sC5uO/OV6yNz1KJ8eQzBr/0GvV1gORDd Qagp4hVtNxtmTabU3+vurbU4xERapwOsFVYvA9lvpnJOdKlV73YkyuRIX95CIe6RByFP T1r9Gbbw4XZIrwt/n9INiasfMrk3wFzZ+SwXNxIdKzLLaLqKwA0YxUeh0HHA9to5T1zP Xz026rPfxkcOK/zMeq2VcHA4+8x7LklIYATsva0ZAYD29t4KU9qPUtgtH/QXn36RbaI1 3EPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748369000; x=1748973800; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YUv/6AxiCYz3znG3EpZR9aFsyQsCRwX0eENShgHFqLA=; b=AEfjPB6Krm8Rbz10T1T6nLld76TNeano5xbNDToUiBzwtmFTFylmzrHZV252tn+mI0 mRssXjg1JnnydT3hWqzr1oFWmoeVnVNw980UhPZq5Ts5xv1YTK7f/6aY2qk6ZARmvlJk HVUPvsVGjCNiqyV7WnH0rybfQ60MCi09Y1scwMHpWNIoF5kkdDCzF0YBQA1SWqzMg4H3 IU6gOrz5LE40kn6ogE4VcnGrLeAtXCDfq9Oc8sfPuIehlkYWi8R+Cslingq71xZv+IQj frEFDIrRuJWhPdYhPYc709mIXAcVhjbae3a3Nlfhli/0G3us5p1rFY0Tde4RNPslQXE/ 1U1w== X-Forwarded-Encrypted: i=1; AJvYcCVgnajW3YC46vZ8cXB0kP6OVW8AGjFW6ewG0sETuvT9LTT9/IHudW9Lumf6eTcULKr57GSWRidNJQ==@kvack.org X-Gm-Message-State: AOJu0YyasGI2oQbw0JOIAZyZ6uDid0DwNuHysHPmOXd2sI42v42Hngvt srSo+zrsUAMqxaTelfArGNXrs/CgbRKTHJl5JmGDu3RZioSfrjzR2PQyB4fTsIv2UoQMiA9AR+j vOQ== X-Google-Smtp-Source: AGHT+IHwxDDpSOhp5JOPkw7Az3zA1+GOA36Sv5kSChHXs1Dol8FyTA+PxlhBcFS+OXHG5kgq1/hOAHktgQ== X-Received: from wmsd9.prod.google.com ([2002:a05:600c:3ac9:b0:442:f482:bba5]) (user=tabba job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3c84:b0:442:f4d4:53a with SMTP id 5b1f17b1804b1-44c9151293fmr149200335e9.2.1748368999693; Tue, 27 May 2025 11:03:19 -0700 (PDT) Date: Tue, 27 May 2025 19:02:45 +0100 In-Reply-To: <20250527180245.1413463-1-tabba@google.com> Mime-Version: 1.0 References: <20250527180245.1413463-1-tabba@google.com> X-Mailer: git-send-email 2.49.0.1164.gab81da1b16-goog Message-ID: <20250527180245.1413463-17-tabba@google.com> Subject: [PATCH v10 16/16] KVM: selftests: guest_memfd mmap() test when mapping is allowed From: Fuad Tabba To: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com, tabba@google.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 29B9B1C000A X-Stat-Signature: 54q8owyd9wu5tppg41ayooosgfs8qeo7 X-Rspam-User: X-HE-Tag: 1748369000-91235 X-HE-Meta: U2FsdGVkX18ZWWiNG0R9ihpZnH1ni7rU98jDEOlF/6Kw+q8baqZT46m1jTBNbms0REeDJaHWCfaki333fp+zP7aYvih9iwbVRBfqVjM7TFJKHMqnN0SSetO+8Vgzb8xgyGLfM8hRInj+UvIF0iaK0vXeNWr4s3BMYxzoVz/s8p/Pd5YAA7Ayq+kaLdP5fr3MspY+dJnYKM4BtO/8dN8bt/MYExdRLrkaI2ZjLvvipd2Dg17jRH4JXCskf+liaTU+qWosB2yZo6wxVTJm7lP1FZN8hmm6M7EVflaDEBFHx6YXAS2VLiePh4PkzFDFFUzQg8BvLm6bKulaCmDcyYNEV4yr37pJATBa/GH9o1X/96e8BSVip+v386Ga9vBHhfQKNV/8yxcva0qAtQv3u8TaYj/aK4/VtEtNzI91LYJkyshIBc1FTq6/JcDtP1O8NT0jgK+L86nUjNpmtlyyPXNu4mV2C50MLm6radpDVcSZyeAFxQ+4TTUSc5rDEVxDGf4uifaEdvSXXFm7+5BGQV9S204gEOFqDfn7Rmc9D+12HM0Tn/J4WyHMIHzsbelnCPaQ8BD4N9Gosy+igfYtSzSEeF1fGNSqRZnDYg2p5Vlj8r3CnGSEBqgICW16st5yynTq10jigzWSysqC0N2rlMPNHgitX4o1J9wc3zDCFOh/kezGu04VKUM0r+pcKcS4fgkoh3NVUqJcJgiqOIBxANmHVK+AOLPx8QlA+i/qH/AgU10Ognq4Vf5V9lYqFq1ZTa4f/cnpBJCFEWbwewjODU/gYlMs2k60CYSY1zvo82RPigT7k5Iw1UWlG1pt2ymDC7XqQCrFzm7e3rRZdWj9jaLMMXzK11DCFkrWsMzhOhJ4oOvVzqV9p+rB0drJXU6+ftAZecWZBbwJmBcemWKhA6NguGmXZetQjOucxmrCWiM768GTRVHIlGm0MgOW/MRHfg5mE7U9VyZIsDZM3LPO5r7 Pwg0nmhW C1CZxEs3V3m2eB04zOTY6rkWX2eJXE1nzzI2uOixctl9k7gnpvwC6Ra//t0iGQ10vpNxB5QTKB3YJPWYNcpjOLk8ru+V0vcUpAg7L43kOmN8m3elSkV5v9lQz7WjMig241FZd5GFzL1VTeP/RXISEN8C8Z8Y93rI0Wx1wOkip0k9yM+xszA15tmuDQEfX1h90YXddLdfirBpGiKhUL+ZNxZrQMFlrqJ7fTCCk9/T65jjPjjNP/WKO9iRIFwU6wIAX0594sJdkAA24mQmmM4m+AYvQGNNNTOmu3SWCnT1oSdYVfKh5ljr/EvfBgoZ9tzLjaCCFe8ueKCzLL1hCMe+au9l+IxwnhAMBIeu+MpFwTP30Q3r20/pRV8gHkSRhCgy9ex5uIAWni7Fr/LatiQUAK6sazvY//WnOCsqzAkGOtWIbJh2bTajWQqVCpJ112JsdDDEZGCxfmWzdzqdOCB/aiEQMiClIKF8n0YjaRe8FcMBvmICGeTViwStAzJY5u+21Jb0y98DrgDPCSb557tiErlCv/aMyimhLitUnxg72kNb4+NPA3+OLUbI7ttioVB1OsOikVlSvdZ0fesWrvOrSPwlc1w96o5ipl8+WHRVSniakquKBgrElhVfCZPT1LEyZYBxP47AtLEBt4C5T42nJwswbBg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Expand the guest_memfd selftests to include testing mapping guest memory for VM types that support it. Also, build the guest_memfd selftest for arm64. Co-developed-by: Ackerley Tng Signed-off-by: Ackerley Tng Signed-off-by: Fuad Tabba --- tools/testing/selftests/kvm/Makefile.kvm | 1 + .../testing/selftests/kvm/guest_memfd_test.c | 162 +++++++++++++++--- 2 files changed, 142 insertions(+), 21 deletions(-) diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm index f62b0a5aba35..ccf95ed037c3 100644 --- a/tools/testing/selftests/kvm/Makefile.kvm +++ b/tools/testing/selftests/kvm/Makefile.kvm @@ -163,6 +163,7 @@ TEST_GEN_PROGS_arm64 += access_tracking_perf_test TEST_GEN_PROGS_arm64 += arch_timer TEST_GEN_PROGS_arm64 += coalesced_io_test TEST_GEN_PROGS_arm64 += dirty_log_perf_test +TEST_GEN_PROGS_arm64 += guest_memfd_test TEST_GEN_PROGS_arm64 += get-reg-list TEST_GEN_PROGS_arm64 += memslot_modification_stress_test TEST_GEN_PROGS_arm64 += memslot_perf_test diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c index ce687f8d248f..3d6765bc1f28 100644 --- a/tools/testing/selftests/kvm/guest_memfd_test.c +++ b/tools/testing/selftests/kvm/guest_memfd_test.c @@ -34,12 +34,46 @@ static void test_file_read_write(int fd) "pwrite on a guest_mem fd should fail"); } -static void test_mmap(int fd, size_t page_size) +static void test_mmap_allowed(int fd, size_t page_size, size_t total_size) +{ + const char val = 0xaa; + char *mem; + size_t i; + int ret; + + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + TEST_ASSERT(mem != MAP_FAILED, "mmaping() guest memory should pass."); + + memset(mem, val, total_size); + for (i = 0; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + ret = fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, 0, + page_size); + TEST_ASSERT(!ret, "fallocate the first page should succeed"); + + for (i = 0; i < page_size; i++) + TEST_ASSERT_EQ(mem[i], 0x00); + for (; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + memset(mem, val, page_size); + for (i = 0; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + ret = munmap(mem, total_size); + TEST_ASSERT(!ret, "munmap should succeed"); +} + +static void test_mmap_denied(int fd, size_t page_size, size_t total_size) { char *mem; mem = mmap(NULL, page_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); TEST_ASSERT_EQ(mem, MAP_FAILED); + + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + TEST_ASSERT_EQ(mem, MAP_FAILED); } static void test_file_size(int fd, size_t page_size, size_t total_size) @@ -120,26 +154,19 @@ static void test_invalid_punch_hole(int fd, size_t page_size, size_t total_size) } } -static void test_create_guest_memfd_invalid(struct kvm_vm *vm) +static void test_create_guest_memfd_invalid_sizes(struct kvm_vm *vm, + uint64_t guest_memfd_flags, + size_t page_size) { - size_t page_size = getpagesize(); - uint64_t flag; size_t size; int fd; for (size = 1; size < page_size; size++) { - fd = __vm_create_guest_memfd(vm, size, 0); - TEST_ASSERT(fd == -1 && errno == EINVAL, + fd = __vm_create_guest_memfd(vm, size, guest_memfd_flags); + TEST_ASSERT(fd < 0 && errno == EINVAL, "guest_memfd() with non-page-aligned page size '0x%lx' should fail with EINVAL", size); } - - for (flag = BIT(0); flag; flag <<= 1) { - fd = __vm_create_guest_memfd(vm, page_size, flag); - TEST_ASSERT(fd == -1 && errno == EINVAL, - "guest_memfd() with flag '0x%lx' should fail with EINVAL", - flag); - } } static void test_create_guest_memfd_multiple(struct kvm_vm *vm) @@ -170,30 +197,123 @@ static void test_create_guest_memfd_multiple(struct kvm_vm *vm) close(fd1); } -int main(int argc, char *argv[]) +#define GUEST_MEMFD_TEST_SLOT 10 +#define GUEST_MEMFD_TEST_GPA 0x100000000 + +static bool check_vm_type(unsigned long vm_type) { - size_t page_size; + /* + * Not all architectures support KVM_CAP_VM_TYPES. However, those that + * support guest_memfd have that support for the default VM type. + */ + if (vm_type == VM_TYPE_DEFAULT) + return true; + + return kvm_check_cap(KVM_CAP_VM_TYPES) & BIT(vm_type); +} + +static void test_with_type(unsigned long vm_type, uint64_t guest_memfd_flags, + bool expect_mmap_allowed) +{ + struct kvm_vm *vm; size_t total_size; + size_t page_size; int fd; - struct kvm_vm *vm; - TEST_REQUIRE(kvm_has_cap(KVM_CAP_GUEST_MEMFD)); + if (!check_vm_type(vm_type)) + return; page_size = getpagesize(); total_size = page_size * 4; - vm = vm_create_barebones(); + vm = vm_create_barebones_type(vm_type); - test_create_guest_memfd_invalid(vm); test_create_guest_memfd_multiple(vm); + test_create_guest_memfd_invalid_sizes(vm, guest_memfd_flags, page_size); - fd = vm_create_guest_memfd(vm, total_size, 0); + fd = vm_create_guest_memfd(vm, total_size, guest_memfd_flags); test_file_read_write(fd); - test_mmap(fd, page_size); + + if (expect_mmap_allowed) + test_mmap_allowed(fd, page_size, total_size); + else + test_mmap_denied(fd, page_size, total_size); + test_file_size(fd, page_size, total_size); test_fallocate(fd, page_size, total_size); test_invalid_punch_hole(fd, page_size, total_size); close(fd); + kvm_vm_release(vm); +} + +static void test_vm_type_gmem_flag_validity(unsigned long vm_type, + uint64_t expected_valid_flags) +{ + size_t page_size = getpagesize(); + struct kvm_vm *vm; + uint64_t flag = 0; + int fd; + + if (!check_vm_type(vm_type)) + return; + + vm = vm_create_barebones_type(vm_type); + + for (flag = BIT(0); flag; flag <<= 1) { + fd = __vm_create_guest_memfd(vm, page_size, flag); + + if (flag & expected_valid_flags) { + TEST_ASSERT(fd >= 0, + "guest_memfd() with flag '0x%lx' should be valid", + flag); + close(fd); + } else { + TEST_ASSERT(fd < 0 && errno == EINVAL, + "guest_memfd() with flag '0x%lx' should fail with EINVAL", + flag); + } + } + + kvm_vm_release(vm); +} + +static void test_gmem_flag_validity(void) +{ + uint64_t non_coco_vm_valid_flags = 0; + + if (kvm_has_cap(KVM_CAP_GMEM_SHARED_MEM)) + non_coco_vm_valid_flags = GUEST_MEMFD_FLAG_SUPPORT_SHARED; + + test_vm_type_gmem_flag_validity(VM_TYPE_DEFAULT, non_coco_vm_valid_flags); + +#ifdef __x86_64__ + test_vm_type_gmem_flag_validity(KVM_X86_SW_PROTECTED_VM, non_coco_vm_valid_flags); + test_vm_type_gmem_flag_validity(KVM_X86_SEV_VM, 0); + test_vm_type_gmem_flag_validity(KVM_X86_SEV_ES_VM, 0); + test_vm_type_gmem_flag_validity(KVM_X86_SNP_VM, 0); + test_vm_type_gmem_flag_validity(KVM_X86_TDX_VM, 0); +#endif +} + +int main(int argc, char *argv[]) +{ + TEST_REQUIRE(kvm_has_cap(KVM_CAP_GUEST_MEMFD)); + + test_gmem_flag_validity(); + + test_with_type(VM_TYPE_DEFAULT, 0, false); + if (kvm_has_cap(KVM_CAP_GMEM_SHARED_MEM)) { + test_with_type(VM_TYPE_DEFAULT, GUEST_MEMFD_FLAG_SUPPORT_SHARED, + true); + } + +#ifdef __x86_64__ + test_with_type(KVM_X86_SW_PROTECTED_VM, 0, false); + if (kvm_has_cap(KVM_CAP_GMEM_SHARED_MEM)) { + test_with_type(KVM_X86_SW_PROTECTED_VM, + GUEST_MEMFD_FLAG_SUPPORT_SHARED, true); + } +#endif } -- 2.49.0.1164.gab81da1b16-goog