From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A5DEC54FB3 for ; Mon, 2 Jun 2025 05:01:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E84AF6B0254; Mon, 2 Jun 2025 01:01:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E35186B0256; Mon, 2 Jun 2025 01:01:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D721B6B0257; Mon, 2 Jun 2025 01:01:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BE9CB6B0254 for ; Mon, 2 Jun 2025 01:01:33 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 341F812211C for ; Mon, 2 Jun 2025 05:01:33 +0000 (UTC) X-FDA: 83509262466.21.255E025 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf24.hostedemail.com (Postfix) with ESMTP id 79ECE18000E for ; Mon, 2 Jun 2025 05:01:31 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=pass (policy=none) header.from=lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748840491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=suUQ3U+Vy1trQD/+6QCxhpH+MP0gYBUcXfBzgUykvCY=; b=pFuiEAaDUpp6ckyAg62B57xWIiisnEske34RuLZUN5kEHxGWv+k0nue5N5mha17DmDLy/t f/SZx33H1kB6VpYCClMvRKNXbfTf38ZcUgNZIQxc1HUYb81VWCwVFx0Fg7t/BTKmTT+3h9 4Sa3+Ivp5qNicNF0ZZUZIUKBasLbFGU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=pass (policy=none) header.from=lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748840491; a=rsa-sha256; cv=none; b=hkQVGwXXaHUu89ks6+81Us4W4yP9ib71D3WYgL3G+WCEjbxkqCnczcreo5+AgHm9Jb71qF MhKbNskfikgwzN32Vw37ZIkSPv0OhLrtJ5fXOZghZQBz9JVHhGeCqNHsghOHT0l1ysT1PJ FjksXwmpAV290esqtNteIuDAF+lREmo= Received: by verein.lst.de (Postfix, from userid 2407) id 3E49E68C7B; Mon, 2 Jun 2025 07:01:27 +0200 (CEST) Date: Mon, 2 Jun 2025 07:01:26 +0200 From: Christoph Hellwig To: "Kirill A. Shutemov" Cc: Andrew Morton , David Hildenbrand , lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hongyu Ning , stable@vger.kernel.org, Christoph Hellwig , Hannes Reinecke , Johannes Thumshirn , Jens Axboe Subject: Re: [PATCH] mm: Fix vmstat after removing NR_BOUNCE Message-ID: <20250602050126.GB21716@lst.de> References: <20250529103832.2937460-1-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250529103832.2937460-1-kirill.shutemov@linux.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 79ECE18000E X-Stat-Signature: rksww9h6gm64f5ab1tory8789nnjotsb X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1748840491-275136 X-HE-Meta: U2FsdGVkX18doPFkXCXrcJkrWQgvtBpNsXned9SDLW7vGTITRlPIVUnN2IOHVB0TBMaAB7x7Vti3rQIMLaNWXWnFpPuOT8nlWnrSdZWQROQrfHHAr4g2ZSC3MNNwTTX6wIp5KYTK7RxEeC3X0K9OZSnmzjh/Yuics0mzUC/Qvu+OcCuioz9GmcjIY5lZ8l9FgyhDCA9o3CojIs9AiMJ+O5OtIzjmKGByJYy8GBfFBGe4z7U9KFrtH4ac6sevTKcDuMWQ8TFpAzstqr7mc/SfstaMPw/m+8TOTLsy7ZojDnrRs9O952/Z3uRL0kSZwC69nhXBGRB4GExKpWlZ6ArolqaV29oudpnL72KjP9fdfmrw8ki3Fi3ubjNHdnWC4C3WZLmy1qiKduXEnoX8aHN4mQL9l16CWOyF6GLajDBm5kq+BjLKbdDgVy+YoNeHFRShzclOgEsv1sT+s0d09o5AB669XXVkxVAbxLIwvaJ9LVOpkj+aJS5WsjHmD0MhWG+fneROdptpKDfi/Xc/WMfx8rF6O3JbxtE96uwRyLJikVMMbgULKmPkdvenT8g/FRkFtn719AlpSeZUy+1ZIKOELPHikaZRFFP2duB3xrYxUPUP/1mlE6Ml3EU73lgN/noeeepj80g5YUm3cXKc8XtDziloS6HpLEThtBgfxkBuQGXDtxXSEEg+oMuwBGZgY4n74P/2DxdfkNMX057IEn4Xl0cLekoXMa45wsrTPLRDi37AnquJFF2Nsz2IiXQL4+CuNjteisq8RXGUt8tJlwNtyF1imckLvgBzsV6lQZF0saYoLOG+sD8V+5s4p2jK0EgGjcXB/Cdemt2TNsAm9TVQJbeQROEOKNvxNiCWHhrysqQX5yLhmb30sXX3VDg5VrEtvQUfb2aw/BerguRHvFcPbqqfumzAbypGLPdcscj5yCPJ5Ty5k/IMqfi2R44GuGxJZpgBvqbt3sdo5mpSNzc 5MPf7MJr QS4aMfEjRaexXUgUMjJN31MOKCr1upxOGd+Xr7luudIy/0q/+knavgkK2aj/0DsJpdr5lwyaVHGhbMhfmaviIK7OK1Jghx7iT+tSWt8YleAWJhqasmjfzj7mOwdIRNwnriC/C1RLDNDjhbF4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 29, 2025 at 01:38:32PM +0300, Kirill A. Shutemov wrote: > Hongyu noticed that the nr_unaccepted counter kept growing even in the > absence of unaccepted memory on the machine. > > This happens due to a commit that removed NR_BOUNCE: it removed the > counter from the enum zone_stat_item, but left it in the vmstat_text > array. > > As a result, all counters below nr_bounce in /proc/vmstat are > shifted by one line, causing the numa_hit counter to be labeled as > nr_unaccepted. > > To fix this issue, remove nr_bounce from the vmstat_text array. Ooops, yes: Reviewed-by: Christoph Hellwig > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 4c268ce39ff2..ae9882063d89 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1201,7 +1201,6 @@ const char * const vmstat_text[] = { > "nr_zone_unevictable", > "nr_zone_write_pending", > "nr_mlock", > - "nr_bounce", > #if IS_ENABLED(CONFIG_ZSMALLOC) > "nr_zspages", > #endif It would be really useful if such pretty printing arrays used named initializers, as that would make it obvious that an entry needs removal.