From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24E94C5AD49 for ; Mon, 2 Jun 2025 14:22:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B949E6B02B8; Mon, 2 Jun 2025 10:22:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B44CF6B02B9; Mon, 2 Jun 2025 10:22:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5C036B02BA; Mon, 2 Jun 2025 10:22:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8A16F6B02B8 for ; Mon, 2 Jun 2025 10:22:43 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 43D00BC7EC for ; Mon, 2 Jun 2025 14:22:43 +0000 (UTC) X-FDA: 83510676606.10.F2BB676 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf09.hostedemail.com (Postfix) with ESMTP id 8B8F9140003 for ; Mon, 2 Jun 2025 14:22:41 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=lst.de; spf=pass (imf09.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748874161; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y1bRJdz6nL2klaaDwAuwNJqiE7K2mtRuzbdyKjXqih4=; b=2xDNqhgYDlxkusGn6x15qzXMUQc4T0WLoWqLsK6JWos43yEUg1uO7cTDRHOAl1hT9qxI/8 ncQVu0vSo3Pg8HEyYFYChnDyPIhBd5o3VNATcGiBLIJntI3DGK9wBcLabLq+VenNCsEeih x401R5EwVMdJuvLhiE8VKz/jIChqWlU= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=lst.de; spf=pass (imf09.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748874161; a=rsa-sha256; cv=none; b=PKhaVmQdlqrNQ47D3YH+lU3YfjdS3YDkwlectlCMpVZPrGQ4n3HhPkYuFcp/YAIko2YHvi O63+vu011c5+VbfmtcNT5kdx4tDbzNL8IJiG33wJ1017/DWQZI4ESa2c/brAiwNC0QVGOE 5Po+su+1t62MvrC2ZDkeHRIviJTWM1o= Received: by verein.lst.de (Postfix, from userid 2407) id 1DB8D68C7B; Mon, 2 Jun 2025 16:22:38 +0200 (CEST) Date: Mon, 2 Jun 2025 16:22:37 +0200 From: Christoph Hellwig To: Kundan Kumar Cc: jaegeuk@kernel.org, chao@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, miklos@szeredi.hu, agruenba@redhat.com, trondmy@kernel.org, anna@kernel.org, akpm@linux-foundation.org, willy@infradead.org, mcgrof@kernel.org, clm@meta.com, david@fromorbit.com, amir73il@gmail.com, axboe@kernel.dk, hch@lst.de, ritesh.list@gmail.com, djwong@kernel.org, dave@stgolabs.net, p.raghav@samsung.com, da.gomez@samsung.com, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, gfs2@lists.linux.dev, linux-nfs@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, Anuj Gupta Subject: Re: [PATCH 12/13] nfs: add support in nfs to handle multiple writeback contexts Message-ID: <20250602142237.GD21996@lst.de> References: <20250529111504.89912-1-kundan.kumar@samsung.com> <20250529111504.89912-13-kundan.kumar@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250529111504.89912-13-kundan.kumar@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 8B8F9140003 X-Stat-Signature: hb77r9c3yifaqp7jgu6dwcoyght1e8z6 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1748874161-98763 X-HE-Meta: U2FsdGVkX1/WGN/Km0Dfo0AXgwK0x8NTXLfquqFeR/ElQZ9arar/Y1BfwMIWSCR++VavAJskXZCJesLIOwx7bLTw3tBuuN8k8DdZhITu+4UMegL/3ocP2hKa9mL4fmwa44mIbOZD4JTQjZkFRiPfAk6ma/LnPpivx+WeAwIHVljGTmv2GkXE+jx23OStofyspJqtk1/tB+QezO8NYbotEXbKhAUDxPLyP8A1pPMI8IDGYnccju1gBupaNo6NwenjVMFugVl1i1AgD/WJp7dDQaZ11plEXOQpZoMshk/5+7nW5gVN15cHcfwnQ6+zjg3aHyBWct27KuPtJIT1Xyhvn/TBQ9Yntk1Cxx7GjlPZ+YsNPWVuA/YJcxWjmJSsBCUc9iwgNfYwd/wE5feoQbJmQyg7yelAxnZFvYH25fVTDzOWy4pNNKr/Q6jks6TPxkwf7Ts3dlEL3aSfhIkefQqbV7h0jcphXhbSynQtgPLljkJfjVCVS0fgNCrybWNN/tlNF1MlrnHsZE7/7r+bp9mbqf8vUCyEmjxGQ/GHpGv2QdxHIKPThHRb9l2AM6sszgj0WSkSDfTi8TgG4FBHMFb7XxIO8OjcKaNGTdoHiWL8hRfchU/Pb9MyAF2NHOLsphMzFelEBx+oL8V3w8Q2mjBYj9xrTUXJJypxeLMeHVnVDq1OosyvtTDJRy0glq/SnBpy/EWbRjqjDpEFUIViCOvalqY1Wav7DMHpYk0N9Zq77YLYsIFu0eSaQ6FsQZVX1Lc+XB+Pit9L4dwEKZaFrSS83X86q4QNwigyT4Oh7+QlNBX5105Fu8gRJZxVD69TXTww78g7ux29Y4Ub/5aorBxyA6bCHvLHHc/GEdfsxizLkbbfXdKMVJ+kUjtakD1PWP0f4xynEQDAWcEhSy5nx89yZ3IorBSIc/HbB1neUZVTaPecFeTsT/hsYpDEDmlpYpAWdoZTCKdQQWo1JcNHtYX 75gquOwp gmBGa7Ft8n36qbXqQXL3N0V1KxktT+vz2bY0yLI/vc3ORux8NyiDQX8LZfXLezjluM+IjX+zRDzJ3B7BtoEoHRHGWiOge170NyiDi/0r8MMHDT745eyvf/gsBHi2X5Oq/6yM+tSOnvnReg41f8GNK5KOblE5WJb2uk0TgcX1jjHmTGM0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 29, 2025 at 04:45:03PM +0530, Kundan Kumar wrote: > if (folio && !cinfo->dreq) { > struct inode *inode = folio->mapping->host; > + struct bdi_writeback_ctx *bdi_wb_ctx = > + fetch_bdi_writeback_ctx(inode); > long nr = folio_nr_pages(folio); > > /* This page is really still in write-back - just that the > * writeback is happening on the server now. > */ > node_stat_mod_folio(folio, NR_WRITEBACK, nr); > - wb_stat_mod(&inode_to_bdi(inode)->wb_ctx_arr[0]->wb, > - WB_WRITEBACK, nr); > + wb_stat_mod(&bdi_wb_ctx->wb, WB_WRITEBACK, nr); Similar comments to fuse here as well, except that nfs also really should be using the node stat helpers automatically counting the numbers of pages in a folio instead of duplicating the logic.