From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC5E6C5AD49 for ; Mon, 2 Jun 2025 17:35:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEFC96B0305; Mon, 2 Jun 2025 13:35:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC8606B0306; Mon, 2 Jun 2025 13:35:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDE666B0307; Mon, 2 Jun 2025 13:35:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B0ACB6B0305 for ; Mon, 2 Jun 2025 13:35:32 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EF56280E33 for ; Mon, 2 Jun 2025 17:35:31 +0000 (UTC) X-FDA: 83511162462.24.F16248C Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf20.hostedemail.com (Postfix) with ESMTP id 403D81C0004 for ; Mon, 2 Jun 2025 17:35:30 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="nuqOEwb/"; spf=pass (imf20.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748885730; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B2H8ITi3obDdMPx1uT8ZJ8lx+pBUS6w/tkAwoBjMv4M=; b=06HiV6wlCzV8YsXN8sqQiOai21Es11UovGhx0mWJ+JfL7uechEqVVNMlWkuynfrcHR/Clv 0pYDcgTubb7qyfeub/RH8A+NZNTAGnte1e15CTM0hbj0+V6SkypcsKLlep+12H/BVRPD8L PZ6Bt9rDHtH62MA+IW1P2WeJTNvHlwY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="nuqOEwb/"; spf=pass (imf20.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748885730; a=rsa-sha256; cv=none; b=TcBb1qmFUxnpMporR2t/xIvhT071XbhsB8Xzv2nkNKKNhnRVKMJb0rfa7x4jIgr69q87Bb 0G0LAEdkG1LK5M4tc/qQK+QS7SlGFRQ0zoe32HPjFnYVVs3H2/eVuUFUUyum68h+0TGIBB E7PXj0RiblXsA+WwtegGo2oiv5rraVc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id DF5384363F; Mon, 2 Jun 2025 17:35:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91B96C4CEEB; Mon, 2 Jun 2025 17:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748885728; bh=3qNdLWtW2T/xyAcKJWtubOFBpBEB/Hd6bXD6++CDdp8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nuqOEwb/MQgfBBUo3RghyWX52e5ddoF/O07yXPgMUkY86/Z+PLR1kdfHY05rV82jA lTpHhd/abkoawUPd0kvhbX+YaUWthudn0zVnYlZth01h/IqmgKJnQmjtieGt09Zex0 lSf9B/OV+yZf5cYtyrCCtIDa8BWjIMt3b0rEo5o/02CQFnt9xcFzVc/KXltIWiuHuR uEMIez23DqI5LbSgDoNU/0j6ZeH9ZOXWSMbmoM5fry5emARc+X88E7zmGaZw+Nfd6y 7WmQGbxbCWW4JySVjUW22f5M0RXe8NOTDUV6+7QHFTMOcCx0FWkQxGE97W09aoi+Lk 1O2xG4H9aGmtQ== From: SeongJae Park To: Barry Song <21cnbao@gmail.com> Cc: SeongJae Park , Lorenzo Stoakes , Jann Horn , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , "Liam R. Howlett" , David Hildenbrand , Vlastimil Babka , Suren Baghdasaryan , Lokesh Gidra , Tangquan Zheng Subject: Re: [PATCH RFC v2] mm: use per_vma lock for MADV_DONTNEED Date: Mon, 2 Jun 2025 10:35:19 -0700 Message-Id: <20250602173519.37005-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 403D81C0004 X-Stat-Signature: s3gjmgkbbtg3w9sbos36ftfcaotqn9fk X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1748885730-351054 X-HE-Meta: U2FsdGVkX19d61o1gPyoqGFTetH2mTLC0O5w3ttjthLNAzstcT5VIvI3WtnBc/RkjDzzn4D/MSCJEtMjkaoFpaXjQ7ah6hABI6k973j/aMNpHMh+ZNpAI0Ge6qFI9MmQUkM6TU8VcVQHsdEjmWN26JPjafL5l9sQK5vnufrRNVGGb8BV0ml+0E6SVRomOl6ikPqD7XsylsMqU7jB8njVL6suFVFH4uoSFwjqzHrGFseCRA7d65p/iuDRF1kcqj6/fSOx5X0OrNkJSdQByU9b3vcwkQS8VQfxmwTPe/K617XCx1J7qM70MG1IG3J3m/FJKryvZ01WlZXOL/HbD2OfteD/uAHm33fsdEgGKOMc/B7drvzty4PnXoJ5unSbEwfuxcWBu+YajF4eiYZXj3BuCKLIW9kCIiIhuFx54BEHnLfUZRAxcoAck9bDIvXDyVlLaIwMXjFtT4Q79RHybBSA6OFgJnDtlepuKz7LdbWpC9BeSOnedfI421nHbD/CP7IMmpBPrFrhgTn/JOJyFt4NM9XYTc4R45sco9rvFZzkkQJnq3cYfqsvpX0D80838UUJ3siflJs3Z8I8lUerNc/8fy++weT7NEJGqm3HHpYtf8Tqtm27KzBR7mVj5oOeaG5zuiUDBC6jc+1s8FJo/oXlWwioVrynXpJMPU6WlfJ0cjWpXTZJ7JCm5KemZHaL3c+Wr54oPr2RMBYZG3/RBhUcdi1ReDw1fEwoSg3hI8yWZOja1WAc/IDCb/I6ZhMeZDCwTbEsuygjm/7HqXuBZZTgin1mob+0d4DOKhMdmCu1OW6lONN9ixJFa3wTxQatkcaoxg8VdFPWvHkgiJEDKn0+JarD4zRcyIYc2Qvocv1tpe1qvGpy4PlQIRTFBmXKI8XXIo/levXkP2PmiuQ28sDSFnkKbrkzeep1Krc//d3DcgNAkT3UC5jjqcXzTjHXxA7LIA9BpFfNVC04MsIaOkc Jg3xzP7M ZIU4sQwyo5yGktNpyHM/j2t+2eCqZRpflmaP/Ewpx6850RjYrlfkX4SVW6PbMp3DMJLnEVimZB7e7kzFy4FniI7i0kZXDiVlCyIus8ufwh8VcqhpsV05gYs1doaz2OupTLSLCTWIqGPg9rUXCke9jdeGjbcXtYK79cnIgiYtQF6gx7li40bSkCsWwxUl2aGD8zoUvlJoNDxFPl57qzpfOLVmHPBTsBC1T7qgjRjOILGcqwz0aZHYmPwrYNArbcgxOncBiYRapyFxFQOd1M9bJemRiCw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 31 May 2025 04:17:51 +0800 Barry Song <21cnbao@gmail.com> wrote: [...] > BTW, I found vector_madvise doesn't check the ret value of madvise_lock(), > it seems also a bug? > > static ssize_t vector_madvise(struct mm_struct *mm, struct iov_iter *iter, > { > /* Drop and reacquire lock to unwind race. */ > madvise_finish_tlb(&madv_behavior); > madvise_unlock(mm, behavior); > madvise_lock(mm, behavior); /* missing the ret check */ > madvise_init_tlb(&madv_behavior, mm) > } Thank you for finding this, I will post a fix soon. Thanks, SJ [...]