From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 958BBC5AD49 for ; Mon, 2 Jun 2025 17:53:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 166F46B0309; Mon, 2 Jun 2025 13:53:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 117C06B030A; Mon, 2 Jun 2025 13:53:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02D926B030B; Mon, 2 Jun 2025 13:53:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D89FB6B0309 for ; Mon, 2 Jun 2025 13:53:08 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 56FA01D6EE8 for ; Mon, 2 Jun 2025 17:53:08 +0000 (UTC) X-FDA: 83511206856.13.4018B0C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id A942514001D for ; Mon, 2 Jun 2025 17:53:06 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Kf7BcB0G; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748886786; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WBklYxIk8v1ibueIfKqmOzU7EMd46YjSiT0cixnuNdM=; b=fndIsOKv7ynFcKr5OKBM8DCeMSUJ4HtdL8NU2vjVIZhrC85wO70lgygcS7kH6r7pZyHIYt K1D4y8aylNrOMroPRpcfA2fo7kk13wOCkosk/PwJfQkmmOCeMyp+TjsvGyCZqLNMw8KzNv oyp0P79nqsgV4ORW6XJ2NQIS5rvy8QI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Kf7BcB0G; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748886786; a=rsa-sha256; cv=none; b=YAUkHRjvYxUeOAa8OMRAXZmklgPsJwK2PkFtmtIsoHzNvOKGnGsHpUAnFtp/Ej/mWy1ThK g4wawKI5CUYJYC4mkrmwJGTu7IVNe6I87nk9GlQCnBBQyb3sVXbgQcXbkRFIzkdd8bO4ze YkW9Lj5sQq7l7Dd3mirhKQK7n68haxk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BE1025C62CB; Mon, 2 Jun 2025 17:50:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 519C7C4CEEB; Mon, 2 Jun 2025 17:53:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748886785; bh=uWEBc01E7ixIW/R/wWSVu1frd6MhrO1U98CFMR1JsWs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Kf7BcB0G/EghBA7aJQqJ78fZV6+3cp1SAPb3EiuiBYg9mT1x/J4txPOWT7erPPPxC V18UoD7KJJtVotJWD9rLCOnytXGiuP2m6DTN0bGgWl5AOSh0KEEXK9icrZ+gvzGZA3 6jORp1p6RcDpIcs5NLjX19Rjd/KqCTR2AHXXY1vCwg/NvxxH+vcaKMV670K0c3nMh7 ipG1/Ajv7uIJuWN52wWTo5oS/SeAn5YQNZbxore++/qT28y3DennLsaRBtXZv0h0YQ qkdOWXwml5vTtfIAdhCwNtUF/bTCCVRdh6JEoa5M62G4BIAJ9kqko9Q7lQvb8XCgd8 bY7fkm73xUXIQ== From: SeongJae Park To: SeongJae Park Cc: Barry Song <21cnbao@gmail.com>, Lorenzo Stoakes , Jann Horn , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , "Liam R. Howlett" , David Hildenbrand , Vlastimil Babka , Suren Baghdasaryan , Lokesh Gidra , Tangquan Zheng Subject: Re: [PATCH RFC v2] mm: use per_vma lock for MADV_DONTNEED Date: Mon, 2 Jun 2025 10:53:02 -0700 Message-Id: <20250602175302.1115-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250602173519.37005-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: 4huwiygyhod9kdmh8ex1keqj1txzds9y X-Rspamd-Queue-Id: A942514001D X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1748886786-782759 X-HE-Meta: U2FsdGVkX1+5cuPHyBvw3P06Ku/UWQ5PyS7kR3simYKECZwwOZYD6pBt20cMuXdz5OknxcR6Z8mkz8J9mNMFazlJ6MNHzhJSFRv8ZHcQdKNISw00o/Z3AJnuNND/SqkQv7qFrPc68DQVVt7V50aoCt2U0jtSUZ/M2ywOEBUIwra4RX94WxNn81wCHWqxNekYL8WFNkzJLX3ikZbFERrRtojpBbmdx6hdRStaYied4SLBjmUa+gvVyXkOSI58eZZc2md6nVItb4oXarEiKYamrs1LmfUcFAMV1obp6dOdjqnFuix73LHHHEPXRdiwTfrddw/RWN6/P8s+/5PUb4gR3U/sYkD+QcCLl5/4VABtnzVTjID3P23bxFgjpM27rBv+v76Fe9QoeiegBGhkDp/JNRBl1qkHn2h0HRJJtYdPJx5p+jpMcffN/Qj7rVenKl4N3ci5h8wn3Rpe5BFh9+qYvvcLfIZJgJ2VqYK/CmbNnIAziwDvcUX1Ol+qH2u7pn8Ev8lOiJfXoPh02g3AZleZAXCpHu7+V2lcrn07umSRlmgpe+t5pbs3b019JXuhyTRSXrGSW7AYzYivFpQJFmzMvp1XsaXrxBTy4EBZbi3B7cDfo8LRe07bHhblanpE7M3S405MXeKaRk/ORjxcomUWr5tfTXdQLnA/PQWY8TzK0qDpLO3I9xbCkAWQqb8sKXrtiU0WAapnWjoagkHxlq9cVqJyXkcmg16sPx2+ebfNlTyPt2i1qhNVKh2sXYf3rshavBh102SkEIVsPHT4bnILXKbsIfmELWdzt1gU5oFDPeK/kjwR0gcqGnEGRkEPnhxNSMzLwOSQAy8vK/TMPYjzQSVDT15tq0AwoaIAPE4JUI4extmfVdudUXCNaViVprLIA+WSgbQLKgeJNoIN2yWGH5eU6YA2ZYyzx5WSoYrjiH/PxEFqHs1rwt+IFv+msDDI6McQvXWc/orUwEfGRgz 4oUAzZME sTwq6zLL1Xt2M1uH0SPpfGnj0IuunhAxmFLLnWultfKXj6e5BLW1qsCC+xhDZWmp5dQToO0tN0H08QKEUDExSMOszvq3z18yCV6fJuZuDT/XrhDtK9PuWNJurkUSQYWs9dTE4q6gg8IrNoa4JEArC51gxvyf+V/iqchcQ3KKSBusGcaEWKtQHChaR6zOF31FAfmW6Ld0RbovW4WhFDq5k0QtSmrT9DW7IU+7lbpsaSxWxDL9NmatJPFlKvhnDPB5bIFloE/QwZMQ3DL9Dc0OeQQQieJtnikmpII/U1pc4FD5Vrz03ZyK+v82r8A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 2 Jun 2025 10:35:19 -0700 SeongJae Park wrote: > On Sat, 31 May 2025 04:17:51 +0800 Barry Song <21cnbao@gmail.com> wrote: > [...] > > BTW, I found vector_madvise doesn't check the ret value of madvise_lock(), > > it seems also a bug? > > > > static ssize_t vector_madvise(struct mm_struct *mm, struct iov_iter *iter, > > { > > /* Drop and reacquire lock to unwind race. */ > > madvise_finish_tlb(&madv_behavior); > > madvise_unlock(mm, behavior); > > madvise_lock(mm, behavior); /* missing the ret check */ > > madvise_init_tlb(&madv_behavior, mm) > > } > > Thank you for finding this, I will post a fix soon. The fix is now available at https://lore.kernel.org/20250602174926.1074-1-sj@kernel.org Thanks, SJ [...]