From: Andrew Morton <akpm@linux-foundation.org>
To: Khaled Elnaggar <khaledelnaggarlinux@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel-mentees@lists.linux.dev,
shuah@kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] selftests/mm/run_vmtests.sh: skip hugevm tests if write_to_hugetlbfs is missing
Date: Mon, 2 Jun 2025 19:12:16 -0700 [thread overview]
Message-ID: <20250602191216.7173b77e4f9ab5f659d1a448@linux-foundation.org> (raw)
In-Reply-To: <20250602232233.224099-1-khaledelnaggarlinux@gmail.com>
On Tue, 3 Jun 2025 02:22:32 +0300 Khaled Elnaggar <khaledelnaggarlinux@gmail.com> wrote:
> The hugevm tests 'charge_reserved_hugetlb.sh' and 'hugetlb_reparenting_test.sh'
> depend on the 'write_to_hugetlbfs' binary to simulate writes to hugetlbfs
> while checking reservations asynchronously in the background.
>
> When this binary is missing (e.g., excluded from the build), these tests hang
> for up to 180 seconds. During this time, run_vmtests.sh is eventually killed
> due to timeout, aborting all subsequent tests.
>
> This patch skips these tests if the binary is not found, preventing delays
> and ensuring that the test suite runs to completion.
OK, but why is write_to_hugetlbfs missing? If we're in a situation
where we _could_ run it then we _should_ run it! The user wants to
test stuff so we should test as much as we can.
So I'm thinking that it would be preferable to make sure the dang thing
is there?
next prev parent reply other threads:[~2025-06-03 2:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 18:43 [RFC] selftests/mm: Skip tests dependent on a binary not built Khaled Elnaggar
2025-05-23 21:09 ` Shuah Khan
2025-05-23 21:33 ` Khaled Elnaggar
2025-06-02 23:22 ` [PATCH RESEND] selftests/mm/run_vmtests.sh: skip hugevm tests if write_to_hugetlbfs is missing Khaled Elnaggar
2025-06-03 2:12 ` Andrew Morton [this message]
2025-06-04 22:35 ` Khaled Elnaggar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250602191216.7173b77e4f9ab5f659d1a448@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=khaledelnaggarlinux@gmail.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).