From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13C10C5B549 for ; Tue, 3 Jun 2025 02:12:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A84706B0393; Mon, 2 Jun 2025 22:12:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A35766B0394; Mon, 2 Jun 2025 22:12:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94D436B0395; Mon, 2 Jun 2025 22:12:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 768936B0393 for ; Mon, 2 Jun 2025 22:12:20 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 26745BF772 for ; Tue, 3 Jun 2025 02:12:20 +0000 (UTC) X-FDA: 83512464840.15.21D3BD2 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf04.hostedemail.com (Postfix) with ESMTP id 5B7564000C for ; Tue, 3 Jun 2025 02:12:18 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="j//vDRUu"; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748916738; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BG9k7mQgcrRnvhV/OBYEVtEbT1N3lLnCfsM31IiR6dE=; b=ESSqbpxdha/Hdil91urs+D/Ps28xpY9ABx27oMhdtaEaRBGD9OBZdo/kwD7pf3AovbRmc5 MljhSBiwjgGsj/HCDcHT/6/UDBh1kjTDd8tCgszfiLJkh+fKrbJL3SWX7RfFFjkPc7VEyx SNsVR4WRDdJIPKlaBotnNa2xLs0g1o4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="j//vDRUu"; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748916738; a=rsa-sha256; cv=none; b=vuOoihlEhSdRPOY6cQ79vLf09r9+OFxhdZB8gDg3bZrnzlyOewwVt2ioWXC1eAswsBaYVf KJagvTFBKS/6VN2QyI5ehqf5g0Yg5bqiPOz3k+EfkxywpMxS71xpPMJ/sSAt9r2l54zbkT laIyokAPRg0FVUT3UQJ8QRaFPqHkfD4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 0E86E4A5C1; Tue, 3 Jun 2025 02:12:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA438C4CEF0; Tue, 3 Jun 2025 02:12:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1748916736; bh=iSnNBGbsqCxVEZgDWP/TPN2p1e/vwAekYOJXt2gIxzo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=j//vDRUuMhEfxOx/h4IuIYPd0uqddYAJvS7lWqPYH9eopkxR8qbZYuKCi3/Oykobu LljW5ZJGknEkKtHyZW29tHF2z1EwCIbZ58Qht/kCOMaKO31HKHs7oQylOpZsNkaw78 X5Ua/IqKPtqQMzfvyq9UfcDs4NqRZoAg+jX+2PVk= Date: Mon, 2 Jun 2025 19:12:16 -0700 From: Andrew Morton To: Khaled Elnaggar Cc: linux-mm@kvack.org, linux-kernel-mentees@lists.linux.dev, shuah@kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] selftests/mm/run_vmtests.sh: skip hugevm tests if write_to_hugetlbfs is missing Message-Id: <20250602191216.7173b77e4f9ab5f659d1a448@linux-foundation.org> In-Reply-To: <20250602232233.224099-1-khaledelnaggarlinux@gmail.com> References: <20250523184312.2647781-1-khaledelnaggarlinux@gmail.com> <20250602232233.224099-1-khaledelnaggarlinux@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: war6a3nzkz4sfsdxaaay3abedhnntdam X-Rspamd-Queue-Id: 5B7564000C X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1748916738-953779 X-HE-Meta: U2FsdGVkX18eLF73P50VqZVC3WottzrqjNpeDNRoojJOGaplpgEMGIu6a53cHSrbu50yclAgwjy9+MmGs81BX07x674FggcGxti8aR6TSuw8uCzsfMSFpXDvVNw4FgjEUAvwbzCYmUM9j10lOkmBPV4SpsKWctpfmkRADhvzlRSxJXQYENhRNi3tkkx44i8m2Q9IQe/KphJ/5KxNHREKiUQJELk4i4yzB1Uj8TpzGuWt+iQ3b/hDLsHpP0QBULRhE9pRr27xprP9G8ikVGs89poSs+m9tNIgEJhEEv2NYHTYvIEfdUHNn2w0PnDwZuGIEXGjgKsuXqHMAo5KIuXScxbKFZ+qmrVEsbW6QeC+GfJk2NWwPq7VTX7SWz9Nn/ZJCSO2MvqpdS0U0k1pYEVtaiJIxABSrX+WhkTAZ1EMgtOPvEcV7zHeLIjbqBNEoUElIy/JD0vdLAuVlxB25okPA7y4pd+dXnXAosyEj82US7qkxLBF32pVZNjbr6Weqy3dn1qzfU+SE1/ECU0gH635gOjcQpU8B9B5qo+uy9BPmCSHtAECpWcz2Zr5XxUOD9iaj3xda90KjNhPQU07g+hAGYMcpRYR6O51psYJ2g43qGnP5msQRaSLmjH7ELT+k7wpj/15jsZUHMikPT5ZRcUF4SV7G2wRX9sLL9nu3FkbtSSpwZ/5aruFTddI/o5ZQaDsd2cHABrdwTtgVajjWg5VngpOYYxddAcTvwUhwc8fNKGLBYa83JGMu0IGRkFONQaXgcQceOnIqvVBanwnkTfgAjHc+2bElSrBOntBZ2UiHvudJMF4xxzIVssqximNpRa+VLsEiL2Xu6BKQ3v9vWyrHR6TLBYPkkmAg79TWKvN+L51JX10Xg24TEmz4G/o1vRKSIGKSGyAz7oNM1hE8FRGF8vEdk8wpdTFYzbfuRauae33HLiK45+T2nXiSoClXf3Z/pPcpmrLvtRsApC2Jax tzmHUv/G aCoBmVFbVzENGQyCv3XqYu15S0I1hJNxy7n5ZNU9vMu51JRJy1CPTd+Ey0vGUZY0HeSbnuweGJTIBmTmrRijSLWI+sRnqiQpmnh5QLnF8YxR8P/27CGAKiE7zzjfoce/8osBs2msBATlJxdJAxXTC9gNqHCwS2y/KXn7DV5OcjRnwvaWxIji8IBuQtf/tACc81Aq/PlpcMBQ0FpjhP5URtpUPVezbX2hcnu2iWtUZo82fGZ6UhH/aQLo+tPZoSmHDM4Ws2rhM84TBzQUVCf9KEeUTPQ2hNFWk2FGoZf1V74qV261RK6QcfKBv4khTR3cPea3wG2q9DDZbK+hyU/3j08kfRw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 3 Jun 2025 02:22:32 +0300 Khaled Elnaggar wrote: > The hugevm tests 'charge_reserved_hugetlb.sh' and 'hugetlb_reparenting_test.sh' > depend on the 'write_to_hugetlbfs' binary to simulate writes to hugetlbfs > while checking reservations asynchronously in the background. > > When this binary is missing (e.g., excluded from the build), these tests hang > for up to 180 seconds. During this time, run_vmtests.sh is eventually killed > due to timeout, aborting all subsequent tests. > > This patch skips these tests if the binary is not found, preventing delays > and ensuring that the test suite runs to completion. OK, but why is write_to_hugetlbfs missing? If we're in a situation where we _could_ run it then we _should_ run it! The user wants to test stuff so we should test as much as we can. So I'm thinking that it would be preferable to make sure the dang thing is there?