linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Byungchul Park <byungchul@sk.com>
To: willy@infradead.org, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com,
	ilias.apalodimas@linaro.org, harry.yoo@oracle.com,
	hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net,
	john.fastabend@gmail.com, andrew+netdev@lunn.ch,
	asml.silence@gmail.com, toke@redhat.com, tariqt@nvidia.com,
	edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com,
	leon@kernel.org, ast@kernel.org, daniel@iogearbox.net,
	david@redhat.com, lorenzo.stoakes@oracle.com,
	Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org,
	surenb@google.com, mhocko@suse.com, horms@kernel.org,
	linux-rdma@vger.kernel.org, bpf@vger.kernel.org,
	vishal.moola@gmail.com
Subject: [RFC v4 07/18] page_pool: use netmem put API in page_pool_return_netmem()
Date: Wed,  4 Jun 2025 11:52:35 +0900	[thread overview]
Message-ID: <20250604025246.61616-8-byungchul@sk.com> (raw)
In-Reply-To: <20250604025246.61616-1-byungchul@sk.com>

Use netmem put API, put_netmem(), instead of put_page() in
page_pool_return_netmem().

While at it, delete #include <linux/mm.h> since the last put_page() in
page_pool.c has been just removed with this patch.

Signed-off-by: Byungchul Park <byungchul@sk.com>
Reviewed-by: Mina Almasry <almasrymina@google.com>
---
 net/core/page_pool.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/net/core/page_pool.c b/net/core/page_pool.c
index b7680dcb83e4..dab89bc69f10 100644
--- a/net/core/page_pool.c
+++ b/net/core/page_pool.c
@@ -20,7 +20,6 @@
 #include <linux/dma-direction.h>
 #include <linux/dma-mapping.h>
 #include <linux/page-flags.h>
-#include <linux/mm.h> /* for put_page() */
 #include <linux/poison.h>
 #include <linux/ethtool.h>
 #include <linux/netdevice.h>
@@ -712,7 +711,7 @@ static __always_inline void __page_pool_release_page_dma(struct page_pool *pool,
 /* Disconnects a page (from a page_pool).  API users can have a need
  * to disconnect a page (from a page_pool), to allow it to be used as
  * a regular page (that will eventually be returned to the normal
- * page-allocator via put_page).
+ * page-allocator via put_netmem()).
  */
 static void page_pool_return_netmem(struct page_pool *pool, netmem_ref netmem)
 {
@@ -733,7 +732,7 @@ static void page_pool_return_netmem(struct page_pool *pool, netmem_ref netmem)
 
 	if (put) {
 		page_pool_clear_pp_info(netmem);
-		put_page(netmem_to_page(netmem));
+		put_netmem(netmem);
 	}
 	/* An optimization would be to call __free_pages(page, pool->p.order)
 	 * knowing page is not part of page-cache (thus avoiding a
-- 
2.17.1



  parent reply	other threads:[~2025-06-04  2:53 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-04  2:52 [RFC v4 00/18] Split netmem from struct page Byungchul Park
2025-06-04  2:52 ` [RFC v4 01/18] netmem: introduce struct netmem_desc mirroring " Byungchul Park
2025-06-04 16:53   ` Toke Høiland-Jørgensen
2025-06-05 10:03   ` Pavel Begunkov
2025-06-05 10:04     ` Pavel Begunkov
2025-06-05 19:34   ` Mina Almasry
2025-06-04  2:52 ` [RFC v4 02/18] netmem: introduce netmem alloc APIs to wrap page alloc APIs Byungchul Park
2025-06-04 15:14   ` Suren Baghdasaryan
2025-06-05  0:53     ` Byungchul Park
2025-06-05 10:05   ` Pavel Begunkov
2025-06-04  2:52 ` [RFC v4 03/18] page_pool: use netmem alloc/put APIs in __page_pool_alloc_page_order() Byungchul Park
2025-06-04 16:54   ` Toke Høiland-Jørgensen
2025-06-05 10:26   ` Pavel Begunkov
2025-06-05 19:39     ` Mina Almasry
2025-06-05 20:27       ` Pavel Begunkov
2025-06-05 20:34         ` Mina Almasry
2025-06-04  2:52 ` [RFC v4 04/18] page_pool: rename __page_pool_alloc_page_order() to __page_pool_alloc_netmem_order() Byungchul Park
2025-06-04 16:54   ` Toke Høiland-Jørgensen
2025-06-05 10:28   ` Pavel Begunkov
2025-06-04  2:52 ` [RFC v4 05/18] page_pool: use netmem alloc/put APIs in __page_pool_alloc_pages_slow() Byungchul Park
2025-06-04 17:02   ` Toke Høiland-Jørgensen
2025-06-05 10:30   ` Pavel Begunkov
2025-06-04  2:52 ` [RFC v4 06/18] page_pool: rename page_pool_return_page() to page_pool_return_netmem() Byungchul Park
2025-06-04 17:03   ` Toke Høiland-Jørgensen
2025-06-05 10:31   ` Pavel Begunkov
2025-06-04  2:52 ` Byungchul Park [this message]
2025-06-04 16:54   ` [RFC v4 07/18] page_pool: use netmem put API in page_pool_return_netmem() Toke Høiland-Jørgensen
2025-06-05 10:33   ` Pavel Begunkov
2025-06-04  2:52 ` [RFC v4 08/18] page_pool: rename __page_pool_release_page_dma() to __page_pool_release_netmem_dma() Byungchul Park
2025-06-04 16:55   ` Toke Høiland-Jørgensen
2025-06-05 10:34   ` Pavel Begunkov
2025-06-04  2:52 ` [RFC v4 09/18] page_pool: rename __page_pool_put_page() to __page_pool_put_netmem() Byungchul Park
2025-06-04 16:55   ` Toke Høiland-Jørgensen
2025-06-05 10:35   ` Pavel Begunkov
2025-06-05 10:39     ` Pavel Begunkov
2025-06-04  2:52 ` [RFC v4 10/18] page_pool: rename __page_pool_alloc_pages_slow() to __page_pool_alloc_netmems_slow() Byungchul Park
2025-06-04 17:03   ` Toke Høiland-Jørgensen
2025-06-04  2:52 ` [RFC v4 11/18] mlx4: use netmem descriptor and APIs for page pool Byungchul Park
2025-06-04  2:52 ` [RFC v4 12/18] netmem: use _Generic to cover const casting for page_to_netmem() Byungchul Park
2025-06-04 16:55   ` Toke Høiland-Jørgensen
2025-06-05 10:40   ` Pavel Begunkov
2025-06-04  2:52 ` [RFC v4 13/18] netmem: remove __netmem_get_pp() Byungchul Park
2025-06-04 16:56   ` Toke Høiland-Jørgensen
2025-06-05 10:41   ` Pavel Begunkov
2025-06-04  2:52 ` [RFC v4 14/18] page_pool: make page_pool_get_dma_addr() just wrap page_pool_get_dma_addr_netmem() Byungchul Park
2025-06-04 16:57   ` Toke Høiland-Jørgensen
2025-06-05 10:45   ` Pavel Begunkov
2025-06-04  2:52 ` [RFC v4 15/18] netdevsim: use netmem descriptor and APIs for page pool Byungchul Park
2025-06-04  2:52 ` [RFC v4 16/18] netmem: introduce a netmem API, virt_to_head_netmem() Byungchul Park
2025-06-04 16:59   ` Toke Høiland-Jørgensen
2025-06-05 10:45   ` Pavel Begunkov
2025-06-05 19:43   ` Mina Almasry
2025-06-04  2:52 ` [RFC v4 17/18] mt76: use netmem descriptor and APIs for page pool Byungchul Park
2025-06-04  2:52 ` [RFC v4 18/18] page_pool: access ->pp_magic through struct netmem_desc in page_pool_page_is_pp() Byungchul Park
2025-06-04 16:59   ` Toke Høiland-Jørgensen
2025-06-05 10:56   ` Pavel Begunkov
2025-06-05 11:49     ` Harry Yoo
2025-06-05 12:17       ` Harry Yoo
2025-06-05 13:28         ` Pavel Begunkov
2025-06-05 19:47       ` Mina Almasry
2025-06-05 20:16         ` Pavel Begunkov
2025-06-04  3:23 ` [RFC v4 00/18] Split netmem from struct page Byungchul Park
2025-06-05 19:55   ` Mina Almasry
2025-06-09  4:22     ` Byungchul Park
2025-06-09  7:53       ` Byungchul Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250604025246.61616-8-byungchul@sk.com \
    --to=byungchul@sk.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=almasrymina@google.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=asml.silence@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=david@redhat.com \
    --cc=edumazet@google.com \
    --cc=harry.yoo@oracle.com \
    --cc=hawk@kernel.org \
    --cc=horms@kernel.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=john.fastabend@gmail.com \
    --cc=kernel_team@skhynix.com \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rppt@kernel.org \
    --cc=saeedm@nvidia.com \
    --cc=surenb@google.com \
    --cc=tariqt@nvidia.com \
    --cc=toke@redhat.com \
    --cc=vbabka@suse.cz \
    --cc=vishal.moola@gmail.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).