From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2B1DC5B543 for ; Wed, 4 Jun 2025 17:25:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 635656B00FD; Wed, 4 Jun 2025 13:25:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E64D6B00FE; Wed, 4 Jun 2025 13:25:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D49D6B00FF; Wed, 4 Jun 2025 13:25:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2C6D86B00FD for ; Wed, 4 Jun 2025 13:25:33 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B46601402DD for ; Wed, 4 Jun 2025 17:25:32 +0000 (UTC) X-FDA: 83518394904.08.84CDD4E Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf29.hostedemail.com (Postfix) with ESMTP id 17ACA120013 for ; Wed, 4 Jun 2025 17:25:30 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gqbCR5rZ; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749057931; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XiaisUPFg8cxQo7pKAzqkA92AkyNgjULdXnGy9/lx6w=; b=uRWnHk6kLWnz7Dy/6Joxk2/6blj8pakR6+paz+EVc7rBsKtABYxAa3HPDIdmU5dCaVXzM8 NmY+LKHy44MsbnHp3FDIV2KK4r3Wm+E9Nav9kcb++ob44QBvdojAPCRpMIzr69KVpS04wv obdABUmoOa1Z5O/EjWWlHEf2j2TrgnI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gqbCR5rZ; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749057931; a=rsa-sha256; cv=none; b=cdTvfy4RJmegULDB+9f9TPGsth3XOEqDV/XqluE+6OOWlO3qLJ6x5w64TdYBAZQ3K14RK4 +Ihm2raZgxW1qTfdqwU/a+tvSegygq9bsS1KfOcH6nYHBkqm1HmEbji4228DNWxJGwJWT2 YGw5MDrXEreu37TzGpIK35S2rWYldh8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 4C541614E0; Wed, 4 Jun 2025 17:25:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFD34C4CEE4; Wed, 4 Jun 2025 17:25:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749057930; bh=SD9ZtYC8DZGJPnmggzhoPOkgEH8ofRd+R865IgSmohQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gqbCR5rZgMbTFYPVMyb5Cw07NuruYy+eiQkUGkBbqRSXm6w/RtrfJFw9Tsz0fvxhO imtpwSf67o4rLqv2Ziol8cZMvdRDOabPPP3lyJ9xLp/d9q41eSs0OYmEc5SG4gJuIe HoL4TYD4wXBGk/w6+9yjRwrQSIJhSvQZ3xbg3EKJZi4KFA23lQTkEjSBvj9xfdrDCh vKhGTLywOFVin0aybWxPmQGof+zXi4J0OwIujl6Qpn500QwZoehdb5iNVTPcQeh/Kl IUtyw05TmdcqmB8wrPKLtHeChJwwo+8+t5sB9POIzWH3p8kG9cp2S5pioZe365+Ybc Y21Z0IXNUQSnw== From: SeongJae Park To: David Hildenbrand Cc: SeongJae Park , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jason Gunthorpe , John Hubbard , Peter Xu Subject: Re: [PATCH v1] mm/gup: remove (VM_)BUG_ONs Date: Wed, 4 Jun 2025 10:25:27 -0700 Message-Id: <20250604172527.7245-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250604140544.688711-1-david@redhat.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 17ACA120013 X-Rspamd-Server: rspam09 X-Stat-Signature: 3m4bemcfqgshmppqsz5t8e9jpznxeq86 X-HE-Tag: 1749057930-761172 X-HE-Meta: U2FsdGVkX18b4k5z5tm/7c7AB8tOs/oxIHK6YwTAMONsGugrHSQOsIfgE5lndvbohULBW7r9ITc0Afjdo1I+AWtS/FgQ2YHOCBaAMMZEUIEEGNcZ02zkmSnYF2qjWlRp0oxM4PNIQQXGZPfRzdcK0jXhhapAbshneEzMWogelxKcw/RvqQyCiTUenDMKfDS6JGQAEL2nvyV/ClCEbMXfc51tYdEAe0nysxCIe1r8nz8JhcbXz4zBoBArhh3wCRkzs/3kUCX/CdbuEctET2DoCFNMmsupKbUlwiJz+qcC6CthFePfsq3IZzG8PvdepPynTtaqQHEJaNY6QhKHgXQFQfmBSoGXpd17HvwFB69tCcPINOP/ir9FO0ZluB6hC5zKefFPCJHJyHUjRG2OwD6G10rxCMkD4JLeFRXwH73Hw3suWMmGYEd4/UjWLS7KAylzjLeR+PvCtyftY+jplLkMrDZKonPpg2mqkmZysJ0By6RB/NeGSljlkZuYPIWYWy5ZvvvwczCT3Z3VFNQGdm4Gvo9YNjltHeFs+4Kd0lTk15bqWxt4McxP5t4HlZcr2rcxlcnhE6GFpNm4Vtfc9RgQvY8CAsus7s94tT4AzVmGXiMC+/A3qxKrY2ZKedvzQZfDmP2ZZofIAB/q4So0c1vOgJk53ncS9owhM+5XkKrCe/JwMJVJXma3UcRNO5G/tl5sRgwmbFpVAszGGpXSuwfXxthpVM6zMjKNHEvquvTwfBZCTGM3COqz1DZfXgeozQoe7IIPMJfjqy+IpnYBJXaFkuiJkDV1REj0b4OZ8jtXS5TvjOd8/Yj3tc3QPxpjLpb4U5hsFW46WwmOZpoqbOU3oWPm7EM/lCcBdVGKfl1HujjyVuYHD//5yIuSqWlkUpZqVsAxIN9ym0tKTWGYnyT2NMJ7dQVFlJwLmLMyCUfI9SMOWToRv3IdgMWLLJ4ci1v+2R3/Jcfn9nGI8SK4350 xC60nXEj g1Jw/7HQBqm5NqBSNccmjUGMBAHdMW/iTF602xlbwrTHXeV7GgwI+Jhlwf6gUBJNmU+J94bq+Me41OD8/YtaBeQlrGx0d7fT2M3koB+X+WwkzrJ6o/hoFnFWIgcKN/Y0meIuwHGBMNehn3DFENWa341eNAOl6rdqabhorkdbGE4Dhk+2Z+PeCkHTMY5C00jjIQyBQTJg++Lk1ZjoEEtw+k7Nkzo96JGuVYqusT5mUVcbqYFvGYf7e+dMMrPGA4nsu0M7MFmriCMYDpheEvAXrJJmH1MZzrrh2jhS4Wa+zGvO3RY8tKzjbzE/zji9BzfZ/R4W+8JZlrTukZmKkX5LFaQ6h/GqvgDGZ3+pP9ox/uYdoAsTCTmN9UsLIHzFyjwXGmCdkPlzUkkciDr5B57+NVB8Y4LROUhF9dOt/zDXmDKRIF31OSO+ColGYfVGD7kDfFOtFkH72p7dQzaBLUoaYdDFuk+1jaRPmRp/R/7nXDGxvEhR4Ejs/j+gChcmb4wnTRrX6KD6fP+wcUTQaJ0JmtoZ7mW8vwXqcTxKnjsbBhX7SKK8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 4 Jun 2025 16:05:44 +0200 David Hildenbrand wrote: > Especially once we hit one of the assertions in > sanity_check_pinned_pages(), observing follow-up assertions failing > in other code can give good clues about what went wrong, so use > VM_WARN_ON_ONCE instead. > > While at it, let's just convert all VM_BUG_ON to VM_WARN_ON_ONCE as > well. Add one comment for the pfn_valid() check. > > We have to introduce VM_WARN_ON_ONCE_VMA() to make that fly. > > Drop the BUG_ON after mmap_read_lock_killable(), if that ever returns > something > 0 we're in bigger trouble. Convert the other BUG_ON's into > VM_WARN_ON_ONCE as well, they are in a similar domain "should never > happen", but more reasonable to check for during early testing. > > Cc: Andrew Morton > Cc: Lorenzo Stoakes > Cc: "Liam R. Howlett" > Cc: Vlastimil Babka > Cc: Mike Rapoport > Cc: Suren Baghdasaryan > Cc: Michal Hocko > Cc: Jason Gunthorpe > Cc: John Hubbard > Cc: Peter Xu > Signed-off-by: David Hildenbrand Acked-by: SeongJae Park Thanks, SJ [...]