From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18DCAC5B559 for ; Thu, 5 Jun 2025 07:46:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A61BF6B0539; Thu, 5 Jun 2025 03:46:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A12296B053A; Thu, 5 Jun 2025 03:46:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 901C06B053D; Thu, 5 Jun 2025 03:46:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 719E66B0539 for ; Thu, 5 Jun 2025 03:46:45 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E64AB161C9E for ; Thu, 5 Jun 2025 07:46:44 +0000 (UTC) X-FDA: 83520565128.06.EA36E9F Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf27.hostedemail.com (Postfix) with ESMTP id 41FB040004 for ; Thu, 5 Jun 2025 07:46:43 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=lst.de; spf=pass (imf27.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749109603; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cKee/qIwlygXPG54z9FwQFwIvcRLKFKQeaibnDMRW2w=; b=EGA9B0FHUOSTLSG96+TsII4GHIvQerbGJhB4GdDb7Zd/tbiQMbRujXxj0SLouWRUPHC3Zt MOueU1NeO+TuZTW8gup0nYtyz6QNWK/dd/ylb6KBbERguu4bL5hEFocRO64k3isptAICGU RnDuZJpy9903RxNvTQC7IypgYo/WNrk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749109603; a=rsa-sha256; cv=none; b=GaPzg16T2DcbUBI5mR5qOTMGQ5YCBM5owKJyaHDKWdoYTU2BjN7NZaSbwk0VZta1z7mMm8 6ciCkWolI3hmqUa95AQBKxbZDVdVThy3PN7YeLRuTy0maIavKTbfUWr8bM+BjZ1xXpaWVw VxFyyVuTZ6XiQZecxDlQNUv2IQ4TvU4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=lst.de; spf=pass (imf27.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 7FA0568AA6; Thu, 5 Jun 2025 09:46:37 +0200 (CEST) Date: Thu, 5 Jun 2025 09:46:37 +0200 From: Christoph Hellwig To: Dan Williams Cc: Alistair Popple , linux-mm@kvack.org, gerald.schaefer@linux.ibm.com, jgg@ziepe.ca, willy@infradead.org, david@redhat.com, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, zhang.lyra@gmail.com, debug@rivosinc.com, bjorn@kernel.org, balbirs@nvidia.com, lorenzo.stoakes@oracle.com, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-cxl@vger.kernel.org, dri-devel@lists.freedesktop.org, John@groves.net Subject: Re: [PATCH 03/12] mm/pagewalk: Skip dax pages in pagewalk Message-ID: <20250605074637.GA7727@lst.de> References: <1799c6772825e1401e7ccad81a10646118201953.1748500293.git-series.apopple@nvidia.com> <6840f9ed3785a_249110084@dwillia2-xfh.jf.intel.com.notmuch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6840f9ed3785a_249110084@dwillia2-xfh.jf.intel.com.notmuch> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 41FB040004 X-Stat-Signature: qfukfhrw45qg39ayasiju99dopfurmex X-Rspam-User: X-HE-Tag: 1749109603-174844 X-HE-Meta: U2FsdGVkX1+7s3ONxV7kmoosXCKeULZS6TbEKn6fMxqmTUben/5/L0up0W4ruSQ6dM28rS5HgVhcyjrUoQSIwdxD0tVQa3tPaI3BqEBQn4+30S6F5TynJ/kj7W62HLPJRX6ylHjV+r6KpJBRGbkiZlrDdWAm6Shisciv5pw4ezUZtAn+WJWFl9UBYyvvIHy0uOd0WcSA/Fj1J6C/PUnju7MysNFTW87EVlKOsKpeTQbrH/xVuRoTmA5hiHT7juX1fRUSBBjFNvWg83IuFIRnFyR074/qJi69oDo0xvlyKG1yRgMMii37u+F0KTjV6mgNiB1r1Vrix5W4o03n+8XnsW9eiDXTiAp5SY6p9deTCBDKsHVwErZs0C4eRoV71Vf2RBop7iQzdTXXONtPKRR5nTp1odVXbTvoubyP5aq/Z5aSbkRHQIjV2OSlkpCth03bMzBsD6EsjGCQfZY6xxSAk7taieaFLCPEG5OrSUwmlve6FQKjHUxxK909vv4TG6EFa/2CFA/iEpxCZMhvxQxDnDJHtfJJVffLWumc6ZOXXKmQRWtGXqcrWWzjnDKlGcSnzbwhxh4K1VWiA2CIoU6uykMPV7OJNLSo7r9cb+GqYswN2GG237pN87dBwIEMiekO9vcdhJ9rP7q/Wg1fmIwfbCesFq7BJ6KdTzQ+qMaz9VG3u49Iy9wuAAOouxNeR491TbKwv0ifqVtEeOzqhue9lH8wI0/zpZNmwnzXx81Vx7iqvL5mXiJ/3VZRyTETyydFzFxg7QkgIlROBvkrPY4QRmDwupee5m/2vvjFEFJ7Z4w22kddpT0NBxbi5eJstnLf6O4+uRF2xOrFjMJEmkCjNr1qGlBgBPJfM3iWB388gt+HfnhmHS0SlD3E9n/jmj9cPEOwoceLM422NXH149ynxPUUK0AhXCgqh9PTHaWuXhwS4FbtZV3HijvbAJAVNef6SUqj+4t8bGqNn0mAKig 2ZPaQyRu fVpxEie0mTg6MHljbX9z+LWtuzhxGPlVqzMH+y4rje0p/tULuOyzfTvJo+QzlyLs42jK9VhQ2tgp4GvNyO970MKCcydN1r230KUIopS1LuwwUveSe6qCGV+UqJ9796Qt/RJM5SLYGI8d5W5aG+wl5yGKYv5gf0gTMlhHwFNH6mctmxkU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 04, 2025 at 06:59:09PM -0700, Dan Williams wrote: > +/* return normal pages backed by the page allocator */ > +static inline struct page *vm_normal_gfp_pmd(struct vm_area_struct *vma, > + unsigned long addr, pmd_t pmd) > +{ > + struct page *page = vm_normal_page_pmd(vma, addr, pmd); > + > + if (!is_devdax_page(page) && !is_fsdax_page(page)) > + return page; > + return NULL; If you go for this make it more straight forward by having the normal path in the main flow: if (is_devdax_page(page) || is_fsdax_page(page)) return NULL; return page; > +static inline struct page *vm_normal_gfp_pte(struct vm_area_struct *vma, > + unsigned long addr, pte_t pte) > +{ > + struct page *page = vm_normal_page(vma, addr, pte); > + > + if (!is_devdax_page(page) && !is_fsdax_page(page)) > + return page; > + return NULL; Same here.