From: Andrew Morton <akpm@linux-foundation.org>
To: Jan Kara <jack@suse.cz>
Cc: Chi Zhiling <chizhiling@163.com>,
willy@infradead.org, josef@toxicpanda.com,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Chi Zhiling <chizhiling@kylinos.cn>
Subject: Re: [PATCH] readahead: fix return value of page_cache_next_miss() when no hole is found
Date: Thu, 5 Jun 2025 14:51:52 -0700 [thread overview]
Message-ID: <20250605145152.9ae3edb99f29ef46b30096e4@linux-foundation.org> (raw)
In-Reply-To: <qbuhdfdvbyida5y7g34o4rf5s5ntx462ffy3wso3pb5f3t4pev@3hqnswkp7of6>
On Thu, 5 Jun 2025 10:22:23 +0200 Jan Kara <jack@suse.cz> wrote:
> On Thu 05-06-25 13:49:35, Chi Zhiling wrote:
> > From: Chi Zhiling <chizhiling@kylinos.cn>
> >
> > max_scan in page_cache_next_miss always decreases to zero when no hole
> > is found, causing the return value to be index + 0.
> >
> > Fix this by preserving the max_scan value throughout the loop.
> >
> > Fixes: 901a269ff3d5 ("filemap: fix page_cache_next_miss() when no hole found")
> > Signed-off-by: Chi Zhiling <chizhiling@kylinos.cn>
>
> Indeed. Thanks for catching this. Don't know how I missed that. Feel free
> to add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
Thanks. It's a simple patch - do we expect it to have significant
runtime effects?
next prev parent reply other threads:[~2025-06-05 21:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 5:49 [PATCH] readahead: fix return value of page_cache_next_miss() when no hole is found Chi Zhiling
2025-06-05 8:22 ` Jan Kara
2025-06-05 21:51 ` Andrew Morton [this message]
2025-06-06 10:54 ` Jan Kara
2025-06-08 3:00 ` Chi Zhiling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250605145152.9ae3edb99f29ef46b30096e4@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=chizhiling@163.com \
--cc=chizhiling@kylinos.cn \
--cc=jack@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).