From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 249C3C5B552 for ; Mon, 9 Jun 2025 09:22:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2C576B00A2; Mon, 9 Jun 2025 05:22:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADC496B00A3; Mon, 9 Jun 2025 05:22:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CAF36B00A4; Mon, 9 Jun 2025 05:22:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 781A56B00A2 for ; Mon, 9 Jun 2025 05:22:29 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 395FFBF22D for ; Mon, 9 Jun 2025 09:22:29 +0000 (UTC) X-FDA: 83535321618.09.D266B59 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf11.hostedemail.com (Postfix) with ESMTP id 0536C40002 for ; Mon, 9 Jun 2025 09:22:26 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=sz5JOrIx; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=9gBX0nwR; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=sz5JOrIx; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=9gBX0nwR; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749460947; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uHOgvF9itSvkhMsMVkzRlsFcZ/xr0pjhSkbXFFTW4PA=; b=UYPP7ZawnTuoFO3WIsgsYhDt7Du0P9wj0f4aYcelnfvosNpdKRLDQX3h0ZXLTYtE+pLQZY T9Ux0Y7205WZCvXYgbzA2G9NGxt0BIuBSnXrmCsf3stK+fhympXzdDt1GMaLgKc1eXVPIX EnQSefL8UtBG5rGPrB5iYoy2r4nhxRw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749460947; a=rsa-sha256; cv=none; b=YgXHfc27Ha7PYB3KXrnkkbB6WojIDhG2cIIC1/W17YhDkbgvp4fNi31KkWs5enDcc/izrB CRh7ICrNMUpsfM30F0wYgqfnxH+jtuwst9H+NlNhQG6cE40n7nZ7FPy3n+aK2FGQVRwxuQ IFKnpMPKc70k7UXxhPq86GDMvPHhnAQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=sz5JOrIx; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=9gBX0nwR; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=sz5JOrIx; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=9gBX0nwR; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0461B211A7; Mon, 9 Jun 2025 09:22:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749460924; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uHOgvF9itSvkhMsMVkzRlsFcZ/xr0pjhSkbXFFTW4PA=; b=sz5JOrIxe0qfhJ0PRnJlV9vhrhSRHOdS3WCXd/sOjYhQl7Cz02bcEqWtQiOWdzdGr7ZOQe lcPLZQe+iPGVZBZAUgCLOl2eI5bI4rmtwZZlcy3VwWMWS+kl4gIMTBQcAA85uyo/ufkjwp xdZynO5qAZoc7X746nC6vchwuLLnbvE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749460924; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uHOgvF9itSvkhMsMVkzRlsFcZ/xr0pjhSkbXFFTW4PA=; b=9gBX0nwRa8VtQ0PQBTu4kneOeTHqYtZqFkWpkUyv7nUk+YuDPZU6tBgRwi/rhm6hXSUv8p 4ijnbJly+sXQlcBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749460924; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uHOgvF9itSvkhMsMVkzRlsFcZ/xr0pjhSkbXFFTW4PA=; b=sz5JOrIxe0qfhJ0PRnJlV9vhrhSRHOdS3WCXd/sOjYhQl7Cz02bcEqWtQiOWdzdGr7ZOQe lcPLZQe+iPGVZBZAUgCLOl2eI5bI4rmtwZZlcy3VwWMWS+kl4gIMTBQcAA85uyo/ufkjwp xdZynO5qAZoc7X746nC6vchwuLLnbvE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749460924; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uHOgvF9itSvkhMsMVkzRlsFcZ/xr0pjhSkbXFFTW4PA=; b=9gBX0nwRa8VtQ0PQBTu4kneOeTHqYtZqFkWpkUyv7nUk+YuDPZU6tBgRwi/rhm6hXSUv8p 4ijnbJly+sXQlcBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6093813A85; Mon, 9 Jun 2025 09:22:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id aE/oFLunRmjJGAAAD6G6ig (envelope-from ); Mon, 09 Jun 2025 09:22:03 +0000 From: Oscar Salvador To: Andrew Morton Cc: David Hildenbrand , Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Joshua Hahn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: [PATCH v6 05/10] mm,memory-tiers: Use node-notifier instead of memory-notifier Date: Mon, 9 Jun 2025 11:21:42 +0200 Message-ID: <20250609092149.312114-6-osalvador@suse.de> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250609092149.312114-1-osalvador@suse.de> References: <20250609092149.312114-1-osalvador@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0536C40002 X-Stat-Signature: c816bp4cru166egc7iio1fy7kstwwd6o X-Rspam-User: X-HE-Tag: 1749460946-237332 X-HE-Meta: U2FsdGVkX1+e2Oq/KWbL2P2SkMkUTVq/jTjsU16X9xXBfWq5+vlcjnwsU+s5P488ToUsUmcebzS5Qwx3DhFPQuTNEuOT7tct8z1PB18jhDyZKqcngg8QQxq/BeW7CpENemCNnYfA+Ev3ocmMcwjj5X2P6pobsomrB5sLyNB93uxyo/FZiN1GrhJ8prQdy29qvxvp5rH9CPfX7RrnbUa17o5uWNcR49he1MF0wcs32U7hHM4Ey+cJ84rliRvmNycFS7fBVSvIVg1Kl0xs5orkvKbojYKORAAFliHYm1affyFhYxsHBcTSfl38q8e9cX+14Zd0AHPeutvBHISuw8SKb+BvKE+gTkYJdfzPgtXjdK/YaFFZhkehSWY88yVe5FvPzMYFz7FBkVba3mx1FZFKYpN3/dKmXedkNNg9sEUcZ4DoK0N55TAJhweUrM3UfQONoIGRetVXcnVIbxnf/8/S/Ij/umo4NUZ6wUbC1hGv6ZzA3CvaUu1erYj1wEJuLLBTWakh8xX0rcGWF3UKu67Ha+1ZfDH7+Gdh6UBt8k7eRODbvmDOVj3IxQ5gwj5659ZYnWLiz7n54V+kepeyrew3HT/2Q0g5FqK5rPBMsSwx/cUcJSEqtRel5qIRtgsoYxn/41KoHx5KvlhRB2yIe31DWtt66MGXZLZiSBkjGWeeyRqI0H1FJLc6YqMiHgMe/ylzWlBHgip4TRiPqYEg0pNXWQlFns6bfvdgM6u4tdHG6bAdm7eETKzjc7gdGvBO5gUeYomGgca+2E7D0wX7l1+BHSlslaxtEMHP1Ayq7oYdG9esQKgkP/UXIqJNi93XI4gbWfXS5lRPHJX8S9WHa/ILW9IgFzrL/SvC5xFhXZe2Il+HHIiBRO0+DzEynq1f+5B8ghpHpkYJMj5QxLDcmAGruGoKtgDnSuxeeo9hiw1IZmLjGkPe5jw4d2OsOrmybtbqDB0+tITYaY13PboUmHo C6fZY4Cm 4OFdhmhPZsTXDvucmOEeaON5yCRS/NcOnXAiK+hET2VbDPdCnBK23/ZQtFDvMT+BZ3fis9CWXStZ2/jPjAg0QNtS3tqSmGqbgqmFt2bQxyL42DqfCEx+kzNRlg5FnVU0Nh2VxcCqy6L8jdavVzO4fqCaHqH2m8MzyueNrD2tnJ30SMgsX94RuD4cYy/P3TJiz9uhWoAJ4UNR3ByNr1U54Irim9C9Ph+VW22hFHdFugD1RG2TIouY5BqcQ9ntonCr78xmTookB4+AE2t4Wxd96Xi8HGRmTbECGsYKQJvlYizviLW7FwvuGhsXlMv9kr5XznECpzezuj1nsNFEfslEwCWwv+/fvC1/CYoaqdMt2GXmjmyEXQKhImO/VKw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: memory-tier is only concerned when a numa node changes its memory state, because it then needs to re-create the demotion list. So stop using the memory notifier and use the new numa node notifer instead. Signed-off-by: Oscar Salvador Reviewed-by: Jonathan Cameron Reviewed-by: Harry Yoo Reviewed-by: Vlastimil Babka --- mm/memory-tiers.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c index fc14fe53e9b7..0382b6942b8b 100644 --- a/mm/memory-tiers.c +++ b/mm/memory-tiers.c @@ -872,25 +872,18 @@ static int __meminit memtier_hotplug_callback(struct notifier_block *self, unsigned long action, void *_arg) { struct memory_tier *memtier; - struct memory_notify *arg = _arg; - - /* - * Only update the node migration order when a node is - * changing status, like online->offline. - */ - if (arg->status_change_nid < 0) - return notifier_from_errno(0); + struct node_notify *nn = _arg; switch (action) { - case MEM_OFFLINE: + case NODE_REMOVED_LAST_MEMORY: mutex_lock(&memory_tier_lock); - if (clear_node_memory_tier(arg->status_change_nid)) + if (clear_node_memory_tier(nn->nid)) establish_demotion_targets(); mutex_unlock(&memory_tier_lock); break; - case MEM_ONLINE: + case NODE_ADDED_FIRST_MEMORY: mutex_lock(&memory_tier_lock); - memtier = set_node_memory_tier(arg->status_change_nid); + memtier = set_node_memory_tier(nn->nid); if (!IS_ERR(memtier)) establish_demotion_targets(); mutex_unlock(&memory_tier_lock); @@ -929,7 +922,7 @@ static int __init memory_tier_init(void) nodes_and(default_dram_nodes, node_states[N_MEMORY], node_states[N_CPU]); - hotplug_memory_notifier(memtier_hotplug_callback, MEMTIER_HOTPLUG_PRI); + hotplug_node_notifier(memtier_hotplug_callback, MEMTIER_HOTPLUG_PRI); return 0; } subsys_initcall(memory_tier_init); -- 2.49.0