From: SeongJae Park <sj@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: SeongJae Park <sj@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Andrew Morton <akpm@linux-foundation.org>,
Honggyu Kim <honggyu.kim@sk.com>,
linux-mm@kvack.org, mm-commits@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] Additional MM updates for 6.16-rc1
Date: Tue, 10 Jun 2025 10:32:28 -0700 [thread overview]
Message-ID: <20250610173228.49109-1-sj@kernel.org> (raw)
In-Reply-To: <CAHk-=wgXTJo5G7e1cQxetFLbqbTUfP7Nfzt7-C89FjUHo1J9cA@mail.gmail.com>
On Tue, 10 Jun 2025 10:27:46 -0700 Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Tue, 10 Jun 2025 at 09:41, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > Just revert the commit?
>
> Yes. We don't do "default y" for random features.
>
> EVERY SINGLE DEVELOPER thinks that *their* feature is so important
> that everybody else should enable it.
>
> And if that feature wasn't enabled before, they are completely wrong
> 99% of the time.
>
> There is a very real reason why 'default' defaults to 'n'.
>
> So we do *not* use "default y" for features that aren't universal.
>
> The only time we should use 'default y' is if some old feature that
> used to be unconditional gets split up into a new Kconfig variable and
> not using 'default y' means that people *lose* functionality.
>
> Or if the feature is some critical security thing, or is some hardware
> thing that has become so universal that you find it on basically every
> single machine.
>
> Or if that feature cures cancer or brings world peace.
>
> Then you can enable it by default.
>
> I have reverted that 'default y' thing, because I see no reason to
> believe that DAEMON cures cancer.
Makes sense, and thank you for explaining these all. I will keep thse in my
mind to avoid making same mistakes in future.
Thanks,
SJ
[...]
prev parent reply other threads:[~2025-06-10 17:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-01 22:12 [GIT PULL] Additional MM updates for 6.16-rc1 Andrew Morton
2025-06-02 15:05 ` Matthew Wilcox
2025-06-02 19:17 ` Andrew Morton
2025-06-02 19:20 ` Matthew Wilcox
2025-06-02 23:03 ` Linus Torvalds
2025-06-10 9:05 ` Geert Uytterhoeven
2025-06-10 15:54 ` Andrew Morton
2025-06-10 16:41 ` Geert Uytterhoeven
2025-06-10 17:04 ` SeongJae Park
2025-06-10 17:27 ` Linus Torvalds
2025-06-10 17:32 ` SeongJae Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250610173228.49109-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=honggyu.kim@sk.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mm-commits@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).