From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19818C61CE7 for ; Wed, 11 Jun 2025 10:23:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69B0C6B0088; Wed, 11 Jun 2025 06:23:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 64C1E6B0089; Wed, 11 Jun 2025 06:23:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53CBA6B008A; Wed, 11 Jun 2025 06:23:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 322426B0088 for ; Wed, 11 Jun 2025 06:23:39 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id ADF78BBB9E for ; Wed, 11 Jun 2025 10:23:38 +0000 (UTC) X-FDA: 83542733316.28.CBA04BD Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf14.hostedemail.com (Postfix) with ESMTP id B13AC100007 for ; Wed, 11 Jun 2025 10:23:36 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ESoBHF7Q; spf=pass (imf14.hostedemail.com: domain of tamird@gmail.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=tamird@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749637416; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=ouktr7NzISP8qHlPn0djqUJNZCl5UN30Gq1Q/RrQ/jc=; b=HSSETXHTU3al4fbKA1L+5W/gWNIPmkmde6CE/IB0UkoGN80EmjE/HuMhsMxdZwqkoT4qVc 2My7q95hwPNd6aotppl9yRNdBREP4hFLLq2poeZjXnVJpC+sXXbh7+WA2O4Yq6sQ2NEyJI FVWtWss9i8jdl3IneEb+XJnMd+XeOQk= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ESoBHF7Q; spf=pass (imf14.hostedemail.com: domain of tamird@gmail.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=tamird@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749637416; a=rsa-sha256; cv=none; b=n8huwvxP7U6hjB0T7eIaf6cIL2EUhcQrhsi3z3j7NTOQXXWenPm6I5SMPFiaD2pM2gwFxm DI8RZXj24pQ8ZyaCcRzDB3NB/e7F3M7ZNqPGuia60gaepMt/BM51lFYAKH3m6qblovQvtw lLsrufxy3/1S47kSBAaeEfLBNULWAFo= Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-4947635914aso63921461cf.3 for ; Wed, 11 Jun 2025 03:23:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749637416; x=1750242216; darn=kvack.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=ouktr7NzISP8qHlPn0djqUJNZCl5UN30Gq1Q/RrQ/jc=; b=ESoBHF7QuZHUOiOQHd//eE/UHfYbYIK/G36USLBKtWyXqiOWyB6nOp9O5evp0P0kND tD76NdBUSdFIQ7hlSlKcuDL2Qxtusj+DvOZZeDKL77ZGGvelzJez64hkmkOz+OgtxcTy kyjdKiEolDPvJdXXpocM/ZKWYLuUMYz2/Taar28x0sniJci46bBc659cPrQ7ONGa3r2I p9mjSOw+AAVK13cQOHMa2ibX85JTh4meKZW0kF3XGIjkq5GLwFWawgUWE7Lm413gYy2f mUUqhqDu5y7raSsc/u3PJsaAkKJ929tx+dpY88lkrIrQ4+IAH5nI13FpmPetj7rravI9 wy1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749637416; x=1750242216; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ouktr7NzISP8qHlPn0djqUJNZCl5UN30Gq1Q/RrQ/jc=; b=Iv0JYPLOfAbi+pxyIxU++U0Lyx30TwyWdgXcdBKNXDN3ZXVKIZ9FLguZhdsb/rGeGp KS06pci4boDzrhI6YRTVM7vwc23XKIUr5NRAj482wTtXuyCikk19geNcq4pk+ACHPa36 Tfi5L+vXmLAfr5NR0KZGsQ/HwUBKRWw4C8v+PIZ3RzHe+WaRPuDdyGEOCzWlf1yxj4Vt IA+yUIQry6xe5V8I3u9CvyUau65KwOvRMT52/+TTRx/p5ghFXLeILZfrCyqFGRiGvWgP gabx4TJsBmkhHw9daRYCxFfvKLWxI3Hzp3i9DhUUzN+cMytiBjI6Uujdku4n0RuZKAn2 mN0A== X-Forwarded-Encrypted: i=1; AJvYcCU4aH1v5ewsR4QKcVXbBg+gK7UAokO5DydoAPHjf9VBXEnaH7AU68yhJdngsm8P6guWh3P6MVj6iw==@kvack.org X-Gm-Message-State: AOJu0YyOvsqZByioNExqMt2iqvM9dIpnVuLYItcI4Ir0QwOAvTvCE9LS K4MvVSgt25Sjk6DAqQaK8itMxhGVk+2lIBSrkIrf5dmQFTw6pCA6rtAL X-Gm-Gg: ASbGncuHZuxeRkHZzYO8xXy3wDiAsqxbTlbzvIaJ4muFha50/d+DHNT9E+WPQr5hqg9 714s608d6SyWgynWcKvcSoibxANrOyiI2sJe1IVCCY9u6042zDIrDanpl06ae1ylxS+EQg/8fy+ fGAkOXcsDA3Pu2aTXN2evlMjFjxXx+dxIGcrIp9HmVGt27KGAVqpfX47vz1n4nYLuPT5WEkfvFE B25wmy3zhfOAEfuU8HatlGs0A0dBnqy4Sp9ZeXejjNkFo6GUryOloKBkoyfkm59kDGN1AZfCYG2 cPaqyT+LUJLR0l7ntQ/LzVZrN/Avs8fvDrkeLXEuIFJMixm2JUQzcjt/DM2GLiuGxMo= X-Google-Smtp-Source: AGHT+IHsvSPSRKL5BLyCiE7wrGxoztQqmqBzrCOW1KhgcOy5ZWe+lay1sWUZlMSeWRX1BrOpW7T/1A== X-Received: by 2002:a05:622a:2446:b0:4a6:f99d:9633 with SMTP id d75a77b69052e-4a713c30c5amr57226931cf.31.1749637415620; Wed, 11 Jun 2025 03:23:35 -0700 (PDT) Received: from 1.0.0.127.in-addr.arpa ([204.93.149.208]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a61114ff18sm85664341cf.6.2025.06.11.03.23.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 03:23:35 -0700 (PDT) From: Tamir Duberstein Subject: [PATCH v11 0/6] rust: reduce `as` casts, enable related lints Date: Wed, 11 Jun 2025 06:23:24 -0400 Message-Id: <20250611-ptr-as-ptr-v11-0-ce5b41c6e9c6@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIABxZSWgC/23SyU4DMQwG4FdBORMUO87GifdAHLK2I9GFmTICV X130oJEEjhFjvTZifWf2ZLnKS/s8e7M5rxOy3TY1wLg/o7Frd9vMp9SvWAoUAkpDD+eZu6X24E QwGpTIiViFRznXKaPW7fnl1pvp+V0mD9vzVe43v7bZgUOXFlMQiug6OzTZuen14d42LFrmxVb6 jqKXHBUSQufHGIwI5UNBeqorDSb4DUIsoX8SKmlqqNUacBkMAKliHqkqqX9X1WlKqiCUDxK8We qbij2D9aVkksQTEmETozUtLR/sKnUGh9IIZAJbqT2l9KwYVupNNIKDUpSLiN1DQXdUVcp2BzRh ZqUIkcKorW2z4S4zk1aJjROGN8t6vIdtjm/vdfEnn4Sd7l8AZwWx6LPAgAA X-Change-ID: 20250307-ptr-as-ptr-21b1867fc4d4 To: Masahiro Yamada , Nathan Chancellor , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Bjorn Helgaas , Luis Chamberlain , Russ Weight , Rob Herring , Saravana Kannan , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , FUJITA Tomonori , Nicolas Schier , Frederic Weisbecker , Lyude Paul , Thomas Gleixner , Anna-Maria Behnsen , Benno Lossin , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , John Stultz , Stephen Boyd , Lorenzo Stoakes , "Liam R. Howlett" , Nicolas Schier Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-pci@vger.kernel.org, linux-block@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-mm@kvack.org, Tamir Duberstein , Benno Lossin X-Mailer: b4 0.15-dev X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B13AC100007 X-Stat-Signature: eudwtrzq4h1ra1ira9ajegntbc8fb5cr X-Rspam-User: X-HE-Tag: 1749637416-831422 X-HE-Meta: U2FsdGVkX1/syYLUtOPMUWtnVObOwxB0mzD5mVRildVqZXIox/gIGyn7HCh7tIQgSN/U5v+M8ES5VlFnouxxtesmoQvOR1evgjy15hbVcTUePY9XcHHMKRwKk1SdO6RnM+dKO0ixr0hcwC+ToiwVG2O54HonNWppIHhBb+nDeioW+4p3RCWZBKhDDzFg0dj1z4Ap5/kLJyCEARlnCICPfcftUrd1HMpBW8QcBACAXyWk/9MOubAaATrZItQdvTYSXdECMaIqt8K0yGheAXGNRI6HMwOn2IHsdvgKMrVIQHT5XthLTp+aCkOwtvRJYjEqMcHZLl6CNj2/6wqnQEuU6YYzWlANcgt9ULMxcylOq7HXeY02UMTj/uxy/fac5bWU0XASSN5B9yS9CEo/WlnUigOkbc+tqZUIJwKAHdn3sfPY2qjmTDmmvQSH2Ruqgc8uPNHxn0qMBAAb64eIcqr4Cir83o5dOiwsB0YGTaP1fLrerq9hv2inF2/RgNBHSDqEo3ow3Q340+ROHAXxoLtGsgEnyitIVJjKKo7zL5t/8cci6McFVaOBP0Je53nYHNrLvYIsmV/uEpURhheqMY7rXrzYfODD8VSx9PzGUmD+ZsjoZI3qeXWgtydVEZLvdK/KEctP6Y8wea4RHoh1xHNf0uf7kfKuCHcd4xPP/L1SaI8o6z+VW6Tau7caASoBqwcjD/r2C5yjj0CbPLX5QQqdfg4RPpItVtUIOFOaQldtQs5QkxxE2YdjBctse5CrxoJIImopbmtWUZDWmg9zM2rJvVZJl8vkOONKClKTqLb/rQ8ZAndsEeZvjoJzz0OS8Mk6q5g82lb3zHEkQgWF2gW4b3dXYv1Jwb74kjiRTOPhRYDmzUQHAUXiq01eqEqvPqyp9IpTBCxCHHaxHBSwMUlpzcUXTpXgT1KIis9+gU6iFDWuoAM7S69AwFW7XyFFSMYj4JkS+Dq+FzBlD+DavJN LUSQCe/H wh8SGHJJLeKMqJ4AuGozRJJXByh5rJ+gfItKAvvZmurS5aA7PECYfDVLcvtt151t6/IWYf/9vM4Bvs5kT6LA26wrb7IvcZYvATmEqOlBghiw3xnAOwLYLua6EHTMIMwGP1EnZbCfBbkNOvsJYaHIIxR7+hB1/GDivzWzP6aFfZj3qlq9WtPW1qC3qYRBYgxq/6gpMxT9zj4NTsYambvJwNTMtcaT018AEzsK94+3pydyk39iBb7PQZEIaySof6YGaeESwUBa/5fxKKiohLSqE3UIrtgZZIxLXE9fbSp911aQLaJ0SvCC34y3qTvCieQ/03N8r7Z7sDXBfKaUURO5y7fcO26zbbFdGn6IlihMiOnHU73ae30481t9jv3kgWNEAE0vH9ipMLU8ac5msAqU0/TlCLpgX0SDi3Y5KDDwwUyag4f2EPxr3PbKly9ATCf70Fn5K0hppGm94AIkHCaOLCZ90p+49efbqvsnVHk1/OfJjWXixBEb1ZYDp9TKKElvqZTmt4RJt6Lx4osuXDrsQl1oRnQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This started with a patch that enabled `clippy::ptr_as_ptr`. Benno Lossin suggested I also look into `clippy::ptr_cast_constness` and I discovered `clippy::as_ptr_cast_mut`. This series now enables all 3 lints. It also enables `clippy::as_underscore` which ensures other pointer casts weren't missed. As a later addition, `clippy::cast_lossless` and `clippy::ref_as_ptr` are also enabled. This series depends on "rust: retain pointer mut-ness in `container_of!`"[1]. Link: https://lore.kernel.org/all/20250409-container-of-mutness-v1-1-64f472b94534@gmail.com/ [1] Signed-off-by: Tamir Duberstein --- Changes in v11: - Rebase on v6.16-rc1. - Replace some `as ` with `as bindings::T` and others with `as ffi::T`. (Miguel Ojeda) - Revert explicit `ffi::c_void` import which is in the prelude. (Miguel Ojeda) - Link to v10: https://lore.kernel.org/r/20250418-ptr-as-ptr-v10-0-3d63d27907aa@gmail.com Changes in v10: - Move fragment from "rust: enable `clippy::ptr_cast_constness` lint" to "rust: enable `clippy::ptr_as_ptr` lint". (Boqun Feng) - Replace `(...).into()` with `T::from(...)` where the destination type isn't obvious in "rust: enable `clippy::cast_lossless` lint". (Boqun Feng) - Link to v9: https://lore.kernel.org/r/20250416-ptr-as-ptr-v9-0-18ec29b1b1f3@gmail.com Changes in v9: - Replace ref-to-ptr coercion using `let` bindings with `core::ptr::from_{ref,mut}`. (Boqun Feng). - Link to v8: https://lore.kernel.org/r/20250409-ptr-as-ptr-v8-0-3738061534ef@gmail.com Changes in v8: - Use coercion to go ref -> ptr. - rustfmt. - Rebase on v6.15-rc1. - Extract first commit to its own series as it is shared with other series. - Link to v7: https://lore.kernel.org/r/20250325-ptr-as-ptr-v7-0-87ab452147b9@gmail.com Changes in v7: - Add patch to enable `clippy::ref_as_ptr`. - Link to v6: https://lore.kernel.org/r/20250324-ptr-as-ptr-v6-0-49d1b7fd4290@gmail.com Changes in v6: - Drop strict provenance patch. - Fix URLs in doc comments. - Add patch to enable `clippy::cast_lossless`. - Rebase on rust-next. - Link to v5: https://lore.kernel.org/r/20250317-ptr-as-ptr-v5-0-5b5f21fa230a@gmail.com Changes in v5: - Use `pointer::addr` in OF. (Boqun Feng) - Add documentation on stubs. (Benno Lossin) - Mark stubs `#[inline]`. - Pick up Alice's RB on a shared commit from https://lore.kernel.org/all/Z9f-3Aj3_FWBZRrm@google.com/. - Link to v4: https://lore.kernel.org/r/20250315-ptr-as-ptr-v4-0-b2d72c14dc26@gmail.com Changes in v4: - Add missing SoB. (Benno Lossin) - Use `without_provenance_mut` in alloc. (Boqun Feng) - Limit strict provenance lints to the `kernel` crate to avoid complex logic in the build system. This can be revisited on MSRV >= 1.84.0. - Rebase on rust-next. - Link to v3: https://lore.kernel.org/r/20250314-ptr-as-ptr-v3-0-e7ba61048f4a@gmail.com Changes in v3: - Fixed clippy warning in rust/kernel/firmware.rs. (kernel test robot) Link: https://lore.kernel.org/all/202503120332.YTCpFEvv-lkp@intel.com/ - s/as u64/as bindings::phys_addr_t/g. (Benno Lossin) - Use strict provenance APIs and enable lints. (Benno Lossin) - Link to v2: https://lore.kernel.org/r/20250309-ptr-as-ptr-v2-0-25d60ad922b7@gmail.com Changes in v2: - Fixed typo in first commit message. - Added additional patches, converted to series. - Link to v1: https://lore.kernel.org/r/20250307-ptr-as-ptr-v1-1-582d06514c98@gmail.com --- Tamir Duberstein (6): rust: enable `clippy::ptr_as_ptr` lint rust: enable `clippy::ptr_cast_constness` lint rust: enable `clippy::as_ptr_cast_mut` lint rust: enable `clippy::as_underscore` lint rust: enable `clippy::cast_lossless` lint rust: enable `clippy::ref_as_ptr` lint Makefile | 6 ++++ drivers/gpu/drm/drm_panic_qr.rs | 4 +-- rust/bindings/lib.rs | 3 ++ rust/kernel/alloc/allocator_test.rs | 2 +- rust/kernel/alloc/kvec.rs | 4 +-- rust/kernel/block/mq/operations.rs | 2 +- rust/kernel/block/mq/request.rs | 11 +++++-- rust/kernel/device.rs | 4 +-- rust/kernel/device_id.rs | 4 +-- rust/kernel/devres.rs | 17 +++++------ rust/kernel/dma.rs | 6 ++-- rust/kernel/drm/device.rs | 6 ++-- rust/kernel/error.rs | 2 +- rust/kernel/firmware.rs | 3 +- rust/kernel/fs/file.rs | 2 +- rust/kernel/io.rs | 18 ++++++------ rust/kernel/kunit.rs | 11 ++++--- rust/kernel/list/impl_list_item_mod.rs | 2 +- rust/kernel/miscdevice.rs | 2 +- rust/kernel/mm/virt.rs | 52 +++++++++++++++++----------------- rust/kernel/net/phy.rs | 4 +-- rust/kernel/of.rs | 6 ++-- rust/kernel/pci.rs | 11 ++++--- rust/kernel/platform.rs | 4 ++- rust/kernel/print.rs | 6 ++-- rust/kernel/seq_file.rs | 2 +- rust/kernel/str.rs | 14 ++++----- rust/kernel/sync/poll.rs | 2 +- rust/kernel/time/hrtimer/pin.rs | 2 +- rust/kernel/time/hrtimer/pin_mut.rs | 2 +- rust/kernel/uaccess.rs | 4 +-- rust/kernel/workqueue.rs | 8 +++--- rust/uapi/lib.rs | 3 ++ 33 files changed, 128 insertions(+), 101 deletions(-) --- base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494 change-id: 20250307-ptr-as-ptr-21b1867fc4d4 Best regards, -- Tamir Duberstein