From: Wei Yang <richard.weiyang@gmail.com>
To: Liam.Howlett@oracle.com, akpm@linux-foundation.org, willy@infradead.org
Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org,
Wei Yang <richard.weiyang@gmail.com>
Subject: [Patch v3 0/3] maple_tree: Fix the replacement of a root leaf node
Date: Wed, 11 Jun 2025 01:12:50 +0000 [thread overview]
Message-ID: <20250611011253.19515-1-richard.weiyang@gmail.com> (raw)
On destroy we should set each node dead. But current
code miss this when the maple tree has only the root node.
The reason is mt_destroy_walk() leverage mte_destroy_descend() to set
node dead, but this is skipped since the only root node is a leaf.
Patch 1 fixes this.
When adding a test case, I found we always get the new value even we leave the
old root node not dead. It turns out we always re-walk the tree in mas_walk().
It looks like a typo on the status check of mas_walk().
Patch 2 fixes this.
Patch 3 add a test case to assert retrieving new value when overwriting the
whole range to a tree with only root node.
V3 rebase on latest mm-unstable with base commit eba4438e2296.
Wei Yang (3):
maple_tree: Fix mt_destroy_walk() on root leaf node
maple_tree: restart walk on correct status
maple_tree: assert retrieving new value on a tree containing just a
leaf node
lib/maple_tree.c | 3 ++-
tools/testing/radix-tree/maple.c | 24 ++++++++++++++++++++++++
2 files changed, 26 insertions(+), 1 deletion(-)
--
2.34.1
next reply other threads:[~2025-06-11 1:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 1:12 Wei Yang [this message]
2025-06-11 1:12 ` [Patch v3 1/3] maple_tree: Fix mt_destroy_walk() on root leaf node Wei Yang
2025-06-11 1:12 ` [Patch v3 2/3] maple_tree: restart walk on correct status Wei Yang
2025-06-11 1:12 ` [Patch v3 3/3] maple_tree: assert retrieving new value on a tree containing just a leaf node Wei Yang
2025-06-11 1:37 ` [Patch v3 0/3] maple_tree: Fix the replacement of a root " Andrew Morton
2025-06-11 2:54 ` Wei Yang
2025-06-11 3:55 ` Andrew Morton
2025-06-11 6:15 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250611011253.19515-1-richard.weiyang@gmail.com \
--to=richard.weiyang@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).