From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE079C677C4 for ; Wed, 11 Jun 2025 01:13:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E78E36B007B; Tue, 10 Jun 2025 21:13:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E29D46B0088; Tue, 10 Jun 2025 21:13:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3F516B0089; Tue, 10 Jun 2025 21:13:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B4D756B007B for ; Tue, 10 Jun 2025 21:13:00 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B712F1A1570 for ; Wed, 11 Jun 2025 01:12:59 +0000 (UTC) X-FDA: 83541345678.27.2ECC8F5 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf10.hostedemail.com (Postfix) with ESMTP id E6EDDC0006 for ; Wed, 11 Jun 2025 01:12:57 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Mn9QvUF2; spf=pass (imf10.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749604378; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references:dkim-signature; bh=WbnbKAGcQHhMvneJdg+PKwdS3cbj5rQklHr+9CtRx9g=; b=4s36o3Q2J5mube0Dd/9fNhTeCK/8LH/p77/2uVAVDcaDSv08ItgUS1eWacnpCEw+DpPKEj X4Bbi+01RfpJlocaXt9hDmZ7zUKXQsQS0nN/q1PNTHMH3rRoSKb87yyRyJxpTaACA/vlPR uZBfyGqPxV6aXbugbjlv9l6+iPZqZGg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749604378; a=rsa-sha256; cv=none; b=uSPuwSYPlPpKinvqeu+riIQTxU04KLzm6x2+aPM3crTwXcgZ/vOjv6wD66fzy6PiLQEMJL 8vtGaEu6SOXAro9jJtkt/XqcDN6INI8NXDnhrYOj7uSq69aqA9sBWbrvNqEv/NiK2rMWHr Z5DAE7lAjA+2yiteZ0Wsx17Y3g/P4I8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Mn9QvUF2; spf=pass (imf10.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-6071ac9dc3eso9225229a12.1 for ; Tue, 10 Jun 2025 18:12:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749604376; x=1750209176; darn=kvack.org; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WbnbKAGcQHhMvneJdg+PKwdS3cbj5rQklHr+9CtRx9g=; b=Mn9QvUF239mHwNWdRpuVJO+4xupBCEfMcJLUS9cOrz/sjC+v7qb4xeavQMPqXwnQwL TyOPsPTvDbCqEsmgcG+AAA5sq+XwcP6fXyTfuqpWWyx8iVkagXn4IiNEaOhsTAwGYLGd CKPwpIdNL+eiAtfvFNRMYEA2ykmPcs+2Fsnt52VGhnQuccX8f6G4faOC/5Pr0f3tUL+h PsX87/mRCNgsaMkXUugaz7XjxiVSsK7NrUWlDRfY3oTcjDXEFh9DBHdf9zupbKN+VMQj kTWfPuZG+nd97vC/vcjSS7ls+DYkGgNAHarDQ1jirfHNRJh3dLZ/51iNyIeS1sQElcdS /SkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749604376; x=1750209176; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WbnbKAGcQHhMvneJdg+PKwdS3cbj5rQklHr+9CtRx9g=; b=pDC0il1FbuNOKGzL1IFTOGMRBXzN1Uyjm2pz3qfwyR3Pa3MGR5Sqci2fV7QL4qGLs0 /QHtQjjumBRz/+t6nnM85RQHv+8rjANfSBsbX4vaX86BmHGqaTilvSDcbjxjvsDOTpil MXMBvcOTA9oXrHoCvg1LEUIMpsgXZYabgEeJ570zzKUy4lYT/BEdlSgEzl95p/5alDtW RrJ4MLe2eCl+cUMb7nCy1M9fpZiAyvy15IoWjwqXa3aicgppQgbNe8DZ0kJ4yHid/p73 pO7X0Hk5+hMN7TRByOwP3e/L/CbOm4YDfFr5k8PxPw3Obes7W9waOHOHSMvSjkLkTEEP igIA== X-Forwarded-Encrypted: i=1; AJvYcCVrfN+28POTFpfjIcI2z80zNhQpNclKAZI11V3WOefNqny34XjbLw9SZOdm16mReUFgMqzqFj3kLA==@kvack.org X-Gm-Message-State: AOJu0YzhxL7rilDJl0NAPfh1Lx9zKqOROZ22Qz35bnew2z8QtNwj9Ef+ lfO3R/FhiDpWb35ehkLCa+BUA+6h3sdKFM1vr3dDOJ+0Q3FUy7c3Jfj/ X-Gm-Gg: ASbGnctiyykGpFKhdScewOXW/iVuy6Hy0VWTRAtNt4OrP3Fxl2KzTO5jo0Ei84gQslt ppqR21fKg/MaoRruwY55YKCh1dCZadaKFEiDAGJ4eHvQijplhobdRekxvp3WQ7D9xx59dOFrpLg b/pALqiuhbNYjZB8/c1EcJAMAXg4gBBaUtU5jrgCFgXw03mXO/349M/XiDTiJXdNfD6NompSKt2 arp+YAlAQVdxyOJoLp2J0d4DpHQFjWubRfWbpslwPLcCEqdUtEezP/0UOCYIoijlkc6G5sxlk2k E6ZF+CoG5X68Bt7NZVjvA0R9hTjn37LUNXV2NG5DtzJ+lfApUFJIAB9CS9mmHw== X-Google-Smtp-Source: AGHT+IFS4X/tc2Kr/KXp7VRy3kkkQUsqUfR3z6B7Uh3fimwjDhcoIK4hpIWIJaLrUTh82/FGZHqknQ== X-Received: by 2002:a17:907:60d0:b0:ada:abf7:d0e1 with SMTP id a640c23a62f3a-ade8c8d9dfdmr76004866b.37.1749604375816; Tue, 10 Jun 2025 18:12:55 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ade1db55a80sm802565066b.42.2025.06.10.18.12.55 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Jun 2025 18:12:55 -0700 (PDT) From: Wei Yang To: Liam.Howlett@oracle.com, akpm@linux-foundation.org, willy@infradead.org Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org, Wei Yang Subject: [Patch v3 0/3] maple_tree: Fix the replacement of a root leaf node Date: Wed, 11 Jun 2025 01:12:50 +0000 Message-Id: <20250611011253.19515-1-richard.weiyang@gmail.com> X-Mailer: git-send-email 2.11.0 X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E6EDDC0006 X-Stat-Signature: fz9sydt7wbo663he85hg3e59xrkg3o1h X-HE-Tag: 1749604377-440149 X-HE-Meta: U2FsdGVkX1/EC3PYIKcw11ORDdh3RjfrKiIQtd3JV7gZ3iRS/Qgko+681mTl1Y/Q2NMOGBtV/SGyjSzLR8wxR8IpyODk58LNCYgbc3MD3V2BQlfvkZbl+n/GGW57TTBM7R+RJ/mTAGzeJKIV301jqbP5JgyYDhY7hoh/ieqFOrD9HVtPVCBua6aV4FAc+3EOBgKamiL2WZSG3BayApj4i1nDRlCfKmcXLdxOYeNM/AlUXFiSwZ03IKdThQclEbhuc+fZTzqCsYy9pQ+pvORuCCTMibuYuYoGyBj9UpIMMaA2JRwivgGMqFL27J+dlujHyee0RGMjMA1chiTopA545QEH8km7SHKySUncFHF/BIz6CgKymQqsvc2+4UEvR0Jc+lF+HJTYolpG2Rn2NSRaI0cNX3Gb/xzhGxBR2URLtm3a14OeLLj52ED1ZESLgiDoYwBtvjtLRi2h8lpWUps6EAR9bra6vxOxsqNymvv8uMSFEZfs/uOY/f6l8UPosS4CBDrIlxWzAxERd8C2Jo2pJnvDqBII5Lxpj1g1quZF0aFdBFsi0xjneho0mqnhHOh6ZS44NMQt72Nr0y4GyAtXkxv5SEd0pmsiDXuQVoeEpHANDQv4QHIEuXEvkxoBqvNkd33HQLqIDZquQWkG+9d3R879cAlvY/vZcboMTC8YjgFJFjoC3HJhY9zOQe06NyFNUCjZlBqoU5zo14gh0XjIdl/lkS0z3BPfFpJ3jGlPCkV3G7tkbed166vniyvn1Mi4vKM5rW6CLR2LDZm5bRDhOlXbae61BLscnKvxJaCzFN4V/r8UhdQ24Zp0C+oMZLNTIWpyBBjgcfSz95dGLs8iTWbJ6UhvoS1ERA/z2AwoutyBLPh0DbEPiFxUFS1/EBeOHKaoU8krQENghfNVoFLoZ1jEhlsBLGPJZ2xHjS5rzNHo0GOc/Et8eU+9V86DlptwFSInArlWgkPyOv5Gkm/ WMkuu5qS zvy7vgCtejq39nPYRDmyLvCaF79o9yhjn+htVFmvjWJTDyZHtIvH7Rq79cvytd46ocMOZSxdQLN1/LnWdNZHHQnsToYaDkAzf8kIKBCF5+fh5MIv/qVCc9heSfBbyuoFavALrr1mu/c7j9mxkxPq3KvfX+faPPGsx/QbWiP6XcyYKIyJZlu2l341qOdAnkCqTp4w45NpHbwuhnnxuTLFIO4BekJFEdDpw9jx9yzSqhrXrAdUKwpQNVLWz+5G75FzHzj1PXzJ7qFT3qv9ZxG65Xz0FkdsvFVVQEQt7BrrEjs1UHTLhgd0/gWdOB6wR1GOGKIAnNV7wZ+gCGzJbwH32Zx47/0wC3gXh2/mryBZA/fVVSijnGd7ZL7ZyImNsDbiPo6Ul3Dgtm4k6rghZqCCtDeRJQMY/+LmnayqpzVLWEyJIuyd87RsgM1Nz8lkPp7VJRQphw0OkU6fzjpa9dvqIqxNKAvXUsraIbY+hdQBoc6acA378IofsdiQky7T3yUZIcKxK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On destroy we should set each node dead. But current code miss this when the maple tree has only the root node. The reason is mt_destroy_walk() leverage mte_destroy_descend() to set node dead, but this is skipped since the only root node is a leaf. Patch 1 fixes this. When adding a test case, I found we always get the new value even we leave the old root node not dead. It turns out we always re-walk the tree in mas_walk(). It looks like a typo on the status check of mas_walk(). Patch 2 fixes this. Patch 3 add a test case to assert retrieving new value when overwriting the whole range to a tree with only root node. V3 rebase on latest mm-unstable with base commit eba4438e2296. Wei Yang (3): maple_tree: Fix mt_destroy_walk() on root leaf node maple_tree: restart walk on correct status maple_tree: assert retrieving new value on a tree containing just a leaf node lib/maple_tree.c | 3 ++- tools/testing/radix-tree/maple.c | 24 ++++++++++++++++++++++++ 2 files changed, 26 insertions(+), 1 deletion(-) -- 2.34.1