From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7AEEC61DB2 for ; Wed, 11 Jun 2025 01:13:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8ED26B0088; Tue, 10 Jun 2025 21:13:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3FBE6B0089; Tue, 10 Jun 2025 21:13:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C54BA6B008C; Tue, 10 Jun 2025 21:13:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A80C16B0088 for ; Tue, 10 Jun 2025 21:13:01 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5722A101628 for ; Wed, 11 Jun 2025 01:13:01 +0000 (UTC) X-FDA: 83541345762.21.CB5EB33 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf02.hostedemail.com (Postfix) with ESMTP id 884C08000A for ; Wed, 11 Jun 2025 01:12:59 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GfXyEzk1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749604379; a=rsa-sha256; cv=none; b=7Fk7VSu3hqmgJAmPbWDvEWspVLAwFCvokDMFhH8eAZIS6exnmu5dU2b2RVkZTL6ULMWpyh DPX8nUimSEzpk/SrFp0RpG/MVByiH5204lNJOnw802OGSHKVztaKo3oOUQvspBGNU4wtm9 1xGlHRlzispoAqZHcJxSMSyZnWlCX4A= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GfXyEzk1; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749604379; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=iRJ6O+s3XABPlTWV3eN6DId9Ma2DDx185T/aGv+NQxk=; b=LRRhmRDiD4Io2bD1Q9SO2Lr5CDHKrzrr+pakstSXM3Cmd7QJb+0MzrQkumD8r9Cwp0eH3R y+R8LSwMtfE+G5yeMdHBMj/2MdB8a23n/pYjGZ1VXDSFwFwoHWPyX1mhlEVZWWXWZflIp8 /VwegrG/SFMd5/6FIvqaGZ850uv96mE= Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-601dfef6a8dso10658566a12.1 for ; Tue, 10 Jun 2025 18:12:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749604378; x=1750209178; darn=kvack.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=iRJ6O+s3XABPlTWV3eN6DId9Ma2DDx185T/aGv+NQxk=; b=GfXyEzk1mwoCXNTDWwUvmIlpFZkgIGS+iXDe8fRKJq5wGXMGpVVXicydB6DqKsTYZB DdsUtED1QVTYt8SaKs3yiQ8z1XjB7jhcIh/iLvn85qmaG4EF6RKSMPk2lYW3o3VR6tWt idAilmD5+pFLEVqYFnN6je+PIetkuERA6bqNC/fwaHUiEZUn1K0zXGjvT8e3X2HzhA72 yH/XD/ORATB6Cx7P3kNgwdb7b2Duvg9QyRxxvwyUaLxOoNjQmLx7iLLaXRLdUgYO5VFi nWMkmXLyCzilsq45TD8/j5Gk1QyyfZCwX7eNp3gJoHR4GKmKKebuCy7IviZABVsXBnhL BYDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749604378; x=1750209178; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iRJ6O+s3XABPlTWV3eN6DId9Ma2DDx185T/aGv+NQxk=; b=pvdFCZidtLYiarp72ZUlguAAUFo6mitl1sSAqEsjq9eK1fHzhQ8NZ9xNI4CXkqFAak 5tyfIEkaehK0TKCgdNOK+m5vwErU/mQz83OStYUMAaVVtp+dcVY2drcGLhUebONfvJi3 tFFF5/CVSkw6hj/911PuDJ+YXFvs3P5DQbmBn1V7a2QRUNfBldjUuKpbctrda0vTLaDe obBYPEYX+aPJbT0PBbJRJ/5psJfFjzOD5jqFDJ6V/rqGZ6tu+3xxQxcbp+SKba/3T3og ETZi2hjbRLOvww2cIxFhBtl27xHgNF6uMPxHlf1++aSIRfAgO3lauWzd5+c0BiGtLtTV WdPw== X-Forwarded-Encrypted: i=1; AJvYcCWRIug6f1um9ovE+7VEFPY+H05f+OZiBdZNNhar6q01JboFRqA8wJyuRe1pnO5LB8kVUmAOKkYZ2Q==@kvack.org X-Gm-Message-State: AOJu0YxBE8kmWpRnDNnrq1lVxhn9xEaf++GR4K449uRdSrOh9/s0galn QWp/+KYtrGnh8ZAqxjGpX8xSCNGdwcXqoFoFDuJNNS+8fkgERz6ENaxz X-Gm-Gg: ASbGncu2XbbqclmIcqVnK/WOkfPcvvQZDGJwb6hNSUmE3zdNV72AfRhjxUne4DyFCSs R9S9MoIpjfF9qpUAfTlmwPh0P84MfpvwdzOmO+Sia03WWjJEBeIQ45DiBKwVcULl3yK4gQDOxyj S2AaJdGuxSwGxM/h2qcGZmG3jROM+rf73/lOP5FucMEeEUfNtY51W94vgtFatfi8fSz41vglUPK 6nqzIouk63aQA6ZFwwb0qbXKmbuQkzSd+Ru2k/QInFSGL5q96nd9q3vgeyKyYtG5Vt2XmHCl3b5 5/tx7pe/XDs7Em89Q75IziHs/t0fFb7b4EmpJkhFLcXdZbBYVyaST9Yj801MVQ== X-Google-Smtp-Source: AGHT+IEYbL/caU1BJpVVJ1puQQCXnkuwbG4wlacVSfVfmhF3K+TSkyvjMUgCDcScAVdWcl/uWLu60Q== X-Received: by 2002:a05:6402:5194:b0:601:31e6:698d with SMTP id 4fb4d7f45d1cf-60846cdb725mr1004872a12.23.1749604377903; Tue, 10 Jun 2025 18:12:57 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6077837756esm6824352a12.17.2025.06.10.18.12.56 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Jun 2025 18:12:56 -0700 (PDT) From: Wei Yang To: Liam.Howlett@oracle.com, akpm@linux-foundation.org, willy@infradead.org Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org, Wei Yang , "Liam R . Howlett" , stable@vger.kernel.org Subject: [Patch v3 1/3] maple_tree: Fix mt_destroy_walk() on root leaf node Date: Wed, 11 Jun 2025 01:12:51 +0000 Message-Id: <20250611011253.19515-2-richard.weiyang@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20250611011253.19515-1-richard.weiyang@gmail.com> References: <20250611011253.19515-1-richard.weiyang@gmail.com> X-Rspamd-Server: rspam01 X-Stat-Signature: 88efz7mh8m8gy9cyrxena8jxfqtrozb1 X-Rspamd-Queue-Id: 884C08000A X-Rspam-User: X-HE-Tag: 1749604379-273247 X-HE-Meta: U2FsdGVkX18rynEYqXdpRWL9lR6j4l+zywyCorI50tZvRQJK9Wz6w8jCoLpfUI+4RGSC9cfOQOKVGR0hLd/BiBkHWccxNf653yCl5YoQmMhM+m4ML9fSymya872V+XLJz/SXAXzDgNw5gJCNzuN9lIju+rtxXOT1s4evCcaPKZagiJwBF+vOzof8pu66b4XWmOwrV00kP1SYwxQP+ZLEwEkLn9tR4BeX3fZiax/iTYFnfgQllswy2Pyqh/DZ8D4vTiUzn22sjJRKLqpX0GlejZbXvTTxQUb0unqud8J8VoNbd+kCwvDOnBx3hY/sk7vVenCJKh7iw0oYJ13c+WJHqpOZXe75ahFm5WoYOvqRv4XAhseMciATN0n6TmMkt5dGAR6lsiknVI326NsBSxglGysSYr1RLM5uBgLSgirIbgnMN1k780eaH9btHb7b2lfA7oY9MfULv4sABX0FY3tZm5pFECaUcHB4iP1OkAn8XnfGdEsGrjp+eaETWAj0yjQCTeYjbkFA5vE48eh9iP6fm5xNUFS+1zToKsSCcUMdJ+4GExJmwl5CAx/6vZyfsF/x8ka3S5zrKTzyIybPwWEePJnNk6dcWZ0BzVRU+mU/F5kvBtGXkhBJR4tyzXiHpzdcZs68H9CyvGAQxIsza8YAxlGyC6CV1CjuBgsjpj2AXXJ7ruGOrreLe2uCbb3bmh2LPi0qmKXhcTEKHI6q7rKxgzU7tCDq0Dj4w6QtJeRg43ESqfcYj5rnTs9ftrWEGG3c2ySMQGXFNZ0ZJvGv4rzAtdpFJyFGiZ2oX4wikijwtxiU555MH8Lg7/sRjavPDY/5lCP0zffbLz6B9/NlvitC85siE30VuPuoz/bNDDCP7mtPlHdLEQJc4mr+psyiEnEqTR0BtXhbNKNNtp5IdtvaBslLzUX88QqvcSL/WZhPWSF85mtt34gkpJP5f8SMaBgbsnXu6S+zh85g/8KmJe4 JM7K3F9n l8Z7VKposVcVz59VtBynP43NCfkLOsvx5ImJxofgzZ8MRYlCeCqwl8c8JGnTXY0/BKnEzBMrkGm86OYxcXOMaiEbAfFiFNY9IaOOFk+4wTpymkXXaqr0UWtid2OiLZM0HMyS0AO8JSMy9GHDcQdY/U2+tukpDEmHfBLvProIKkb0QexGgov6uzvZYQVq75iuX5/vRDNh6TN21MWuzMr/RsfL1XJ4r0bGCtdPAQ7CGkH91B6a08DQciiMZuoKawWNACF36Vbqz9pgwqtAwKwPP4TBb+zRo4dkQQXJfrNCJsHF4UugGrX4tWBftzQQiO573iGMM66+3slcLW1nMGIyNKHeUiXb93ScZAev1bpH5lUJE1fFFLj62J8u2O3a0BRglBRB00L7gLgY6eGFlfRlpzVEpz1folA/aWTENmANZy0AVvZKmzlWQ+USRa20h5Yzvf5kXjfQGAIWX/8KSTdAvJp8YnFOAMFw0nNHOKekeJO2/u9bfd1whxt5KCAk+hc7w/RhH7l4vgtLBul0GeCwVzI/Vw68OWJtuiWEhJwUgIIqbSeGb9oTImd1YBFgGiEEAi0YdnM76RpqVPuM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On destroy, we should set each node dead. But current code miss this when the maple tree has only the root node. The reason is mt_destroy_walk() leverage mte_destroy_descend() to set node dead, but this is skipped since the only root node is a leaf. Fixes this by setting the node dead if it is a leaf. Fixes: 54a611b60590 ("Maple Tree: add new data structure") Signed-off-by: Wei Yang Cc: Liam R. Howlett Cc: Reviewed-by: Liam R. Howlett --- v2: * move the operation into mt_destroy_walk() * adjust the title accordingly --- lib/maple_tree.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/maple_tree.c b/lib/maple_tree.c index affe979bd14d..b0c345b6e646 100644 --- a/lib/maple_tree.c +++ b/lib/maple_tree.c @@ -5319,6 +5319,7 @@ static void mt_destroy_walk(struct maple_enode *enode, struct maple_tree *mt, struct maple_enode *start; if (mte_is_leaf(enode)) { + mte_set_node_dead(enode); node->type = mte_node_type(enode); goto free_leaf; } -- 2.34.1