From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED92AC677C4 for ; Wed, 11 Jun 2025 01:13:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CFB36B0092; Tue, 10 Jun 2025 21:13:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17FDC6B0093; Tue, 10 Jun 2025 21:13:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BE4F6B0095; Tue, 10 Jun 2025 21:13:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DEC586B0092 for ; Tue, 10 Jun 2025 21:13:03 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 591FE81457 for ; Wed, 11 Jun 2025 01:13:03 +0000 (UTC) X-FDA: 83541345846.25.6145FF9 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf16.hostedemail.com (Postfix) with ESMTP id 79EE2180007 for ; Wed, 11 Jun 2025 01:13:01 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mimSu79X; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749604381; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=T7BzYZ0HwQMO8On28SrUYjxN4nxQyJ0i5gaZcr6fbYg=; b=QzawmBa5yGND8KfVdy86ia8TEmzOrWaVF+2EmMrs9biKRfvtOAd6r/ZGKJmadGwoV2M65J ufD07kgPzxtPo69uKNQZft7WUJojcPRnT7wd6/4OeFZSOhGyeQEsc2XXG3codYd8aE3ZmX tob1OjueeCpD2ZafSoUhuIdj/50v7X8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749604381; a=rsa-sha256; cv=none; b=0N38qIQsVj1iiVhFNne/K9gIWJxtJhCr8A6mcbCNwll5QV+9hDAgj5Mq4SPLSu1I1QaW07 N1MP+h3MjC671OOer6LyAeAG3tUS8p0PdmVxCwEd1TD5ri/Y3cbIGNu0Wh05h3vKBZ2ZKT y2ltLErAFZZjm2xDzsiyisakLzo4DPQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mimSu79X; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-60179d8e65fso6217901a12.0 for ; Tue, 10 Jun 2025 18:13:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749604380; x=1750209180; darn=kvack.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=T7BzYZ0HwQMO8On28SrUYjxN4nxQyJ0i5gaZcr6fbYg=; b=mimSu79XcGQCDirnJYFfSXr5URMr2RBOQKS7Rz62w4qY84N97piUzv00N9ywvJ9NTT tRu4pkJ9MrrV+QPZ8Urv0u5RIOqxGT3MCOMPUpzv3iArVi8uCmj/wcFevSuTW/pod9T9 R7o91H6GL21g/AJLf66V2/XrSBM3QIlMfsVXhaVgTBm2sLJE/TGCwKIVGX5DXZ2ApgaW Fx176c5tRQ5i/ay46OPvTinSWVI0OYjw+tkOoDFx50ctEwWDInAHk7w6JWVDRbk4TNJD ie/4+WHEtNroQuEaTeT6cf7v12BuQM4O9oK7nEFgxPQ6QKXOXNuAMBJnt1NUAbKLGb65 PYhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749604380; x=1750209180; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T7BzYZ0HwQMO8On28SrUYjxN4nxQyJ0i5gaZcr6fbYg=; b=GqxCDLdIhRyoHZwqJTYIlXHGSblMc4BUGraFXzORPJylr2ddiuM/q4BLxxs8L04lak /G/a5w7ij3n7z/UsRyu1/W04CqQuqFNdxBL5cC1P+q0wdXD2CY4+d8kg8iDzrDMeJ5gp G4Crq2rgpyVp0qbrJvQJLxdOCdEqtNZ9XHTlMqiJHcVbR2BklD1HlVz82aRQVJmb8kWX F8R0iVy4b784WyDs7+KvhPufW5eJhzUOnJnUzx2MmM5ElpdL30HyZIVLkgXCmrxa0Top UlvvtMqpfDHZevcpDt/oTCdkiMYe1G13Y5jSbJE+bvmOsT6VXy5XRkIwtQHaCF7nHmXz V4aw== X-Forwarded-Encrypted: i=1; AJvYcCXw6/0wQOehmgqLLDPuaWsaSu/dMetnxjf5avohVduPzZBNYc9F2bgMEf520HB38ICw3exzOTv3Fw==@kvack.org X-Gm-Message-State: AOJu0YwLmNbUu6oGAjvaLI79XWdruwzpNE0pXFNaA874KEjOmO4HqpM5 IIyMVb8RCbmz+7dghLCuK+PvlQz8CJXGrw7OhUzbDskv3qje3Eu8O0v0 X-Gm-Gg: ASbGncvDBg4XBz96RXuww2SsYvap/M6ZVi6Wn1h95irqGIbpVVpijPrGb/vGSI25CmJ AlH3/CFPi5df9nLiV7dKAeT7/s6+koe9M2Kit/D2/yl7tCai08+LOp/x23bNJUQ7AtscTIpuah2 orsLtCZ8+aMYzyfj8yrcnbh7TW6PURYlT8r0rAgKDuTAfRAUZxQOalSRvealdlhmepCLuBuaKSW kas1G3OAj2SmdY3AOAh4uLDSHVH5tv+DETRHUcl1ZLGdKu2xq2V9hurRw1aTGIP5bQPIIdTnFC5 rO5nX5Ov87a3uqGYxpvvsemOiyxl4k7d0vxPRGJRcm8Je/b9ckGdpFiahnkA5w== X-Google-Smtp-Source: AGHT+IGWLY6VzTfRRE6aaCfx6kKcqZfzwG17Y38nmgYbhMmGDSuQee+ztaUCf2OLXiQnsWdVRjbpmg== X-Received: by 2002:a05:6402:2792:b0:5f6:fab2:9128 with SMTP id 4fb4d7f45d1cf-60846b1fc08mr1121804a12.19.1749604380030; Tue, 10 Jun 2025 18:13:00 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6077837015fsm6795210a12.14.2025.06.10.18.12.58 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Jun 2025 18:12:59 -0700 (PDT) From: Wei Yang To: Liam.Howlett@oracle.com, akpm@linux-foundation.org, willy@infradead.org Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org, Wei Yang , "Liam R . Howlett" Subject: [Patch v3 3/3] maple_tree: assert retrieving new value on a tree containing just a leaf node Date: Wed, 11 Jun 2025 01:12:53 +0000 Message-Id: <20250611011253.19515-4-richard.weiyang@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20250611011253.19515-1-richard.weiyang@gmail.com> References: <20250611011253.19515-1-richard.weiyang@gmail.com> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 79EE2180007 X-Stat-Signature: t371as9c9tcee8b4q4bjq7stj6xe5pay X-Rspam-User: X-HE-Tag: 1749604381-852624 X-HE-Meta: U2FsdGVkX1/ZbOUPvIvuRUJFa8uqSqekfe1eng+sGuVqWhWclDXdaSNZcLYPXrfv/jZD7ltdIepvQYynDfW6BkP0IIC941L6ViFlOQMvX2YpFSarXMwsrQoGRqlUvpeBNDSrJuDVSsWXViJ7InusjAT5UdsV2B5xvLBnirDdu4hn+XDDGOckQ267OjQarefdo2FMArd/ZdNmuVkoA4bGpzkvclEv3FnGiSB+GODU7+WtuS7ZHTGFaPyjXMSW0XhEVI6WUg0UagPajkosgt2/v+p2j6zRpNhwT58W7xlsM3bdZvPFtYbAkFfkVAxkF1n+nux+grokOer43vNx1Gy78FQxBXhKWbwLDkUu2tHtNcb6riVLFXe136dtWU33dAs6+93NvgdikSWE+XcmO8B1Bpgn4xM7obmwocnkPfwtAbg+Gm0yygrJShyElNUyhTlqLOGcLvdSJlUndOKY+f/9iI9tAP96CZJuP2aY1OZ041b+3NQrcv5s6WIIReewh/9yweXn3jz0P2M4GbWK8H9VDdNwBD8RdO4GyqETwx5I6qmU2S7yMFssYqKanBSxvvVZyq+/xwfYvopSmbDizt8EMscYJup0x+BxnxUUv2Ge2o+lhMa4mRcYEkTR22bDwYv///ao1sy5XSN6X+jjpUnhW5iaw0RCcFN66oxDnz4zYxwxc5Sn+vvRtu6O4m/FmA2fEkLSrCFiqHT7lzSlO1GNxFK5bQMPHou8PiYLo1vXkw2lDD+LTpmLVmHorXU7jDJMtjYWd/TSODiJkL5WPOzWRWWemxXbk5WKgJsIa6gvBqMntJbH6Bl1UwFx9Uzto8i8/FFgbHCNjnJ7DXp5ajAWY6f2KUPlc2OXxpx8IaG+B3Gfjdy8wkKd2gW9U+nI1w1kWVYgfikBtWY6cOc38dRwNj5rXb6JD7n2uPStzLgbUkm6y44bVsIHSUNFPw/YvS/QFqXAzNJzuAf3PEe7yDu m8lpqvad I5jW223vs5vgoWLAhOG+cYh3E0KAB1RH+tLc8ZdknRwxNyCs+rpEF8wQAEe+n2k0tjwswNkXR1kRWsPlgMAqgcfZj09U4NU2uF9bg8JKl8kLbyMGuvONPnwGnD7Tua+S41gmtnlj+nS9LA35EGT2x2STivyaSW0+UCFYCTbuD+dlyAWJkvZAkpizL9GgCeiDaXIF6heF5mUP86VjxM2YW0ReZVd+uurcZqeU1IXnNAbJ3CoDrha+D6vXXUEVKrGbu7085km7Cf+dH0wY1kowD+5BYwTnhD9ub4l2kEsOo9XUi8e2tljPEPCE/mLSeW2KvTL+rrTw6Nyvq6D/z3qN1bj1ogpxeSQbdDHUN0sNGAiNy9K6WA8Yx9PAeGYmh5gw/t7Boc5K4fuA/liJ70AnAlkJgvrq/UzGr4OaVi2bTjBCCNtP8INlsKae2cghS8xAjeiCRSnhM/hKbefYg7/PAQuNrLnK/Bqs4DGUscbMJuZnNo3QoMdEcRSskeJvJHAl6IOwXKg70VTQOUopcAav0az9nRL7xq50/u9VfuWMRG8WuRn/4PbUm9D0FpA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Original code may not get the new value after overwriting the whole range on a maple tree containing just a leaf node. The reason is we didn't set the only root node dead during destroy. Add a test case to ensure the new value is returned when overwriting a tree containing just a leaf node. Signed-off-by: Wei Yang Cc: Liam R. Howlett Reviewed-by: Liam R. Howlett --- v2: adjust the changelog according to Liam's suggestion --- tools/testing/radix-tree/maple.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c index 2c0b38301253..8b97aac1084e 100644 --- a/tools/testing/radix-tree/maple.c +++ b/tools/testing/radix-tree/maple.c @@ -35256,6 +35256,30 @@ static noinline void __init check_rcu_simulated(struct maple_tree *mt) MT_BUG_ON(mt, mas_prev(&mas_reader, 0) != xa_mk_value(val)); rcu_read_unlock(); + /* Clear out tree & create one with only root node */ + mas_lock(&mas_writer); + mas_set_range(&mas_writer, 0, ULONG_MAX); + mas_store_gfp(&mas_writer, NULL, GFP_KERNEL); + mas_set_range(&mas_writer, 0, 0); + for (i = 0; i <= 5; i++) { + mas_writer.index = i * 10; + mas_writer.last = i * 10 + 5; + mas_store_gfp(&mas_writer, xa_mk_value(i), GFP_KERNEL); + } + mas_unlock(&mas_writer); + target = 10; + mas_set_range(&mas_reader, target, target); + rcu_read_lock(); + MT_BUG_ON(mt, mas_walk(&mas_reader) != xa_mk_value(target/10)); + + /* Overwrite the whole range */ + mas_lock(&mas_writer); + mas_set_range(&mas_writer, 0, ULONG_MAX); + mas_store_gfp(&mas_writer, xa_mk_value(val), GFP_KERNEL); + mas_unlock(&mas_writer); + MT_BUG_ON(mt, mas_walk(&mas_reader) != xa_mk_value(val)); + rcu_read_unlock(); + rcu_unregister_thread(); } -- 2.34.1