linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	Christoph Lameter <cl@gentwo.org>,
	David Rientjes <rientjes@google.com>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Harry Yoo <harry.yoo@oracle.com>,
	linux-mm@kvack.org
Subject: [PATCH v2 03/11] slab: Add SL_partial flag
Date: Wed, 11 Jun 2025 16:59:06 +0100	[thread overview]
Message-ID: <20250611155916.2579160-4-willy@infradead.org> (raw)
In-Reply-To: <20250611155916.2579160-1-willy@infradead.org>

Give slab its own name for this flag.  Keep the PG_workingset alias
information in one place.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Acked-by: Harry Yoo <harry.yoo@oracle.com>
---
 mm/slub.c | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/mm/slub.c b/mm/slub.c
index be44d7bd1f89..2bf1ad8a70ce 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -91,14 +91,14 @@
  *   The partially empty slabs cached on the CPU partial list are used
  *   for performance reasons, which speeds up the allocation process.
  *   These slabs are not frozen, but are also exempt from list management,
- *   by clearing the PG_workingset flag when moving out of the node
+ *   by clearing the SL_partial flag when moving out of the node
  *   partial list. Please see __slab_free() for more details.
  *
  *   To sum up, the current scheme is:
- *   - node partial slab: PG_Workingset && !frozen
- *   - cpu partial slab: !PG_Workingset && !frozen
- *   - cpu slab: !PG_Workingset && frozen
- *   - full slab: !PG_Workingset && !frozen
+ *   - node partial slab: SL_partial && !frozen
+ *   - cpu partial slab: !SL_partial && !frozen
+ *   - cpu slab: !SL_partial && frozen
+ *   - full slab: !SL_partial && !frozen
  *
  *   list_lock
  *
@@ -186,6 +186,7 @@
 /**
  * enum slab_flags - How the slab flags bits are used.
  * @SL_locked: Is locked with slab_lock()
+ * @SL_partial: On the per-node partial list
  *
  * The slab flags share space with the page flags but some bits have
  * different interpretations.  The high bits are used for information
@@ -193,6 +194,7 @@
  */
 enum slab_flags {
 	SL_locked = PG_locked,
+	SL_partial = PG_workingset,	/* Historical reasons for this bit */
 };
 
 /*
@@ -2729,23 +2731,19 @@ static void discard_slab(struct kmem_cache *s, struct slab *slab)
 	free_slab(s, slab);
 }
 
-/*
- * SLUB reuses PG_workingset bit to keep track of whether it's on
- * the per-node partial list.
- */
 static inline bool slab_test_node_partial(const struct slab *slab)
 {
-	return folio_test_workingset(slab_folio(slab));
+	return test_bit(SL_partial, &slab->flags);
 }
 
 static inline void slab_set_node_partial(struct slab *slab)
 {
-	set_bit(PG_workingset, folio_flags(slab_folio(slab), 0));
+	set_bit(SL_partial, &slab->flags);
 }
 
 static inline void slab_clear_node_partial(struct slab *slab)
 {
-	clear_bit(PG_workingset, folio_flags(slab_folio(slab), 0));
+	clear_bit(SL_partial, &slab->flags);
 }
 
 /*
-- 
2.47.2



  parent reply	other threads:[~2025-06-11 15:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-11 15:59 [PATCH v2 00/11] Various slab improvements Matthew Wilcox (Oracle)
2025-06-11 15:59 ` [PATCH v2 01/11] doc: Move SLUB documentation to the admin guide Matthew Wilcox (Oracle)
2025-06-11 15:59 ` [PATCH v2 02/11] slab: Rename slab->__page_flags to slab->flags Matthew Wilcox (Oracle)
2025-06-11 15:59 ` Matthew Wilcox (Oracle) [this message]
2025-06-11 15:59 ` [PATCH v2 04/11] slab: Add SL_pfmemalloc flag Matthew Wilcox (Oracle)
2025-06-11 15:59 ` [PATCH v2 05/11] slub: Fix a documentation build error for krealloc() Matthew Wilcox (Oracle)
2025-06-11 15:59 ` [PATCH v2 06/11] doc: Add slab internal kernel-doc Matthew Wilcox (Oracle)
2025-06-17 14:03   ` Vlastimil Babka
2025-06-17 14:16     ` Matthew Wilcox
2025-06-11 15:59 ` [PATCH v2 07/11] vmcoreinfo: Remove documentation of PG_slab and PG_hugetlb Matthew Wilcox (Oracle)
2025-06-11 15:59 ` [PATCH v2 08/11] proc: Remove mention of PG_slab Matthew Wilcox (Oracle)
2025-06-11 15:59 ` [PATCH v2 09/11] kfence: " Matthew Wilcox (Oracle)
2025-06-11 15:59 ` [PATCH v2 10/11] memcg_slabinfo: Fix use " Matthew Wilcox (Oracle)
2025-06-11 15:59 ` [PATCH v2 11/11] slab: Update MAINTAINERS entry Matthew Wilcox (Oracle)
2025-06-15 21:51   ` David Rientjes
2025-06-16  7:24   ` Harry Yoo
2025-06-23 12:28 ` [PATCH v2 00/11] Various slab improvements Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250611155916.2579160-4-willy@infradead.org \
    --to=willy@infradead.org \
    --cc=cl@gentwo.org \
    --cc=harry.yoo@oracle.com \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).