From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0060C71136 for ; Thu, 12 Jun 2025 11:24:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4ECA56B008C; Thu, 12 Jun 2025 07:24:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49C2F6B0092; Thu, 12 Jun 2025 07:24:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38C076B0093; Thu, 12 Jun 2025 07:24:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1A06E6B008C for ; Thu, 12 Jun 2025 07:24:59 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BF7F880C6A for ; Thu, 12 Jun 2025 11:24:58 +0000 (UTC) X-FDA: 83546516676.12.FEEDAEA Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf08.hostedemail.com (Postfix) with ESMTP id 3585E16000F for ; Thu, 12 Jun 2025 11:24:55 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=ntI1wtiH; spf=pass (imf08.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749727496; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2AMC/bEjzv39eZGGnud64gi+zqY2Gy6AQYpnVFQJ9NI=; b=RfDiXHRIsfHKxK+Gi0c2rt2cD4TcCGyxhKJIOsL8CJN57wBZjsIWwSZvakrDnP8D8NpFzO 2Lw941VM3L62q0STGdH/J5beI5f56CMw18KCr5J24yJUIbcp33xgg/9acwGB7/SxQxRVPc GKMSbPppSN4YOBAZRwDwWSn+GLKqK68= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749727496; a=rsa-sha256; cv=none; b=tcDzMRN2oGEAVxAnxzyChzt9JFMV8wTo5HZPK1h6qOHZ0d/NOU5lm7R3Zkt+tzi+HdSwtx +E8yl1NlSdNt1ofSwMP4U9w+3wUgpgDQkmkLBcoyg8Wn5XyURX/Ah/mXCQARL9sdW/FcHb 5/TLIPmmsyg9x197kgIn1GH9dY8aWY8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=ntI1wtiH; spf=pass (imf08.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55CAA74e012275; Thu, 12 Jun 2025 11:24:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=2AMC/bEjzv39eZGGnud64gi+zqY2Gy 6AQYpnVFQJ9NI=; b=ntI1wtiHn/hqxY+baL8YNU65U85XzX7YVO5tHLbxJGGqXh 2FK+Pmne7Iy+kz7fF6RIUTdTO40fJivDQkwesidYjpzrHNkuQu7TtZjtMSwnykAD 6tThwNvs735Yv2e+GHHZCX2fhqHddMGYRyOUdG0K7t5XFEoILBUafVp6K1BjsPWQ b0lVDO3WhRp69dDsxbLkXfTnlwfzFLgPDLrcXdxeeQvlxGvgmYiEMtTnWks3Ih3y kzCcOA5QrM2n48GsbCwCNnOjofjG6JDCgbPMmJmCAo/lGpGcmTfOxAtgJ1qEgNZj klzn/ykODUW35LYBo6J1A7aD/NX/qauivvSvHSjA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 474cxjjewp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Jun 2025 11:24:52 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 55CBOpBR005609; Thu, 12 Jun 2025 11:24:51 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 474cxjjewn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Jun 2025 11:24:51 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 55C9TMCs022352; Thu, 12 Jun 2025 11:24:50 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4750504k9w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Jun 2025 11:24:50 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 55CBOkgj25494242 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Jun 2025 11:24:46 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8D0E720040; Thu, 12 Jun 2025 11:24:46 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 70FCF2004B; Thu, 12 Jun 2025 11:24:45 +0000 (GMT) Received: from osiris (unknown [9.87.144.171]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 12 Jun 2025 11:24:45 +0000 (GMT) Date: Thu, 12 Jun 2025 13:24:44 +0200 From: Heiko Carstens To: Mike Rapoport Cc: Hao Ge , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Richard Henderson , Matt Turner , Dennis Zhou , Tejun Heo , Christoph Lameter , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Kent Overstreet , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-s390@vger.kernel.org, Hao Ge Subject: Re: [PATCH 5/5] mm/alloc_tag: add the CONFIG_ARCH_NEEDS_WEAK_PER_CPU macro when statically defining the percpu variable _shared_alloc_tag Message-ID: <20250612112444.10868E66-hca@linux.ibm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: Sv26n7mf3EWJevs8xBu8ADqXhqE1AM8t X-Proofpoint-GUID: CogFJVGLtjbrl2bCisizEvHCcJ_c4YH5 X-Authority-Analysis: v=2.4 cv=fZWty1QF c=1 sm=1 tr=0 ts=684ab904 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=1XWaLZrsAAAA:8 a=uybNw-qwnAclyCFN39wA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjEyMDA4NiBTYWx0ZWRfXzbs0KW3AiFNP hCFHSWNqOurrf3COjJlIlankl5U4ZnRZHhog94FLrN37KGhTrq8EhfTAhJNXuw3JeBWQmA2Uxee bbvmRBnsQa4Rt0jIdYxDOQWED70MMnvDBaNmNE7vAKAhA4UOWFZYRF87Zab/IFDqGmQxsrZbZfK hU354BsC3OcmSAxGpxBNjwGPS/O2isOcDIOT3fo/TVI5rqnFCEz/FSdJDPT3rQdSMzF48FiP2Oa ChUJDM8sLnH/cNbZKwSbddQre0obvu9do2nnfvjZvI/8rj77f3D1H1jIjx0iVgBOBobBOTtaEE/ JlD9q/FEG8mjmEMmGRwlG7+1dHQbwQULSDCuj3ypfA1NtVmztc4+44lpVH5kT96RV0i5DnJxed8 4onDv6HrjNpMeBJt5SK2NtAN8ZQ72DDetR9Ol1oD052pZJBvA9JaumbZ+QbVRPx86gXc2x6Q X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-12_07,2025-06-10_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 priorityscore=1501 spamscore=0 bulkscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxscore=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506120086 X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3585E16000F X-Stat-Signature: tgin8me7qzyqj4698nde6bjo6ckwxnbt X-HE-Tag: 1749727495-537905 X-HE-Meta: U2FsdGVkX19Z+4ldjs84jQaWY6b0qULCPwSvAv0SyVsoAJCETAI5iZ3m2OUZpPg+sdPYngv58BseWL5vlbp4CA3Pheg+C8IFTTCn6c50Yz1MRCHaxyDTnQHkwIrkxEXE+dslVovo1DezdsVewiKu9O/eX83kK7jqgtkDX4GdR9f0F4Uu4n5VK4+LlaIi8mv0TWU51rI6wnVLNajk953yAk86J0yV3u8RZshdQcU2mhTHGdFt/RYEFgJwkTuoP9QQHalTEruC/zC0D+Rnj7wPPlZnDuzAy4nZjnGArBHKnukt67u2GkZAefHvCpCCdi/pIr6O9n7pr+l1ofCOBnBd15YrGxafGDBS6IgfptExvrZL0b0TcFCrbhKjgUIxH5q8emDm2DrU4gZuBcrJa0uHg6IdKTVic7YHzlK/QxwKGB8LkGsFnl5hvGFRxWdkA90Fu8i2wWLE753m/IlbltHpBbVcIpZzeIBd7Muoj+nAcRvg2J0+k5XT/6kGKPAz4kwkhO5ieAgVR+jwpU/GMnbFkYY77uQIDTYoQ0vtHU3SBqbAQ2F4B3a3pfJx29FUsiwNT5CT+HI1ibWgcxINj/MV6SzO4Bk/3Kd9KCsYtvBQmF6IIDXQz0aEP/8U3bjfKsj/+7lcKi2Dc30I/qQjalBi/bK+9h0lQS/v8JSNj2Mh4R+xUTRDqMhgEpzSscpJ7EJNIbqyKrQImb60PyVAvzxeQpvcFxbHFmxV/YxSVAWPnLPLgHbYordXY/NNU9O3Ts+4ILx3++fwYQlZZVt0/POz2qRYGacen+b9fO7HpjQo2ZS0uwy0sJliDnLGxI/ldO5vQM51z1MIK03UTXD9m2KgWNidDdImRVaEWkZPOv2LvW9nU7P+bOYdVK2zJGUhsNQFnvANSY8nYKnzZIVTGnkpMRfN446l14i3NXjhessXuKns3mkEnOoBcQHh3u+SfurHD7PmTa9GJmB9xmj92Qa XI/uWpPJ RcOYgCJQSygLx2A67isvpFs2DaHcUWkzLh0iHJxDChZy4mc/W5ZCvZ/aum3RiVwpIyKfDJ5VFCkutWY+zO8P8wRG68eZGRuhd599Uinso0dbT6U0vedMPK5YzGOIb7czgCvMbUMoswMSZo/IXU5hKhzw3D6emcKg5PhOZDnLPVsxmrcaaWQlRhdJI/K8FTwON8OC58SdX7PWIEQDbxCUPJVqZ35ifX9d5FNum2u+1nj4b6//bIq2cFYC9eOMf9xfzttPpRqgFulUa++8IN31bc4L9Y81rV8QfP0QntzicW4ACNd4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 12, 2025 at 11:57:49AM +0300, Mike Rapoport wrote: > On Thu, Jun 12, 2025 at 04:27:30PM +0800, Hao Ge wrote: > > From: Hao Ge > > > > Recently discovered this entry while checking kallsyms on ARM64: > > ffff800083e509c0 D _shared_alloc_tag > > > > If CONFIG_ARCH_NEEDS_WEAK_PER_CPU is not defined(it is only defined for > > s390 and alpha architectures),there's no need to statically define > > the percpu variable _shared_alloc_tag. As the number of CPUs > > increases,the wasted memory will grow correspondingly. > > > > Enclose the definition of _shared_alloc_tag within the > > CONFIG_ARCH_NEEDS_WEAK_PER_CPU condition. > > > > Suggested-by: Suren Baghdasaryan > > Signed-off-by: Hao Ge > > --- > > lib/alloc_tag.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c > > index c7f602fa7b23..14fd66f26e42 100644 > > --- a/lib/alloc_tag.c > > +++ b/lib/alloc_tag.c > > @@ -24,8 +24,10 @@ static bool mem_profiling_support; > > > > static struct codetag_type *alloc_tag_cttype; > > > > +#ifdef CONFIG_ARCH_NEEDS_WEAK_PER_CPU > > It should be enough to add #ifdef ARCH_NEEDS_WEAK_PER_CPU here instead of > all the churn. That won't work since ARCH_NEEDS_WEAK_PER_CPU is only defined if MODULE is also defined, which is not the case for core kernel code like lib/alloc_tag.c. As a side note: I'm wondering if s390 still needs ARCH_NEEDS_WEAK_PER_CPU due to all the compiler option changes we had recently. But that's a different story and independent of this series.