From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5107FC71136 for ; Thu, 12 Jun 2025 18:15:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0E546B0096; Thu, 12 Jun 2025 14:15:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBE086B009E; Thu, 12 Jun 2025 14:15:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CADC86B009F; Thu, 12 Jun 2025 14:15:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A82536B0096 for ; Thu, 12 Jun 2025 14:15:16 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 46A41A17EC for ; Thu, 12 Jun 2025 18:15:16 +0000 (UTC) X-FDA: 83547550632.26.2D7288B Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by imf09.hostedemail.com (Postfix) with ESMTP id 622A4140010 for ; Thu, 12 Jun 2025 18:15:14 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=h+PE09mw; spf=pass (imf09.hostedemail.com: domain of bijan311@gmail.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=bijan311@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749752114; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rI4RhBSsXuuVnpj1aLVVp/cqvhqfeHIgQ1Bp+6ronfs=; b=Tn7vMm6WYB3PJA3dgsDmZQX8qVHeHddVh0amEYfr0PFusKH517X3S7TbkiQ3B23FNIMOjj aeYcBFVTFQ8PNMMNc8EvvpYnkI1XnSubvt/SIeLys3zNAv1QbUdHD63i3T7qeCmj/wuz/s TQ9/C+IMUD6MutWb87bwiNaGXJvnF0c= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=h+PE09mw; spf=pass (imf09.hostedemail.com: domain of bijan311@gmail.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=bijan311@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749752114; a=rsa-sha256; cv=none; b=DSOcTU/YiBWRC3dvK/k1oNwDAMbAd4WWllVbnpoAjqMfjKwjy0tBQz4qR9GlemaXacvsOL 9eXfV5W82NyA+SXXSfSO6QC5QqyOBewaZOQeEbTKpIf2C5VjM4nXkDfRmtR6Q2t/GXtQWW SPo/wRbM87qR3a0YycIABWOaaDIldPw= Received: by mail-yb1-f176.google.com with SMTP id 3f1490d57ef6-e733a6ff491so1256678276.2 for ; Thu, 12 Jun 2025 11:15:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749752113; x=1750356913; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rI4RhBSsXuuVnpj1aLVVp/cqvhqfeHIgQ1Bp+6ronfs=; b=h+PE09mw5WjoMCxAlt5D5Qky5zGzVWfTT/4m4cOPik/GQmSZ5q/Im5RJory4nQrYBJ Lo8HT8Fjgsng85JEdaxRBMJOeQyWW0uJJOQpkRPaCKvwZqmw0Cv/KsHUmwIsIRqJW4Uh sflvf8SxMiXANDQmgX6pYY6JlOVisYvs3oGKshSOk/5mnHUWiXUGa30DlNjN41amNQ/G ORZ1hIc3w4M1qjGKFoX0ZMpGCXdfS1CWvgl0AMW5ss7vhIuaKvLeXlUUueURqo15GxV0 PzS7sL7Gbk9TNxe++koTPri1aBjNX1qTyThC5jIcYCvu4UIXixo18EJpIsDUaoQVTXQT otlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749752113; x=1750356913; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rI4RhBSsXuuVnpj1aLVVp/cqvhqfeHIgQ1Bp+6ronfs=; b=Y/WLO5s2krsckDe65NLGjIttzP+mMc8c74TpOLHeNESv109Rqow/LjfnDfd0u4STO3 30xZbTk5klPR41Sut4+A9uNwhbn+zNgciET0d6fcG7XXpcbrM2XjtfF5eg6OnL+2xheQ BdTiZrwtyRai2CfXqYb4/j85hlp3X1RKkuHltqXkti3PRbB2FJ8uCv8WEEIU6rRBbTZU EkoZEWTKwfxDI3lxKpZK7Gdz6I1LhI27veFfzR8XVmf+YkTVhUdK2w7PBXjK5h8KrKB3 xaLdv6XQ1Tf7/oZpHlKGFYAqW0Sfd7i1B9Et7RJM6ofBz+pT867fA7cpurLCyGy8Wz8v mqjA== X-Forwarded-Encrypted: i=1; AJvYcCVVnR3FMKm+yVeOZqUVE53LsUux3wbi38J/nltRQ+9piesjD/vzJCm48OEDXbHDB6k/huOr7Q2xdg==@kvack.org X-Gm-Message-State: AOJu0YwssjInxBFdnkyo459GPwiz2ozxtd20NOWOEBOeybo9/gjp7fd+ 7Nc0vmlKjIN+JA+O4KJbn6WrcK2iyHqjF34vbDa2ohxcG1gUyvVby3LN X-Gm-Gg: ASbGncvWn3eyelY5ZLak6apW5geb9y7Ket2uXDSyBLUFvQAbTwfYfSGN0c0cRqRWInd pcIFgcv2Tl81bAG3NdudsOAQA6dj+XUJwDr58X345HavHfDz9pVDUHGXmglX8l+Po6yoApAYNYz PcARnYnTjWNQvSaPvG973Y5EumPSmRyicVUAvYSwwISsKDEKPpsYiaJlIcRqE8WvN+yz5A50p4v GHQ98z8XNC9CVOH2yAy161zgwpxU5VftPsf6uc5FjU72pEl4NpEHBC2vxs0P9vhhtk9+AcyMEvB 8cf17PL6EE2ZwhWEPKnrl3pAiBB3h1VmjLfZxkY2X0M5bQOqGAA2JbZJF4AYFPS8ZA7xaWU/dXA wdyMJcGDD/lo3y/+z+A== X-Google-Smtp-Source: AGHT+IFRULeRqZvjiyXhrkg+34BsFqcLiAM8WQUjj7GW8kCxanbKyVwN1t/1QqcXNLvmk8wOV/g/ow== X-Received: by 2002:a05:6902:220c:b0:e81:d976:ce25 with SMTP id 3f1490d57ef6-e820b64c93cmr6416416276.3.1749752113416; Thu, 12 Jun 2025 11:15:13 -0700 (PDT) Received: from bijan-laptop.attlocal.net ([2600:1700:680e:c000:dd1b:d4ae:15de:11db]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e820e312452sm592480276.40.2025.06.12.11.15.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 11:15:13 -0700 (PDT) From: Bijan Tabatabai To: damon@lists.linux.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: sj@kernel.org, akpm@linux-foundation.org, corbet@lwn.net, david@redhat.com, ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, ying.huang@linux.alibaba.com, apopple@nvidia.com, bijantabatab@micron.com, venkataravis@micron.com, emirakhur@micron.com, ajayjoshi@micron.com, vtavarespetr@micron.com Subject: [RFC PATCH 2/4] mm/damon/paddr: Add DAMOS_INTERLEAVE action Date: Thu, 12 Jun 2025 13:13:28 -0500 Message-ID: <20250612181330.31236-3-bijan311@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250612181330.31236-1-bijan311@gmail.com> References: <20250612181330.31236-1-bijan311@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 622A4140010 X-Stat-Signature: fa4y6nd37y5xt9s9qimim1dfpm4hy8hg X-Rspam-User: X-HE-Tag: 1749752114-199876 X-HE-Meta: U2FsdGVkX19DNGISpvSdNm+wQGjAIs0rFajQuViJhtT6j5EHtot5RTUrDf6Aaut2lWcNS8nDDytdfcLcDwnzlu8Q1YxZTxPY37NBiWjdUbbScD+YDhhboHNe0fkvHpNXOVHg42BaAjK6veRHI2muTh7s9pl11bgbeSYZKGU/byhH17gG+xFOHrjoVDNNy9+xCSZKQ4uzOQfELPP+mbD9MaW7HIGcYU5ZiwNJxddxK3S72Pro290PhCgfQd1DeANIzk5E+4fWyx/l9OZSwsYnuuYM5rhK9k/3HqoMVM8Bs3HOFTlzdUwsjZ4n7L92EzUNJK36054qJTT/oSlxjRvk0QtfPtEk0beCSNnLl3o9Jwy3cIgBOWrLGCBZGizbWonAOaGM7zqXEhh17fG6MMloU0e4ntToG/KrZ/FOzktnZs838j3LnV82UfIYUL7yrWNdvnxAfE/pLee8n+MB6kP4HU+65Gk/KMi4yleZPyxXavUCZWkcsZIz/irPRb3QRjy66CEsg1V8K7hYPtpag+nFAdCEuxBmiHXk6wkIm5KuwdQ1UVzxOQOS0lbFrjGBVklhZryZgQoAqTJHOt94dGFvJsRx+bYlhC3FWLIYbRoO8oK6Vovb41xNGMhbB4cK+tb3IKr7kXJb0EDPu00ALe6mMkGq2qeSPkYyXVbyqHEtBuZqlca2ZN0fG8f2GaD3tESzwrAKaTdxBXSD6OTWSMv4vNqwO0Do5ugahkd8LjwTGJoDPbChZnHIWHZPizsETF7LMe6iDWUMAAOVcnWnK6FnwxodGj2leZYMUUaWMMGKYJfvd5Ro5WJLuAbvgq1L5+3w2wguIlW2De4BnaFXFAVVccfw4vOxwXQItB5577D1qGpjgWjKRH7aX7n9tH6twgsvgTGi5KxQ9DjOz2s+Gsm/kvzBBV1unJPE4+udtsSFEVAYGVOR9lv5P7BczpIw2j+WZdznhrfvaizkutL01wa 9ZXeqMZp eaplHqT+aZKqEphIdv3jMMeBukxCvH+W5kw55a6amYqhwm1KAjUk4RKE5TbNAEUshAvCwsBrEFxOazVSlmzvTJT1QRTsXtA64Prvq8XgDpm83lehjNCzbiCVvOgvmnbYd873695VQ34qyvEpax6a0Tm1XrY+7lDC7wTwhC3e5rzF3UNMmHwRORLX6ZQjK/qXEFtvsl58CXnYTTSl9iQkU4NER6hjWREsRzalzZ0WZC61B57zYJB4oyAl76mYCZfsx5SKzDU/HZQn4EUHyNaB9W7JuL8yAl9h2WBd4p2/8iQqJqPfemmet8VizM7xnWKL1Y9+pUfcBxz5o90WEzzVyHHULpelMImuVYwExV4utWSkazuDTYTdMGhDJqreiHWuhWGMhQqYYsZtVYInxeS5Fn6p+wiLf5mYZcfqGt81KKfoxRQ/bjsBIZPsFwiD0LUmiz4XpV7gZMPCd5Yn2YxSDiUBeKc/796+9WMFE88VUdODRHWvKiJKcw9agnOri/boGYOACYrSyIx/vrBGWWZe7RFEIgMpUxECrwFag5q9HSUxkGPKI/qvZnEiRyMe4fG3fWDoU4rY5FGDZGuiTPJcpGwHcJY8otDHAqWu1Th1bAMfaiSU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Bijan Tabatabai This patch adds the DAMOS_INTERLEAVE action. It interleaves pages inside of a given region according to the weights in the iw_table. To reuse existing interleaving code, the target nid for a folio is determined by calling policy_nodemask, therefore only folios belonging to processes using the MPOL_WEIGHTED_INTERLEAVE policy will have their pages migrated. Below is an example of its usage where pages are initially interleaved at a 1:1 ratio and then changed to be interleaved at a 2:1 ratio. The alloc_data program simply allocates 1GB of data then sleeps. $ cd /sys/kernel/mm/damon/admin/kdamonds/0 $ sudo cat ./contexts/0/schemes/0/action interleave $ echo 1 | sudo tee /sys/kernel/mm/mempolicy/weighted_interleave/node0 $ echo 1 | sudo tee /sys/kernel/mm/mempolicy/weighted_interleave/node1 $ numactl -w 0,1 ~/alloc_data 1G & $ numastat -c -p alloc_data Per-node process memory usage (in MBs) for PID 18473 (alloc_data) Node 0 Node 1 Total ------ ------ ----- Huge 0 0 0 Heap 0 0 0 Stack 0 0 0 Private 514 514 1027 ------- ------ ------ ----- Total 514 514 1028 $ echo 2 | sudo tee /sys/kernel/mm/mempolicy/weighted_interleave/node0 $ numastat -c -p alloc_data Per-node process memory usage (in MBs) for PID 18473 (alloc_data) Node 0 Node 1 Total ------ ------ ----- Huge 0 0 0 Heap 0 0 0 Stack 0 0 0 Private 684 343 1027 ------- ------ ------ ----- Total 684 343 1027 Signed-off-by: Bijan Tabatabai --- Documentation/mm/damon/design.rst | 2 + include/linux/damon.h | 2 + mm/damon/paddr.c | 112 ++++++++++++++++++++++++++++++ mm/damon/sysfs-schemes.c | 1 + 4 files changed, 117 insertions(+) diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst index ddc50db3afa4..c50d2105cea0 100644 --- a/Documentation/mm/damon/design.rst +++ b/Documentation/mm/damon/design.rst @@ -455,6 +455,8 @@ that supports each action are as below. Supported by ``paddr`` operations set. - ``migrate_cold``: Migrate the regions prioritizing colder regions. Supported by ``paddr`` operations set. + - ``interleave``: Interleave the regions according to the weighted interleave weights. + Supported by ``paddr`` operations set. - ``stat``: Do nothing but count the statistics. Supported by all operations sets. diff --git a/include/linux/damon.h b/include/linux/damon.h index a4011726cb3b..81d26a203337 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -117,6 +117,7 @@ struct damon_target { * @DAMOS_LRU_DEPRIO: Deprioritize the region on its LRU lists. * @DAMOS_MIGRATE_HOT: Migrate the regions prioritizing warmer regions. * @DAMOS_MIGRATE_COLD: Migrate the regions prioritizing colder regions. + * @DAMOS_INTERLEAVE: Interleave the regions by the weighted interleave ratio * @DAMOS_STAT: Do nothing but count the stat. * @NR_DAMOS_ACTIONS: Total number of DAMOS actions * @@ -136,6 +137,7 @@ enum damos_action { DAMOS_LRU_DEPRIO, DAMOS_MIGRATE_HOT, DAMOS_MIGRATE_COLD, + DAMOS_INTERLEAVE, DAMOS_STAT, /* Do nothing but only record the stat */ NR_DAMOS_ACTIONS, }; diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c index 4102a8c5f992..e989464635cd 100644 --- a/mm/damon/paddr.c +++ b/mm/damon/paddr.c @@ -535,6 +535,114 @@ static unsigned long damon_pa_migrate(struct damon_region *r, struct damos *s, return applied * PAGE_SIZE; } +#if defined(CONFIG_MEMCG) && defined(CONFIG_NUMA) +struct damos_interleave_private { + struct list_head *folio_migration_list; + bool putback_lru; +}; + +static bool damon_pa_interleave_rmap(struct folio *folio, struct vm_area_struct *vma, + unsigned long addr, void *arg) +{ + struct mempolicy *pol; + struct task_struct *task; + pgoff_t ilx; + int target_nid; + struct damos_interleave_private *priv = arg; + + task = rcu_dereference(vma->vm_mm->owner); + if (!task) + return true; + + pol = get_task_policy(task); + if (!pol) + return true; + + /* Getting the interleave weights only makes sense with MPOL_WEIGHTED_INTERLEAVE */ + if (pol->mode != MPOL_WEIGHTED_INTERLEAVE) { + mpol_cond_put(pol); + return true; + } + + ilx = vma->vm_pgoff >> folio_order(folio); + ilx += (addr - vma->vm_start) >> (PAGE_SHIFT + folio_order(folio)); + policy_nodemask(0, pol, ilx, &target_nid); + + if (target_nid != NUMA_NO_NODE && folio_nid(folio) != target_nid) { + list_add(&folio->lru, &priv->folio_migration_list[target_nid]); + priv->putback_lru = false; + } + + mpol_cond_put(pol); + return false; +} + +static unsigned long damon_pa_interleave(struct damon_region *r, struct damos *s, + unsigned long *sz_filter_passed) +{ + struct damos_interleave_private priv; + struct rmap_walk_control rwc; + unsigned long addr, applied; + struct folio *folio; + + priv.folio_migration_list = kmalloc_array(nr_node_ids, sizeof(struct list_head), + GFP_KERNEL); + if (!priv.folio_migration_list) + return 0; + + for (int i = 0; i < nr_node_ids; i++) + INIT_LIST_HEAD(&priv.folio_migration_list[i]); + + memset(&rwc, 0, sizeof(struct rmap_walk_control)); + rwc.rmap_one = damon_pa_interleave_rmap; + rwc.arg = &priv; + + addr = r->ar.start; + while (addr < r->ar.end) { + folio = damon_get_folio(PHYS_PFN(addr)); + + if (damon_pa_invalid_damos_folio(folio, s)) { + addr += PAGE_SIZE; + continue; + } + + if (damos_pa_filter_out(s, folio)) + goto put_folio; + else + *sz_filter_passed += folio_size(folio); + + if (!folio_isolate_lru(folio)) + goto put_folio; + + priv.putback_lru = true; + rmap_walk(folio, &rwc); + + if (priv.putback_lru) + folio_putback_lru(folio); + +put_folio: + addr += folio_size(folio); + folio_put(folio); + } + + applied = 0; + for (int i = 0; i < nr_node_ids; i++) { + applied += damon_pa_migrate_pages(&priv.folio_migration_list[i], i); + cond_resched(); + } + + kfree(priv.folio_migration_list); + s->last_applied = folio; + return applied * PAGE_SIZE; +} +#else +static unsigned long damon_pa_interleave(struct damon_region *r, struct damos *s, + unsigned long *sz_filter_passed) +{ + return 0; +} +#endif /* defined(CONFIG_MEMCG) && defined(CONFIG_NUMA) */ + static bool damon_pa_scheme_has_filter(struct damos *s) { struct damos_filter *f; @@ -584,6 +692,8 @@ static unsigned long damon_pa_apply_scheme(struct damon_ctx *ctx, case DAMOS_MIGRATE_HOT: case DAMOS_MIGRATE_COLD: return damon_pa_migrate(r, scheme, sz_filter_passed); + case DAMOS_INTERLEAVE: + return damon_pa_interleave(r, scheme, sz_filter_passed); case DAMOS_STAT: return damon_pa_stat(r, scheme, sz_filter_passed); default: @@ -608,6 +718,8 @@ static int damon_pa_scheme_score(struct damon_ctx *context, return damon_hot_score(context, r, scheme); case DAMOS_MIGRATE_COLD: return damon_cold_score(context, r, scheme); + case DAMOS_INTERLEAVE: + return damon_hot_score(context, r, scheme); default: break; } diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c index 0f6c9e1fec0b..12a32e066d06 100644 --- a/mm/damon/sysfs-schemes.c +++ b/mm/damon/sysfs-schemes.c @@ -1597,6 +1597,7 @@ static const char * const damon_sysfs_damos_action_strs[] = { "lru_deprio", "migrate_hot", "migrate_cold", + "interleave", "stat", }; -- 2.43.5