From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EC3CC71135 for ; Sun, 15 Jun 2025 20:55:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 759956B008A; Sun, 15 Jun 2025 16:55:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 70A7D6B008C; Sun, 15 Jun 2025 16:55:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F9626B0092; Sun, 15 Jun 2025 16:55:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4C69A6B008A for ; Sun, 15 Jun 2025 16:55:14 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D0975141AC1 for ; Sun, 15 Jun 2025 20:55:13 +0000 (UTC) X-FDA: 83558840106.12.8B2C999 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf27.hostedemail.com (Postfix) with ESMTP id D92E340002 for ; Sun, 15 Jun 2025 20:55:11 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ksnHZXfL; spf=pass (imf27.hostedemail.com: domain of tamird@gmail.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=tamird@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750020911; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=j16wuFNqkdjB5TUdH0zffnUQd8bgZAgYJK6kemWeowM=; b=7jg4hChSdWEV8YlKpGzDUfJyxW1wwcoEbmo3I9Sdmjr9ldV3tX5JNOcM0V3TvzYEWhMctL RkUw6lJuisU9uvFaVWaYjw1iVEVqd0VNdEaf7JsesbDBsMvXQBfrRt0Exy3wdLFaKpuwZl t7rcmB01F70R2nH3A3y+7K45/GfzcSU= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ksnHZXfL; spf=pass (imf27.hostedemail.com: domain of tamird@gmail.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=tamird@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750020911; a=rsa-sha256; cv=none; b=8Hj4EmIliS7QXTwRbRGe5yadllS6ke4c3VcanwtVdBFjrjegiurFm52w/O9LCLBUe0bw9B 5VyvJRgNhzezmvR11QKCxOIVnBJOtxUJCBU8ZGyRZuxCtRXb82f3MPk+EiUpm+9swUrrr7 miM+1MUFqIQaaz/z8tDdh3n3/dSM2S0= Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-4a4323fe8caso27050641cf.2 for ; Sun, 15 Jun 2025 13:55:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750020911; x=1750625711; darn=kvack.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=j16wuFNqkdjB5TUdH0zffnUQd8bgZAgYJK6kemWeowM=; b=ksnHZXfLS9hekdIBBR4z8agvYK3qGciqC1cQ16BFerWge8g/BROhprOng4LwYHm+EV NYJne9Od+Xd58W492X5P1YzR2dIGjQ0jxrayYJ+ypp27yZ6deJTwMyZ+TNoUeap/9Y3U s24kOejr98EO3jNSiDB8/Q8GtUGR7cKE4jtRktQ2RPUGnV3++U7mV7QzOxDdSDXWceot /LmKlOUtfNAkiW/yWLs6CwMHjp6yffsL4kd1B9oCe4zc8v1brTcZsVILIJ+zeavgjsLD ny61BF1TzYIH97fq3ftSpxF2A8x6LIhT1yM3ZT7mTtPFkTdlHBiXG5J68Oh5QZP6WGkC CZxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750020911; x=1750625711; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j16wuFNqkdjB5TUdH0zffnUQd8bgZAgYJK6kemWeowM=; b=icRYf3A7jOSxBWChjUUE/Q4aAwtj0wUH61R4abidu0sSisAElumWLoy+/o64V6IMTY 8O1U+8KrOocxiRV5NQg4Wy4Tuaitdi9cqS6QWR4+GI3KT4D+LlIdm6ujCNV2M0a0lyIe PD4ZsRdfHDyvwGVDyQP6IkLDMrcOUlrudUN1tGFC8nTRF7B1zlXydGqZVnI23idjdbhf aM/6Hu4CV1h/cIGlzDVqePCrOpEmAltr7Lhs6wXMtUKAvgouD+HHU2TLXkubo1qitrWV 8fna8d8VnW771c0fUzmmgL2O6rZUGqSIsaSOqyURAFyqmkJvNclaqhXZBewhMKoEwPPA 5/8w== X-Forwarded-Encrypted: i=1; AJvYcCUjVN14CN8xN7b0xYgO5FxQ9aXABz7POsfvznIDp6uKH3UiLCnEc/szoEG8bu/U5ajqBpaly3qbaQ==@kvack.org X-Gm-Message-State: AOJu0YyXws+xgOBxuTwCp0mlL6A0fU26plmUotqyt14eloeOCFtUsIgP wNkHax+FEnxlPTxwLaQ1N59TifcwGHxH0pc+Gsa13J4Fn/q/8+HXGD7zdlnR0BsY X-Gm-Gg: ASbGncvVZNbmSqHO6VpysXEfw2suj5TKQtYjN1KJYvOT+su5VDSzrLWQSPCWVD6/lzP yrujGh9MXnl9g+nZdrDoipkCfZ2EQ0iEqo6/h1pyxyOqJCZarYR5UpDozkn1LKynSord+VdObJs kvaHZ8K0HIj8eFvM26ZKL6HGSqXFo3D6pNiYFiFOPgL2Dev/+/UWpEHxT2Lotwigt5TJC24zsn9 CblgTFP7yV09MRhYwpFm77fYY8UlUHees3vfxemEvgpVyfxOU4MER5G+zFR3GO6soNViMASNOpr h133cS29/X2dxjE0CEqQ8DUvn2kzldS+rOMnsZPUaHrwMbi8AI0UQSvQEUiVh5wbOW82VoMSuM6 f04CM X-Google-Smtp-Source: AGHT+IGd7UFbSuHT8VxGXjaCZlDB3nAmPpggFjehtIlQAqgZaWIhMSzFnKX+9RpIkD9GXqlEWnKWJQ== X-Received: by 2002:a05:6214:d47:b0:6fa:fb4f:b582 with SMTP id 6a1803df08f44-6fb47627690mr98707346d6.6.1750020910309; Sun, 15 Jun 2025 13:55:10 -0700 (PDT) Received: from tamird-mac.local ([2600:4041:5be7:7c00:b0c6:92db:d807:21a6]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fb35c84148sm43468176d6.109.2025.06.15.13.55.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Jun 2025 13:55:09 -0700 (PDT) From: Tamir Duberstein Subject: [PATCH v12 0/6] rust: reduce `as` casts, enable related lints Date: Sun, 15 Jun 2025 16:55:04 -0400 Message-Id: <20250615-ptr-as-ptr-v12-0-f43b024581e8@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIACkzT2gC/23S204DIRAG4Fdp9loMMwwnr3wP4wXHdhPbrbt1o 2n67tJqIlCvCCTfzAD/eVjSPKZleNqchzmt4zJOh7IBfNgMYecO28TGWA4G5Ci54JodTzNzy21 B8GCUzoEiDQUc55THz1u1l9ey343LaZq/bsVXuJ7+W2YFBkwajFxJoGDN83bvxrfHMO2Ha5kVa 2obiowzlFFxFy2i1z0VFQVqqCg0ae8UcDKZXE+pprKhVKjHqDEAxYCqp7Km7V1lodLLjJAdCn7 XVVUU24FVoWQjeJ0joeU91TVtB9aFGu08SQTS3vbU/FHqXtgUKrQwXIEUlHJPbUVBNdQWCiYFt L4kJYueAq+taTPBr32jEhG15drdPRRUgVIALYaCQ5KeIKhkQ/NBl5+kzun9o8T99BvXy+Ubr32 BVgwDAAA= X-Change-ID: 20250307-ptr-as-ptr-21b1867fc4d4 To: Masahiro Yamada , Nathan Chancellor , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Bjorn Helgaas , Luis Chamberlain , Russ Weight , Rob Herring , Saravana Kannan , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , FUJITA Tomonori , Nicolas Schier , Frederic Weisbecker , Lyude Paul , Thomas Gleixner , Anna-Maria Behnsen , Benno Lossin , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , John Stultz , Stephen Boyd , Lorenzo Stoakes , "Liam R. Howlett" , Breno Leitao , Viresh Kumar , Nicolas Schier Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-pci@vger.kernel.org, linux-block@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, nouveau@lists.freedesktop.org, Tamir Duberstein , Benno Lossin X-Mailer: b4 0.15-dev X-Rspamd-Queue-Id: D92E340002 X-Rspamd-Server: rspam07 X-Stat-Signature: grp61y64e3mot1iu3h9fq8qkqwpz6yhs X-Rspam-User: X-HE-Tag: 1750020911-687007 X-HE-Meta: U2FsdGVkX1/GdJPeNOcp8IHApFPQQTJ7QvIdvE40XbPy+xpCxlEJs2iTWdYOYZICbkKkytRf6LN4WOkIsiXly/zytVzWMpWuvl+DH1Rt+JX598eRVfreMl3AIQeN+3rXTD7AmnlUG/yeSAqZfEWoUPNMSb/V/4XDNN+m/SRx70H10Zx/tdUvNVXDbzTTxyORa7Pt9oFeweGRmn3XUTFuhFuB9KLa0Yx24APEiajR5W0wawRwC3qY8vjiC4sTCW6pWII98U4r3+iyIcaZwqjuTHhYRxcjpWJdkVnEKO16rJtL7h6+KvtBgvqCXlh5bkVjaRh6duefEtu1Y/pl8CtTn6d37wxYYFWb08knxDl3rsIdMtNb2YxU4hD/Lyhm8jSaVLZPCLNRJKU9+k6Iwu2VQ7Uhsu0DWIQOWNdz/uyZvF6zCqP3Xmj/hijaM1frXyUFb5cFwqx/WmDk9CoO9qyUYGmXjbGUSrIlszPN47AmiBkPemY3tZa5NJJy/WsYNhzzc07qJiDxZXgwTKw8L/3HyBRzGLcp1lRfCDg7zpjoChHe0xs4xqJZnsqKsoa6PkYlEglnYBqIK7yJUlknGclQ+aoOx1hR5WliYrxfF1KoxhDNuEpb52nhYf59uMdp5QDCsLk9QlQx4f2YdKWndgH0vEteYshUloZcdcLf6Ok2BTiiAW+27MxW9JPnDjNg21Gh6lBPGJLZwso7bX4OkwKzt7cbEZtGRT4JN5cf341LxJT3p42bP5Wp1dvONASSNsnynBCz9KrkgyJHqkDgodpiSGXX/pDUhZMH4Ms8D1RZFckqPSESzQ9I0zbYDTnfEX5Rbek5j+UfM6y8GJNHbKVHWTLkZJ17YZ5D+xhvmg70i7agAZD8CDzkN82tiotz6xwsivJmDUB/q4F8/4uLfWrFYf0QHeKrLefKAH0WyAeS+alo5IzHhrkPX7cbhT6B4iNSii7LGTzKrJOCgbba9Da 6WyBV6mB 5e9SKY28z9WsKJHLtvJCYXK3MKOU9CfEwrqZcqI9l0r7FDU/Btaxsm2Kseslca9oK8KqEFoMqPs5Whay41VQzXp0ie+YmAJG+YeL64NeUVJeo0el0Z6OBuX8PX/BRrIcwlQrOlyZsk76Bhw2dPKxoBi2WWr1PKDmt8XcE6mH3w7Y0sTCV2GlI0lxPS7V8nGa338cr2P8ZDGSPiOCpfbo2u4MJC2kjjOWqcMU3zON2sLTbQhdeBXparD0Hrpoq+vMQ/uiinK6gU/YNiA4bhARJWNb3NogBjyRdW+qA6NW3VLeDf3eEQaJ+AbINNJLL96+yvMEMs62aV1Nhj8a6TBWsR66Xsjb0y/7sNsfJgc8pws9vboz46cPbUYmg9zOX2C9IDF2KQKWUPB19y80DWMlwxjlF4Et6QVfu1xUCjUiB8L9SiosdqW/iiFPGF48qb64/PKwRh9H1RwcIFDdHNutq3KOElFmLiJxxldBHZ1yXCoqTiagmnnMYiIDidG1HZQS0I+K/NuVyfax5rX3Vr6apnJJiwUcnaekzQc2A X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This started with a patch that enabled `clippy::ptr_as_ptr`. Benno Lossin suggested I also look into `clippy::ptr_cast_constness` and I discovered `clippy::as_ptr_cast_mut`. This series now enables all 3 lints. It also enables `clippy::as_underscore` which ensures other pointer casts weren't missed. As a later addition, `clippy::cast_lossless` and `clippy::ref_as_ptr` are also enabled. Signed-off-by: Tamir Duberstein --- Changes in v12: - Remove stale mention of a dependency. (Miguel Ojeda) - Apply to config, cpufreq, and nova. (Miguel Ojeda) - Link to v11: https://lore.kernel.org/r/20250611-ptr-as-ptr-v11-0-ce5b41c6e9c6@gmail.com Changes in v11: - Rebase on v6.16-rc1. - Replace some `as ` with `as bindings::T` and others with `as ffi::T`. (Miguel Ojeda) - Revert explicit `ffi::c_void` import which is in the prelude. (Miguel Ojeda) - Link to v10: https://lore.kernel.org/r/20250418-ptr-as-ptr-v10-0-3d63d27907aa@gmail.com Changes in v10: - Move fragment from "rust: enable `clippy::ptr_cast_constness` lint" to "rust: enable `clippy::ptr_as_ptr` lint". (Boqun Feng) - Replace `(...).into()` with `T::from(...)` where the destination type isn't obvious in "rust: enable `clippy::cast_lossless` lint". (Boqun Feng) - Link to v9: https://lore.kernel.org/r/20250416-ptr-as-ptr-v9-0-18ec29b1b1f3@gmail.com Changes in v9: - Replace ref-to-ptr coercion using `let` bindings with `core::ptr::from_{ref,mut}`. (Boqun Feng). - Link to v8: https://lore.kernel.org/r/20250409-ptr-as-ptr-v8-0-3738061534ef@gmail.com Changes in v8: - Use coercion to go ref -> ptr. - rustfmt. - Rebase on v6.15-rc1. - Extract first commit to its own series as it is shared with other series. - Link to v7: https://lore.kernel.org/r/20250325-ptr-as-ptr-v7-0-87ab452147b9@gmail.com Changes in v7: - Add patch to enable `clippy::ref_as_ptr`. - Link to v6: https://lore.kernel.org/r/20250324-ptr-as-ptr-v6-0-49d1b7fd4290@gmail.com Changes in v6: - Drop strict provenance patch. - Fix URLs in doc comments. - Add patch to enable `clippy::cast_lossless`. - Rebase on rust-next. - Link to v5: https://lore.kernel.org/r/20250317-ptr-as-ptr-v5-0-5b5f21fa230a@gmail.com Changes in v5: - Use `pointer::addr` in OF. (Boqun Feng) - Add documentation on stubs. (Benno Lossin) - Mark stubs `#[inline]`. - Pick up Alice's RB on a shared commit from https://lore.kernel.org/all/Z9f-3Aj3_FWBZRrm@google.com/. - Link to v4: https://lore.kernel.org/r/20250315-ptr-as-ptr-v4-0-b2d72c14dc26@gmail.com Changes in v4: - Add missing SoB. (Benno Lossin) - Use `without_provenance_mut` in alloc. (Boqun Feng) - Limit strict provenance lints to the `kernel` crate to avoid complex logic in the build system. This can be revisited on MSRV >= 1.84.0. - Rebase on rust-next. - Link to v3: https://lore.kernel.org/r/20250314-ptr-as-ptr-v3-0-e7ba61048f4a@gmail.com Changes in v3: - Fixed clippy warning in rust/kernel/firmware.rs. (kernel test robot) Link: https://lore.kernel.org/all/202503120332.YTCpFEvv-lkp@intel.com/ - s/as u64/as bindings::phys_addr_t/g. (Benno Lossin) - Use strict provenance APIs and enable lints. (Benno Lossin) - Link to v2: https://lore.kernel.org/r/20250309-ptr-as-ptr-v2-0-25d60ad922b7@gmail.com Changes in v2: - Fixed typo in first commit message. - Added additional patches, converted to series. - Link to v1: https://lore.kernel.org/r/20250307-ptr-as-ptr-v1-1-582d06514c98@gmail.com --- Tamir Duberstein (6): rust: enable `clippy::ptr_as_ptr` lint rust: enable `clippy::ptr_cast_constness` lint rust: enable `clippy::as_ptr_cast_mut` lint rust: enable `clippy::as_underscore` lint rust: enable `clippy::cast_lossless` lint rust: enable `clippy::ref_as_ptr` lint Makefile | 6 ++++ drivers/gpu/drm/drm_panic_qr.rs | 4 +-- drivers/gpu/nova-core/driver.rs | 2 +- drivers/gpu/nova-core/regs.rs | 2 +- drivers/gpu/nova-core/regs/macros.rs | 2 +- rust/bindings/lib.rs | 3 ++ rust/kernel/alloc/allocator_test.rs | 2 +- rust/kernel/alloc/kvec.rs | 4 +-- rust/kernel/block/mq/operations.rs | 2 +- rust/kernel/block/mq/request.rs | 11 +++++-- rust/kernel/configfs.rs | 22 +++++--------- rust/kernel/cpufreq.rs | 2 +- rust/kernel/device.rs | 4 +-- rust/kernel/device_id.rs | 4 +-- rust/kernel/devres.rs | 17 +++++------ rust/kernel/dma.rs | 6 ++-- rust/kernel/drm/device.rs | 6 ++-- rust/kernel/error.rs | 2 +- rust/kernel/firmware.rs | 3 +- rust/kernel/fs/file.rs | 2 +- rust/kernel/io.rs | 18 ++++++------ rust/kernel/kunit.rs | 11 ++++--- rust/kernel/list/impl_list_item_mod.rs | 2 +- rust/kernel/miscdevice.rs | 2 +- rust/kernel/mm/virt.rs | 52 +++++++++++++++++----------------- rust/kernel/net/phy.rs | 4 +-- rust/kernel/of.rs | 6 ++-- rust/kernel/pci.rs | 11 ++++--- rust/kernel/platform.rs | 4 ++- rust/kernel/print.rs | 6 ++-- rust/kernel/seq_file.rs | 2 +- rust/kernel/str.rs | 14 ++++----- rust/kernel/sync/poll.rs | 2 +- rust/kernel/time/hrtimer/pin.rs | 2 +- rust/kernel/time/hrtimer/pin_mut.rs | 2 +- rust/kernel/uaccess.rs | 4 +-- rust/kernel/workqueue.rs | 8 +++--- rust/uapi/lib.rs | 3 ++ 38 files changed, 139 insertions(+), 120 deletions(-) --- base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494 change-id: 20250307-ptr-as-ptr-21b1867fc4d4 Best regards, -- Tamir Duberstein