From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39588C71159 for ; Mon, 16 Jun 2025 13:52:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A0D616B00AE; Mon, 16 Jun 2025 09:52:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BDE66B00B8; Mon, 16 Jun 2025 09:52:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 836FF6B00B9; Mon, 16 Jun 2025 09:52:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 767996B00AE for ; Mon, 16 Jun 2025 09:52:25 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4221BB9670 for ; Mon, 16 Jun 2025 13:52:25 +0000 (UTC) X-FDA: 83561403450.15.228A298 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf19.hostedemail.com (Postfix) with ESMTP id 1CC641A0003 for ; Mon, 16 Jun 2025 13:52:22 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="x/99woWr"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=eAQ5bvop; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=hvdBehz6; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=K021Rof3; spf=pass (imf19.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750081943; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oPo5dP2xx4yCEpwtQyV+S69pInSlZfneHcEHHsBK/5o=; b=XspwAgaJHF+Y6Z9m4/WI62rFFpx4OlMNXhJPwt8xS0pXDqL0Nq2bpue3zrffTyg2P9KYRx YQC35RkHRwWAY2WAbLwEAjiAoKCRnDnW3Ts1dRhtSpW5k3uw3p3D6wkYzF61JGJjckctNf yzsqFaQ1dbjMbVobMA7bUhw0DVWAFlU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750081943; a=rsa-sha256; cv=none; b=spW9Loc2GLprpkV1Ha0VbJOoFUeXmraPKWyToEBbizAyONIbAsjJ39pDtte3EDmSiafT+T lPEWKO8nuZzlCVUO0l52sNjb0Z9Wihck34Bdch7nBDdU+o9515Rl2q7eZjQO5g3Q3lk+IQ ieV1+VHwxfsEXMbwzWB4FO3TNs5HVZE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="x/99woWr"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=eAQ5bvop; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=hvdBehz6; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=K021Rof3; spf=pass (imf19.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 921BE211B3; Mon, 16 Jun 2025 13:52:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750081936; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oPo5dP2xx4yCEpwtQyV+S69pInSlZfneHcEHHsBK/5o=; b=x/99woWrllKp2E0FlvZah0Bz/Y8ZQVPX6bEi8NLk/wyZoH7TFTY8wdTXQPyueE3f2NuHp7 r0AsHScIjkYnf9gy3kwbzMPTyQTkdhJUURUgvaA/54SXWic5A9ITiJoy6XxXHi9f6s12hk ftTnHFUt2fpG5RFL37ajG8+ElndJmSs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750081936; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oPo5dP2xx4yCEpwtQyV+S69pInSlZfneHcEHHsBK/5o=; b=eAQ5bvopSHs8j5mFMFJYjPsq4xvHpwr5LXLy7OUA3uu2kDbMcDPjz/ax+73TPN9YSbLmUz LdA9Ot+xcjJD55Aw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750081931; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oPo5dP2xx4yCEpwtQyV+S69pInSlZfneHcEHHsBK/5o=; b=hvdBehz68NOIPgj6zXx7S3On2ls13+7vkdrV0KWmN9e974nEFuF025M7muV5JYwZdu9+se u6R2wV2uXR4vPDiemMVET5fek/QMH9Py3nE+mL6kjFgJ5xNbT1oBmus+d5KgW2T2welJ8u 0ZRRVl5LzcdUtDUBSiwsPEktYUZ94VQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750081931; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oPo5dP2xx4yCEpwtQyV+S69pInSlZfneHcEHHsBK/5o=; b=K021Rof3kE2oHNm9fiQXHjnjE1x9Z3qLKTW5j66tR0dFQYOp1jE5AFRCoNz1T7VgeBurnV 0jciM26L7Qy+U3Bg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 074F213A6D; Mon, 16 Jun 2025 13:52:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id KJLEOoohUGhHLwAAD6G6ig (envelope-from ); Mon, 16 Jun 2025 13:52:10 +0000 From: Oscar Salvador To: Andrew Morton Cc: David Hildenbrand , Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: [PATCH v7 01/11] mm,slub: Do not special case N_NORMAL nodes for slab_nodes Date: Mon, 16 Jun 2025 15:51:44 +0200 Message-ID: <20250616135158.450136-2-osalvador@suse.de> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250616135158.450136-1-osalvador@suse.de> References: <20250616135158.450136-1-osalvador@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 1CC641A0003 X-Stat-Signature: diphtc7kqbmwu6cm6iwcqdzwea1zttus X-Rspamd-Server: rspam04 X-HE-Tag: 1750081942-921985 X-HE-Meta: U2FsdGVkX18BM7VB9NEdqCAYoIBFAKBWMsXqY7LEfc37NNJbXIMz2oSss3nZRSmVwtaLOymXxzTCFzPYxuu1ofK65iu61tROLVybyntjvFQAJEbWkpIc+jvHJjZGH+v1Nj5/w0hftcRcdsUHEFggy1FsyChMXuRhdqcMg9jP6/QYxX6XmtRyeQkBksI1VzBbUWsqHJUCFHokOXKuGDRvbGwVZShbcriBCzE2SvUZ35YpcQU9PvddI16lsI5bzJcxztTuCm21NoHe0Npx1cYW/uBVGMjeEViHEdIFEG2JqvJ7dywJ60Be16xvYGNAkOIJEnmOORLCoeCIpGU67qjmNabwcVahJSwpAmCWSWuNdySLmgk/t0YNhgyUcmQz75YfoWHeFbHF16b9fakSNbtJG58c1tHPClmpbJpYyhkUPMFUX5mSKBZxS4mOzSu0d+9kCdpETn39L8Om/zbVMGrjrraAsUKvcjFNED4PJ2R2Y9NDvOwtmTjDxfJGWiiUsKDXpMa4nP3acXk3Jf/7LhMdjTRQY40QrX/lBVRgH4AcwRDRg/sGug86mWcQZbXfS3S646G1JFHCLYM/jkAi2RJwECeitEGhLz6O6WdZdDWqrNuXYM7MAt4vx4c9gMpnx7gC4htxapl6jVU9h+DR6pYjU8tz5krd9zVxRzC20VarbzsKlViVpt99XP8l4cE6O+M9K3eYQ5YIHnfvSMG2n/DkKY19b12YUj8oZvBKvNpEcjYduQmW+b6Jnd0vRRC2gCFx1TYK3y16fuL1Hsr7WGnPJVDxNZidrfW55A0BhMW5Ii+xPjguEzHef7QZqnwppsmxriS3YiyY8fdGgfnrZXoaGCtB/mvwWAq3zmWu3S7yq1hXqBWm00WwpK7CDkD79hfbMS8YCf3XZQr5gMeyjy2+rIUSWhyvlsbWu8yE8DoYLTF0eCgxH/CNAkJ9BhQtU3ntJBDntSha7ettUSncwft cfcpzpTC ZNlBoFRivFlhY2f+bt8iexZE3hvHDjYk+Vp+/m43TzQaoaOeJBt+MgP/xp+5xpeSvU8AMwWjY8G2UuWrZV2suSlA2gVOBO+ElLxxF1zgSUp7KpJlUal1eajd7BYwcnd3kaxCBbpXPzij/jh/FXoELctYgXAfsH0j9jwYHGfVbwQRJO01JJkzxlIvkDWo51u2Jq64MKy6IF4j/lU1DBoezVeW1mxvDbySupJbhoKVL+QifbdinNKChQ3SlK/Tf8RelGfJcNmdy19LdiegLjUAt7E7IharxVbvgsrOvaix3fwGMuk2NVqne5v/Wgne+VshswrW0fGG1KJdNDgSOEV4JtQOjeYWT2q8PW813n4yuOqVyfYwlWyMOW+7oi2tkkC1GPjv/1pAsKmV6Rnjmh3Pi6JVel5GOmoD2i0nihD8w1Z6Gjrs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Currently, slab_mem_going_online_callback() checks whether the node has N_NORMAL memory in order to be set in slab_nodes. While it is true that getting rid of that enforcing would mean ending up with movables nodes in slab_nodes, the memory waste that comes with that is negligible. So stop checking for status_change_nid_normal and just use status_change_nid instead which works for both types of memory. Also, once we allocate the kmem_cache_node cache for the node in slab_mem_online_callback(), we never deallocate it in slab_mem_offline_callback() when the node goes memoryless, so we can just get rid of it. The side effects are that we will stop clearing the node from slab_nodes, and also that newly created kmem caches after node hotremove will now allocate their kmem_cache_node for the node(s) that was hotremoved, but these should be negligible. Suggested-by: David Hildenbrand Signed-off-by: Oscar Salvador Reviewed-by: Vlastimil Babka Reviewed-by: Harry Yoo Acked-by: David Hildenbrand --- mm/slub.c | 34 +++------------------------------- 1 file changed, 3 insertions(+), 31 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index be8b09e09d30..f92b43d36adc 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -447,7 +447,7 @@ static inline struct kmem_cache_node *get_node(struct kmem_cache *s, int node) /* * Tracks for which NUMA nodes we have kmem_cache_nodes allocated. - * Corresponds to node_state[N_NORMAL_MEMORY], but can temporarily + * Corresponds to node_state[N_MEMORY], but can temporarily * differ during memory hotplug/hotremove operations. * Protected by slab_mutex. */ @@ -6160,36 +6160,12 @@ static int slab_mem_going_offline_callback(void *arg) return 0; } -static void slab_mem_offline_callback(void *arg) -{ - struct memory_notify *marg = arg; - int offline_node; - - offline_node = marg->status_change_nid_normal; - - /* - * If the node still has available memory. we need kmem_cache_node - * for it yet. - */ - if (offline_node < 0) - return; - - mutex_lock(&slab_mutex); - node_clear(offline_node, slab_nodes); - /* - * We no longer free kmem_cache_node structures here, as it would be - * racy with all get_node() users, and infeasible to protect them with - * slab_mutex. - */ - mutex_unlock(&slab_mutex); -} - static int slab_mem_going_online_callback(void *arg) { struct kmem_cache_node *n; struct kmem_cache *s; struct memory_notify *marg = arg; - int nid = marg->status_change_nid_normal; + int nid = marg->status_change_nid; int ret = 0; /* @@ -6247,10 +6223,6 @@ static int slab_memory_callback(struct notifier_block *self, case MEM_GOING_OFFLINE: ret = slab_mem_going_offline_callback(arg); break; - case MEM_OFFLINE: - case MEM_CANCEL_ONLINE: - slab_mem_offline_callback(arg); - break; case MEM_ONLINE: case MEM_CANCEL_OFFLINE: break; @@ -6321,7 +6293,7 @@ void __init kmem_cache_init(void) * Initialize the nodemask for which we will allocate per node * structures. Here we don't need taking slab_mutex yet. */ - for_each_node_state(node, N_NORMAL_MEMORY) + for_each_node_state(node, N_MEMORY) node_set(node, slab_nodes); create_boot_cache(kmem_cache_node, "kmem_cache_node", -- 2.49.0