From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33EC4C71159 for ; Mon, 16 Jun 2025 13:52:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8396B6B00C4; Mon, 16 Jun 2025 09:52:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E97D6B00C5; Mon, 16 Jun 2025 09:52:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D86F6B00C6; Mon, 16 Jun 2025 09:52:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5BFBE6B00C5 for ; Mon, 16 Jun 2025 09:52:50 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D0B1D80476 for ; Mon, 16 Jun 2025 13:52:49 +0000 (UTC) X-FDA: 83561404458.16.08297CD Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf07.hostedemail.com (Postfix) with ESMTP id 9A55E40008 for ; Mon, 16 Jun 2025 13:52:47 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=THJuL96n; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=L9akPOcz; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Jj8gWIuO; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0Mt4A65e; spf=pass (imf07.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750081967; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0GOPVWW/FS6+WFimcJvKcp1cTSYaDvg9IjFzhzn+sIc=; b=c6w0V6cYJ0cISynlzPBl9A6a+qRt7QFoDcE/+BYuv0GL7C2f286kE9ZjjQ1Czss60xv7ix oIbsEAQKmXLHDugZK6+BUOvZQxOW4l7nZm2vhya8reAA1TbNWOhClBeKjoH1NuLE8tY+Gp hP5EVFIV1k1bzZ+v0AVguWLTv7X2u8g= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=THJuL96n; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=L9akPOcz; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Jj8gWIuO; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0Mt4A65e; spf=pass (imf07.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750081967; a=rsa-sha256; cv=none; b=OkNKPo09pnBK19UD/IVqzHLAA8EkEOdqtkZPgdIXbc5GuB2rooOyOZHyOIIU00u6wlYuqA E0SImHUod6UpdKoxbyJM9ya/k4bg2JBYId1q8qTzgUrXAZB2FtcyHiB4s+Il/H2EH/aQJI RVz6sPJTX0+ho+/LL87ZVUZFsLNTXUY= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A53942118F; Mon, 16 Jun 2025 13:52:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750081943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0GOPVWW/FS6+WFimcJvKcp1cTSYaDvg9IjFzhzn+sIc=; b=THJuL96nOYp9/YhhSRxhZrUfRo/uuzICRAAMeyCqM0Ie9dhRytwEzAkdyG5ZEs2omU0NMf EwK5e/9JfpT8bk4ac4sY4gTbL5vmBX5ToJflt4UCx5D1Li1FCMNZoPBd1isBKqajhKU3T5 TWOUtQhp7k1qeUz5h3irRhX/pMkjKQM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750081943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0GOPVWW/FS6+WFimcJvKcp1cTSYaDvg9IjFzhzn+sIc=; b=L9akPOczaDkXWRuSSsdzbHbRqLaWK/uT6UJyPqpahIeBZ//To1StshVyjJKz15C7OiHrRS jrzSpTccKaLVejDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750081940; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0GOPVWW/FS6+WFimcJvKcp1cTSYaDvg9IjFzhzn+sIc=; b=Jj8gWIuOVbMvge7/vXRbgL0+2Mv2wGG90e0FRIVkhyxn7PptfLW9Si4vnZ70T26K8E6Ez+ COb2aL/kJPsANMiEDAkFSaVp6IZIME9nbq2fSDY2WcoDW5iX72HEU7lKUPlL/SvhDGlb4M Dt1sCnYyn2/BbXAX2Y5gF7w30e/ptOw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750081940; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0GOPVWW/FS6+WFimcJvKcp1cTSYaDvg9IjFzhzn+sIc=; b=0Mt4A65eB8zEM5T92Ncmr2Ji3P+Lm4RSvnVLN/qpulsCdrk4S+0C5O3yaT6xzafG8C6zDh oOHe8mWYBPgyEXDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2838913AE2; Mon, 16 Jun 2025 13:52:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id wKYyB44hUGhHLwAAD6G6ig (envelope-from ); Mon, 16 Jun 2025 13:52:14 +0000 From: Oscar Salvador To: Andrew Morton Cc: David Hildenbrand , Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: [PATCH v7 06/11] drivers,cxl: Use node-notifier instead of memory-notifier Date: Mon, 16 Jun 2025 15:51:49 +0200 Message-ID: <20250616135158.450136-7-osalvador@suse.de> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250616135158.450136-1-osalvador@suse.de> References: <20250616135158.450136-1-osalvador@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9A55E40008 X-Stat-Signature: m73x4gwjh47nstn9qudkzi7dbydmjegz X-Rspam-User: X-HE-Tag: 1750081967-674504 X-HE-Meta: U2FsdGVkX1/D9P8NXx6+Spo1IwqNNf0GwXKfJlfWXNCKbKryZcgbE6Rm7CnHtFN/XdXs44VrXndugil5Wda58DvBbi5L9h8GBhtqw0T52UAtq7VTi+RTIAxWDk5uyotX/SIa+lCD+ZVc77SxVyERbhHva18qxUnYkR+EPDAe1kB4fuFLPDWduBwtv0GX35P58t8VaL16fz6+mnsKRK6q5W1rLlAkkc3IOsTZaXzA6ObnwmWliLD2FARIhh9nmDdo1RoIirdiAiBLXJ+KGF8Yqd0ga/3JkNO702K3blBgDBo7yH4k2pEVmvKZjJc3n3cqo8oAh2nGaTgrjAeBNUHfXIPysQCsPWU/VeOxWaL+bb2MiGoRp+wCjKFUaPSbmqwCj2IHgr7GA2wjgo9peplMAdxTeQQRTSd51vEjG/Git88wPgwAlDMaTYAvAbbc5u5jpJ0FGTHRazJyRzxVzanM78jc4SR8ZB5EwQq29fB621RRidPJbVa4w3X9vVBr78DQFaEptnKjHeK7NjJMwbfuZcgwm0ZNeeVF59fibOFQ6/PkEmy7RdqEYGHbtsyeA4V71iPXV0z/MOLbrk2/bBteKHTqAXiAJPDNL2hp83luq5+e1kJARDCGwewGPNBWDOk6l9oj8SCenfORuHWhi+mE2T6HQSDK9gGLhfb9CsTWchi0LGATXpmIC4fRhXMAlf1C3hFwY8fcmle5yfN46p8QKPdCmyF7G6LyzD6xvDOF/fhC+5y6ws/ACf57K9GwTfPGuXsZelSe4lk6pGkGJxPG/T7hvNH7jQQlDWoQOSAAQT5SHGQom2WmzZcPdD+OXwj4r/F4CxdLLmSL6j9nHjvpa9s93H1m6JYkxMaNeAoSCw1Y/j/+wURKZNW2jlYR6I0z4IflzVdoP0LJ7yzKfPycUENpMaWo7y3WIQz/TqVNbITGgZ0ZJRlN2E2Ph67DAJsM5C1ANVLBFNayEl6QjA8 4Lp2JHX0 SRAMKGNdDagmSOkmuUH9G2CVsRy8OKS55ZPyZMXR+nD1+mAJgeNGQ/XzVkKcUY9BToqOCjaMJH7+VaWfy8GdlE2vcGQGlqtVy3dzqqTPqR6IeaFxzojnjqJizH+otMDJSeeC0Dnhr81Nrqlf0brV8L2+lZJcGj7rUJ6kLR+ZkzGXeWrJeA+ZMQDi7IoIxa17glHvZO1/+CrX04z3Ag4a4LZWRPGjdB2ZaCyEi2zdGnepF9zvq8zGmfBKeKkJ2mGc8P4rVC3ACzSxrFASSRGdvT6MagENw2mjJCxNfjFyvDpCUKEmCnIEcsBl5APM3TYLRERK4ZvWqo81jLXoqMRAnBeNWZ4WQ1+CGlsQdlXZgmNmh4JWmmJMCAXBRT0Cfdu+DZ9RxQsYIlivaokkAuPW2S69LDg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: memory-tier is only concerned when a numa node changes its memory state, specifically when a numa node with memory comes into play for the first time, because it needs to get its performance attributes to build a proper demotion chain. So stop using the memory notifier and use the new numa node notifer instead. Signed-off-by: Oscar Salvador Reviewed-by: Jonathan Cameron Reviewed-by: Harry Yoo Reviewed-by: Vlastimil Babka Acked-by: David Hildenbrand --- drivers/cxl/core/region.c | 16 ++++++++-------- drivers/cxl/cxl.h | 4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c index c3f4dc244df7..261e07302ca4 100644 --- a/drivers/cxl/core/region.c +++ b/drivers/cxl/core/region.c @@ -2432,12 +2432,12 @@ static int cxl_region_perf_attrs_callback(struct notifier_block *nb, unsigned long action, void *arg) { struct cxl_region *cxlr = container_of(nb, struct cxl_region, - memory_notifier); - struct memory_notify *mnb = arg; - int nid = mnb->status_change_nid; + node_notifier); + struct node_notify *nn = arg; + int nid = nn->nid; int region_nid; - if (nid == NUMA_NO_NODE || action != MEM_ONLINE) + if (action != NODE_ADDED_FIRST_MEMORY) return NOTIFY_DONE; /* @@ -3484,7 +3484,7 @@ static void shutdown_notifiers(void *_cxlr) { struct cxl_region *cxlr = _cxlr; - unregister_memory_notifier(&cxlr->memory_notifier); + unregister_node_notifier(&cxlr->node_notifier); unregister_mt_adistance_algorithm(&cxlr->adist_notifier); } @@ -3523,9 +3523,9 @@ static int cxl_region_probe(struct device *dev) if (rc) return rc; - cxlr->memory_notifier.notifier_call = cxl_region_perf_attrs_callback; - cxlr->memory_notifier.priority = CXL_CALLBACK_PRI; - register_memory_notifier(&cxlr->memory_notifier); + cxlr->node_notifier.notifier_call = cxl_region_perf_attrs_callback; + cxlr->node_notifier.priority = CXL_CALLBACK_PRI; + register_node_notifier(&cxlr->node_notifier); cxlr->adist_notifier.notifier_call = cxl_region_calculate_adistance; cxlr->adist_notifier.priority = 100; diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h index a9ab46eb0610..48ac02dee881 100644 --- a/drivers/cxl/cxl.h +++ b/drivers/cxl/cxl.h @@ -513,7 +513,7 @@ enum cxl_partition_mode { * @flags: Region state flags * @params: active + config params for the region * @coord: QoS access coordinates for the region - * @memory_notifier: notifier for setting the access coordinates to node + * @node_notifier: notifier for setting the access coordinates to node * @adist_notifier: notifier for calculating the abstract distance of node */ struct cxl_region { @@ -526,7 +526,7 @@ struct cxl_region { unsigned long flags; struct cxl_region_params params; struct access_coordinate coord[ACCESS_COORDINATE_MAX]; - struct notifier_block memory_notifier; + struct notifier_block node_notifier; struct notifier_block adist_notifier; }; -- 2.49.0