From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2A53C71136 for ; Tue, 17 Jun 2025 15:24:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65C086B0093; Tue, 17 Jun 2025 11:24:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60C2D6B0096; Tue, 17 Jun 2025 11:24:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5222E6B0098; Tue, 17 Jun 2025 11:24:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3FFFE6B0093 for ; Tue, 17 Jun 2025 11:24:02 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0B7C01204AE for ; Tue, 17 Jun 2025 15:24:02 +0000 (UTC) X-FDA: 83565263124.10.1FE8F82 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by imf28.hostedemail.com (Postfix) with ESMTP id 205B4C000C for ; Tue, 17 Jun 2025 15:23:59 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=HZCiBueu; spf=pass (imf28.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.44 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750173840; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1G30twoTSmDNYqYLbQb9BVxeBr+2W0lftNV3Vff6vfU=; b=KAA6U5Khnz4kxQtf027Dc8SOH24n6KChxB1B6qTQ6lBwKPFCz11jbQnn4IVnqpvhHt/Scg Vf6qjSKyTl+KN7j8EgYJ/xyMjTl9bvcPW9oEA4hQ7VmXHLTwapHY2614STpt8+OEPwLDdn YbSRWueKd/YLpQDiwmn+tPBqo+r2IQE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=HZCiBueu; spf=pass (imf28.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.44 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750173840; a=rsa-sha256; cv=none; b=ZmqFWlZYJKoOITXa6xyxVyFHDG1XIGDYpmOGSQjMLZhknN3llbc2zzaHF17Wl0dC+XrWrD Yk09bHUYN7QgMwvCokB3cJ2SsqD6dGEQDFlLOtXaGBlwuBvzYNPxqhbUYV0S+H1SHIbI35 h4Lf2VpB8qwMs8o8NVSNpCNCbvpRCVU= Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-6f0ad74483fso62001106d6.1 for ; Tue, 17 Jun 2025 08:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1750173839; x=1750778639; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1G30twoTSmDNYqYLbQb9BVxeBr+2W0lftNV3Vff6vfU=; b=HZCiBueuh7TNss7mwVkeDRZ8bM8wWweA7ArDuKoRCgw2DvHoM6LflWmAr5HdLoXLnQ VBREvQ9495HGT/BbGXLy9IU8q83qi7+Zq/z8fRMO6iodfYLaKgwlz2Rv8Ky0PWqD05D/ i26puOAhGkYG6FSn+upq/lx2ZCvCTRUKG7FPr1b5Szm9j9JI3X+aOvoNg5Zwiw891PAR fJxQJ7ea2GYIYiUgeK4n9uzNGqQT/VJcjfc4V/RW6EaLypkMxJEzbjbksDD4QXqh638T BdvfEHu6TJeWB8JpD8aCQSSuX/QbAOmfoxSAaZD1QXZAzKqB7u5eR5lVnVs/fDUC32Nr 5P/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750173839; x=1750778639; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1G30twoTSmDNYqYLbQb9BVxeBr+2W0lftNV3Vff6vfU=; b=m/lH4A1WoEd/mGawrVe/rsQRM9hFAhi5/LFIUDYy/10YhS7sNYoAELdlvOyW9IKhxT ww1fOuzknwRdvE8EWoJDGIU2UODuB4KPZvMFhfX1L/6KqFg6Vu/02JkLVFqFipLN0vqv r1QClnSvKoXS6xiHiVyDWk11P7jlFlUrzHbUNMnYh2LuS49YzGHBdRb7Ao2s6zVfh2EG RJVX6Oxg+ITMtA5po2a53eB2MfXu/SgcM8lLuiXBHt8qknZ2J/KS2Ej+YaB4v3bAdYiQ Td6nRPOlVzUNv0lWpxzfwsd5NnrAs+P9BmCCwib8CHeIiSsdyVRJxOiR1PRxhFTbWRf7 BqPQ== X-Forwarded-Encrypted: i=1; AJvYcCWHa0zg/KxDS6ZvwgtgIXRV122n0PuiKhZuDc2EhIls+Dt1E2WU5qKWzLy1i/+BKwElk6WY+adVFQ==@kvack.org X-Gm-Message-State: AOJu0YxFfyIKg7YHew/FreNmjkwDsDXlXO5ZJBF6JOwDgIjiniCEqQ3h GQBDPMQ6paRTfdrxJlOeoVWJyBjLZwTMAMK6RBbh1Ea2vSCrNpd2JGvsyOFqh4mF7Ms= X-Gm-Gg: ASbGncvR3RefgmB2Ioqm+jsM18+yRdA8/+g4SvLYG/X05/5R+hicpQbUAcyOfhAdLmh yGwUTEjxMWjo814zQ9wHTUSEd63NXsm9Ru+HmgVMrcEcUGLnq9jk3ZrxuiQaLbU7HISDYp3SEsN cDHf7WoR1e2yk5pOZKr8EwNRiHUL42/9O2LHJ57Dn5SalL0gxKk81T0re7CUPhW9sxiAk5zqb0m 5J194SZG4z1R25ThNEaWplT7uAdm2U1rlzWEAIBDcoZ2tFVEy6QDTgXZlOaGwNFqtYGesaSygEX wrYpOHgfeGcqfeYN0iRlHiZ3n0lmVLOYxSfVKx8HcnRJUhQlAN4gMaG9X1qCkEL1tZ0aiR+4l11 18jB+0AUBKj75eiHWychnI3nuwHAvjg93+0QTqQ== X-Google-Smtp-Source: AGHT+IEoD6WfW4XcrXeA6atAW+1ffW+wg1paWr3c3lf/SNV5jhl70hbs0VEdmHRG0GMaJ0zxaZAYmg== X-Received: by 2002:a05:6214:20ea:b0:6fa:8c15:75c1 with SMTP id 6a1803df08f44-6fb4762f389mr178635926d6.2.1750173838901; Tue, 17 Jun 2025 08:23:58 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-167-56-70.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.167.56.70]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fb5f63431bsm7780936d6.43.2025.06.17.08.23.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 08:23:58 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1uRYAH-00000006W0E-3mNh; Tue, 17 Jun 2025 12:23:57 -0300 Date: Tue, 17 Jun 2025 12:23:57 -0300 From: Jason Gunthorpe To: Pratyush Yadav Cc: Pasha Tatashin , jasonmiu@google.com, graf@amazon.com, changyuanl@google.com, rppt@kernel.org, dmatlack@google.com, rientjes@google.com, corbet@lwn.net, rdunlap@infradead.org, ilpo.jarvinen@linux.intel.com, kanie@linux.alibaba.com, ojeda@kernel.org, aliceryhl@google.com, masahiroy@kernel.org, akpm@linux-foundation.org, tj@kernel.org, yoann.congal@smile.fr, mmaurer@google.com, roman.gushchin@linux.dev, chenridong@huawei.com, axboe@kernel.dk, mark.rutland@arm.com, jannh@google.com, vincent.guittot@linaro.org, hannes@cmpxchg.org, dan.j.williams@intel.com, david@redhat.com, joel.granados@kernel.org, rostedt@goodmis.org, anna.schumaker@oracle.com, song@kernel.org, zhangguopeng@kylinos.cn, linux@weissschuh.net, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, gregkh@linuxfoundation.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, rafael@kernel.org, dakr@kernel.org, bartosz.golaszewski@linaro.org, cw00.choi@samsung.com, myungjoo.ham@samsung.com, yesanishhere@gmail.com, Jonathan.Cameron@huawei.com, quic_zijuhu@quicinc.com, aleksander.lobakin@intel.com, ira.weiny@intel.com, andriy.shevchenko@linux.intel.com, leon@kernel.org, lukas@wunner.de, bhelgaas@google.com, wagi@kernel.org, djeffery@redhat.com, stuart.w.hayes@gmail.com Subject: Re: [RFC v2 05/16] luo: luo_core: integrate with KHO Message-ID: <20250617152357.GB1376515@ziepe.ca> References: <20250515182322.117840-1-pasha.tatashin@soleen.com> <20250515182322.117840-6-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 205B4C000C X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 4sejb54bqbbfzkth5ep48dkouhw5izfk X-HE-Tag: 1750173839-941075 X-HE-Meta: U2FsdGVkX19ifkloaLibo2FIIgmQhRC+fQeD+ddMkbsSh78GFxnYwQ6bhTiewhr416JNpF+Ewuzz2pIZ6NIOrusM77olTUH7h8/50LzDWSU/ZofM/nxSs0bpmOEL5XDBu49cchaw8Q4QIyC/ZFtpJUVdOaqNplbLDXQq1P7wq5bak3CiWQBstVCgdvcRadPpqEzYtIvI59ye8tl8ifphjBEgU5aZE4QGkuLQ/cyiEgomt+Q2P4T/y61rQr2Tov1ALPaSkAD6xXoJg/DFbEXzAXwKdtQRuFxe8usd8vIa00txJY/x9uSciwmRynqHLboSDW1C8xXOEy2zLLV/RBHtcI6cIUzrKWUnG/Z5DXm18gPsFWYTkg8w9ixYmHVoZyrXkDqo2/115GKXly9sLRz+CZgJkRq+7PHo9LYtz9XarmtcxHQQ5afB4e5Ed+59BZLjg8f4fo9nlLL/NkQNL4lbY7O3ELyJgS3M6WcNJxA0qW7MbWUA5VVzqo0v9rw4BmPR8JG627juayIdpizI9CXI5W2dsXGILLoLcO99b3KdifxR1ICcUSV76zW0c73jpJKirNp7+Z1Q94cmUdiUrZ5WKoSAP6GO6O3gqi6eMgPp8jrRy9/g6euDlQ0R9DOegUBTFtI/wIRvKJlm0p+xvdQ5NKanx+y86cl0fs39aNTsvqvDDhA8bF7RaoFgIM71SlPeCOQ/mDd8hgAIqnOzeeQh9bF5wpBbAIWqWw8b1IDagRiddFcM8XPryUeodQQwxqgfCqglPAK31ZRQai4VXnNy6VDQxCSwFjm3row7hiq4ENteELPkqjduOpAR9uUBK6bcgwx2ETX0S+klnqb9CeZvPRaRIRs1sYLjYmraQ7eGRSL931O8GvXKYZrKnR7avVBIAz5tptU9fjaeon6iT9w8sYg/ZDJ8lVcqXUzcr0L65w707LKDvvjAtinDAzvXouIZMBMucO20vGhFzkmfMLg dimj8UHU Yw/TLpdwgLOEAyCKQm14h87OV9Lu+D6iB/gDk/WY5hQCOSSsilLD3cHjxG0MPb9N1z5SGGEX5Y39ZpBoqSxBFtlQJd58syFNzm9OFUcFBkoRydupchAeqv2A1SfQD4uBufLACKbBVGFdb5fcsRkTS8Vlqa3oqr46PGMyJJ1di9fnf2kpeuy1guzcAuTwXf+1j/36zJ3Ve6DI/dboEMJLCUmKvEfL+dstZjAdO4641682xx4VH9klabJW3Q8YrdlGV0NDiiykDdXmwAlrOS4gARXABntVedn2j/3ZYvLGVUfoVTFRzp+6o3O66hTI5BSAnTfziV+LRiCkP+VIZiUVBaVO7FpsdsqS+E3fBw5Bmy1c/prjNlbpPZuQGEo2LkQBm8BI9FTeu8DcJ+W8Qnh0Rd8y6ng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 13, 2025 at 04:58:27PM +0200, Pratyush Yadav wrote: > On Sat, Jun 07 2025, Pasha Tatashin wrote: > [...] > >> > >> This weirdness happens because luo_prepare() and luo_cancel() control > >> the KHO state machine, but then also get controlled by it via the > >> notifier callbacks. So the relationship between then is not clear. > >> __luo_prepare() at least needs access to struct kho_serialization, so it > >> needs to come from the callback. So I don't have a clear way to clean > >> this all up off the top of my head. > > > > On production machine, without KHO_DEBUGFS, only LUO can control KHO > > state, but if debugfs is enabled, KHO can be finalized manually, and > > in this case LUO transitions to prepared state. In both cases, the > > path is identical. The KHO debugfs path is only for > > developers/debugging purposes. > > What I meant is that even without KHO_DEBUGFS, LUO drives KHO, but then > KHO calls into LUO from the notifier, which makes the control flow > somewhat convoluted. If LUO is supposed to be the only thing that > interacts directly with KHO, maybe we should get rid of the notifier and > only let LUO drive things. Yes, we should. I think we should consider the KHO notifiers and self orchestration as obsoleted by LUO. That's why it was in debugfs because we were not ready to commit to it. Jason