From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0C62C71136 for ; Tue, 17 Jun 2025 19:46:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61BA66B009E; Tue, 17 Jun 2025 15:46:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F36F6B00A1; Tue, 17 Jun 2025 15:46:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E2B66B00A3; Tue, 17 Jun 2025 15:46:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3C4526B009E for ; Tue, 17 Jun 2025 15:46:34 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E84DF120CA2 for ; Tue, 17 Jun 2025 19:46:32 +0000 (UTC) X-FDA: 83565924624.10.E7AA326 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2082.outbound.protection.outlook.com [40.107.101.82]) by imf03.hostedemail.com (Postfix) with ESMTP id 231C420006 for ; Tue, 17 Jun 2025 19:46:29 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=kNsNfLxW; spf=pass (imf03.hostedemail.com: domain of jgg@nvidia.com designates 40.107.101.82 as permitted sender) smtp.mailfrom=jgg@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750189590; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=adlTw0BALeWFW/5VtFYDUbT9WcsWjfcLz89yoghOEhA=; b=7PexOxfiXJLcQtksiG14lLM4pBJ6Wgr1l5A6YpNNzTYZvUB5meTXx7QwwSaHcs4lpvc9u4 4PdaqM5hTZc2QiDDg8fW3yK2PtrTRxoG6bOuHah5uEtmzaLwESNmH42xUiVygYY5YycxRD qFs2zB4zv5pTtGfCgQf2ZqtXPr1W+YE= ARC-Authentication-Results: i=2; imf03.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=kNsNfLxW; spf=pass (imf03.hostedemail.com: domain of jgg@nvidia.com designates 40.107.101.82 as permitted sender) smtp.mailfrom=jgg@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1750189590; a=rsa-sha256; cv=pass; b=6tTrcc/gybWyDDPn584ttWHZcX2b5giVpwBb8jaNPjHdpOdNuTErNRpY273Nbh/tnMSgBF HX7PVGExA2ED8cIygm9Sx1hihRmh5uihpaJpEJ0da7/DXe7ybkeaaG2xi2fwYrA4yS2zmC fRPQNvbEtWVv5eECfihctiB2zQG3/Fo= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qq3oJSEgG1lv1a66RDONCQ5xIAUyDjWyRilaMfvwAO9fDkYFSpBgWs8mzNYfxy4FlutJYg44X7x3q5a9uaaGZgkzZv2FUO+tBiFA19o0Fw9JUxPHg4VzNGvvzK4CfAOTfYYVCSegu1Cu0OLO+YuTPtbU3Ti4e3bLLUYXpuugLRKTt8qvGroRYZ11v+RAkIyzpeUmvi1oCcBMwUDZNLQ7Lsj+WR2pDfOkJitD8I3OkvIozcDtlr2pwn5rY+s7pQdhJVnRv99CantM/x+UXc0Dvn4yxX2bjcWISyPVio0N6SCaIlNe3p9b+Etv4QWY/0wZyHrNRBb+ma+qmooPZKIOLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=adlTw0BALeWFW/5VtFYDUbT9WcsWjfcLz89yoghOEhA=; b=rCSHUnFVBSpE63oJeka2+sq4yyfLZag8TKkch6jdLVlhiMGVhk34o2zB+rR0B/Kiol5nSApyIwScdRDjMW3U6xxt2PneYeMcr9uGpYpgixgH+er2UFeYgqca7Net0PDf/BEbncEb+9Ob7hJ50YfhcnMHSM5I5iNN3RjYm8xy1+LMATh27ZZHLkVQcwnxx+C9NaYLNI+ke/9fRp4Cy7eHg6y946FX60aR9kiMJFEl+IHn1tT25fS24rWbJZWKIDAQ9f76xDI2lSLkSFEX8W6kbcYDqj5HsoclSj8ajTEJJ6EfE7+PPo0MwkZ0ylH3JLAz/9VHCjAauDkH1lG+yKjs3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=adlTw0BALeWFW/5VtFYDUbT9WcsWjfcLz89yoghOEhA=; b=kNsNfLxWer1C8EPTqwYaKTgQw5r7MR1vJdldbOU1MliW3i4YfCCRXUONx8cv5hGBH9aMVVHfRWGZ+2H77Qqb9vCaFfg1zcZaqSH+T28yIYdUj/H13tJeUAQvR7kmIfOzbctCtbbDn6kqJdQA8/huGv/mMXlYtHQwhyA0DMhUmB5KM0dmeO85iwfD/muiiqDFRXfHNnOmZFTICgxvJiysfXxBxwmbbQTkduWKjRwMCdCYRCJARSIi6dcmMtZl9kZr9pK3fYdVAURjkzzqEWHSE3Y4ifqba7P5lT/ALY40SlqSUgdi4ZWpWWp03gw6ZUGbHcL/rX+kHolRbROhFqJ/fw== Received: from CH3PR12MB8659.namprd12.prod.outlook.com (2603:10b6:610:17c::13) by CY5PR12MB6430.namprd12.prod.outlook.com (2603:10b6:930:3a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.30; Tue, 17 Jun 2025 19:46:23 +0000 Received: from CH3PR12MB8659.namprd12.prod.outlook.com ([fe80::6eb6:7d37:7b4b:1732]) by CH3PR12MB8659.namprd12.prod.outlook.com ([fe80::6eb6:7d37:7b4b:1732%7]) with mapi id 15.20.8835.023; Tue, 17 Jun 2025 19:46:22 +0000 Date: Tue, 17 Jun 2025 16:46:21 -0300 From: Jason Gunthorpe To: Peter Xu Cc: kernel test robot , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, oe-kbuild-all@lists.linux.dev, Andrew Morton , Alex Williamson , Zi Yan , Alex Mastro , David Hildenbrand , Nico Pache Subject: Re: [PATCH 4/5] vfio: Introduce vfio_device_ops.get_unmapped_area hook Message-ID: <20250617194621.GA1575786@nvidia.com> References: <20250613134111.469884-5-peterx@redhat.com> <202506142215.koMEU2rT-lkp@intel.com> <20250617154157.GY1174925@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: YT4PR01CA0440.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:10d::16) To CH3PR12MB8659.namprd12.prod.outlook.com (2603:10b6:610:17c::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB8659:EE_|CY5PR12MB6430:EE_ X-MS-Office365-Filtering-Correlation-Id: 52ed5b9e-29d1-4739-f4dd-08ddadd7a330 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?bheg/ZyMqmMFdpt6TXJQMRt+wdap9olDLOX4qDexUOVC3iiXqOCCqYyYG3TE?= =?us-ascii?Q?Af8g6ttBPRN/Y2u1EI5p8/2OOkyQ3FZj/9sT0qpDg/1KKT1WLEhTbnazL6sT?= =?us-ascii?Q?g/Ajx5BcJrJEhght82KyA27BGci5a3O7R77EKDzJqnyVkooHUC60G4BYHIHU?= =?us-ascii?Q?XueWW7uJqOHbgncJKj8TMBGFEZFv7ZMV9bLRs6GR/dOw4fvweOr/m2dv3HvJ?= =?us-ascii?Q?Y00cJrFq64vWWxEapza3o7WM1V0Z/QxKXdxqN8MBi9CDmduv8R2oUAM9hB1v?= =?us-ascii?Q?fKJ+XfBAUEAy+BbeARTGfYf3iseXOKDWC5TCymythGwh/AjLVXiP9xsGS/u2?= =?us-ascii?Q?2taT3mjKM9FedE3J4qnafNQSxgEppsx5vsiYrJbFWV+P4vdZEhnyORICymdU?= =?us-ascii?Q?DSlUvPBntf6T44VkRpvjA51IKjCm5lUiJi/m6XEuy5vLALfEsEjboN+hn0G7?= =?us-ascii?Q?yT7wndI/TlqCBGQKwOXCWjjOHRZhJqa0HVCw4Qwxy9/mXJ/MNKZzIb1tLn9Z?= =?us-ascii?Q?9NlQ8r3EOnCX1zuqw5SVA18F22ikhD8QUJejWVzft7aV+c2mZkP8Xg5taCKX?= =?us-ascii?Q?ArX3/495WvZVs8aAH9Qr7rkRfFarFfuBd/yvGjy8IDZvwRHlu3EdUoTFIyh9?= =?us-ascii?Q?scPcH7hVmAmAP5MG3KLEYIkn8PY/TSJ1VGGaMCx0wj6yFzz9zgy3/jfo02jt?= =?us-ascii?Q?EMc2JpZC4OozmVX04vfv4285QiPD9H1lFdjNJ1cPASJr5s2ku/LzEEEbb4jz?= =?us-ascii?Q?lQJ1HaXvkVoGdTe+dBEVl9p8aWZSmx4r1+vvrZx+SPzn0292nzickRDuiNts?= =?us-ascii?Q?4XfI3m+goNDcGeS93xNyc0O3qNH7yFLTc2mycuYtRjCCWW+HZdFik0UslJGP?= =?us-ascii?Q?KdQWbm6uKmF+TGkIVecDwOcCZNXbDcbJQ3JQl0ZDZzmglK7IUQr7V0W+VeiO?= =?us-ascii?Q?D42n5YHBhfS9ZMCeSgdjfEYS8Tp0FGzeIgwnsjYZnmfrmtYph1qOPvTtHsmy?= =?us-ascii?Q?l0cFO1bb/+jKdM8iHXBq2xKl8pE8aemL14fvWns+XsM3izMDLL7nr+zJS+Xf?= =?us-ascii?Q?gC6b1Ny4YxeiMxnHB8gd4wTInx4Rtma7wbr5GAiVrG4tLh52tqlaHugUVkHO?= =?us-ascii?Q?cCZ2heN5l4VWOc1sd2Y9fhqWyR8FGTOBJyyuPJ47XhehCMFwPNXaD73jjMKB?= =?us-ascii?Q?oabCbz3HZ95ipJa4rKJI/m/CW3u3NlicvCpfHU3mKqLPQWH9JHHEJlU0JbhY?= =?us-ascii?Q?pl0d13NsMeJ1ZNJ5uCh+oOGBKdEb4CqBip0NX285dsxelfe91cL96qtV9jfA?= =?us-ascii?Q?3HIe4xSbF2ORJ3jUjYCC3EYTo1kQKDxBkwJgEmW6p0k0EVDTKmw7AxEZQ5fS?= =?us-ascii?Q?oiLU1K+qjTwkUIaye1+HrOKaOf20dOx+F37tzXvTB8/5ARC65tks8I4kiR/5?= =?us-ascii?Q?rZenmNtcweA=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR12MB8659.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ItIvZdAWSYXMxowzTwr2iwfoUnTmgZcTAg3k30W5Xci2P8uTaoL95AILik0I?= =?us-ascii?Q?GA7yAuJSYzzi7SitLnyUspAjArwK4xiGvqfxbfnuI1GsDZco6D9BeGUVZLpt?= =?us-ascii?Q?lMD0dLea3bQKbA3QVHbZ1Gw9luDSU/xzEMvhaK73tiOVIDKBHg/TT3QiA5qt?= =?us-ascii?Q?MPtnIyEEZ6evZ1d3QpVzlNoicHBBK+eNShtup5AEeYweUoVVQDGQvVoRN4Yq?= =?us-ascii?Q?+HuN8Y8xrTH2w1Ya71fv6BCFiL6XPUaCiwB2gWd8SlBrctr54zDgfFy2cbtA?= =?us-ascii?Q?SjFywKVjGoLl3vdgUWpgcAS3nhwPG1YZM5CUsYBDXMM4pj/b0mNusWWMUkXe?= =?us-ascii?Q?3B9L8h91HYVkJMywQJP700+VsG3zVx9x4DQtS5Sxi+FQp/r2GMr/F1xdTgka?= =?us-ascii?Q?2lgsnDPr3RLtltor1jcGRUDQCAf/mAmo7laZvsC5SpjTlXpRdTAeAnoulc5F?= =?us-ascii?Q?CGtOzv4985IBt+7+pvFa/FCmBtbWrbk/Fx0rlHWyHjPPmf+fL1oxmykHsYG7?= =?us-ascii?Q?cL1gA+7U+DXgIfXGf4N3/WVgEgvmsMX6qgXai6FHFOH9+sK4sQYjJZmcYt5i?= =?us-ascii?Q?RHj0QWp0SfoRdH35T9WtFv5/gES02/4WRv7U30ft76sx0r1q/wcbJp+GuTS3?= =?us-ascii?Q?9Vh5nYE1BhM5Ave5b1SnPGgReW23EAnVocCrixGYFgycxf9/hSdayb4vra9k?= =?us-ascii?Q?ZoTH03jF/rC7era2C5/ToTwSAZehwYDFpdLYI2CIvcC++FW0ZKCOAyfqtyXj?= =?us-ascii?Q?CRLxxcMWX9fy2m+zQuWj3t8bTzwT9a47oapeiE3AUQnMz7qg3miFmloH94T8?= =?us-ascii?Q?hWv7P32Uc6RCPeezZ6tFwYd23UOEw+/rm4axG099qqgIQoVjuWZflgB+e4Go?= =?us-ascii?Q?o4HZVMrZr38jowP4bL9h0DSibQbtdHtgvwXR0o4z5vVBfaAaK2Lhf5tNahdM?= =?us-ascii?Q?wmqzqmtkm1wf6Y2G+jL+4OdiJh4FgMGDgk3HkcGQtGVMNIojxIMgov+ktP7J?= =?us-ascii?Q?8ZUWiK9BKiVk/GDeddJhbKEuPvxbKbVeuRoRPQF8FYWrPOXNANJEmX5om43D?= =?us-ascii?Q?MaaSlW+Vu19WWKqy/F935EDzMPsl1H1he2JJ7avIIEkJLCnRx3rd9hE15lEU?= =?us-ascii?Q?TdiE+8/EjsBZl+v+48PSSl1mw7f45LhkAKVTO5hpelNmJiG3prg4O+kizphv?= =?us-ascii?Q?LCkFM5ij9ikiEEWFahkT+SnA+CEDxMVGBNW09DL8tuVAmhmNZdCDUH5uCaG1?= =?us-ascii?Q?RcVAqinl0/uaoYccN4RCKu7I4hCYuXOSOvqDI0X86HKlGEgaERjyI2Zyx7TO?= =?us-ascii?Q?Ur/O24CAZc8WE7VM0xyjn+D7Qxv1HoVRxxnVTboHro7sOrNLEtfKgzkGhF1p?= =?us-ascii?Q?dOKdtgyZqtulXcr3JeEBia1U90ZjwviSc2j4c0eQReOMg1YWAdYH6oq6e/VK?= =?us-ascii?Q?Ais9HxP0dSEIqeQRN5scxUXkW4wNv2e9niS+WuHVaoMxcbGK/ad+996Vieu3?= =?us-ascii?Q?/+bZO9LZrakBn0S3Pd8utZzx4pnKCMltVTwOktUR2s4/XbM+JlMpUk1j3wqg?= =?us-ascii?Q?wzC9LOPk1RKJSis/VzdgcvHGaak808f/9m54ru6g?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52ed5b9e-29d1-4739-f4dd-08ddadd7a330 X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8659.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2025 19:46:22.8443 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eCWNLjYcF5E49aHsbFyrZ8D9aW1pmDoEqZkVXvrDGJE6airu5nJ2n0adEz1mqLnc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6430 X-Rspamd-Queue-Id: 231C420006 X-Stat-Signature: mx9y8o5yypew7qnwfp9g5xqxfhfrok31 X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1750189589-995583 X-HE-Meta: U2FsdGVkX1+s4VTVQG94PvyD84uQBUopVLr/qJCPb2JoiLGXbhLwYYPYAWFb9U/g2V0lJ1C6KIfogTc25cne3pamghR0p71klP+R/tg5A+xcW/zYbxxHXWnE4MqMCTMrsmzIpTuqHtVpmbtsm/Uo1xxAdwpAGQu6fp9KgmktMHQ//JjWYBZlFrQ35Dgt7uv+yMgFHKI+RD4EvrjuYBcwrMifbnbZ/nBbp+qJLxLqaMaMmJIOqGMmFI7dMq3ylTHnZGXhZ68uW97IkefZTE69nAFpsDhoo9K6GStpbQb5qDGGNk4ImciFRVsufF9af3ibvfJAvE9vyNo8+6nebm48VVJ7efUgoz5RSdUsHCkLInnNBZIYnlluzfLBaQBW/ATNlfrm+/hVU5JwI4vAqB45EQftyH8gQIBZvh7TVl53shKGiZaa1IqB/tcV6HDBnpjEKo42/DComth4pFQCef3ZnTtAdaPEktaEc63ZdSxcBmcR3cSXxJsXumZ8wVP6hvIBpO20JWLUe6tqEwJAkUkWdaSsHHTfF8dpED6hZqTb/PFOQZLHerkso33zFMmYpOFr+PPVI7H+Qw2qQTRv+B0x/G6VA2jY//bsx13s44Uzetf7SYrv4ptolAsphEPQ02yvR1pK2fI0+vEXywOy/UBzDkzcJtMZV+IJIjFM5g/TS6LTIM1UNPaTAhuWWW6/1SUrFnafFX5jkxrXE0iKPzD/fCuX4ekF12lKkHbNmAYJhzm0ZSX8BgWTWhlCv6qJd8tVsdaaXLY2dRQuw4Dah5rZNMUxEmx+vATZ+i9p+R+lAgWkb3Ec9sw+W4dl2676z64P/Ms8uHiADm7VYTk1Nr/fBmTh5Jvxw2qnEptjIYQKoghuRd8S5RgTX63osPA2E+RQa7X4uuqEKMiQx9LjRE4ZE9evsrf/Dcv8LmRD+evjcoQy8mPXYuaZPjcK4EGPES3MntOXmjzWgsySvdcuach 5aJja3WL gaMvNNWsDsdxx+qMOeExWafTEns6BK0PEL82t7RPNo1vr971M5JRElY/Qg2l93/Ko4s9bsIqSohbnlDk7RbgS1fjkLJFRrTVZVYNRXerqushpizKX1S1LF9X8/z7e8anQ5n/F8G7f1aFSi4e7sPD6jMfrE3oqWghhni/954hwwAqEg+AQ74hz5ECOYjWyGTPiclkhftqhZfZwOepNfkXYfVx5gxG2cEoul0SpE7VqM7XAH/T4Aqb3ulDsBp/w9iIHBA2KLIUnGHNWkM3ge+Bhl/0rhihn7wWTmYs0J2gUD3OKYVqPm/q2IhMgx2Cjg+dbjgACq78TTdCHWBbbCGySlpbCjVGAW104FailYJAZFMrc8mRDEZJesUmk3cMJQusVurjPUUW7JmdpU/65L85w31eU50Lo+XlcXdDEfu6gt/xJ9odgnj/buHEC2E8LrZTx7LJGMhtMTW29F/7HaiIl2COpzVpsOzhlp8GjIa4p5MgZhM1MHb7yFMKJC7yWHB+gnqXg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 17, 2025 at 03:39:19PM -0400, Peter Xu wrote: > On Tue, Jun 17, 2025 at 12:47:35PM -0400, Peter Xu wrote: > > On Tue, Jun 17, 2025 at 12:41:57PM -0300, Jason Gunthorpe wrote: > > > On Tue, Jun 17, 2025 at 11:39:07AM -0400, Peter Xu wrote: > > > > > > > > +#ifdef CONFIG_ARCH_SUPPORTS_HUGE_PFNMAP > > > > static unsigned long vfio_device_get_unmapped_area(struct file *file, > > > > unsigned long addr, > > > > unsigned long len, > > > > @@ -1370,6 +1371,7 @@ static unsigned long vfio_device_get_unmapped_area(struct file *file, > > > > return device->ops->get_unmapped_area(device, file, addr, len, > > > > pgoff, flags); > > > > } > > > > +#endif > > > > > > > > const struct file_operations vfio_device_fops = { > > > > .owner = THIS_MODULE, > > > > @@ -1380,7 +1382,9 @@ const struct file_operations vfio_device_fops = { > > > > .unlocked_ioctl = vfio_device_fops_unl_ioctl, > > > > .compat_ioctl = compat_ptr_ioctl, > > > > .mmap = vfio_device_fops_mmap, > > > > +#ifdef CONFIG_ARCH_SUPPORTS_HUGE_PFNMAP > > > > .get_unmapped_area = vfio_device_get_unmapped_area, > > > > +#endif > > > > }; > > > > > > IMHO this also seems like something the core code should be dealing > > > with and not putting weird ifdefs in drivers. > > > > It may depend on whether we want to still do the fallbacks to > > mm_get_unmapped_area(). I get your point in the other email but not yet > > get a chance to reply. I'll try that out to see how it looks and reply > > there. > > I just noticed this is unfortunate and special; I yet don't see a way to > avoid the fallback here. > > Note that this is the vfio_device's fallback, even if the new helper > (whatever we name it..) could do fallback internally, vfio_device still > would need to be accessible to mm_get_unmapped_area() to make this config > build pass. I don't understand this remark? get_unmapped_area is not conditional on CONFIG_ARCH_SUPPORTS_HUGE_PFNMAP? Some new mm_get_unmapped_area_aligned() should not be conditional on CONFIG_ARCH_SUPPORTS_HUGE_PFNMAP? (This is Lorenzo's and Liam's remark) So what is VFIO doing that requires CONFIG_ARCH_SUPPORTS_HUGE_PFNMAP? Jason