From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FC69C7115A for ; Wed, 18 Jun 2025 17:41:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B57876B00CA; Wed, 18 Jun 2025 13:41:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABA8C6B00CB; Wed, 18 Jun 2025 13:41:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BDE36B00CC; Wed, 18 Jun 2025 13:41:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 76C136B00CA for ; Wed, 18 Jun 2025 13:41:43 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 497D4120844 for ; Wed, 18 Jun 2025 17:41:43 +0000 (UTC) X-FDA: 83569238886.03.8EE0CC1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 1D2C3C0006 for ; Wed, 18 Jun 2025 17:41:40 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ORQqGOTJ; spf=pass (imf10.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750268501; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cBlqU3v31THD5gXpB9nn15wD9nofG3PBMtxlPOPDIeI=; b=yLyh3GIrdiNcyE8BOMsjlvjkGZNTnK74eOK38JBBmTbtDOfC+GqkM1Gl4K1dByQ3vbibWa ucv7n2+YC4/dZuw4MpnCyMj/xLLemB/Xelzb/+amwZ7IWT+KW/TGtPNZgIn2f1fg7NRFgb YvLvO1lnRCCFQvUnM1+2+PxdCS5bhUg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ORQqGOTJ; spf=pass (imf10.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750268501; a=rsa-sha256; cv=none; b=a8Elep07ZFckgh725jYNuEvSNq/l7DlorJwEDwls/qVdszJ3uBvaFZlkDdAOJ8HI9V9XtJ WyUjGFktfI23PrzSPF7vywqm5qCxwrBLOq7lW/oLOMRxb6waNQD5X6bIhJ0/1WFAFv5Zjw +gzldw5VeGxGZyzVD2aY9qKzAtqIlZM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750268500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cBlqU3v31THD5gXpB9nn15wD9nofG3PBMtxlPOPDIeI=; b=ORQqGOTJcHS3YtHnoIs6b20qDNjnzwdED7T30fJoZqqyrzwAFvz4DmKzUH26CTL04yxHcA HSuNgJB6FFYdhRy02hOK2QzpJh7ILANb8KbdZ2bBH3xc8liq8xpsu7K6fIysZrwX7kjtrn zJ/8poY7UsESlEDwEYkb9mxT4wsbSIw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-6_KmYfOHPHWi2-3SeqkiSA-1; Wed, 18 Jun 2025 13:41:37 -0400 X-MC-Unique: 6_KmYfOHPHWi2-3SeqkiSA-1 X-Mimecast-MFC-AGG-ID: 6_KmYfOHPHWi2-3SeqkiSA_1750268496 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-450787c8626so55884125e9.1 for ; Wed, 18 Jun 2025 10:41:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750268496; x=1750873296; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cBlqU3v31THD5gXpB9nn15wD9nofG3PBMtxlPOPDIeI=; b=mYvoAZa4USCoquMMS9TRMjkUHJWrgSNIvH2WG0G+M44kiAijjpmWvSdAHtYdt5l4bh Pdgz/xNfqDrZ1tsWIonkLLLvHrzin+wLT+atXt0iPOerF7wf/j+IzpA/moYyUM9HaPpc FrHMdp3U5/FrDu2DIVzkgNQUv7Y56qanD2tmXss1j6SiUNm/EGsaFofAY31DOoEuI2vD sg7DTzIFzoGe7KI+FxqXMNluDGHfwBAPhgFO/L4pxZkT6dkMbLpj1OFyc/QNy3KTUMtq 5GEejG4+Lg1N25cx66mjU6WE6i+cq8rXE0EFr+cmVgE6QwmjY6LkJ2eXOBr5MzJjRsYI v7Gw== X-Gm-Message-State: AOJu0YypNNGw/sRlH86G1NreNRMi1DcbHwOByvLH4m+7QI3ANInp0RDf 5ZjAMa++fkyMQ68BsQ8H6+JIZA38NfngsDSpiYZkMhQ8Rcr69rMCDjEnxK5BKzBxh9tQakcKHRi 69Hj9eesa2ov6LQJPBtL+j6cJE6VG/B939bXmoUuorKOcEmXR/Ygg X-Gm-Gg: ASbGnctqMrNgVCNghdVoheCbzTQbnJLX4MhQueT46A7qKuhhLK6rhAB3EpRdUO8aFbp /qHAK6GcvMas5aPA0SJDK1JFuviawxPopTysala/4beu3kT5Pd1KguOLDbRg1LGN97U4JNAFQKs Cbc9/zM5ozcZQBvymEqZ2r5Jc6HRikZBypIirJdzP/JLcvcEEEKF6bU4hfRG+fCuUtobXhihVql GLENb7k6foUxKKGi5y//IZlOKkZcEtDomNxJC3ZFl3QlqkMNR1ljcmNxkLrN+wPkObUsSH5KJaX KLHa/QAfrLcT9cbE0yd9Ynp9bHHSlo0/YkCiwGxAfJ3qSKEf+Cull7KsFMtePvQb5lFSQaw2iGo vpjiwFQ== X-Received: by 2002:a05:600c:5253:b0:453:66f:b96e with SMTP id 5b1f17b1804b1-4534219a64fmr154424255e9.11.1750268496123; Wed, 18 Jun 2025 10:41:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFQJSoFqz4Qx4eaIpu3abT7lqqTMcn+cWB1r/wxQDnmsMcckQg5l2MzM3eBNzoSDxLAyECFAg== X-Received: by 2002:a05:600c:5253:b0:453:66f:b96e with SMTP id 5b1f17b1804b1-4534219a64fmr154423805e9.11.1750268495716; Wed, 18 Jun 2025 10:41:35 -0700 (PDT) Received: from localhost (p200300d82f2d2400405203b5fff94ed0.dip0.t-ipconnect.de. [2003:d8:2f2d:2400:4052:3b5:fff9:4ed0]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4535eac8edbsm3459385e9.24.2025.06.18.10.41.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jun 2025 10:41:35 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, David Hildenbrand , Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: [PATCH RFC 29/29] mm/balloon_compaction: provide single balloon_page_insert() and balloon_mapping_gfp_mask() Date: Wed, 18 Jun 2025 19:40:12 +0200 Message-ID: <20250618174014.1168640-30-david@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250618174014.1168640-1-david@redhat.com> References: <20250618174014.1168640-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SoXbKNmPcFufMDybzGWAiQl4uyl6AqJn63e_3Um1xM0_1750268496 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspamd-Queue-Id: 1D2C3C0006 X-Stat-Signature: 49pxq7yobsfboxj54swqw48hn5edwbau X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1750268500-561122 X-HE-Meta: U2FsdGVkX19j2TG6H+gBxVo3udtftbMGTa+KjvOgUR4OF4KPbLnId+B+tw8/UG5jUkisrEn7U9tI0sBz26D7PALeUaCmL4oqYqXA5eFG+fFWUOkR4UXwSLvdt0nf0k/xwzZwm96sv9UexYEUWwWuEkVPwCE/OOA1qBz3oXrTnFDCB3PA2f68+lAQz124bEFdKOOhKTd79ey6mpZkmnTwmKcJX2ujUg3ONKnFDtdKSEgwFHSi5vIBppxXNqPbPU7GprspACKv/AjRyF8T2TKdriVZcToSP1I6JN4gQXM5sXC1pw04g2CDgICuPC1jqMjPTklN6X7WMF3FPZmRIgGWp/v7FzNw0GQY5M5fFr9MBrd5XMl2MzDbPaqVGhMyj0/qhkDihiq3FJtiJSPXl725g9lNWfDSeODA3R/kNGZd5rNk38lKk/b7t48HpiO5YGD1CArFV79a65Y61cx3GeIvACHiRXDY3az7PkXu+QgI73V88F/snsSb+Vf11W9Ok/1Rhd5F2n9rxgg59QTyPJYhqk0GjB0sJKO4Mg9M7OWaJJETAIdTrH1jfy+CeES2H++ndqY/pFJY41OXEWppPMficuPbvOqN6nElyyKlYwdxL93SyLjt20zAnedMFDKEqVB+/JvKY9e9tDgww3DZnAzQIxUEkYRlWa9cyQak3/XgCHE0Kip991ut+FO3zuPFXHtiNLXgfVIHGEnHtRwohjYxcoQ7INFHcwG9b4/fFORUFehNW/q1vHXFad6vErUui86hB9WZ7S4S2reurM4/EK0lr+gxnhTlpw5VeEjDwz+KBwsClSBLy/rP1NhejM4SOFJ/N42a1/8nMRANAfzVs3VatpPLcsrjZvhjCg6d1Q/3kQ9HAq/qC5CzLQ3/BYn6i0/M+pI3C9MoTO0anmDLI0LLv4pl34nElhlUaKhHpy6hw/4TaVZ7WQ9U7egCviBCR40bCuKqGYKpWJErUGxcA71 76s36dTc jpl5fRv1ZqtpUyPU56dOj4rdQjgbrNiUR9yFGbcqa+qzXnFzpltORpF4d1DwWzreTdFO7n2pFTIw7fSxDTjajJ5t9VLg8xT20dc820GrSJH40S5eC6V09CamS6CUguNUW4gxrQaFybA38LpnBrWonPQQPP2chBjM8fDinVcdJxFdoN83Bv4cdwixtxGHYTjwz59yMl76DWkQlBQjeNe8YMPOxubctL/ePALb9bd+vxbF6qCaIHxjx9VlGut2/Op37ybczVPR+JtKUOU1TD8SPd5pn6Za68iwdlJsDjwijwCWcbnfpQV5auyCsFr6bLXjnJz16vLYPmDiXScKlZ07EmsHQdKf9qCyPNTTV9sPt4Sj64+UivMqBTMGT2NNQqha6KempvJ0N3HRMKO7uZe1aqmVV5UotVwE5H15Y4upFU8nmr4nRFlx8iPIcHbzBnFyyNLEXT13LCI1bhylVDor+h/ClqTHO+/KcHei0OIsD/9emQgDEQh1UURHMTEpPfm19TF4aXxdZo+nA3yecisTYmYdphSQ2+nZsJrKOu61qRfEgRzGVirlsIBdFgJ01VfJzsl5m8nnffRosxEkk2LaTzl7+++U81nqKVt8g X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Let's just special-case based on IS_ENABLED(CONFIG_BALLOON_COMPACTION like we did for balloon_page_finalize(). Signed-off-by: David Hildenbrand --- include/linux/balloon_compaction.h | 42 +++++++++++------------------- 1 file changed, 15 insertions(+), 27 deletions(-) diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h index 2fecfead91d26..7cfe48769239e 100644 --- a/include/linux/balloon_compaction.h +++ b/include/linux/balloon_compaction.h @@ -77,6 +77,15 @@ static inline void balloon_devinfo_init(struct balloon_dev_info *balloon) #ifdef CONFIG_BALLOON_COMPACTION extern const struct movable_operations balloon_mops; +/* + * balloon_page_device - get the b_dev_info descriptor for the balloon device + * that enqueues the given page. + */ +static inline struct balloon_dev_info *balloon_page_device(struct page *page) +{ + return (struct balloon_dev_info *)page_private(page); +} +#endif /* CONFIG_BALLOON_COMPACTION */ /* * balloon_page_insert - insert a page into the balloon's page list and make @@ -91,41 +100,20 @@ static inline void balloon_page_insert(struct balloon_dev_info *balloon, struct page *page) { __SetPageOffline(page); - SetPageMovableOps(page); - set_page_private(page, (unsigned long)balloon); - list_add(&page->lru, &balloon->pages); -} - -/* - * balloon_page_device - get the b_dev_info descriptor for the balloon device - * that enqueues the given page. - */ -static inline struct balloon_dev_info *balloon_page_device(struct page *page) -{ - return (struct balloon_dev_info *)page_private(page); -} - -static inline gfp_t balloon_mapping_gfp_mask(void) -{ - return GFP_HIGHUSER_MOVABLE; -} - -#else /* !CONFIG_BALLOON_COMPACTION */ - -static inline void balloon_page_insert(struct balloon_dev_info *balloon, - struct page *page) -{ - __SetPageOffline(page); + if (IS_ENABLED(CONFIG_BALLOON_COMPACTION)) { + SetPageMovableOps(page); + set_page_private(page, (unsigned long)balloon); + } list_add(&page->lru, &balloon->pages); } static inline gfp_t balloon_mapping_gfp_mask(void) { + if (IS_ENABLED(CONFIG_BALLOON_COMPACTION)) + return GFP_HIGHUSER_MOVABLE; return GFP_HIGHUSER; } -#endif /* CONFIG_BALLOON_COMPACTION */ - /* * balloon_page_finalize - prepare a balloon page that was removed from the * balloon list for release to the page allocator -- 2.49.0