From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCF79C7115A for ; Thu, 19 Jun 2025 10:42:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 475286B00AD; Thu, 19 Jun 2025 06:42:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 44CAC6B00AF; Thu, 19 Jun 2025 06:42:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33C056B00B1; Thu, 19 Jun 2025 06:42:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 212266B00AD for ; Thu, 19 Jun 2025 06:42:17 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C55DD1A0B62 for ; Thu, 19 Jun 2025 10:42:16 +0000 (UTC) X-FDA: 83571810672.05.327931B Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf13.hostedemail.com (Postfix) with ESMTP id 40D9B2000B for ; Thu, 19 Jun 2025 10:42:13 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750329735; a=rsa-sha256; cv=none; b=hndbH7anSN9QVs12oY/1x4zYYaubQDibw8wom3biBnbYLJ461+aRTJty0vYz6k9PBr97Lm lRhfExLhKxIQ58EldEmGp+GxoZj4fDvBCbaFvlap9pGLvX1G0+k+npVmItC/3x7AnUgnxv sbKf9Qg7oFNun6YRktqZ1pfwLAZcMic= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750329735; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=otzgWmWcaL+ncDmA2ZVqlfvM8JaeVE6qKNdbXFPio0o=; b=39qoJwYi9ViEADFi/Mh4z8IBZYbPLYBVqY9mdf/7QWNGjWj/FC1QsjAJ++aNrNK2bH+BgT npxwCzgO3GdC+ucPwhvpUVDxRYrZVF13fHmQUhCnXBCPiAHmPMV9BKK+XWlq1XUK/DyU75 xxJl35ys9j1iEQ9/IH3/xX1TO0IL8kY= X-AuditID: a67dfc5b-669ff7000002311f-20-6853e9833638 Date: Thu, 19 Jun 2025 19:42:06 +0900 From: Byungchul Park To: Vlastimil Babka Cc: willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, asml.silence@gmail.com, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com Subject: Re: [PATCH net-next 9/9] page_pool: access ->pp_magic through struct netmem_desc in page_pool_page_is_pp() Message-ID: <20250619104206.GA37590@system.software.com> References: <20250609043225.77229-1-byungchul@sk.com> <20250609043225.77229-10-byungchul@sk.com> <18ee4f16-0885-45f4-bea6-c025a1a0b969@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <18ee4f16-0885-45f4-bea6-c025a1a0b969@suse.cz> User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHeXcuOw4Hx2X2qlS4CsFyaUg+UYnQl+OHLihRVFArT23kjalL hUhzJI68F+hcMTHnJWMxS7e8X1K7kGZp81KKpRRd1Czz2uVokd9+/P8Pz+/58DCErIjyYNRR cbwmShkhpyWk5LNzkW/qhzCV38eBADBaKmm4PZsApSM2CowV1Qi+zQ2KYbqtg4biohkCjF06 Er5b5gkYax8Vw7B5nIS6tBoCRrM6acjQLRBw2VYmgu7qTAquzZcQUJM8IoYXD4w0vKn8RcF4 SwYJjwzlJAxnBkO7yQ1mnnxC0GapEcHM1Rs05PWYaHirG0bQ0zpKQmFKJgJLg4OChVkjHezF 3SvvF3F2w2sxZ7LGc1VlPpze0UNw1op0mrN+zRVzQ311NNeZv0Bydtu0iMtI/UJzU2MDJDfR 0Etzlnu9JPfU1Cbmpq0bDrHHJHvC+Qi1ltdsDzolUU1W+sfMOSfYSxyiZGSW6BHDYDYAN+f4 6JHTMk5U9SMhJtkt+E7PViGmWW/scMwRAruym/Ho3YeUHkkYgh2jcE5vHy0Ua9h4nNaVLRZY ygJ+1ZgrFoZkbB7C16+b/xYu+FHBO1Jggt2G7feHaEFGsJ649CezEm/EqfcLl2VO7G6cf+cn JfBadhNuqu4QCTsxa2NwVpMdrRztjpvLHGQ2cjGsUhhWKQz/FYZVChMiK5BMHaWNVKojAhSq xCh1guJMdKQV/Xkc88XF4zb0tTusBbEMkjtLgytCVTJKqY1NjGxBmCHkrtLizgMqmTRcmZjE a6JPauIj+NgW5MmQ8nXSHTMXwmXsOWUcf57nY3jNv1bEOHkko7gjngrXlMeDWm3zpZ1l733r zS7X1ocMbUgfqteHRKbd3l65lKl181ty9r6S++xmQluf7dCPoNkO+2KtwpI/2Xm09YS/W61m yvhSkX/WFlrwI3rjwY9Lhqa4Xe7Nk/xhXSBvvfU8x+tTYNLpgv37BvvlpkZdjWwwxxxf4NQV OGfeKydjVUp/H0ITq/wNMyeRczQDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0iTYRiGeb+zo8Xn0nytH9UqCitrZfBEp/2I/JKSMigIoo38aEOdtqVo FHgKS9KOks0NVqvlsYWnzTITtdQyXIpulTWZGgVRliXqKmsdyH8X9/1w3X8ejpSdoudxWt0x Ua9TJ8oZCSWJ3ZizKufdXs2a95WLwGSvZKBiIh1uDTppMJXXI/gy+ZKFsbZ2BqzXxkkwdedS 8NU+RcLIIx8LXtsbChrzHCT4znUwUJDrJyHbWUpAq7mTBld9IQ2Xp26S4MgcZKH3romB15XT NLxpKaCg01hGgbdQCY8sc2H8yXsEbXYHAeNnzQxc6rEwMJTrRdDT6qOgJKsQgb3JQ4N/wsQo 5UJt2XNCaDC+YgVLdapQUxoh5Ht6SKG6/AwjVH++yAoD/Y2M0FHsp4QG5xghFOR8YIRPIy8o 4WNTHyNY344Sgr22jxK6LG3s7uADkk3xYqI2TdSv3qKSaEYrFSmTs9IbbnqITGST5KMgDvNR +GPNc5SPOI7il+KqnhWBmOGXYY9nkgxwCL8E++48pPORhCP5ERpf6OtnAsUcPhXndZ9nAyzl AbsfXGQDRzL+EsJFRba/RTDuvDpMBZjkV+KGugEmMEby8/GtH9yfeAHOqSv5PRbEb8TFVT/o AIfyi3FzfTtxHs02zjAZZ5iM/03GGSYLospRiFaXlqTWJq6PNCRoMnTa9MjDyUnV6Ndz2E5+ u+BEX3qjWxDPIfksqbI8TiOj1WmGjKQWhDlSHiK1dsRqZNJ4dcZxUZ98SJ+aKBpa0HyOkodJ Y/aLKhl/RH1MTBDFFFH/ryW4oHmZaPtsxQG5ubdu81D3cOY+q7LjSrLrnsqtXXh/yFWAq+5a le6xPdM7ksIGzvqebg0/vdyStTP7hCx0264u52ju2sN+b3p4XIzbHHVj4Pr40fDJhy6vz5m2 xK+omBiOqSjbr2xr1m/Y6TQnE9NZ0sd5ju/RQ6oPZfrbcsO6g8/ImlA5ZdCoFRGk3qD+CWyb nz4YAwAA X-CFilter-Loop: Reflected X-Stat-Signature: tzi7msybimxgcwdws8ksnm59e7ehuzx8 X-Rspamd-Queue-Id: 40D9B2000B X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1750329733-25453 X-HE-Meta: U2FsdGVkX18zvrgxJywEhqJDRllZy4hu83e+/pxW/0LH/eBJjH3a8eEQZokA973GXwgqARMd04GmSsef8BgXLqV/zN7xNVUhH/CyeeLw6gBT1WJQU9HSGtuTrpSBH5ibRtVbNAo/svV/ikSjpBtrh4V4ROJo5TmrC60aIwx9tufri9Q9O5GOrydzV1kCIKjzuMI2azqs2LVO0di6F0vBVYkvhrZ0eopReAvq7A9h+3fgXzbtLxw4S2z6wTM9G0TIh2PTEqWluVPDyUmHz5zV6DaF12bfTjz2ZPtJdkr/hWUN24NDjhm4w2o3IC1LsI/iVnehXpXhKWkjvBqtSsb93d0LQPvZN7n/2Q322mZS748B24y4fyEuSp9Jr6BrGYKe8/1cTH5s9yQgmB1nyRPjXtwwy+ml1KVmQTxowwOnmQcmX75q2NVWZoemACgfUrekGf0lSHIoeBoh6GwHwQndEPVuD1g6GW6I/K+fTLLZZfnwMloP+jxAibGEBIzrCjJXPUQxm7mOpJGNsyyR6DR49CDYhxALRVVbphSYgjXo5qkahXnpMZP6lciBZl8eIt4gIJ4PZhSZqj7LKqRkdGp9cprT8ji0JVkdmq0T/luwD5O99MGu4Ubvl0BvSABYZDAkEBb36lfAIvFC9seMX8oB8HRnA7CcGEL49WqMBfGuR6w7K59BEIZEZwWFCGPwxTpUj82AZTY1D55FrNd23UT18H9iveRpxvtDx0+UATbS0hCTf0aXSvswB/N1YsUt4BLEtTgm0vlEstkbbbjKWZAyBGcryVExrRE9E3t9vydM4/RpS7scJZl3j4BNF4cOKaWJjmSgTPSopaWkHOBoVwfY6KlvKmcqagsPf+E7Qw2K9lyvwQ5IG5jX51SLs/oZrAcl4CFR3y/kOszNcKhvdvunyr0nCNzUzm7Oo4IyCC9eFsAErlfbzXM6Au1oU4A0ERcJIcgzFOlzZZNcHHjX/rX QLWBCgK+ qUlgutXqR9Obj0MMaMHTut2DCYUqmuKaqYnxYTLfJ9H2k2H17j6QRgsHOBmK/CfuctA/KIcaP2k9p6Gm33i6co57OI8h0fvEZXI6i6JuefAtveNgAJYpwYTOZLuGmH8Ei0Qr7P1Rfet0YutYYyrvqcANzey5b7h08f/UAIJ4YaaiFkZwVA7BlwvKXtg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 19, 2025 at 11:55:03AM +0200, Vlastimil Babka wrote: > On 6/9/25 06:32, Byungchul Park wrote: > > To simplify struct page, the effort to separate its own descriptor from > > struct page is required and the work for page pool is on going. > > > > To achieve that, all the code should avoid directly accessing page pool > > members of struct page. > > > > Access ->pp_magic through struct netmem_desc instead of directly > > accessing it through struct page in page_pool_page_is_pp(). Plus, move > > page_pool_page_is_pp() from mm.h to netmem.h to use struct netmem_desc > > without header dependency issue. > > > > Signed-off-by: Byungchul Park > > Reviewed-by: Toke Høiland-Jørgensen > > Reviewed-by: Vlastimil Babka > > I'm not that worried about the new include as it's for a .c file and not > between .h files. > > > --- > > include/linux/mm.h | 12 ------------ > > include/net/netmem.h | 14 ++++++++++++++ > > mm/page_alloc.c | 1 + > > 3 files changed, 15 insertions(+), 12 deletions(-) > > > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index e51dba8398f7..f23560853447 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -4311,16 +4311,4 @@ int arch_lock_shadow_stack_status(struct task_struct *t, unsigned long status); > > */ > > #define PP_MAGIC_MASK ~(PP_DMA_INDEX_MASK | 0x3UL) > > Do you plan to move also all these PP_ constants/macros (bunch more above > this one) to a net header? No, but it should. I will consider it too. Thanks. Byungchul > > Thanks, > Vlastimil >