From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3538C7115B for ; Fri, 20 Jun 2025 17:33:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 762336B0095; Fri, 20 Jun 2025 13:33:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 73A426B0096; Fri, 20 Jun 2025 13:33:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 677566B0098; Fri, 20 Jun 2025 13:33:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 54A556B0095 for ; Fri, 20 Jun 2025 13:33:38 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 265BF104024 for ; Fri, 20 Jun 2025 17:33:38 +0000 (UTC) X-FDA: 83576476116.29.9E3AAEF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 7F67140004 for ; Fri, 20 Jun 2025 17:33:36 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=a4OTqmdR; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750440816; a=rsa-sha256; cv=none; b=TvaOo35EKjzMSZXHLgSaPJC+Kb/cJVzd8PCI0ExdBBCNU+WVQa6jkPw8gS/uMqkei2Euvz W5K5lvc0ZwCMYdxMeLKYCZNbJX7PhnK4mFxudq3hYricI77K4HFhGH/KD8vfG4OQ/lDDwW QrlXxq3I6lFrSEfZSlvAs15fzDmJB1Q= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=a4OTqmdR; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750440816; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6wfKoAjJ7IquI6vgxYLynrSiHWdngIvBr4rz3oq41II=; b=WwFW9yTAJj7Ro5JXsjh3eEYIQe1aEyV9T5X7Zy9zIaV3mtrxTK3sxB+CDCe44q1KxVB13q xvPSwtP5Xjfv8JsPVGLlBD+aiSUVii85wPUULEB1NY047hGNaxwXLV1/wvc/Ad8ReS7Bs3 6JVVZKs+mCVJ94EKheGCOiqOSj7yCy0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 07F4C5C57C7; Fri, 20 Jun 2025 17:31:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12D5DC4CEE3; Fri, 20 Jun 2025 17:33:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750440815; bh=ty8CZ8PfOQuKhNDdbfpzSP4TCs0Z8KwtEq/Nni1TAls=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a4OTqmdRHh5E+XNrgmwzxQrtuSzLwRXfgIzn4HsfG80tofbr7sFMYARVuBHSIy1Ej TInLIwudMQgAmC4xmggDADO3bjsI3ShIavmPB9BLIGYdG0THxuZ5iMsUUOPwBjYEmc 1m6ma5DctPAkrMIAPAcO0cPV2Ll3OngwfpZ3D5UwrEnWA3CCjpkWhvOBkS5y8GRtL/ XPgTscG8ZynlH+nCMiMKzv2vfPwA+n0y+LNokNX12frf1F5hDiI8ujOiNGwUn7dR8u Q7xF3L550lg2WML65M0ylFAt9n4froQyWjumTYtXoBKtHwyhITTCYCm6glTArzfUyo e/KrLYXG3iSQQ== From: SeongJae Park To: Lorenzo Stoakes Cc: SeongJae Park , Andrew Morton , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lance Yang , Suren Baghdasaryan Subject: Re: [PATCH v2 3/5] mm/madvise: thread VMA range state through madvise_behavior Date: Fri, 20 Jun 2025 10:33:32 -0700 Message-Id: <20250620173332.96194-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <518480ceb48553d3c280bc2b0b5e77bbad840147.1750433500.git.lorenzo.stoakes@oracle.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: wbhh8y7fg7fmqh7o3zxgmgwo6sokjdrr X-Rspamd-Queue-Id: 7F67140004 X-Rspamd-Server: rspam02 X-HE-Tag: 1750440816-541736 X-HE-Meta: U2FsdGVkX1/h8uUIqa3FpmUlsbWpLSSvOeFGVRQiSiVnyhgxzUazAO+3WvRJHp1JnPg29di+CMcWtq5WEtLMMHqV92F628qgywhbvQpG5QKgonbg+WwrDVVpwliyTdzPOGigVQFX/Hd5BeQUNlNC2QPRXmw/hBzW/2CCl24tu0W4Z+WztfmcjSRgQ353DEbIVigB27MD+VAuzyALEvmUoQ04UyhEb/tIjfI2opsGogJCqs/y1qFV/O44m3DuAR+HAGzKSYCdcotJ+3tPumbznH+H+uOCIJ6AC52ZuTRMgcCaaTn39qLkS4LKTdrjxKWsoCze/tZhvT2Kay5dXnyHE04yqgjNv6sRYxPXtbzrVVd7yv3H4hZ/fzjSvPIw3rMgEnLtLNcezjGNHPy0g9PvjW8/ZyLnW+sSLANT+Lj2zdoAmXl+bqZZw2vpEh4CRv9qjFasPefuefDPXDW+O+6Wq7/8VQYc3UjJ23dUgBM1ntbDFH1fuz6QH8AptKHovWeU3N1OhG/okPlqABzn0ShyWwzIHv9If/zD6jpH8j8GgeiH6zGiQI1b/SoDZf01jaaU4wW1oMFMpAPs80XWghXliO7FORq07HaGLNW+orGTx1TepHcjhgHcAb4cBHRZj9Iwa2N838w47e4k7VZxCQVbsyGlq0LzP0FS4QsRprCZ8Lig7gDG9PXDMJdtldnwTRpczNT8nkACL1nBfHVT33l927uzIgKDejM6VoNF3KcV/PnyjDiXy6hjoUUtyn843y/NiVPy5rtGsWmuUOxtXBQMWO5+AGdYwBzLMEoNIJZQT55XhGuqsHbz7GuTZPVNwHxQAhJG2Z2Whzuha+tRe9E6tgwSIopbPG1H7i5CgN6urYw14WNLdTjBlHd2Eept/mt2hAbeRcVaJaOTfRlcUGs3KyFqMbD2Jn+haTHT7W+goBkQhnYY6PZgCVmAuncrXaH9LaR0GqGj8LO1hXAYFWk wfQIjMXP PNNSniRd0FupY7wZM8oeLJwFPRkSwybPAVAPb4AgtLjGzn3hBLOSEJ9rugkgzvJPiuQuYX64u+5JTiHI3/6h39Sf3G8a/GgNjfddOy9VSLXvYrthDxxedtnxtzFtUBaOz4kbQ7zmvTxm9ZjRznzgm/q5u0pKgzmmEZ0m9sDoUVuDyiLTKAn19MSuttiIMw+EHIGuUdiUwNeK3+9zSX4ABOOtd8UxywAbTfoRLB4aG5nolssiTWUG3aVnqyrtv6x/x+e++X1IPKXcy0AZy6jgLUhrvEcglUVVurUhwqwXqXESxReNxG4JtZRDTpQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 20 Jun 2025 16:33:03 +0100 Lorenzo Stoakes wrote: > Rather than updating start and a confusing local parameter 'tmp' in > madvise_walk_vmas(), instead store the current range being operated upon in > the struct madvise_behavior helper object in a range pair and use this > consistently in all operations. > > This makes it clearer what is going on and opens the door to further > cleanup now we store state regarding what is currently being operated upon > here. > > Reviewed-by: Vlastimil Babka > Signed-off-by: Lorenzo Stoakes Reviewed-by: SeongJae Park Thanks, SJ [...]