From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C9ECC7115D for ; Sun, 22 Jun 2025 18:43:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1BAD6B00A1; Sun, 22 Jun 2025 14:43:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A57B6B00A3; Sun, 22 Jun 2025 14:43:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86D0A6B00A4; Sun, 22 Jun 2025 14:43:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 708466B00A1 for ; Sun, 22 Jun 2025 14:43:29 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AFDE55D48E for ; Sun, 22 Jun 2025 18:43:28 +0000 (UTC) X-FDA: 83583909696.18.6546B12 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf02.hostedemail.com (Postfix) with ESMTP id E23B880004 for ; Sun, 22 Jun 2025 18:43:26 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=XHPUHLQg; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750617807; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hnD1ET+CPtpRIqbxr8sSHqg6GQaZqTIY+BPVfM0CTWA=; b=X8+H5+1Bv2SH7XZdGVNZA4CYhN1ALxqouU417aiB4RrII8dKvW4w6gbBJLyZTIaSt2fGw9 DIETRVb0oDTi8NThA1OT++bS8GSCxVpS0s6TO/zkLtQV+/Nrb50MttOX3AguerFfWLK9DY FEEF7Q0bX8uXNaRNkrLEsRTkO2GaGQA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=XHPUHLQg; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750617807; a=rsa-sha256; cv=none; b=axmfnzcvB11JPrBhKjXO0mo9iV+D3R8sJ2x3a/aewFnT4NX/yQnnt5Ys2uyRNmnR+00j0H eNUblwaf6y1dOeLMPHJWt0GAmVsOT1u2bm5K0VohbblTMoeVnulEqeD+0yxHI+mCLta9+r is95z/3JMHeAQGvljFaXH5y7/zSQ+n4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 6028744823; Sun, 22 Jun 2025 18:43:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D189C4CEE3; Sun, 22 Jun 2025 18:43:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1750617805; bh=3H2wKWU2193WXNtIUhATRt/ZTw4+1SQggiDA+AaWVjI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XHPUHLQglzrHpK2ZS8imdC6/smERAODfvRVpH2JeWdzBL/q/n5IqHb2TQkI29zi1K 6oTx1a73gchf1/xMbFySG6/bhXW+GAtxWzT92/UQIr9+80WcSclzzzznwEJHOhgdE7 /RQmsUSfX9zDx/b250gr43W8i8T4klKuUDPcoL2k= Date: Sun, 22 Jun 2025 11:43:22 -0700 From: Andrew Morton To: Matthew Wilcox Cc: Shivank Garg , seanjc@google.com, david@redhat.com, vbabka@suse.cz, shuah@kernel.org, pbonzini@redhat.com, brauner@kernel.org, viro@zeniv.linux.org.uk, ackerleytng@google.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, pvorel@suse.cz, bfoster@redhat.com, tabba@google.com, vannapurve@google.com, chao.gao@intel.com, bharata@amd.com, nikunj@amd.com, michael.day@amd.com, yan.y.zhao@intel.com, Neeraj.Upadhyay@amd.com, thomas.lendacky@amd.com, michael.roth@amd.com, aik@amd.com, jgg@nvidia.com, kalyazin@amazon.com, peterx@redhat.com, jack@suse.cz, rppt@kernel.org, hch@infradead.org, cgzones@googlemail.com, ira.weiny@intel.com, rientjes@google.com, roypat@amazon.co.uk, ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, kent.overstreet@linux.dev, ying.huang@linux.alibaba.com, apopple@nvidia.com, chao.p.peng@intel.com, amit@infradead.org, ddutile@redhat.com, dan.j.williams@intel.com, ashish.kalra@amd.com, gshan@redhat.com, jgowans@amazon.com, pankaj.gupta@amd.com, papaluri@amd.com, yuzhao@google.com, suzuki.poulose@arm.com, quic_eberman@quicinc.com, aneeshkumar.kizhakeveetil@arm.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-coco@lists.linux.dev Subject: Re: [PATCH 2/2] filemap: Add __filemap_get_folio_mpol() Message-Id: <20250622114322.c6c35800e01e4cc4007a0f89@linux-foundation.org> In-Reply-To: References: <20250618112935.7629-4-shivankg@amd.com> <20250620143502.3055777-2-willy@infradead.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspam-User: X-Rspamd-Queue-Id: E23B880004 X-Stat-Signature: 8t7hax7uijpnn5pakxuawzf1gkphtmqa X-HE-Tag: 1750617806-587177 X-HE-Meta: U2FsdGVkX1/hirqXrBvTYcQk8xF5czS6+yu0greZo2ebpeROTyBjHtZvisBfMT6bIOWusb3vT5Js4XtDoEynPqA1w1CKSNwsCseqcg8n7Ar/yQhBOrvy8LlYWTFkecYB/eXDBiGEvuQwsLO4095f8TiAZSO5lemCYdlEi8Cu9yCRRmgD+R4mc9CmBuyw4zeTuIaKpgMwvQ2Mypuh3T1NMg3iGwwEGo/DZNfUMgeY635uiWOnvJSP8K1JKK+b+3GqJcAyNVf1XTJLRPrAbdZGX7EYXT+cpLlOwijgcBPnLx+kd2v9RsPRGNYar06X0wuxSU3maJo8QMzWRTdpIA+tQcug+uCVPueJsOApm7Mj2d4cUCgsOTr3Fl5SlGNZ/FontKF/cDX6340Axfa8EqlonW5+Bd+uxpVMAFWYNDG+jTT/lnthPR4u4o/LN6usfQ4OGWzkcnpjDJ8WRRKRQeAiO4dO5vkurR3A2Oz1pBEH5jrQ6qRX5rwl/IkiVOlSbam/GKbd5O8uK8cxZRCYwGTJR/frjMk7mFVTPALJ9RvUovFKRVicR85d3zXNQVhIB/iJlkT91T1TJbH5TWl17eu55E3x0FgV0TE5SfZr8Bt+ZhSVDHk594YsLx6p4fUYQ0g4rrXWp4BRZMSzIo6ysW/8TAmbfOsQ+mK5ebnfkcRnkHREhw06Gnufvqqv8YbX6+jVFPJWcTRWPMyXuiVme+kTDl5L7pdERsiWqhALHjQZkD+C3ZnYEj9/lV00o5Qn47RUTmDj/a83xUZnLU6T/OP+8DisNVqBxfIp+nDs/lbuDK4diX/IiBGtiYNa0gr9zYG/72NJ0+khr0mzFIbaYhqSq2j7AF52IFHkhNgEYob2J42b+x9B+DCiWPFJdVgHcSZf5/ipDhXhWW+VLzvpcoiL+HzohNnBW8/kolOXyF1f9Cr7AxbCFQD8bp6VhD3h/ecT1t/39T9UGPZDE3ifjO8 CXSHWgzx 6sk3Oixhc8O9iNoFcjec3Pcm6MUAb6JsCKhoUf3aNvKLLgskvpbiRniF+0RMZrrSBbV26Neif9GXLBCP5UkHe6UrV2Kvl97PKxor3yoghs61ntVr6LdOJtQwJRWrjrKpRsoVewxO9yEHihsWrtc815KHUyihpHdPY1s5dcAF45j3/l35S6P+K1QvZP1kroaXifw0uu9YTn1gvYBIj87AKQbS8HqvOodV+TpzWYW6ewIuDaLqWTSeOwEkEI/TDSC9uKBXwDVGpHImmrAXFpy/50Ud2n1H/rSwMg/Hg5qBghIKUaUNySl8zafIcbVrCIxzsy3Xqxh4jM4kit00GdS7VELXBuEM/ptnlJLjtVQaLLEhX4Cj1F9zbqsX0fA13sUKTZQMnm59eJS9iV44JvuS0bNvTg2N+nDR7krXqwvjlUCUnrvo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 20 Jun 2025 17:53:15 +0100 Matthew Wilcox wrote: > On Fri, Jun 20, 2025 at 03:34:47PM +0100, Matthew Wilcox (Oracle) wrote: > > +struct folio *__filemap_get_folio_mpol(struct address_space *mapping, > > + pgoff_t index, fgf_t fgp_flags, gfp_t gfp, > > + struct mempolicy *policy) > > { > > struct folio *folio; > > > > @@ -1982,7 +1984,7 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, > > err = -ENOMEM; > > if (order > min_order) > > alloc_gfp |= __GFP_NORETRY | __GFP_NOWARN; > > - folio = filemap_alloc_folio(alloc_gfp, order, NULL); > > + folio = filemap_alloc_folio(alloc_gfp, order, policy); > > if (!folio) > > continue; > > This is missing the EXPORT_SYMBOL_GPL() change I added this: --- a/mm/filemap.c~filemap-add-__filemap_get_folio_mpol-fix +++ a/mm/filemap.c @@ -2032,7 +2032,7 @@ no_page: folio_clear_dropbehind(folio); return folio; } -EXPORT_SYMBOL(__filemap_get_folio); +EXPORT_SYMBOL(__filemap_get_folio_mpol); static inline struct folio *find_get_entry(struct xa_state *xas, pgoff_t max, xa_mark_t mark) _