From: SeongJae Park <sj@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>,
damon@lists.linux.dev, kernel-team@meta.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-mm@kvack.org
Subject: [RFC PATCH 4/6] selftests/damon/sysfs.py: test monitoring attribute parameters
Date: Sun, 22 Jun 2025 14:03:28 -0700 [thread overview]
Message-ID: <20250622210330.40490-5-sj@kernel.org> (raw)
In-Reply-To: <20250622210330.40490-1-sj@kernel.org>
Add DAMON sysfs interface functionality tests for DAMON monitoring
attribute parameters, including intervals, intervals tuning goals, and
min/max number of regions.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
tools/testing/selftests/damon/sysfs.py | 34 ++++++++++++++++++++++++--
1 file changed, 32 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/damon/sysfs.py b/tools/testing/selftests/damon/sysfs.py
index 4ff99db0d247..a721901a880d 100755
--- a/tools/testing/selftests/damon/sysfs.py
+++ b/tools/testing/selftests/damon/sysfs.py
@@ -20,6 +20,11 @@ def dump_damon_status_dict(pid):
except Exception as e:
return None, 'json.load fail (%s)' % e
+def fail(expectation, status):
+ print('unexpected %s' % expectation)
+ print(json.dumps(status, indent=4))
+ exit(1)
+
def main():
kdamonds = _damon_sysfs.Kdamonds(
[_damon_sysfs.Kdamond(contexts=[_damon_sysfs.DamonCtx()])])
@@ -34,8 +39,33 @@ def main():
exit(1)
if len(status['contexts']) != 1:
- print('number of contexts: %d' % len(status['contexts']))
- exit(1)
+ fail('number of contexts', status)
+
+ ctx = status['contexts'][0]
+ attrs = ctx['attrs']
+ if attrs['sample_interval'] != 5000:
+ fail('sample interval', status)
+ if attrs['aggr_interval'] != 100000:
+ fail('aggr interval', status)
+ if attrs['ops_update_interval'] != 1000000:
+ fail('ops updte interval', status)
+
+ if attrs['intervals_goal'] != {
+ 'access_bp': 0, 'aggrs': 0,
+ 'min_sample_us': 0, 'max_sample_us': 0}:
+ fail('intervals goal')
+
+ if attrs['min_nr_regions'] != 10:
+ fail('min_nr_regions')
+ if attrs['max_nr_regions'] != 1000:
+ fail('max_nr_regions')
+
+ if ctx['adaptive_targets'] != []:
+ fail('adaptive_targets')
+
+ if ctx['schemes'] != []:
+ fail('schemes')
+
kdamonds.stop()
if __name__ == '__main__':
--
2.39.5
next prev parent reply other threads:[~2025-06-22 21:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-22 21:03 [RFC PATCH 0/6] selftests/damon: add python and drgn based DAMON sysfs functionality tests SeongJae Park
2025-06-22 21:03 ` [RFC PATCH 1/6] selftests/damon: add drgn script for extracting damon status SeongJae Park
2025-06-22 21:03 ` [RFC PATCH 2/6] selftests/damon/_damon_sysfs: set Kdamond.pid in start() SeongJae Park
2025-06-22 21:03 ` [RFC PATCH 3/6] selftests/damon: add python and drgn-based DAMON sysfs test SeongJae Park
2025-06-22 21:03 ` SeongJae Park [this message]
2025-06-22 21:03 ` [RFC PATCH 5/6] selftests/damon/sysfs.py: test adaptive targets parameter SeongJae Park
2025-06-22 21:03 ` [RFC PATCH 6/6] selftests/damon/sysfs.py: test DAMOS schemes parameters setup SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250622210330.40490-5-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).