From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06591C7115B for ; Mon, 23 Jun 2025 04:32:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 789486B00AC; Mon, 23 Jun 2025 00:32:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 760E16B00AD; Mon, 23 Jun 2025 00:32:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69DD96B00AF; Mon, 23 Jun 2025 00:32:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5AF2C6B00AC for ; Mon, 23 Jun 2025 00:32:20 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B817C5FD64 for ; Mon, 23 Jun 2025 04:32:19 +0000 (UTC) X-FDA: 83585393598.16.2690E4B Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf14.hostedemail.com (Postfix) with ESMTP id D48A9100006 for ; Mon, 23 Jun 2025 04:32:16 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; spf=pass (imf14.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750653137; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2fID4xde/XRqg/4ZM0boQ8hA8PKuMuFbWTXFQICDMUI=; b=UmjCsjLw/MOJchnAT5ocDQyzocUWDbTnijv7I8zfzo3Lm8DmKUBHuYnAc4+ZqKvcCMQh3L Q3oCcOisbOxJwhG7z1JMe5+gvfnfCib58Ag9zbaY9rnX8ae0N4lVRp+zLqSmIzINtZwGeU ioI4PmUJsMwc2AoDVegSLzDoXh3ZUVw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750653138; a=rsa-sha256; cv=none; b=tt/UvHGt07QnUW4PNGeBuH9jzRLVJ2hxk9HxBvrjEeXnraiqQclGCftp4QYkJtEOjGn/s6 VAV2MesKH2qBIJuWNcc6P8Z8I6eWvpqXLgD02jTortbfncLjFH/2xWom7+AMLCIcouyEOG j4nxDk+1/AOb1DxTKVmoAgFTMTmT0CY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none X-AuditID: a67dfc5b-681ff7000002311f-e8-6858d8cc5518 Date: Mon, 23 Jun 2025 13:32:07 +0900 From: Byungchul Park To: willy@infradead.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, asml.silence@gmail.com, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com, hannes@cmpxchg.org, ziy@nvidia.com, jackmanb@google.com Subject: Re: [PATCH net-next v6 6/9] netmem: remove __netmem_get_pp() Message-ID: <20250623043207.GA31962@system.software.com> References: <20250620041224.46646-1-byungchul@sk.com> <20250620041224.46646-7-byungchul@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250620041224.46646-7-byungchul@sk.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUhTYRTHe3af3V2Xi+syfVIiWklgmRVlBwqNQrpfKiEISyMveWkjXbql qRRprizxDYuyuWoRmWmwmqmzF8211KhIDWOVOtE0MdPUFDezckrktx//8+f8zofDUPIHYj9G pT4haNR8nIKWYul3z1tBb+yRyvV3ckLAYLpPQ/lkCtztsojBUFaF4KfzswTGbI003L41QYHh nQ7DuMlFQW9DtwTKzbvBUdKH4WlWNQXd+U005OqmKHjmHJLAWUupCJqr8sRw2XWHgur0Lgm8 f2ygofP+HzH0WXMxvNLfw+DI2w4NRh+YeD2IwGaqFsFEznUaLrUaaejRORC0vujGUJyRh8BU axfD1OTMjuKXnZLtq7gXg8MU9+jeRxFXo++QcEZzEldRGshl21spzlx2kebMo4USrv3DU5pr KprCXI1lTMTlZg7R3EjvJ8wN17bRnOlRG+beGG2SCK+D0m2xQpwqWdAEh8ZIlaar9TghY1HK w3wDTkd1C7ORB0PYTaQz6wb1j0d0zdjNmA0gjZ2FsznNriZ2u3OGGcabDSYfCg9kIylDsZk0 KWxzzvYXs+HkbWkO7WYZC8T54xtys5zlyYWBc2gu9yKvrn2Z7VPsWlJT2U67d1KsP7n7m5mL l5PMyuJZrQcbQvqHmkRuXsKuJM+rGkVzZzYzxGRLneOlpL7UjguQl36eQT/PoP9v0M8zGBEu Q3KVOjmeV8VtWqdMVatS1h05Hm9GM39UcvpXlAWNNu+zIpZBCk9ZjGekUi7mk7Wp8VZEGErh LbPu2K+Uy2L51DRBc/ywJilO0FqRP4MVvrKNEydj5exR/oRwTBASBM2/qYjx8EtHEaYVLYkD tvbENP9+JmjLnj/L66ZFPo/PhLWs8ap1FQU9Cay/MnI+IKvOvtl1ROe6GX3qYGXeHvOA7zJ2 esjHA0kd4R22Tw0qlSO9qnLL1lZKG7SguIa+MZ1Wbv66K+JQeFHY3jWW8RZeEebZE1rQFfM8 qi16yc4Flw7HjFeUqRUKrFXyGwIpjZb/C5Lllu9DAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTcRjG+e/8d3Zczk5r1Uk/RDMLokzpwptFSCEdsiII1Ppgjjy15bUt TaPIy0IztZpRNlctRF0mrZbXsqx5mWKRKNqypWkqZualdDjt5ozIbz+e9+H3fHkpQpzDd6cU 0ac4ZbQsUkoKsXD/ttT1r6whcp9P6Z6gM5aQcH8qAYo+VvJBV1yOYMLxXgDf6ywk5N+1E6B7 o8YwaZwmoL+hVwD3Tfugu3AAQ3VaBQG9lxtJyFLPEPDMMSKAlEoDD2pvNfGhpTybD9emCwio SPoogLYnOhK6Sn7zYcCchaFJew9Dd7Y/NOiXgr15GEGdsYIH9sxbJOS06kn4pO5G0FrbiyEv ORuB8bmVDzNTs468+i6BvxdbOzxKsKX33vHYKu0HAas3xbGPDWvZDGsrwZqKL5Ks6ZtGwNo6 qkm2MXcGs1WV33lsVuoIyY73d2J29Hk7yeYPjvFYY2k7PiA+LNwezkUq4jnlhh1hQrnxxksc m+yW8OiyDiehmgUZyIVi6E3MuLoFOxnTXoylS0M4maTXMFarY5YpSkJvYDo0hzKQkCLoVJLR tDvm+ovpAOa1IZN0sogGxjH2BTlZTMuY9KEL6G++iGm62TfXJ+h1TFWZjXQ6CdqDKfpF/Y1X MKlleXOzLvQWZnCkkefkJbQn86LcwruC3LTzTNp5Ju1/k3aeSY9wMZIoouOjZIrIzd6qCHli tCLB+2hMlAnNvkrhuR9XK9FE224zoikkdRUZAkPkYr4sXpUYZUYMRUglIvPOILlYFC5LPMMp Y44o4yI5lRl5UFi6TLQnmAsT08dlp7gIjovllP+uPMrFPQnhga81Kw2HA0sXzsSnTFX7rc7v WO7bs7Xn4O2GtJOaveWWoFHHF9uq83GXJk+/dLtTd6Dq7fqzybb3PvWZSe82YunPPl3nCdex 66e9a+iBuLPBi0KajfbPDyWhBSMF7lf9AnI9UybVuzpj/AnLmWOTgz0FoVfk+gcSQebTIbtt eWGYFKvkMt+1hFIl+wM4qcRvJgMAAA== X-CFilter-Loop: Reflected X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D48A9100006 X-Stat-Signature: e3ywou5ss3paz5mmz4ztrnfe3ryfikzj X-Rspam-User: X-HE-Tag: 1750653136-426277 X-HE-Meta: U2FsdGVkX18pAn2QQz7qzfKdLRBN7htPMdQAHjQeStk9h0y79vyTUheTpzKvb6tiBmCNu8AaT6xaHy3Mtg8mRd2XUT00INGa+uIY/IxIRM28+nil8j+DoPQwm8DyDYiFax93tR0vyGPQSZ3LOcVEwONhdwC6QuUV7vFtxgfW+WPxVUJkRN1zE/OrAl+SV5xExJctspbA9kSnKjJnM2D+npnKIQytlKFt1R7nvoK9RA2b42sJRmmPfD5bUVN6DNQfcVxbkBytpDkW87PVO/NwK7vP/FjgE3OPSYldgKZXZgxTwhzJWCpyQVfmgLCKZplF3jDprNthA5XOuBjdqNxYOfbK8yhJ51mWKgKdsXJ2VaGBgf7/y/UHIuYWSaLwPYJC4r+5xTFtkvrGiDBY9qcbdD2/J+IEeklPon1Wt6j0iD7Ch0CcSvOLhpzOWE2bxrdp4FsD0v028hCzhFvcZ6TytRri49PT3T4gona/dBM2bVFFfSZNzGf8cghdeswCyYNXLkGcInV98BKmWn6DmrtOAEAYEpadXI8vd5wvxwFXNjyAI8wfKRszm4i24iU/A+thgiPBdqrAMUcIEc4oCRF/MzeAIhLl9x1/ZfXUvCvknKzT/86/7Kpmkh0e/76gk4PsBVJphwRjWTzLjj6tfMcW7MKPb4jUJeMHwYjBoTVntCiKxAD6ZYp72HNZ65pDOzS26b3+MoJs6VhWZK0RQPvNu4B1BAV+ttZz5bGtVueEqUt6RDV9pxJiNG5nASsxJ7zGWZ15Y5fLjXSdA1Gu5taNMvQoLSXYDw9s6IPHmLu+iq3ISQ61hQsdxr96Ki0C4K0FCTSwKaY3fdNTtBMJFZeuFC5nj7rMRsLOOS22diulflGtA/H22gSJWJzWYANry6xLiiHo0qmECuKNXgzPjqFvqW+Z2yiD3hE9p1bVpTA6N5CyH+WmVzW6odWCaa6RuTV9VMavj2MsFvr3U+eNLgA abnVW5fb cMIxWAQqu/2nk43mmPi2z6Ht6ry/NqdBcxgR/lXeMoFjvWi6Z5AhcJpOxUCNC6+e/Q89UMk3PyhBt0BBC6n1aWbBgaZxoqVvdMLCOKp9rBHN3ooJ1uZK2hiK/Iqve1RhqKGtcYdHfAaaVDdaR3wa6/Sm/lUXdcZHPQ+vONrAYrdw3RDtKWqt4C6XFCsaydiYMPS3ps59z/E0u1slJY4jhLFqZak5Rt1hINvnJtDatuj5FGKqqIO40k1vUzh+wEfrozh6O X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 20, 2025 at 01:12:21PM +0900, Byungchul Park wrote: > There are no users of __netmem_get_pp(). Remove it. > > Signed-off-by: Byungchul Park > Reviewed-by: Mina Almasry > Reviewed-by: Toke Høiland-Jørgensen > Reviewed-by: Pavel Begunkov > Reviewed-by: Ilias Apalodimas > --- > include/net/netmem.h | 16 ---------------- > 1 file changed, 16 deletions(-) > > diff --git a/include/net/netmem.h b/include/net/netmem.h > index e27ed0b9c82e..d0a84557983d 100644 > --- a/include/net/netmem.h > +++ b/include/net/netmem.h > @@ -245,22 +245,6 @@ static inline struct net_iov *__netmem_clear_lsb(netmem_ref netmem) > return (struct net_iov *)((__force unsigned long)netmem & ~NET_IOV); > } > > -/** > - * __netmem_get_pp - unsafely get pointer to the &page_pool backing @netmem > - * @netmem: netmem reference to get the pointer from > - * > - * Unsafe version of netmem_get_pp(). When @netmem is always page-backed, > - * e.g. when it's a header buffer, performs faster and generates smaller > - * object code (avoids clearing the LSB). When @netmem points to IOV, > - * provokes invalid memory access. > - * > - * Return: pointer to the &page_pool (garbage if @netmem is not page-backed). > - */ > -static inline struct page_pool *__netmem_get_pp(netmem_ref netmem) > -{ > - return __netmem_to_page(netmem)->pp; > -} > - In the meantime, libeth started to use __netmem_get_pp() again :( Discard this patch please. Do I have to resend this series with this excluded? Byungchul > static inline struct page_pool *netmem_get_pp(netmem_ref netmem) > { > return __netmem_clear_lsb(netmem)->pp; > -- > 2.17.1