From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AB9DC77B7C for ; Mon, 23 Jun 2025 21:45:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB4F16B00C3; Mon, 23 Jun 2025 17:45:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D65916B00C5; Mon, 23 Jun 2025 17:45:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA28C6B00C6; Mon, 23 Jun 2025 17:45:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BC91D6B00C3 for ; Mon, 23 Jun 2025 17:45:32 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6BE3DC0E6F for ; Mon, 23 Jun 2025 21:45:32 +0000 (UTC) X-FDA: 83587997304.04.1A47A65 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id AE88E40015 for ; Mon, 23 Jun 2025 21:45:30 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=u2GywUPD; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750715130; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D4bYKrowW11fFvUPyftS/eGi1kDFFqRZHX6qtc/q0uo=; b=0S4CUwuvQEhxiJ1hHx+jRN59Aec9AZUpi7rZWPkjkSlIaSFt/Wk5vYma703BXuGgvf8dpJ +WKWQ2o5O2rvYHnhdTqMkE8+ECCJz3w83CiV5UMmMyxII9YZ2/Ov8KyL7no1TAhe54/aM2 IOKzkGMiDGnJvilW89qWGmsKiT4gf34= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750715130; a=rsa-sha256; cv=none; b=eYUL5CFTXBB2GgeGtBdsvYk6yeBFvTg9+0tf/FwesQKdaFPzioLIVjmh0sNsfY5EacJLJd jgXyzL7r5hoPD4YUEu5Cjme3i4TSPIrSwZoQfpvyt3SU6VWwjBNiuF7GlUMTlCKPnsMskP JcjIF/5n0H7H2KVScGmT/yfos3xTFlk= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=u2GywUPD; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 36D4A5C6274; Mon, 23 Jun 2025 21:43:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13F12C4CEED; Mon, 23 Jun 2025 21:45:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1750715129; bh=18Au9ytDbTibIjuzR4zOqs5nyomtzAl1JtHW6kDieqo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=u2GywUPDfzXBr8Aait3ggZAvH5UlvPQc0B1F+44f2xxStPUycjvZachm6Yz6/qnMW 1ThmhialQFv94I5jxq4OvSWb3UjEfxhxxKO4twMUTSaDbHzznSXRgcQEFiWdKXT3bV v5S9DAtOHY8rA9MMn/HvWEVpqW+0MAQRp1FcwGJo= Date: Mon, 23 Jun 2025 14:45:28 -0700 From: Andrew Morton To: Davidlohr Bueso Cc: mhocko@kernel.org, hannes@cmpxchg.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, yosryahmed@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] mm/memcg: make memory.reclaim interface generic Message-Id: <20250623144528.19721543236d8a0165df4cad@linux-foundation.org> In-Reply-To: <20250623185851.830632-3-dave@stgolabs.net> References: <20250623185851.830632-1-dave@stgolabs.net> <20250623185851.830632-3-dave@stgolabs.net> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: AE88E40015 X-Stat-Signature: j168ar3zmepsjguqacadqex4ywr8oy78 X-Rspam-User: X-HE-Tag: 1750715130-935708 X-HE-Meta: U2FsdGVkX18Pr8O+1WH20xSYeRDU+DehxBYTw2dxX7U99OmCQTVV8tdreu8M4LfE6axqWzx8/nnTeYdUCUvEp/tpUXF7jrdvDhf8vQdsPJT6VBDRTK5upmcG7+4veSzVzsYH5EoBQHOFESOSWRISomHFWI9li22uoy3Fv85CC6GK/p4xLh2BoDf1rqWM1R8ZEKzLVznRoYyk4MmgMhvrkgf+6Ssx0mJREYKwZJ23P2p+3YquuI1HsMe2YYCIyCSll94s+Z8/gLxeTsDD4KKN+GCpPhmpqyFuzxrLNqYfP0zVB/tGjPtj+lWoMaiwMylEPvDIDqmpFXeFKR1md7V2hES5uD8mfcjz/eEzoyTzOp/yT2ASaUYZ7kCH8BKugCzBGSv9qkT0LPi0w2HDer+7z+43LOXC9ka033YZywH7cmyW8HnzDZ5XRPlAvazzgYFRKuk1yt+BKLkEgRHksmpmOOh+bAWkhNoGj71Rr7HBab4xPER/fdGMnJGVIaOPdRGZjVX4fo0muoU5hmQIeD/l+YlFfvA4XEXhlhW/ScwGoZPrAVtsZjUjMRM8VlF9ckUV0YGNfFxDwEBoxP203Zy+deMFha0a4ibYQYaRqZKGetQMp1NlLyk2qGHQH1Ax89jZJe2ywdXVWdPs28k5mT7ECSCmTzBUw3H7SMQWsTWp2k2fcEXVA+y2xPaNY8JL8vCnQ5SbesO9y4pv+B9NR4k0/5bn8wfgLYHd7aqaendbr0pN5Ez5GIz3RRx8CzB4oi0y2Lk2lYFPO6psIK92a16pSJ725MsTgiO9USF2U40Bi4AZGPFYoPxBMU/Md5UwfuwDPxkK4iofY2cgOJv7cXi61CIiou87pnNpDLyDxbxgZf4M3lXdiwXvkdr3j5eKkEjgIjZPULc2ExztJgyl6v7bQbKmyOHeu+wKzC47y+S6LVgDex6LnP3ZXAv8ABJs8x7g1nb3wIZN+fTe9jTOLPL fsE+mTKB 1L0JQhh4OMOKrEwT/8ccLaPEAQxvGgeJnxx1KrYV+HC1GSbAifVq8O2xWo1BuODgqCVRcInqymhKgtAdwMbm8Wkt2ZXcGDTXFuRY9Ii+SdFnj0PiGziOa2xcTe8E5QXzAeqkoGm5tAdLiLZzOmKV1s5V+l6GQ/4EQlWe6Idvq2JoCM+1apBi2+x31lAxydXvw7yBmF5Vj3j4calhGely+GHGAK7IXekCkpdGxVkRdtUiqdUBLzG2k42hEzz69wJyOfcvvsJgWHCh1tjBI0ARvDqyFjjqmLLcSeAOva/M6y9ETkerO8j85Gnnmtw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 23 Jun 2025 11:58:49 -0700 Davidlohr Bueso wrote: > This adds a general call for both parsing as well as the > common reclaim semantics. memcg is still the only user and > no change in semantics. > > +int user_proactive_reclaim(char *buf, > + struct mem_cgroup *memcg, pg_data_t *pgdat); Feeling nitty, is this a good name for it? It's hard to imagine what a function called "user_proactive_reclaim" actually does. That it isn't documented isn't helpful either!