linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Honggyu Kim <honggyu.kim@sk.com>
Cc: SeongJae Park <sj@kernel.org>,
	kernel_team@skhynix.com, damon@lists.linux.dev,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, Yunjeong Mun <yunjeong.mun@sk.com>
Subject: Re: [PATCH 3/3] samples/damon: fix bugs for damon sample for start failures
Date: Mon, 23 Jun 2025 11:11:42 -0700	[thread overview]
Message-ID: <20250623181142.44434-1-sj@kernel.org> (raw)
In-Reply-To: <f6739a52-eb5e-4a88-9796-b53f18869059@sk.com>

On Mon, 23 Jun 2025 12:16:32 +0900 Honggyu Kim <honggyu.kim@sk.com> wrote:

> Hi SeongJae,
> 
> On 6/23/2025 1:29 AM, SeongJae Park wrote:
> > Hi Honggyu,
> > 
> > On Sun, 22 Jun 2025 21:09:25 +0900 Honggyu Kim <honggyu.kim@sk.com> wrote:
[...]
> > If we want to make stable kernel maintainers' life easier, we would better to
> > split this into three patches, for each module, and add appropriate Fixes, as
> > below.
> 
> Spliting this into three patches is okay.
[...]
> > Could you please do so?
> 
> If we do, then this patchset has to come before "enabled" renaming patch.
> 
> In addition, I remember mixing stable and non-stable patches together in the
> same patchset isn't welcomed by Andrew or other stable tree maintainers.  So I
> might be better to split those three fix patches into a separate patchset.

I didn't think they would really bother such mixed patch series, but, yes,
please do so.  Being nice to others is cool :)

> 
> The only thing that bothers me in that case is writing cover letter for simple 2
> or 3 patches as they are relatively simple.

I think you could also add the divide-by-zero fix (first patch of this series)
to the series.

> 
> But it isn't that hard so can manage those in the next spin.

Thank you, looking forward to the next revisions!


Thanks,
SJ

[...]


  reply	other threads:[~2025-06-23 18:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-22 12:09 [PATCH 0/3] mm/damon: Enhance damon and its samples Honggyu Kim
2025-06-22 12:09 ` [PATCH 1/3] mm/damon: do not allow creating zero size region Honggyu Kim
2025-06-22 16:04   ` SeongJae Park
2025-06-23  2:58     ` Honggyu Kim
2025-06-23 18:03       ` SeongJae Park
2025-06-25 22:24         ` Honggyu Kim
2025-06-26 15:27           ` SeongJae Park
2025-06-27 11:29             ` Honggyu Kim
2025-06-22 12:09 ` [PATCH 2/3] samples/damon: change enable parameters to enabled Honggyu Kim
2025-06-22 16:14   ` SeongJae Park
2025-06-23  3:04     ` Honggyu Kim
2025-06-22 12:09 ` [PATCH 3/3] samples/damon: fix bugs for damon sample for start failures Honggyu Kim
2025-06-22 16:29   ` SeongJae Park
2025-06-23  3:16     ` Honggyu Kim
2025-06-23 18:11       ` SeongJae Park [this message]
2025-06-25 22:27         ` Honggyu Kim
2025-06-26 15:28           ` SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250623181142.44434-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=honggyu.kim@sk.com \
    --cc=kernel_team@skhynix.com \
    --cc=linux-mm@kvack.org \
    --cc=yunjeong.mun@sk.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).