From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF73FC7EE30 for ; Tue, 24 Jun 2025 14:23:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C2BE6B008A; Tue, 24 Jun 2025 10:23:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5736A6B008C; Tue, 24 Jun 2025 10:23:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 489196B0095; Tue, 24 Jun 2025 10:23:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 312DD6B008A for ; Tue, 24 Jun 2025 10:23:54 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D04E680224 for ; Tue, 24 Jun 2025 14:23:53 +0000 (UTC) X-FDA: 83590513146.05.A0104BB Received: from relay.hostedemail.com (unirelay01 [10.200.18.64]) by imf09.hostedemail.com (Postfix) with ESMTP id F0775140009 for ; Tue, 24 Jun 2025 14:23:51 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750775032; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v0ARfvhIvjYj8Jb+9PPUjeGaIsG5i1CTzy3rqqsGfAo=; b=NZpi3cWHnFvAavmJgFG5XBxv+q8UFigunbsdXPUlgQQbsaD7j2K0gBGff38CAvT9dl/kIG /8KqPUYtGdsEkcRPpEJOOD43iiurKzpp1MALbdZS8YrYbt6VKfNc/ZJwBUC4S+NUO20CV9 rnD9wDo50gR6uYTQEPuMXSLFKmRLCNY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750775032; a=rsa-sha256; cv=none; b=ECrigMDwVheTWrPqlSxJZmkDqnsylYJeMTkrcYAWS52H/xrZ4GzoLyj7YWD50Ju8A53Un1 ZoqiowzDmmGNhaATI+SAp2QnnDGkO8P9zw0pNtHl9u0AZ1QiiMTe8fP2wioc6iBN1doHVL N40Os63VOrav6ZKXWKJ3AqwkoB40mlw= Received: from omf11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 845DD1D71EB; Tue, 24 Jun 2025 14:23:50 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf11.hostedemail.com (Postfix) with ESMTPA id E66972002D; Tue, 24 Jun 2025 14:23:47 +0000 (UTC) Date: Tue, 24 Jun 2025 10:23:46 -0400 From: Steven Rostedt To: Matthew Wilcox Cc: Anshuman Khandual , linux-mm@kvack.org, Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , Petr Mladek , Jonathan Corbet , Andrew Morton , David Hildenbrand , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [RFC 1/2] lib/vsprintf: Add support for pte_t Message-ID: <20250624102346.4e175914@batman.local.home> In-Reply-To: References: <20250618041235.1716143-1-anshuman.khandual@arm.com> <20250618041235.1716143-2-anshuman.khandual@arm.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1+IrmPdEPDMTQPOYQJLheFaIW5Jwe/VI6I= X-HE-Meta: U2FsdGVkX18ZrWvhIVM6zP5G4nszQvGFvGRorQIfUXNQqKlbCXpYq4P7CUojbbp0ixwYRObH4yt956p5nl1byTSPn6rmNm6mermFvf8IGge05jqBii1cCrollhwtGUVmMMW6lHLsGbWAghzsNCXOsWK5NNqhZ+zyryw5ueiKh+JwG+E/DgXwbFoEi6oD3PgnP0mr7CFUGrmWw8bT66SI5ZZLRoEo1khBGdQKrfty//dfldLIbXacD+hNzpES83s6x83uv276GQNyDXYAkEMOqH4CgBX0KJaRcsoHvM0A3FoBp04QHQr1GqNp6H9ixTiPlZiJMXk7MPFFrfrV7nFxKIQr/29/hhkDzE3I1xqZrGfcyQpCXecjzwn+QEEisL76HtKkQINQrqFL5ybj0CPjAQ== X-HE-Tag-Orig: 1750775027-262139 X-Rspamd-Queue-Id: F0775140009 X-Rspamd-Server: rspam03 X-Stat-Signature: hof5jjcu44rxp8i9ann6b3za4k9uwnks X-Rspam-User: X-HE-Tag: 1750775031-533515 X-HE-Meta: U2FsdGVkX1/NWftHfHmhbenhjvdR0yTMEQCWNHRFTlJsGjUFXIMstvae8YDs/RsW8DgCHMUeJ8WlIR30J/WX45n71qcwZbbVOWdItUuWn9NmzytUrQzYQ5KUpZ6a5DQ7KMH2L3GHEkY4C6ePHzCYK7EpCSdOfngpSiUM8tnuDwilU/Y2kf4Rq98foVzeCJDdgbW4P3w3QJtexfzU62ebHFy6FdH9MPKM7qYMM+NBIeFMcIPZD1FJSybRpPlzTIJ5Gs2UaoJ1IJxoVIFxnMyoa871Jw2FAEitJcbqu1xJrh/njXv8PktFeuToBHF0+l1uq+I8lhqDhyZEfehu6F96kVwBW6OFnr73CoXCS85fzS+WEx9CI+ZtyuLJ1KWneEeAxfEuvjdqRRKzuacW3XUvdg3ouvt2nRrUTRdKWQUemH7Ri1I9EvhfdWGsZtVQ1rE58taaaCaXtIsNWgxQVZGJ2PbUWd7xyz6r60uET2EmGGJqwM13L2Gf+pw0/0gi/FM5RgWj8qECv55dbocp7CbKX4pmilMYpjO/u5N1N2X7km4t6sjuL9+rz4gWLEyu+nC9wQ08HZEkOWExR4atM0yXKXjLw7ojPmUTYt5taRC/qnXWPM6JRyaj+LKOv+sgzjXHoG5oiStIuCa8gt/g8eSg20DiQBmsT1VpEA2ZuexzWBmbsphGQdq4J9/T+B40d2sqabwdVwNErCMHEbSdYCEQr4GbdAht+I4m X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 24 Jun 2025 14:11:08 +0100 Matthew Wilcox wrote: > On Fri, Jun 20, 2025 at 01:42:53PM +0530, Anshuman Khandual wrote: > > On 19/06/25 6:56 PM, Matthew Wilcox wrote: > > > Unfortunately, the one example you've converted shows why this is a bad > > > idea. You're passing a pmd_t pointer to a function which is assuming a > > > pte_t pointer. And a pmd_t and a pte_t are sometimes different sizes! > > > (eg sometimes one is 64 bit and the other 32 bit). > > > > As discussed on a separate thread, this might be addressed via separate > > printf formats for each page table level e.g %ppte, %ppmd, and %ppud etc. > > There's still no typechecking! There's lots of %pX formats that have no type checking. I think this is an issue. Could we have one of the static checkers test these? Smatch, sparse, whatever? Or maybe they do and I'm unaware of it? -- Steve